StarCitizenTools/mediawiki-skins-Citizen
1
0
Fork 0
mirror of https://github.com/StarCitizenTools/mediawiki-skins-Citizen.git synced 2024-11-24 06:24:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: better detection for slash toggle

Browse source
This commit is contained in:
alistair3149 2021-05-10 13:26:39 -04:00
parent 6264b918e2
commit 74873da01f
No known key found for this signature in database
GPG key ID: 94D081060FD3DD9C
1 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
resources/skins.citizen.scripts/search.js
View file

@ -96,6 +96,24 @@ function focusOnChecked( checkbox, input ) {
}
}
/**
* Check if the element is a HTML form element or content editable
*
* @param {HTMLElement} element
* @return {boolean}
*/
function isFormField( element ) {
if ( !( element instanceof HTMLElement ) ) {
return false;
}
const name = element.nodeName.toLowerCase();
const type = ( element.getAttribute( 'type') || '' ).toLowerCase();
return ( name === 'select' ||
name === 'textarea' ||
( name === 'input' && type !== 'submit' && type !== 'reset' && type !== 'checkbox' && type !== 'radio' ) ||
element.isContentEditable );
}
/**
* Manually check the checkbox state when the button is SLASH is pressed.
*
@ -107,11 +125,7 @@ function focusOnChecked( checkbox, input ) {
function bindExpandOnSlash( window, checkbox, input ) {
const onExpandOnSlash = ( /** @type {KeyboardEvent} */ event ) => {
// Only handle SPACE and ENTER.
if ( event.key === '/' &&
!event.target.matches( 'input' ) &&
!event.target.matches( 'textarea' ) &&
!document.documentElement.classList.contains( 've-active' )
) {
if ( event.key === '/' && !isFormField( event.target ) ) {
checkbox.checked = true;
focusOnChecked( checkbox, input );
}