mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git
synced 2024-11-28 09:30:17 +00:00
cf17aee48b
Add a new NPM script, `pre-commit`, which _conditionally_ invokes `npm test`. Previously, the pre-commit hook was configured by default to invoke `npm test`. Now it is configured explicitly to invoke the new `pre-commit` script. The rationale for this change is that some folks may prefer workflows that defer all validation until CI. Supporting these workflows is a small change, most of it documentation. This change isn't necessary for T257647 but supports and seems like an overall improvement to the repo regardless of whether code is built or not. Bug: T257647 Change-Id: I19a78e0e677026cd6887245d96e63a414397a3db
73 lines
2 KiB
Markdown
73 lines
2 KiB
Markdown
Vector Skin
|
|
========================
|
|
|
|
Installation
|
|
------------
|
|
|
|
See <https://www.mediawiki.org/wiki/Skin:Vector>.
|
|
|
|
### Configuration options
|
|
|
|
See [skin.json](skin.json).
|
|
|
|
Development
|
|
-----------
|
|
|
|
### Coding conventions
|
|
|
|
We strive for compliance with MediaWiki conventions:
|
|
|
|
<https://www.mediawiki.org/wiki/Manual:Coding_conventions>
|
|
|
|
Additions and deviations from those conventions that are more tailored to this
|
|
project are noted at:
|
|
|
|
<https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions>
|
|
|
|
URL query parameters
|
|
--------------------
|
|
|
|
- `useskinversion`: Like `useskin` but for overriding the Vector skin version
|
|
user preference and configuration. E.g.,
|
|
http://localhost:8181?useskin=vector&useskinversion=2.
|
|
|
|
Skin preferences
|
|
----------------
|
|
|
|
Vector defines skin-specific user preferences. These are exposed on
|
|
Special:Preferences when the `VectorShowSkinPreferences` configuration is
|
|
enabled. The user's preference state for skin preferences is used for skin
|
|
previews and any other operation unless specified otherwise.
|
|
|
|
### Version
|
|
|
|
Vector defines a "version" preference to enable users who prefer the December
|
|
2019 version of Vector to continue to do so without any visible changes. This
|
|
version is called "Legacy Vector." The related preference defaults are
|
|
configurable via the configurations prefixed with `VectorDefaultSkinVersion`.
|
|
Version preference and configuration may be overridden by the `useskinversion`
|
|
URL query parameter.
|
|
|
|
### Pre-commit tests
|
|
|
|
A pre-commit hook is installed when executing `npm install`. By default, it runs
|
|
`npm test` which is useful for automatically validating everything that can be
|
|
in a reasonable amount of time. If you wish to defer these tests to be executed
|
|
by continuous integration only, set the `PRE_COMMIT` environment variable to `0`:
|
|
|
|
```bash
|
|
$ export PRE_COMMIT=0
|
|
$ git commit
|
|
```
|
|
|
|
Or more succinctly:
|
|
|
|
```bash
|
|
$ PRE_COMMIT=0 git commit
|
|
```
|
|
|
|
Skipping the pre-commit tests has no impact on Gerrit change identifier hooks.
|
|
|
|
### Hooks
|
|
See [hooks.txt](hooks.txt).
|