Commit graph

3485 commits

Author SHA1 Message Date
bwang e28e197f1f Prevent language button in sticky header from word breaking
Bug: T316609
Change-Id: Ie4d9efad0850dce52a6e383574b14d986a824d4a
2022-09-15 16:28:26 +00:00
Translation updater bot 6fd247640b Localisation updates from https://translatewiki.net.
Change-Id: I305d5955b8ffd92477db07b7b34327563b71e738
2022-09-15 09:57:19 +02:00
Jon Robson 7ebcf3ccff Limit upgrading of Echo icons to Visual enhancements feature flag
Currently we appear to be applying our icon/button enhancements to
notifications menu if the icon field is present.

These fields are not provided yet, but soon will be, so limiting
to the feature flag.

Bug: T257143
Change-Id: I2cf49a24f2db632e3ca23f749064929678bc8e19
2022-09-14 23:00:34 +00:00
Translation updater bot 2d7d60a14a Localisation updates from https://translatewiki.net.
Change-Id: I90a5eec3de6f287859a87aa9cbb5b81582c2cd29
2022-09-14 10:33:21 +02:00
Jon Robson f9a3d795ef Storybook: Update Legacy/codex comparison table
Upgrade Codex to the latest version and add the new icon
only buttons to our side by side table

This is needed to help bring these inline.

Bug: T314323
Change-Id: I7f59968cf5be6242e8002b11ca030c9bd4dd882d
2022-09-13 23:01:28 +00:00
jenkins-bot e0042bceca Merge "Remove unneeded expansion styles from search box code" 2022-09-13 19:30:18 +00:00
bwang 6b7197cf95 Followup: Removed code for cached HTML from T313060
Bug: T313060
Depends-on: Ia263c606dce5a6060b6b29fbaedc49cef3e17a5c
Change-Id: I0626f5c8d92836ecac961bbe213ffd8b0f0e2df5
2022-09-12 21:47:48 +00:00
jenkins-bot 5e02d2b7ea Merge "Minimize search icon" 2022-09-12 18:26:04 +00:00
jenkins-bot b5c46b8294 Merge "icons: Fix arrow stem to be perfectly 45 degrees" 2022-09-12 16:59:49 +00:00
Thiemo Kreuz 80a935cc9a Minimize search icon
Change-Id: I3f6084fc71930378ecb98180f4bd3d07478e9b4e
2022-09-12 18:53:31 +02:00
jenkins-bot 8626e14ec1 Merge "Don't print table of contents on page with no table of contents" 2022-09-12 15:50:22 +00:00
Translation updater bot f33cbf03ca Localisation updates from https://translatewiki.net.
Change-Id: Ib28dcff412c60712cfbae40570e636235d3df6ee
2022-09-12 09:39:01 +02:00
Volker E 2eeb9e45fc icons: Fix arrow stem to be perfectly 45 degrees
Following-up to further optimize icon SVG and provide arrow stem in
perfect 45 degrees angle.

Bug: T261391
Change-Id: I1fa7789182f0fffb7891205a9099884402d37b61
2022-09-11 23:24:29 -07:00
jenkins-bot 77877254da Merge "Revert "Sidebar: Collapses at lower resolutions"" 2022-09-10 00:34:13 +00:00
Jon Robson ccc8df0ef9 Don't print table of contents on page with no table of contents
e.g. Special:BlankPage

This was causing unexpected visual regressions on Pixel

Follow up to 9c6f6709c

Bug: T313060
Change-Id: If8111f95be53e4504ed49d4ea140f62ac98e8e1b
2022-09-09 17:08:40 -07:00
Jdlrobson 475c237a5e Revert "Sidebar: Collapses at lower resolutions"
This reverts commit 365d3902c9.

Reason for revert: Pixel is flagging the sidebar being closed
in cases where it shouldn't. Since I can't debug that I'm
reverting just to be cautious.

Change-Id: Ib88f61eb6a7fda8ce546a24c2d3dbbde836f2c40
2022-09-09 17:08:19 -07:00
jenkins-bot 2f25456534 Merge "Followup: clean up cached HTML code from T315595" 2022-09-09 22:32:55 +00:00
bwang d538835b5a Follow-up: Align sticky header with header and update collapsed TOC in page title padding
Visual changes:
- Sticky header padding will increase on desktop and desktop-wide viewports to match the header
- Padding on collapsed TOC button in page title is 2px wider on each side

Bug: T315261
Change-Id: I9d0df4f4d399fe120a4c1a5d2df610942cc70f02
2022-09-09 20:07:49 +00:00
jenkins-bot 9ac7a23234 Merge "Correct ContentHeader source order to match design" 2022-09-09 17:24:55 +00:00
Translation updater bot 353843dce6 Localisation updates from https://translatewiki.net.
Change-Id: If74efe4874eedd827adc8ce954f72e1f4c1a2325
2022-09-09 10:12:57 +02:00
bwang abad54d0ab Change article toolbar bottom border color
Bug: T311311
Change-Id: I1731510da0c956d0290508b9a2cef7558d3cde00
2022-09-08 23:54:13 +00:00
bwang fc9fe5e719 Add vector-toc-not-collapsed class serverside
Visual changes:
* No reflow on startup

Bug: T316964
Change-Id: I17f2699fec113d92b3f0f223c357654f52eb7eb3
2022-09-08 22:43:56 +00:00
jenkins-bot bcfc94090b Merge "Sidebar: Collapses at lower resolutions" 2022-09-08 20:50:17 +00:00
Jon Robson 97cf735de2 Icons: Watchstar and wikilove are upgraded
Can be tested by appending ?vectorvisualenhancementnext=1
to URL

Bug: T310838
Bug: T234990
Bug: T234550
Depends-On: I76d0d94c9006cc5f5680849ecdd1c382c16e34ba
Depends-On: Ib7c3021db014827b4b88cac855afc0b54a360f8c
Change-Id: Ie2ffa5c3ecf270c1bb1f315937023ae7ace5ed30
2022-09-08 19:43:35 +00:00
bwang 4c622fe8de Correct ContentHeader source order to match design
- Use flexbox instead of float

Visual changes:
- The title wraps differently when the title is very long

Bug: T313947
Change-Id: I2915e36286b21c8fd1a07247ada7754a08a0b574
2022-09-08 19:10:55 +00:00
Jon Robson 365d3902c9 Sidebar: Collapses at lower resolutions
On resize, or when booted in a small window the sidebar will collapse
and remain collapsed for subsequent page views

Bug: T316191
Change-Id: Ib4961975630871d6630cd747a78cc2ec4f1cdeeb
2022-09-08 08:22:20 -07:00
Translation updater bot e629775aff Localisation updates from https://translatewiki.net.
Change-Id: I02a964b9b170504f7591b8a0ed1cf90f9dcaab43
2022-09-08 10:02:42 +02:00
jenkins-bot e60716e63d Merge "Align language button" 2022-09-07 22:21:27 +00:00
jenkins-bot d4094ffa02 Merge "Align header icon buttons and main content" 2022-09-07 22:21:25 +00:00
Moh'd Khier Abualruz 3a10708b4e Deprecate PersonalUrls hook
* Updated usages to use SkinTemplateNavigation::Universal
in preparation for the hard deprecation and removal of the hook.

Bug: T310017
Change-Id: I133c7479da294c0b8c908ad8d34690297f08200b
2022-09-07 15:12:51 +00:00
bwang cdae8b1937 Align language button
- Add margin-right to language button
- Remove @margin-start-sidebar-content CSS variable as it's name isnt accurate anymore, and its value is derived from @icon-padding-md

Bug: T315615
Change-Id: I75dd87536f70da55c9fa7e0e29ed6b4040d2ddf4
2022-09-07 09:47:55 -05:00
Translation updater bot 948027450e Localisation updates from https://translatewiki.net.
Change-Id: Ia2e7632625ea4210c94575f7ee3a00707138cc21
2022-09-07 09:56:41 +02:00
jenkins-bot ddc3125f74 Merge "Remove dependency on .cdx-typeahead-search--active class" 2022-09-07 01:29:45 +00:00
Translation updater bot 50c2aab74c Localisation updates from https://translatewiki.net.
Change-Id: I774d16c709adfb26358ddd53e2aa95ba97add5fc
2022-09-05 10:14:28 +02:00
Jon Robson c1e923f120 Icons: Enable feature flag for next set of visual enhancements
Change-Id: I10f5a2ee8fa8121f8e9a5a79c98db492fbec6534
2022-09-02 07:54:13 -07:00
Jon Robson 742f659b10 FeatureManagement: All features have an associated class on the body tag
This is a common need for features, and having these use a standardized
class name will make using them a lot easier.

Change-Id: I0e16c26878e7d4399d2bf57f236523d214951a27
2022-09-01 22:09:48 +00:00
jenkins-bot 75115f841c Merge "Add tests for dropdownMenu.js" 2022-09-01 21:03:34 +00:00
Anne Tomasevich 8e04c79dba Remove dependency on .cdx-typeahead-search--active class
This class is no longer needed in Codex and will be removed.
This patch adds a similar dynamic class to the Vector search
app, to be used for showing/hiding the search button on
focus/blur or hover/leave.

Bug: T316893
Change-Id: I738c0f24dcd06ddeb9179cfedc85ed73a6504f1e
2022-09-01 16:42:11 -04:00
jenkins-bot d59885cf89 Merge "Enable related tabs on Vector" 2022-09-01 20:36:15 +00:00
Jan Drewniak f14b4fe5f1 Add tests for dropdownMenu.js
Adds tests for the addPortletLinkHandler, which should
add an icon element to items added via 'mw.util.addPortletLink'
and conditionally move elements from the toolbar into
the more menu at narrow widths.

- Adds tests for dropdownMenu.js
- Adds associated Jest snapshots
- Stubs the mediawiki.page.ready module
- Updates mockMediawiki.js to 4.6.0
- Adds global mock for mw.util.showPortlet()
- Cleans up tests using local versions of these mocks

Bug: T314798
Change-Id: I81394d840321916756a41a23c40d96c4b6341931
2022-09-01 13:11:22 -07:00
Anne Tomasevich eec6d5f608 Remove unneeded expansion styles from search box code
Input expansion behavior has been changed in Codex to expand
the input when the menu opens, instead of when the input is
focused. This patch removes styles targeting the server-
rendered search box that mimicked the expansion behavior
on initial focus to ease the transition between the server-
rendered version and the Vue version.

Bug: T312594
Change-Id: Id716860f52df7585c068a7927bf799129faf4ad3
2022-09-01 15:43:31 -04:00
bwang 3bf377fa7e Followup: clean up cached HTML code from T315595
Bug: T315595
Depends-on: I39959f43f20880e83bef945a7535d58cfe0b6412
Change-Id: I7afb66d6ee2d67d824266ca7240618afdd200c7f
2022-09-01 18:25:39 +00:00
bwang d949621eb2 Align header icon buttons and main content
Technical changes:
- Increase @padding-horizontal-content to align content
- Rename @padding-horizontal-page-container and @padding-horizontal-page-container-wide to @padding-horizontal-page-container-desktop and @padding-horizontal-page-container-desktop-wide respectively
- Replace "gutter" grid area with column-gap
- Clean up TOC styles

Visual changes:
- Below 1000px the header icons spacing is updated
- Above 1000px the page titlebar and articlebar right space is updated

Bug: T315261
Change-Id: I7f51ab3b9613c359db62e918051e942c5c6c878b
2022-09-01 12:42:07 -05:00
Translation updater bot b0b58915d4 Localisation updates from https://translatewiki.net.
Change-Id: If3b50c552f3058d00047a7e10ac9214b139ccab2
2022-09-01 09:37:28 +02:00
bwang 9c6f6709c6 Create new sticky toc container
Bug: T313060
Change-Id: Ia263c606dce5a6060b6b29fbaedc49cef3e17a5c
2022-08-31 21:27:06 +00:00
jenkins-bot 990c7f72b9 Merge "Reduce specificity of siteSub" 2022-08-31 20:49:55 +00:00
jenkins-bot c701486aa2 Merge "Override visited link style in MenuTabs" 2022-08-31 20:38:00 +00:00
Jon Robson 69658483bd Reduce specificity of siteSub
Follow up to I8ab2a554f753348ea2fb0fd4d28053ea17fbe83e
It should be possible to enable the #siteSub element with
a simple #siteSub { display: block; }. When moving these styles
from core we have made them more specific and harder to override

Bug: T316027
Change-Id: I4009c67e97ed0e718c28a1fa18c0059075b7a8a7
2022-08-31 13:07:58 -07:00
bwang 900376f9e4 Override visited link style in MenuTabs
Bug: T316574
Change-Id: I55b6537df709204ff499aa18298721cbec1de405
2022-08-31 19:51:14 +00:00
bwang 1c8af16dfb Replace body:not( .vector-toc-collapsed ) with .vector-toc-not-collapsed class
Follow up to Ibf837775d972deb29e9619cc6c12c919aae5155a

Change-Id: Ib50f6e4a61a09f54763a740bd12cdae3ee63abef
2022-08-31 19:05:50 +00:00