Commit graph

5374 commits

Author SHA1 Message Date
Jon Robson 70fbd6f0c2 Small font size is not applying to excluded pages
Bug: T364887
Change-Id: Ib24beb3a383599dcc3ad64e01992ead908e3bef3
2024-05-21 23:41:35 +00:00
Jon Robson f4befc068d [Visual change] Limits two row header to mobile devices
I accidentally enabled this on tablet breakpoint.

Follow up to e3d2ab5031
The Pixel UI report should only surface changes on mobile - all
of these are improvements as it means the whole UI is visible in
the viewport.

Bug: T361573
Change-Id: I8aa5699a8fe959c1595d74c03f19c14856f6470f
2024-05-21 11:52:10 -07:00
Jon Robson ca9b2274dc Fixes OOUI widget visibility within VE surface
Bug: T365050
Change-Id: I1bc59fcd20174cabe39cab0d5319ddb40a2105e3
2024-05-21 17:24:19 +00:00
jenkins-bot 0ee96091b9 Merge "Bump performance budget to unbreak l10n change" 2024-05-21 15:26:30 +00:00
jenkins-bot 0f9ad1ba67 Merge "Support Vector 2022 at > 320px" 2024-05-21 14:23:09 +00:00
Michael Große 167f6d32d5 Bump performance budget to unbreak l10n change
It is unclear why this is needed, but
I9be50b3749500160e918ff3f2d2e1646ba7dc1a6 (which only touches en.json
and qqq.json files) fails on this test in CI. The cause must still be
investigated separately.

Bug: T365480
Change-Id: I889561b5b669d992c1f152d4bd203a71e2aff9ba
2024-05-21 16:21:05 +02:00
Translation updater bot 0f52e1e85a Localisation updates from https://translatewiki.net.
Change-Id: I827c90d995958bc0456f94f5e15d77b1aa688705
2024-05-21 09:30:35 +02:00
jenkins-bot 6c535ac9f7 Merge "Fixes: Echo icon display when clicked" 2024-05-21 00:40:32 +00:00
Jon Robson 376b607d97 Fixes: Echo icon display when clicked
Styles removed in 1d17b46 were being utilised for Echo without
us knowing. Rather than revert that patch (which seems risky
so late in the day) I think it's preferable to restore these styles
for the Echo icons inside the skinStyle

Bug: T365409
Change-Id: Ibb967343f9c97c5fbe87d29b40e871f0f336f957
2024-05-20 17:16:34 -07:00
jenkins-bot 685a02f8a6 Merge "watchstar: use mw.util.isInfinity() instead of comparing to 'infinity'" 2024-05-20 23:48:09 +00:00
MusikAnimal c06d62a531 watchstar: use mw.util.isInfinity() instead of comparing to 'infinity'
Bug: T353389
Bug: T353483
Change-Id: I580deb0ba47e4c13643524ddd4d57f1a8e0a35ae
2024-05-20 16:27:42 -07:00
Ed Sanders 54b750af14 vector-popup-notification: Use 14px font size instead of 16px
Vector still uses 14px almost everywhere, so use it here
as well.

Bug: T360335
Change-Id: Icf4891375a62480ffbb4808a357935aa6d6fdc58
2024-05-20 13:59:31 -07:00
jenkins-bot 2702cf106c Merge "Simplify PHP code" 2024-05-20 20:18:10 +00:00
jenkins-bot ad03ea0eb3 Merge "configuration.md: Remove mention of out-of-date wmf config values" 2024-05-20 18:57:33 +00:00
jenkins-bot 1a2036b79c Merge "configuration.md: Remove unncessary double-bolding in headings" 2024-05-20 18:57:32 +00:00
Ed Sanders 91e44426f8 configuration.md: Remove mention of out-of-date wmf config values
Change-Id: I40da59927589ad073233fa41fdc378ced86c277e
2024-05-20 18:33:31 +00:00
Ed Sanders 568501f383 configuration.md: Remove unncessary double-bolding in headings
Change-Id: Ia82766e86c5e0c6ee0a10d232f35c3c20282aff9
2024-05-20 18:33:13 +00:00
Fomafix 94d1bee402 Simplify PHP code
* Use !== instead of !=
* Avoid else after return
* Use falsey check for object is null
* Use consistently spaces inside of brackets

Change-Id: I2928664acbab315ab3eae38c74f87b019d46cf29
2024-05-20 18:23:48 +00:00
Jon Robson ee05f8f5bd Update documentation for config flags
Follow up to 0109218ab where we renamed ClientPreferences to
Appearance

Also update wgVectorResponsive for consistency with other
documentation.

Change-Id: I7198e7742a50caa16a061904f05388b6837f251e
2024-05-20 11:15:40 -07:00
Translation updater bot 57873592ff Localisation updates from https://translatewiki.net.
Change-Id: Ib4274eb3401ee93383b7c64404a6c7352b4e6ca7
2024-05-20 09:28:44 +02:00
libraryupgrader bbef8b3bcd build: Updating grunt-banana-checker to 0.13.0
Change-Id: Ia3dfc349bbb6b2c2542884ed08b9f74d038ca250
2024-05-19 10:33:49 +00:00
Volker E dd5b98515d styles: Replace deprecated breakpoints
The values have slightly changed:
- Tablet breakpoint is decreased by 80px,
  pushing lesser devices into a mobile only experience but
  should make barely a difference to vast majority of our users.
- Biggest difference is in `min-width-breakpoint-desktop`,
  which is increased by 120px in comparison to
  `@width-breakpoint-desktop: 1000px`

Bug: T349793
Depends-On: I3afba8c51f60de9271054499bfa3ffbcc1a9d779
Change-Id: I56b93d5241d6a029dcb6814de02d18ac9f38ee5d
2024-05-18 02:28:18 +00:00
Jon Robson e3d2ab5031 Support Vector 2022 at > 320px
In preparation for enabling responsive Vector on Wikifunctions,
we lower the support threshold to 320px for Vector.

Minor adjustments are made to the header to make it use two
lines at lower resolutions.

Fixes to tables to make them responsive will be made shortly as
part of T330527 which will complete the responsive behaviour.

Bug: T361573
Change-Id: Idbac393ab6ee60100ba0fd6df4b224cc45949bfd
2024-05-17 23:31:37 +00:00
jenkins-bot b33513e20b Merge "Override default sublist styles" 2024-05-17 21:08:51 +00:00
jenkins-bot 2852b2b9f9 Merge "Increase bundlesize to accomodate Extension:WikimediaMessages and responsiveness" 2024-05-17 19:11:16 +00:00
jenkins-bot c570ec099d Merge "Optimize styles" 2024-05-17 18:30:33 +00:00
Jan Drewniak ff5a61e9c6 Add exclusion behaviour for "width" option in Appearance menu
- Adds the notice "This page is always wide" and disables
  the inputs for the "width" options in the Appearance menu
  when pages are excluded via configuration ( `$wgVectorMaxWidthOptions`).
- Changes layout behaviour so that pages in the
  $wgVectorMaxWidthOptions['exlcude'] configuration
  stretch the entire viewport width.
- Stops the width settings in the Appearance menu from
  being hidden on smaller resolutions.

Bug: T364015
Change-Id: Idee294adf3b309e03834276ea75e4ae43b0cffcb
2024-05-17 17:58:19 +00:00
Jon Robson 08bc5c53b4 Increase bundlesize to accomodate Extension:WikimediaMessages and responsiveness
WikimediaMessages is deployed on all wikis. It provides important
fixes for night mode.

The work to make tables more responsive in T330527 will also
increase the bundle size.

Note:
Some of this budget will be reclaimed later as we roll out the
appearance menu to all users.

This is needed to unblock
I3ce5fe61f58592a9e6bf982745f9d4cf22d8aeb3

Change-Id: I276e1a3c3fb1603d72c4e8c34abd002e5cd27eba
2024-05-17 10:06:52 -07:00
Jon Robson 1d17b4624f Optimize styles
1) Icon optimizations
* Load styles for expand icon in
JavaScript since it relates to table of contents and that is only
enabled with JavaScript
* Drop vector-icon--x-small class since it only applies to this icon
* Remove some FIXMEs to an issue that has already been fixed
upstream

2) Move styles that do not need to be render blocking to skins.vector.js
* Move sticky header to skins.vector.js since it doesn't work without
JavaScript
* Move popupNotification to skins.vector.js since this is never server
side rendered.

Change-Id: I98e6c0826b514aaefcf88f66275bba37125129b1
2024-05-17 16:26:16 +00:00
bwang ff894e3682 Override default sublist styles
Bug: T364865
Change-Id: I179c059992b2ae614b984b8023774306764ccb57
2024-05-17 15:46:41 +00:00
Translation updater bot d85f9797db Localisation updates from https://translatewiki.net.
Change-Id: I024b9641c1044ece0dda0414d6a7bea02ed40e05
2024-05-17 09:52:53 +02:00
libraryupgrader 2ed17dc985 build: Updating dependencies
composer:
* mediawiki/minus-x: 1.1.1 → 1.1.3

npm:
* @wikimedia/codex: 1.5.0 → 1.6.0
* @wikimedia/codex-icons: 1.5.0 → 1.6.0

Change-Id: Ie380608c4fa8e067571a0f39453942216bf998dd
2024-05-17 04:29:53 +00:00
jenkins-bot 4966ec2271 Merge "Reflect production defaults" 2024-05-16 22:03:07 +00:00
Jon Robson 9bdde667fb Reflect production defaults
Bug: T363814
Change-Id: Iea89208342f09f621acc6219f814271955bbd5fc
2024-05-16 21:09:45 +00:00
Ed Sanders 11b9e7fd2d configuration.md: Fix list formatting
* Use unordered lists at the top level. These
  items have no inherent order, and any patch
  to remove an item would require renumbering
  all subsequent items.
* Use consistent indentation

Change-Id: Ied3768e9c53d7d1104b20711fb0213ba6b27a555
2024-05-16 21:02:13 +00:00
Taavi Väänänen e2bfd5f957
Fix one more message using "day mode" instead of "light mode"
Bug: T361157
Change-Id: Iaa8f8792b5c93fe31655c8e97e6e032ef255d236
2024-05-16 14:28:45 +03:00
Jon Robson 176a6397ce Correct behaviour of ConfigHelper, add tests
Bug: T365084
Change-Id: I220990554d0a07642dd03a0c7bd53f9bd7ff55ec
2024-05-16 08:04:45 +02:00
Umherirrender fb03108304 i18n: Replace mw: interwiki with url to mediawiki.org
The interwiki table must not contains an interwiki link with prefix mw:

Bug: T285439
Change-Id: I2aa9c676d42d1741d57c6792c7fb85b844a6f969
2024-05-15 22:57:17 +02:00
Moh'd Khier Abualruz 37e8e4c929 feature(Vector): Add configurable font size exclusions
This patch introduces the ability to configure font size exclusions
for specific pages within the Vector skin, ensuring certain pages
always use a small font size. This change is part of ongoing improvements
to the Vector skin's customizability features.

Changes:
- Updated `skin.json` to include `VectorFontSizeConfigurableOptions`
- Added new i18n string `vector-feature-custom-font-size-exclusion-notice`
- Modified logic for font size exclusion handling in `FeatureManager.php`

Additional Notes:
- Affects testing and beta deployment environments, ensure relevant
  settings are updated in `LocalSettings.php`.
For testing and on beta deployment, these settings should be set in
the LocalSettings.php of the environment, example:

$wgVectorAppearance = [
    "logged_in" => true,
    "logged_out" => true,
    "beta" => true
];
$wgVectorFontSizeConfigurableOptions = [
	"exclude" => [
	"namespaces" => [ -1, 2, 6, 8, 10, 14, 100, 710, 828 ],
		"querystring" => [
			"action" => "edit|submit|diff|info|protect|delete|undelete|diff|history",
			"diff" => ".+"
		]
	]
];

Bug: T364887
Change-Id: I23b9c4fb63f35c7d27544197fead3ad7619c67f1
2024-05-15 19:19:38 +00:00
jenkins-bot 7cf832dd50 Merge "Remove list-style-image used by ul elements" 2024-05-15 18:39:29 +00:00
bwang f13bc5ed80 Remove list-style-image used by ul elements
Bug: T364865
Change-Id: Id365e946e8c71f4812cbb9e4b00618fb73572554
2024-05-15 15:01:40 +00:00
Translation updater bot 6a06e8f0e1 Localisation updates from https://translatewiki.net.
Change-Id: Ibacebd86aebbe451b2d49d5026367f186feeec3a
2024-05-15 09:23:38 +02:00
jenkins-bot e27ef588fb Merge "Mark night mode as a valid beta feature" 2024-05-14 22:15:26 +00:00
Jon Robson 2d4f0a86d2 Mark night mode as a valid beta feature
This was not well documented but it seems that anything that
can be a beta feature needs to be added to this constant for it
to function as a beta feature.

Bug: T363814
Change-Id: I556114c65d9507829d9eb737edf09245ae14c0f4
2024-05-14 13:43:00 -07:00
Jan Drewniak 0d1de4773d [Follow-up] Override VE overlays in night-mode
Follow-up to 26d39ec, change VE overlay selector
from `.ve-ui-overlay-global` to `.ve-ui-overlay`.

Bug: T363861
Change-Id: Ie531ce6d03d81fbce374f7e17c785d4bb076bfda
2024-05-14 14:30:56 -04:00
Translation updater bot 60b0191340 Localisation updates from https://translatewiki.net.
Change-Id: I3e6e4b540426b4f3d06251018b62485380393d77
2024-05-14 09:29:26 +02:00
jenkins-bot e5c51204ac Merge "Override VE overlays in night-mode" 2024-05-13 22:30:45 +00:00
Jan Drewniak 26d39ecafa Override VE overlays in night-mode
Creates a Less variable `@OOUIOverrideSelectors` which can serve
as a list of selectors that we want to treat the same as the `.notheme`
class (as an alternative to adding the `.notheme` class across repos).

Adds only one selector to this variable, `.ve-ui-overlay-global`
in order to force VE overlays to appear in light-mode while night-mode is
enabled.

This is a temporary measure until T363849 is resolved.

Bug: T363861
Change-Id: I3e3a209f1a9bd9130fc61915b9b2ff7134405e59
2024-05-13 21:58:20 +00:00
Jdlrobson b7743a1dbe Revert "Add exclusion notice for "width" option in Appearance menu"
This reverts commit 89c250c18e.

Reason for revert: We need some more time to test this one and
the resulting behaviour. After discussing this morning we decided
to remove from the next train release.

Bug: T364015
Change-Id: I0dfc17d9c8a8697b8b4f590acdbc2d2c54de9429
2024-05-13 21:33:49 +00:00
jenkins-bot ed49a09010 Merge "Deploy limited width settings" 2024-05-13 15:34:23 +00:00