Commit graph

5374 commits

Author SHA1 Message Date
Lucas Werkmeister ca9ba6cc65 SECURITY: Properly escape vector-toc-toggle-button-label
CVE-2023-PENDING

The line param can contain some markup (since headings can contain
markup), so make that a raw param.

Bug: T340217
Change-Id: I9295a8e0f9f00b62d5206f6d7e40bb657f43651a
2023-09-29 09:08:57 -04:00
James D. Forrester 507de0f4e2 VectorComponentTableOfContentsTest: Add mocks for Message:: escaped() and rawParams()
Needed for new security patch.

Change-Id: I9295a8e0f9f00b62d5206f6d7e40bb657f436510
2023-09-28 20:30:48 -04:00
Lucas Werkmeister 124a4efa2f SECURITY: Catch MalformedTitleException from vector-intro-page
CVE-2023-PENDING

If the vector-intro-page message doesn’t parse as a valid title, skip
customizing the menu entry label instead of crashing. (Optionally, this
could maybe log a warning or something later.)

Bug: T340220
Change-Id: I2769c1f3115898bbe697ebe9c9c0eaf0ddc0d251
2023-09-28 23:16:30 +01:00
jenkins-bot 4a16173b7d Merge "Apply body styles to teleported elements in vector legacy" 2023-09-28 15:49:01 +00:00
Sergio Gimeno 30bddf7f35 Apply body styles to teleported elements in vector legacy
Bug: T347199
Follow-up: Ibd5d8c7cc7880678fae498a451cfd417f1f8e1b8
Change-Id: Ief1c88ce7c3110c2e92793bec3994b8b6a548a7d
2023-09-28 12:20:49 +02:00
jenkins-bot 9fa7eaea9f Merge "build: Update devDependencies" 2023-09-27 23:31:01 +00:00
Jon Robson d35db97615 It should be possible to persist Vector font size for registered users
Bug: T346987
Change-Id: I01e0fac5ba781480ee32a8b32f6ef7fafb8d1ca5
2023-09-27 20:04:22 +00:00
Translation updater bot fbc456b666 Localisation updates from https://translatewiki.net.
Change-Id: I45bb66413a7827228c1fb79b1cfd6934d8344fe8
2023-09-27 09:25:12 +02:00
jenkins-bot 618ec9249d Merge "Apply body styles to mw teleport target" 2023-09-26 20:33:57 +00:00
Sergio Gimeno 76c21734d6 Apply body styles to mw teleport target
Bug: T347199
Change-Id: Ibd5d8c7cc7880678fae498a451cfd417f1f8e1b8
2023-09-26 20:16:57 +00:00
Ed Sanders 1cd0d66bb9 build: Update devDependencies
Holding back some packages as they need some work to unbreak tests:
* mustache
* jest
* typescript

Change-Id: If2b9e27bd83c43c6e7d8c0ac1b6d25b2aa74499b
2023-09-26 07:56:34 +01:00
Translation updater bot 0595a86b5e Localisation updates from https://translatewiki.net.
Change-Id: I2de91055da5a7d558b97afd5998ff42277a6db35
2023-09-26 08:46:46 +02:00
jenkins-bot 315eb55b05 Merge "[anon prefs] Update TOC pin/unpin classes for Zebra" 2023-09-25 22:57:20 +00:00
Translation updater bot ec33b0bd78 Localisation updates from https://translatewiki.net.
Change-Id: Icf13ba2a535fde62f6f1553bd341d3de71d8aead
2023-09-25 08:49:23 +02:00
Translation updater bot 5d7018722d Localisation updates from https://translatewiki.net.
Change-Id: I893fa9c68d61b0529b2b51421f8f382ef1119f51
2023-09-22 08:49:51 +02:00
Jon Robson 0f354e3950 Fixes saving of limited width
Bug: T345363
Change-Id: I3fee7e2b3a063d86a8d91ffa832cca4b72b48610
2023-09-21 19:13:38 +00:00
Translation updater bot 9352cc80e3 Localisation updates from https://translatewiki.net.
Change-Id: I36c2ab08b9d829f60dca2b7e909c766f7d94b795
2023-09-21 10:18:44 +02:00
jenkins-bot edad71e454 Merge "Clean up FIXMES now the cache has cleared" 2023-09-20 07:50:12 +00:00
Translation updater bot 639351e214 Localisation updates from https://translatewiki.net.
Change-Id: I289f33ce263c28faf7ede6a7a6ed53fdd3c94704
2023-09-20 08:58:31 +02:00
Jon Robson d6544e4c5c Clean up FIXMES now the cache has cleared
Follow up to Iad8523037ed364f09962b2d6ca0a3d50d7bd2266

Bug: T346401
Change-Id: Ifa4ab87e43cf28143dc7d753e264d4f0957dcbfa
2023-09-19 20:28:56 +00:00
jenkins-bot 8a2da26eec Merge "Disable client preferences by default" 2023-09-19 20:23:29 +00:00
Jon Robson 2edf135018 Disable client preferences by default
Also make code safe to run when the preferences are
disabled.

Bug: T345363
Change-Id: I00554f3d7b0338170c537ae21d937da35303e8e6
2023-09-19 19:52:21 +00:00
Translation updater bot 67660dc6a8 Localisation updates from https://translatewiki.net.
Change-Id: I40090eb9286aa0869de630dbd5de299bff4e45d1
2023-09-19 09:27:48 +02:00
bwang 09781a5a96 [anon prefs] Update TOC pin/unpin classes for Zebra
Change-Id: I15cc4597d75a18f07bf96491df7a21113b0376ba
2023-09-18 16:27:30 -05:00
jenkins-bot 2049e71435 Merge "Feature: Client preferences interface" 2023-09-18 18:10:47 +00:00
Translation updater bot 4a26581901 Localisation updates from https://translatewiki.net.
Change-Id: I36c06378a6d97db19250bc0bf18efa0915d7c584
2023-09-18 08:47:40 +02:00
Jon Robson 65c48d4eb2 Feature: Client preferences interface
Notes:
* This is functional but intentionally not designed until the design
has been finalized.
* A feature flag is added that swaps out the limited width toggle with
a settings cog
* The preferences module is kept in a separate ResourceLoader module
(skins.vector.clientPreferences) to make it more portable for
when we eventually want to add it to Minerva as well.
* Intentionally have not focused on non-jS version given we will
likely revise this again in a future version/upstream to core.

Bug: T345363
Change-Id: I0c793b73e0676e32f031c6168c292f63908c72e3
2023-09-15 10:03:28 -07:00
Moh'd Khier Abualruz c88d72f1d7 [anon prefs] TOC pinned / unpinned
- Status should persist across page views for anonymous users
- Added 'toc-pinned' as a persistable feature in features.js and FeatureManager.php.
- Handling for cached HTML supporting both new and old class names for pinned/unpinned TOC

Based-On: I0fbe0ab458c5bd55d659d3c35a8fbaa6cd6ec0e1

Bug: T316060
Change-Id: Iad8523037ed364f09962b2d6ca0a3d50d7bd2266
2023-09-14 21:37:50 +00:00
Translation updater bot 9db0f9c3c4 Localisation updates from https://translatewiki.net.
Change-Id: I60186f7c77b63cf07ebea640e19aaa48b8eb78e6
2023-09-14 09:32:30 +02:00
Translation updater bot b0dcf6240e Localisation updates from https://translatewiki.net.
Change-Id: I626987613a4ff5d624ee775c14c4d64f983132ed
2023-09-13 08:34:00 +02:00
Translation updater bot 63d9b48007 Localisation updates from https://translatewiki.net.
Change-Id: I5eda75f870afce294352b4b27329d62b5dd347db
2023-09-12 08:28:49 +02:00
Translation updater bot 8ac1339771 Localisation updates from https://translatewiki.net.
Change-Id: Ief2e5470b35ec0e96c8073eb7f566ed62e8664b9
2023-09-11 09:08:13 +02:00
Translation updater bot 865a3d7c4f Localisation updates from https://translatewiki.net.
Change-Id: I8528c8d15442ebedecc02713d9a6a237057fc00b
2023-09-07 11:17:14 +02:00
Translation updater bot 9ff6559678 Localisation updates from https://translatewiki.net.
Change-Id: I3ee1c250a2d1eb2d762c11aae0cd63d5e79bf666
2023-09-06 08:45:34 +02:00
James D. Forrester 24cebb3d1f build: Update MediaWiki requirement to 1.41
All skins in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: Ic3635684c09e5589a1951ed0e98f08a87d3e5e8c
2023-09-05 23:32:46 +00:00
jenkins-bot b1fd016447 Merge "Update label for Page tools navigation region" 2023-09-05 18:04:37 +00:00
Moh'd Khier Abualruz 7fc6bb0a6a Update label for Page tools navigation region
- Set aria-label to read 'Page tools' in the nav elements

Bug: T330326
Change-Id: I99119aebe98b329d6d1f4e2f8c9f37f77692e8ab
2023-09-05 18:41:38 +02:00
Ed Sanders 1aec6764ad build: Use wikimedia/server for root folder eslint config
Change-Id: I8b6938f2ac935724cf80e01096591e6a4c0cbbe0
2023-09-04 18:13:32 +01:00
Translation updater bot 2286a896bb Localisation updates from https://translatewiki.net.
Change-Id: Ifcf9787f2ee6de3a9702d0cd7f9dea77bf42031c
2023-09-04 08:47:43 +02:00
Translation updater bot 9dd430ee90 Localisation updates from https://translatewiki.net.
Change-Id: I19feed4158ddc509c4751071959082c6df000240
2023-09-01 09:07:40 +02:00
jenkins-bot 66fbc2bf63 Merge "Only show notification after CentralAuth autologin on Vector 2022" 2023-08-30 14:49:05 +00:00
Bartosz Dziewoński 0bb02c9c57 Only show notification after CentralAuth autologin on Vector 2022
This brings in CentralAuth for phan analysis, using config patch
8063720d68ee1d2db2c37c1ad55da3fbef688bce in CI.

Bug: T345112
Change-Id: Iddd94b38f04a34dc18df8978c2bf45e8e204a85c
2023-08-30 08:53:53 -04:00
Translation updater bot 4f66351879 Localisation updates from https://translatewiki.net.
Change-Id: I05d0ec306a0ea411dc10cfed03e9747a8dffe7f8
2023-08-30 08:47:51 +02:00
Translation updater bot 16f50e9277 Localisation updates from https://translatewiki.net.
Change-Id: Id16c45229221eb3ccd48fb715fffdbcb8929ed3a
2023-08-29 08:30:46 +02:00
Eric Gardner 61392b87fe Apply teleport target styles to mediawiki.page.ready module
Updates the style overrides for the #mw-teleport-target element
based on its new location.

Bug: T343476
Depends-On: Id106a36f8ead7424c2ad2881ad79586e48f7bf1d
Change-Id: Id81d7c5c87daeea1b26f4ceda509eb4626364aa8
2023-08-28 22:49:31 +00:00
jenkins-bot 744193d177 Merge "Remove limited width cached HTML handling" 2023-08-28 12:16:23 +00:00
Translation updater bot 3a447ec497 Localisation updates from https://translatewiki.net.
Change-Id: I9af91631f9ecfc72ad81275cbd43aeab44dea8cb
2023-08-28 09:33:23 +02:00
ksarabia c490b19fd0 Update package.json
This updates mw-node-qunit

Bug: T343930
Change-Id: Ice6b8983071b701b752f487935e62736097c2fe9
2023-08-25 16:42:22 -05:00
Eric Gardner 9504b7fb97 Add skinStyles for mediawiki.page.teleportTarget
As part of the fix for T343476, we need to ensure that Dialog
componenents which are teleported out of the main body content
element still receive the appropriate font size from Vector.

Bug: T343476
Depends-On: Ia79b76c0e73890dd18477e5c3ea307d753cedb3a
Change-Id: I545df434f85f38c4074e2fcdfff51e686c9b465a
2023-08-25 21:10:20 +00:00
Jan Drewniak a448233d1d Make Vector feature flag compatible with clientPrefs
Adds the `-clientpref-` string to the Vector font-size
feature flag class, which will now read:

    vector-feature-custom-font-size-clientpref-enabled

Bug: T343928
Change-Id: Iefc575229d52bea820fbee35711650408c917338
2023-08-25 14:58:30 -04:00