wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 15:53:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Clean up FIXMES now the cache has cleared"

Browse source
This commit is contained in:
jenkins-bot 2023-09-20 07:50:12 +00:00 committed by Gerrit Code Review
parent 639351e214 d6544e4c5c
commit edad71e454
5 changed files with 9 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/skins.vector.styles/components/StickyHeader.less
View file

@ -151,10 +151,8 @@
// to make their templates compatible with the Vector 2022 sticky header.
// @stable See the Integration notes for developers section at
// https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Sticky_Header
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
// - `.charts-stickyhead th` makes chart and table headers appear below the sticky header.
&.vector-feature-toc-pinned-clientpref-1 #vector-toc-pinned-container,
&.vector-feature-toc-pinned-enabled #vector-toc-pinned-container,
&.vector-feature-page-tools-pinned-enabled .vector-page-tools-landmark,
.mw-sticky-header-element,
.charts-stickyhead th {

6
resources/skins.vector.styles/components/TableOfContents.less
View file

@ -136,13 +136,9 @@
display: none;
}
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-0 body:not( .vector-sticky-header-visible ) .vector-page-titlebar,
&.vector-feature-toc-pinned-clientpref-0 .vector-sticky-header-visible .vector-sticky-header-context-bar,
&.vector-feature-toc-pinned-clientpref-1 .mw-page-container-inner,
&.vector-feature-toc-pinned-disabled body:not( .vector-sticky-header-visible ) .vector-page-titlebar,
&.vector-feature-toc-pinned-disabled .vector-sticky-header-visible .vector-sticky-header-context-bar,
&.vector-feature-toc-pinned-enabled .mw-page-container-inner {
&.vector-feature-toc-pinned-clientpref-1 .mw-page-container-inner {
> .vector-toc-landmark {
display: block;
}

4
resources/skins.vector.styles/layouts/grid.less
View file

@ -81,10 +81,8 @@
}
// Horizontally center content when column start is empty (i.e. no pinned ToC or pinned main menu)
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-main-menu-pinned-disabled .vector-sidebar-container-no-toc ~ .mw-content-container,
&.vector-feature-main-menu-pinned-disabled.vector-feature-toc-pinned-clientpref-0 .mw-content-container,
&.vector-feature-main-menu-pinned-disabled.vector-feature-toc-pinned-disabled .mw-content-container {
&.vector-feature-main-menu-pinned-disabled.vector-feature-toc-pinned-clientpref-0 .mw-content-container {
grid-column: mainMenu / pageContent;
margin-left: auto;
margin-right: auto;

8
resources/skins.vector.styles/layouts/toc/pinned.less
View file

@ -8,9 +8,7 @@
}
@media ( min-width: @min-width-desktop ) {
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-1 #mw-panel-toc,
&.vector-feature-toc-pinned-enabled #mw-panel-toc {
&.vector-feature-toc-pinned-clientpref-1 #mw-panel-toc {
// Support: Chrome
// Work around sticky-positioned layers disabling subpixel text rendering (T327460).
// NOTE: This property has an effect similar to 'overflow: hidden', and will prevent elements
@ -27,9 +25,7 @@
top: 0;
}
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-1 #vector-toc-pinned-container,
&.vector-feature-toc-pinned-enabled #vector-toc-pinned-container {
&.vector-feature-toc-pinned-clientpref-1 #vector-toc-pinned-container {
// Default spacing separating the sidebar TOC from the main menu.
margin-top: 1.5em;
}

20
resources/skins.vector.styles/layouts/toc/unpinned.less
View file

@ -70,9 +70,7 @@
//
// TOC in page titlebar
//
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-0 body:not( .vector-sticky-header-visible ),
&.vector-feature-toc-pinned-disabled body:not( .vector-sticky-header-visible ) {
&.vector-feature-toc-pinned-clientpref-0 body:not( .vector-sticky-header-visible ) {
.vector-page-titlebar-toc {
.mixin-toc-unpinned();
}
@ -81,9 +79,7 @@
//
// TOC in page titlebar below page title
//
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-0 body:not( .vector-sticky-header-visible ).vector-below-page-title,
&.vector-feature-toc-pinned-disabled body:not( .vector-sticky-header-visible ).vector-below-page-title {
&.vector-feature-toc-pinned-clientpref-0 body:not( .vector-sticky-header-visible ).vector-below-page-title {
.vector-page-titlebar-toc {
.mixin-toc-below-page-title();
}
@ -92,9 +88,7 @@
//
// TOC in sticky header
//
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-0 .vector-sticky-header-visible,
&.vector-feature-toc-pinned-disabled .vector-sticky-header-visible {
&.vector-feature-toc-pinned-clientpref-0 .vector-sticky-header-visible {
.vector-sticky-header-toc {
.mixin-toc-unpinned();
}
@ -106,9 +100,7 @@
//
// No-JS TOC in page titlebar
//
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-0,
&.vector-feature-toc-pinned-disabled {
&.vector-feature-toc-pinned-clientpref-0 {
.vector-page-titlebar-toc {
.mixin-toc-unpinned();
}
@ -121,9 +113,7 @@
// Make the TOC appear in the page titlebar on small viewports
// even when the TOC location in the DOM is actually in the sidebar
// This case only happens for no-js anon users.
// FIXME: Remove vector-feature-toc-pinned-(enabled|disabled) when cache allows.
&.vector-feature-toc-pinned-clientpref-1,
&.vector-feature-toc-pinned-enabled {
&.vector-feature-toc-pinned-clientpref-1 {
#vector-toc-collapsed-button {
display: block;
}