Commit graph

629 commits

Author SHA1 Message Date
jenkins-bot cf999f4e17 Merge "Add print logo" 2017-08-02 00:59:51 +00:00
Translation updater bot 3e05f2b91e Localisation updates from https://translatewiki.net.
Change-Id: Id7c27fad5464e6a31777f1f39dc10548dac72e7c
2017-08-01 22:11:33 +02:00
Baha 413870d350 Add print logo
Logo cannot be displayed as a background image because it won't be
visible in print unless the user prints backgrounds too.

A sample configuration looks like this:

$wgVectorPrintLogo = [
	'url' => 'https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-en.svg',
	'width' => 174,
	'height' => 27
];

The solution presented in the patch has a downside of not being able
to scale images down if their dimensions are bigger than the
dimensions specified in the config variable. For example, if we want
to go with an SVG image, then IE8 won't be able to render it.
Alternatively, if we want to go with a PNG image, its dimensions need
to match the exact dimensoins in the config variable, otherwise the
image will show up larger or smaller depending on its dimensions.

A more complicated approach of scaling images using `transform: scale`
hasn't been used because we wanted to keep the configuration simple
while supporting the majority of our users. With the current change,
we can reuse the existing configuration options from Minerva, for
exmaple. It would look something like this:

$wgVectorPrintLogo = [
	'url' => $wgMFCustomLogos['copyright'],
	'width' => $wgMFCustomLogos['copyright-width'],
	'height' => $wgMFCustomLogos['copyright-height']
];

Bug: T169826
Change-Id: If8f9f8d95fd3c955ece37d6c8ab6995596189667
2017-08-01 10:55:53 -04:00
Translation updater bot 80171ff47f Localisation updates from https://translatewiki.net.
Change-Id: I90221888af4401289eb9dc327ac865019553b358
2017-07-31 22:12:37 +02:00
Antoine Musso 60d6ecbaad Define npm peer dependency explicitly
npm 3 requires dependencies to be explicitly defined.

Bug: T172094
Change-Id: Ic640ccf0f577e47036d473892522ea758014fab4
2017-07-31 12:04:32 +02:00
Bartosz Dziewoński 8c9c30781e Use makeListItem() for menu items rather than building HTML by hand
This affects the four tabs menus (namespaces, variants, views, actions).
Other menus (personal menu and sidebar) have already been using it.

We need some minor overrides to get the same results as the hand-built
HTML, but I think this still makes the code a lot nicer.

The output is the same as before, except for unimportant whitespace
differences and the order of some tag attributes.

I tested this with several extensions and configuration options that
mess with the tabs:
* $wgUsePigLatinVariant = true
* VisualEditor extension
* FileAnnotations extension
* FileExporter extension
* Viewing the page as administrator

Change-Id: I2d1255442abf5fa4bac2de1b084d0bcacbba7d0f
2017-07-29 04:02:36 +00:00
Piotr Miazga 678e39fb91 Hygiene: Do not use ConfigFactory::getDefaultInstance()
ConfigFactory::getDefaultInstance() is deprecated and code should use
MediaWikiServices instead

Change-Id: I085c6cfd724e6005bf8ea6933bf13de98dadb018
2017-07-28 17:59:03 +02:00
jdlrobson d1d639a3ab Print styles: Border bottom of headings should not overlap infoboxes
Specifically this avoids the issue highlighted here:
https://phabricator.wikimedia.org/T169823#3461814

Bug: T169823
Change-Id: Ie73b727e26876b027e5c4276f82a9ae98caff2bb
2017-07-28 11:58:04 +00:00
jenkins-bot 3717c3e590 Merge "Print styles: footer" 2017-07-28 09:34:08 +00:00
jdlrobson d897c8d1d3 Print styles: footer
Tones down license information
and makes last updated primary information in
printed view

Additional changes:
* variables now inherits from mediawiki.ui

Bug: T169823
Change-Id: Ie678967a27baec8715cf86b6a0f7e7651f867be1
2017-07-28 11:22:07 +02:00
Translation updater bot 699ffb8604 Localisation updates from https://translatewiki.net.
Change-Id: Iab1b2191878a4782e8b415d1f36ce7bc7585ae94
2017-07-27 22:32:56 +02:00
jenkins-bot 79647bb41e Merge "Add target support for view_urls" 2017-07-26 17:15:01 +00:00
jenkins-bot f7ec0489cb Merge "Print mode: Define when to use serif and when to use sans-serif" 2017-07-26 16:01:56 +00:00
jdlrobson 728e9a13a2 Print mode: Define when to use serif and when to use sans-serif
Additional changes:
* Define variables for fonts and use them
* Group and make clearer where fonts apply

Bug: T169823
Change-Id: I0b7d557048859936f2eb2f646202bc8071bb84ba
2017-07-26 15:54:52 +00:00
jdlrobson f5124a0dec Print styles: Apply padding and margins to ol as well as ul
Bug: T169823
Change-Id: I60638f18ea5ca4362699e7ea930b426be4e8eee1
2017-07-26 15:54:43 +00:00
Translation updater bot 204781957d Localisation updates from https://translatewiki.net.
Change-Id: I9b102e5fee483f7fc6499704356a5615cb42c443
2017-07-25 22:02:19 +02:00
jenkins-bot 9668f880f5 Merge "Fix CSS selector output in print stylesheet" 2017-07-25 11:55:15 +00:00
jdlrobson 1cbfd714d1 Fix CSS selector output in print stylesheet
Less doesn't allow to nest like this. It creates the invalid selector
`.vector-experimental-print-stylesbody`

This is a follow up to I453ae43099796a74c39d965b796f2fa13942106c

Bug: T169823
Change-Id: I9cc2f474fdcafdcc68378185391607b72b0f667a
2017-07-25 11:29:43 +00:00
Translation updater bot 1ebb116692 Localisation updates from https://translatewiki.net.
Change-Id: I6e72ee22f64273e169e5e4bce974f9004e68ee74
2017-07-24 22:29:33 +02:00
Umherirrender 59ddbcecff build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Change-Id: I1e4fc4fc234b4108c42473e53be608f5f9ba9021
2017-07-24 19:08:55 +02:00
jenkins-bot 1c54b94bc8 Merge "Experimental table of content print styles" 2017-07-21 20:42:28 +00:00
jenkins-bot 5dec71ecd4 Merge "Feature flagged print styles" 2017-07-21 20:41:05 +00:00
Translation updater bot a3b223d001 Localisation updates from https://translatewiki.net.
Change-Id: I89275f2a8b0c05a63a7d9fe7610a1d1f0e0eaa61
2017-07-21 22:06:26 +02:00
jdlrobson 8b9c485580 Experimental table of content print styles
* Provide sense of hierarchy
* Make full width
* Break pages before and after

Bug: T169823
Change-Id: I8a20c70b550de5bfda638873d180ea97880dfd13
2017-07-21 10:45:01 -07:00
jenkins-bot c59d00982e Merge "Remove irritating transition on menu tabs" 2017-07-20 21:50:30 +00:00
Volker E 7a42af066b Remove irritating transition on menu tabs
Removing irritating dropdown arrow position transition
on menu tabs. It is the only place we're using this and it seems obscure
and not helpful to the users from UI Standardization point of view.

Bug: T68698
Change-Id: I8d30108b86b47358349de2ea424c0ba7f67ee7e2
2017-07-20 21:20:59 +00:00
Translation updater bot f5214fa397 Localisation updates from https://translatewiki.net.
Change-Id: I51d3e822edb6a1fc5734a2f3ecf13afb31280200
2017-07-20 22:11:55 +02:00
jdlrobson 3a3e7ac046 Feature flagged print styles
These are feature flagged to allow editors to test before making
them the default. A class is added to the body tag to allow us
to switch between old and new styles at a later date.

To start with we introduce some typography improvements.
Further iterations will focus on other elements.

Changes:
* headings were previously diluted in the body content and difficult to spot.
This evens out the spacing between last content and its own content block.
* clear ownership of <p>s with its heading
* We would like to match Latex style body typography with single column.
The new styles reduce the number of pages by around 20-25%
* hyperlink underline -
This is a community requested feature. We do not use color in print styles
because it's printer friendly. Because of this, it is not possible to indicate
blue links in articles. If a user wants to know if this article exists on wikipedia,
it's not possible given solution.
We would like to underline the <a> tags in print styles.
it's better for accessibility as well.

Bug: T169823
Change-Id: I453ae43099796a74c39d965b796f2fa13942106c
2017-07-20 11:54:55 -07:00
golopot 3f19c24696 Fix misaligned menu tabs
Ensure vertical alignment of menu tabs (for example “More” button) 
with link-only tabs by setting:

* `padding-top: 1.25em;` as on `div.vectorTabs span a`
* `line-height: 1.125em;` as on `div.vectorTabs ul li`

Bug: T171142
Change-Id: Ic4ef86589c6c3d442035f3d768cb9036e1ecc237
2017-07-20 14:14:15 +00:00
jdlrobson c4bab69e96 Don't print #siteSub
Bug: T169823
Change-Id: I45f0abe6ab9378830fa59356b29ff6953962f477
2017-07-18 14:14:15 -07:00
Translation updater bot d39eec0e35 Localisation updates from https://translatewiki.net.
Change-Id: I4004ce8ead79b6c804cf98809411d97ee317d5a0
2017-07-17 22:17:21 +02:00
jenkins-bot 1c03a59ba6 Merge "Remove position: absolute from #p-logo element" 2017-07-15 00:28:45 +00:00
Translation updater bot e967b5ba85 Localisation updates from https://translatewiki.net.
Change-Id: I01d3273ac68bad9c33c69f67c55e43001a6dcea8
2017-07-14 22:04:09 +02:00
Translation updater bot 759c416a12 Localisation updates from https://translatewiki.net.
Change-Id: I349ea91dd144e000f2d7a86aa725760f43c3bfe5
2017-07-13 22:17:18 +02:00
golopot ffc0837bf3 Remove position: absolute from #p-logo element
This was inherited from Monobook (r2881, b52a2a1567).

The #mw-panel (sidebar) was at `top: 160px`.
The #p-logo was at `top: -160px`.
This looks hacky so I set #mw-panel `top: 0`.

Bug: T170053
Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
2017-07-13 16:28:08 +08:00
Fomafix 56ec1a3c87 Remove <div> inside of the <h3>
The <div> was introduced in aba11a7b but this is not valid in HTML 5.

This change ommits the <div> and attaches the background image to the
existing <span>.

Cached HTML with the <div></div> does not matter for the result.

Bug: T169551
Change-Id: I04f7032b6f6bafe10548fde690f55de66b56f61f
2017-07-12 06:21:51 +02:00
jenkins-bot 40699a9a28 Merge "Remove unused selectors for action menu" 2017-07-11 23:45:36 +00:00
Fomafix 5c363643a7 Remove unused selectors for action menu
This change is a follow-up to aba11a7b1c.
Do not deploy this change until HTML cache from before aba11a7b1c expired.

Change-Id: I631260d58229b1b70e2d4e55f8302f9769de3511
2017-07-11 02:59:14 +00:00
Translation updater bot 31d2f2ecba Localisation updates from https://translatewiki.net.
Change-Id: I9f147b1db2a9a487bbf1dd01bf6074bb4552ad90
2017-07-10 22:12:09 +02:00
Translation updater bot 8bc0f3ee74 Localisation updates from https://translatewiki.net.
Change-Id: I57d715864cc9e75a79ce61f416e91c301e213717
2017-07-08 22:03:54 +02:00
Translation updater bot 40596be82c Localisation updates from https://translatewiki.net.
Change-Id: I32d8cdda3dc1883e2a51475d87865761af6743cc
2017-07-07 23:40:35 +02:00
Umherirrender 7e88b1ba45 build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
Change-Id: I7194b948cdae7832c25258d22f51cddbc1dd49dc
2017-07-07 21:25:39 +02:00
Translation updater bot 4a548260ec Localisation updates from https://translatewiki.net.
Change-Id: Id2bcfcc8fb192e7d618dda42433202440e3b7f5e
2017-07-06 22:02:58 +02:00
Translation updater bot 04f955d5bb Localisation updates from https://translatewiki.net.
Change-Id: Ifd8aaa53bf10d7eae80d6018b818173d05332193
2017-07-05 22:00:55 +02:00
jdlrobson e53b4cf522 Vector should operate in responsive mode when the mobile skin
With MobileFrontend installed applying
?useskin=vector&useformat=mobile will ensure that responsive vector
mode is invoked.

I'm keen to do this, as it would help to have more examples of skins
that are MobileFrontend aware as part of the work I am doing in
T166748

Change-Id: I81edd855a5e96400d1179fb10907fcc30ea43ef7
2017-07-03 15:57:49 -07:00
addshore f804c100b6 Add target support for view_urls
Bug: T160676
Change-Id: I07890d17fdf86ece3e01cd8fa0c0e572a4d988c5
2017-06-30 10:54:04 +01:00
Translation updater bot ef8fc08532 Localisation updates from https://translatewiki.net.
Change-Id: Ie59a1f6cca4cc8da0b78f68a9238fac09aa1a199
2017-06-29 22:25:26 +02:00
Translation updater bot fe57327b33 Localisation updates from https://translatewiki.net.
Change-Id: Ia7b4209901b5459e5b6b8961e63f87bbe16204b7
2017-06-28 22:10:54 +02:00
Translation updater bot b72b0e2d06 Localisation updates from https://translatewiki.net.
Change-Id: I20054fa3fa14f5927cc6d553ccb0a59ff48d8fbc
2017-06-27 21:58:35 +02:00
Translation updater bot f184b27b8b Localisation updates from https://translatewiki.net.
Change-Id: Ic3562ce21d350b3838bef114a21e27a3186dce80
2017-06-25 22:24:54 +02:00