Commit graph

5310 commits

Author SHA1 Message Date
Jon Robson 426ff06241 [Optimization] Remove bottom dock styles from critical path
These require JavaScript to work, so hide it by default and then
style it once JavaScript has loaded.

Change-Id: I34ded9f279600945ab18dd7ecfd69d22e141a324
2024-06-14 22:56:52 +00:00
Jan Drewniak d8705f98bf Followup to 71c532e Separate out indicator and icon selectors
@OOUIIndicatorSelectors was accidentally added to
the selector that prevents double inversion.

Bug: T365764
Change-Id: Idc3e2ac9ef50270512b9786db4f525a9ba4754a3
2024-06-14 21:21:29 +00:00
Fomafix c9408c027e Inject service LanguageConverterFactory into VectorComponentVariants
Change-Id: I0e1fa5a8f8f6705e2439bdbc914b9d80b0072c30
2024-06-14 11:23:51 +00:00
Michael Große b32116de30 Add styles performance budget for GrowthExperiments extension
We have CI failing on this test for GrowthExperiments with the styles
budget being exceeded. On changes that do not touch production code at
all.

I do not know how this can happen in the first place, or whether fixing
it this way is sensible, but we need to unblock our CI.

Change-Id: I178cb7ff6f111a11e9b6060960548e65d1c7d3c0
2024-06-14 13:01:43 +02:00
Translation updater bot ed47ecfc46
Localisation updates from https://translatewiki.net.
Change-Id: I7e07e88c4015b0e1af18cf1ca39dd27528e3340a
2024-06-14 09:52:26 +02:00
jenkins-bot 8e263b373f Merge "Separate out indicator and icon selectors" 2024-06-13 23:56:55 +00:00
Jon Robson 71c532e542 Separate out indicator and icon selectors
Follow up to I584491c280d93f18a48d8c90c4d8a6628f1a672f

Since these selectors are nested, this was generating unexpected
selectors, meaning the invert wasn't applying correctly to indicators.

This is evident on Special:Search

Bug: T365764
Change-Id: I40f8a8ad6598d145a6284c831e0cef944c5d7e75
2024-06-13 23:10:10 +00:00
Steph Toyofuku 578e8aaf18 Raise performance budget for GrowthExperiments extension
Bump the GrowthExperiments extension-specific performance budget from
5000 to 7500 since we seem to be running right up against the limit.
Adding a bit of extra wiggle room since this seems to be causing issues
for the growth team, although we should potentially work with them as
the existing comment suggests to lower this

https: //wikimedia.slack.com/archives/C8W3HEHLG/p1718263715588799
Change-Id: Ide1cc5cc1e78dc86b90d731f54a913893ba8c8bd
2024-06-13 14:44:02 -07:00
jenkins-bot 74d5cd5cfc Merge "build: Updating stylelint-config-wikimedia to 0.17.1" 2024-06-13 12:22:06 +00:00
Translation updater bot e6bffd2e48
Localisation updates from https://translatewiki.net.
Change-Id: I101a7bb1823b8b75924eef165e5aec716b2b710d
2024-06-13 09:30:59 +02:00
Umherirrender e8ffe82549 tests: Use renamed class BundleSizeTestBase
Follow-Up: I131e0d85bd14e75aaebd6f212b2e64a45d4c73a2
Change-Id: I55d7a3f0aa281e813e92f676c225fc825c256f13
2024-06-12 20:39:06 +02:00
Volker E 7e6e3bcedb styles: Apply inversion on certain OOUI icons and indicators
In order for most OOUI black icons and indicators to be inverted
correctly, we need to apply the inversion to a limited number of
elements by a general class.
Applying here to keep OOUI library MediaWiki agnostic.

Bug: T365764
Depends-On: I792e89a8253a426b8c723486b96cb87bf9e1d85d
Change-Id: I584491c280d93f18a48d8c90c4d8a6628f1a672f
2024-06-12 15:31:01 +00:00
Translation updater bot 4353654418
Localisation updates from https://translatewiki.net.
Change-Id: Ieb60bd4d3d56cbb57c217743b38b0d56fcb4fd23
2024-06-12 09:24:49 +02:00
Steph Toyofuku 799c2be819 Remove not selector and target OOUI icons for inversion only
A number of icons using the vector-icon class that have been converted
to codex are being double inverted by this rule.  Instead, switch it to
enumerate the full list of OOUI icons and invert them, so that
subsequent codex migrations can be easier as well

Also bumps the bundle size to account for the increase in bytes

Visual change for the table of contents arrows being fixed, ideally not
for anything else

Bug: T365951
Bug: T365580
Change-Id: Ia389e73c72432eb5f7a2df4ff9b48593751bc184
2024-06-11 16:51:14 -07:00
Translation updater bot 1f23275988
Localisation updates from https://translatewiki.net.
Change-Id: Idd7c1ef441d928bac57ea6ef0d6366f07aadf30e
2024-06-11 09:58:17 +02:00
VolkerE 695e355f95 Reapply "styles: Replace deprecated breakpoints"
This reverts the revert commit 4da9b57dcf
and adds updated hardcoded values.
Note that we're also planning a better maintainable solution
with JS constants as Codex library output in T366622

Reason for revert: Working CSS changes now including hardcoded values

Given the issue described in T367103 with max width breakpoints,
these are left hardcoded at their new values with a FIXME to update
these later.

VISUAL CHANGES: there are 3 visual changes with Pixel with this change
- all 3 apply to legacy Vector and look like false positives.

Bug: T349793
Change-Id: I7d151c4ba608cabebe9375b960c0c18b3992954f
2024-06-10 23:09:26 +00:00
Jon Robson 0991d5ef79 Make Vector 2022 pseudo-responsive
We want Vector 2022 to exhibit more responsive behaviours when the
window is resized by forcing these on mobile users

The skin--responsive class is added to the body alongside the
viewport. For now we'll add it in Vector 2022.

Depends-On: I5e3cba54a8d52852e4c33cebdeb76d8ce3257017
Depends-On: I604ea436a816939cd6b2d9ef8c352e319ffcbec0
Depends-On: I0a74a18707dca582bac094e38fa5a0db7298033a
Bug: T113101
Change-Id: Ic5365fc82e2f52486abcd6c52f6cc8964f80a5bd
2024-06-10 22:09:37 +00:00
Umherirrender d3b251de52 Use namespaced classes
Changes to the use statements done automatically via script
Addition of missing use statement done manually

Change-Id: I84dc0ec8a909fce94db2b958eadac9caf661972b
2024-06-10 22:28:40 +02:00
libraryupgrader 5763df6bf4 build: Updating stylelint-config-wikimedia to 0.17.1
Change-Id: I7c1411a3aac14cf6fb4fdbb762b0de22b348b73f
2024-06-10 14:00:06 -04:00
Translation updater bot 8a7933dcf2 Localisation updates from https://translatewiki.net.
Change-Id: I779a1e580cc7cdf54414cc0fc048fd0b01319ab4
2024-06-10 10:00:03 +02:00
jenkins-bot 7a2a013dfe Merge "Revert "styles: Replace deprecated breakpoints"" 2024-06-07 22:24:50 +00:00
Jdrewniak 4da9b57dcf Revert "styles: Replace deprecated breakpoints"
This reverts commit dd5b98515d.

Reason for revert: There are some hard-coded values in JS that reference these breakpoint, and need to be updated along with this change.

Change-Id: I4a16959d98c12ea1ca8b5b848f9cea0b9cea66f5
2024-06-07 21:05:50 +00:00
bwang 711f67ce00 Avoid wrapping floated tables using computed styles
Bug: T366314
Change-Id: I71657b7f1f26bcf52f5ade5b7668955a1f4df24b
2024-06-07 16:49:30 +00:00
Translation updater bot 6298977161 Localisation updates from https://translatewiki.net.
Change-Id: I71a781411f1c5d936edd5e5f8aa11500045767ae
2024-06-07 09:49:40 +02:00
jenkins-bot 873eb668b0 Merge "build: Update eslint-config-wikimedia to 0.28.0 and autofix" 2024-06-06 21:12:56 +00:00
jenkins-bot 2d2a1acdee Merge "styles: Replace deprecated breakpoints" 2024-06-06 19:46:07 +00:00
jenkins-bot abbee9416c Merge "Follow-up to Id04e39 "Adds invert exception for dropdown"" 2024-06-06 18:51:23 +00:00
jenkins-bot 60c61e681e Merge "Add skin-invert-image class" 2024-06-06 16:38:45 +00:00
bwang b24cb0518c Add skin-invert-image class
Bug: T365102
Change-Id: I5961d945b1aaeae1bff1d86c50118fc02dfb77b2
2024-06-06 10:58:57 -05:00
Ed Sanders 7e7486c4a5 build: Update eslint-config-wikimedia to 0.28.0 and autofix
Change-Id: I350941a711d2304fc968b3ba1f1e0afa5878578e
2024-06-06 16:22:05 +01:00
Jan Drewniak 8fb8731c04 Follow-up to Id04e39 "Adds invert exception for dropdown"
Adds hue-rotate( 180deg ) to the
.mixin-vector-arrowed-dropdown-toggle() mixin so that
the language icon doesn't appear with an orange
chevron in dark-mode.

Bug: T366337
Change-Id: If8f07e5924a31d761ac0af7efe0d982886bf6984
2024-06-06 15:17:13 +00:00
jenkins-bot a7dcf88b06 Merge "VisualEditor toolbar should use notheme" 2024-06-05 22:44:08 +00:00
jenkins-bot e1a73d9956 Merge "Make paragraph spacing 0.5em top and 1em bottom by default, handle adjacent inline elements manually" 2024-06-05 19:42:38 +00:00
jenkins-bot 1e4e03395b Merge "Add width exclusion notice" 2024-06-05 19:37:29 +00:00
bwang 716aad56af Add width exclusion notice
Bug: T366216
Change-Id: If50e9adcec6f2fa139e793b3a8108f3b4dd689ca
2024-06-05 19:15:11 +00:00
Jon Robson 8bb2e7d0ae VisualEditor toolbar should use notheme
For now, let's exclude VisualEditor's toolbar from the night theme.
This should result in no visual change, but will make sure it and
its associated icons are not impacted by the roll out of OOUI.

Bug: T365764
Change-Id: Id626a75dbdeddc8809e4ea75eba3c0fd6d2b08fe
2024-06-05 18:13:21 +00:00
bwang 225a02ff20 Make paragraph spacing 0.5em top and 1em bottom by default, handle adjacent inline elements manually
Bug: T366389
Change-Id: If83c7af5ccd4147bcf9b45436c905efac865b98a
2024-06-05 16:02:13 +00:00
Translation updater bot 7775e08ccf Localisation updates from https://translatewiki.net.
Change-Id: I0631dec47bedfb4d8829cafcc6692a32a797d269
2024-06-05 09:26:13 +02:00
Translation updater bot 51f323e3d7 Localisation updates from https://translatewiki.net.
Change-Id: I7df1ad098b6502d90399faadc5b0fa09b2b8a912
2024-06-04 09:34:47 +02:00
Jon Robson e469d75505 [Vector 2010] Increase bundle size limit for responsive behaviours
We will be adding support for responsive images in
core (see I604ea436a816939cd6b2d9ef8c352e319ffcbec0)
so we will need to increase the permitted bundle size for
legacy Vector.

Bug: T113101
Change-Id: I7d9eab9b01bdfa49c7aa0db4a82e006b775cc172
2024-06-03 23:39:27 +00:00
Jon Robson 78136827ce Vector and Vector 2022 no longer share site styles or scripts
Bug: T365771
Change-Id: I508eeb143ecd0a972e2b8790ca2b5982b1d83e71
2024-06-03 18:13:28 +00:00
Translation updater bot 0f4d1bc3b4 Localisation updates from https://translatewiki.net.
Change-Id: I5e72d23f98082599496ba33218b5c39f49022df6
2024-06-03 09:37:11 +02:00
Bartosz Dziewoński 25cc1d2ad7 [Vector legacy] Indicate support for new heading HTML
Add `"supportsMwHeading": true` to the skin definition,
so that MediaWiki 1.43+ will output new heading markup
when using this skin.
https://www.mediawiki.org/wiki/Heading_HTML_changes

The required CSS changes were already made in commit
3c2602b682.

Bug: T365736
Change-Id: I2fd2ef99e49f1c3d0711a08f7bc72fc3cff9e444
2024-06-03 03:33:12 +00:00
jenkins-bot bbfd2ff26c Merge "PerformanceBudgetTest: Increase WikiLambda's budget post-Codex 1.6.1" 2024-05-31 20:19:19 +00:00
jenkins-bot 930665bbed Merge "build: Updating npm dependencies" 2024-05-31 14:01:22 +00:00
James D. Forrester ab7d8ada65 PerformanceBudgetTest: Increase WikiLambda's budget post-Codex 1.6.1
Change-Id: Id2ce4de5efc7bfa67334eecfea0bdda85ac11640
2024-05-31 09:45:51 -04:00
Translation updater bot 83dc6fed7c Localisation updates from https://translatewiki.net.
Change-Id: I6327461cf9d32f76c1851ce756e54d9f5f2673db
2024-05-31 10:00:50 +02:00
libraryupgrader 47c1b2417c build: Updating npm dependencies
* vue: 3.3.9 → 3.4.27
* @wikimedia/codex: 1.6.0 → 1.6.1
* @wikimedia/codex-icons: 1.6.0 → 1.6.1

Additional changes:
* Re-generated the NPM lock file.

Change-Id: Ib47b554180c4140c3fe04f857a5ed810919da108
2024-05-31 05:30:37 +00:00
Steph Toyofuku 84be3de748 Minor fixes to gadget disable logic
Two small changes per comments on
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1036766:
* remove both night mode classes in a single function call
* slightly rework alterDisableLink logic to account for the possibility
that the message is empty when we check it

Bug: T365083
Change-Id: I1633df85e768b7da2f1f542fb793089f34bcc6b7
2024-05-30 16:48:55 -07:00
jenkins-bot 66bc7dbca7 Merge "Minor code change to literal" 2024-05-30 23:04:38 +00:00