Commit graph

1187 commits

Author SHA1 Message Date
Jan Drewniak c12c5f06db Move namespace & view tabs into a VectorTabs.mustache component
Creates a new VectorTabs.mustache component and uses it to render
the namespace & view tabs.

Bug: T239248
Change-Id: I859e4e95a2a12470f66564db547679c9f0a16727
2019-12-04 15:51:02 +01:00
Translation updater bot f790133284 Localisation updates from https://translatewiki.net.
Change-Id: I3b721a7b6fa8bd02316c5813f865d2e10618c271
2019-11-29 08:44:40 +01:00
Translation updater bot d97834d65d Localisation updates from https://translatewiki.net.
Change-Id: I375b30a4689d5b2dbd80b8cec84926b6f586a8ef
2019-11-25 08:29:51 +01:00
Stephen Niedzielski d6f4aaa88e Hygiene: extract VectorTemplate inline HTML to SearchComponent Mustache file
Extract SearchComponent.mustache from VectorTemplate. The "search"
message is now escaped by the template parser. As is, htmlspecialchars()
for "wgScript".

A later patch will change each component renderer function as well as
renderNavigation() to return a string.

Change-Id: I3084b7e0ef73d320c85ee780c9eff13ecea92906
2019-11-20 16:41:05 -05:00
Stephen Niedzielski c9f15a4206 Hygiene: move VectorTemplate inlined PHP to variables
Move template logic outside of the template and into variables. This
will allow a future refactor to move the template to a separate
template-only file.

Change-Id: I91c2df11106cf09428a890a2d96ecbddb18ef0fe
2019-11-20 16:35:04 -05:00
jenkins-bot 501b94f1b4 Merge "Hygiene: divide VectorTemplate.renderNavigation()" 2019-11-20 20:00:40 +00:00
jenkins-bot 546560c755 Merge "Set overflow-y to scroll to prevent reflow" 2019-11-19 14:21:34 +00:00
jenkins-bot 7aa2e8f19a Merge "Hygiene: remove getPageClasses" 2019-11-18 22:59:52 +00:00
Volker E c8e0ea32b1 Set overflow-y to scroll to prevent reflow
Setting `overflow-y: scroll` to prevent reflow as soon as content
comes in. Adding it to `body` as there might be side-effects when
it's set on both, `html` and `body` and latter seems to be the
place where volunteers or third parties would have set it already.

Bug: T204084
Change-Id: Id9ee2e85225f969b6a286628b70fb7a4e447040c
2019-11-18 14:42:03 -08:00
Volker E 6d6e1f1121 Bump h3 to 14pt to set apart from running text
Bug: T183105
Change-Id: I56ebe653a49f548a84643944fd96453219cad804
2019-11-18 14:22:03 -08:00
Stephen Niedzielski 625ec18f81 Hygiene: divide VectorTemplate.renderNavigation()
Cut up renderNavigation() into several discrete methods. Smaller methods
are easier to read and reason about.

Change-Id: I4e55d858ab1745fb2baddef02f7046ec842eb149
2019-11-18 15:26:20 -05:00
Piotr Miazga 2f355a3e11 Hygiene: remove getPageClasses
Looks like the SkinVector::getPageClasses is doing nothing, only
calling the Skin::getPageClasses and returning the output.

Change-Id: I5becaa1505d46cbf9a07b8bfe73ddf324b740876
2019-11-18 15:13:24 -05:00
Translation updater bot 6ce3b83954 Localisation updates from https://translatewiki.net.
Change-Id: I42bcb178a4fe1df0e617b218e7cce99c8d7fae87
2019-11-18 08:35:36 +01:00
jenkins-bot dca39c79cc Merge "Bump running text to more generally readable 12pt on print stylesheet" 2019-11-12 10:45:43 +00:00
Volker E 1d68f1dec3 Bump running text to more generally readable 12pt on print stylesheet
Also bumping headings to not go smaller than running text and
leaving footer text unchanged.

Bug: T183105
Change-Id: Ifb57a6261b6908f23dca52e4544c58ec1935009a
2019-11-12 10:30:24 +00:00
Translation updater bot 45f66ed038 Localisation updates from https://translatewiki.net.
Change-Id: Iaf9ec4c1d26fbc0c580ae03c2edbe8159f8d7f07
2019-11-11 08:40:46 +01:00
Translation updater bot 28b575ddff Localisation updates from https://translatewiki.net.
Change-Id: Ia65aaa9ca4b598f45f1a4b9c5957cab46aa4b6c8
2019-11-07 08:52:29 +01:00
Translation updater bot e8c9b1e47d Localisation updates from https://translatewiki.net.
Change-Id: I4730c4ffcfa25dac408e2449dfa734b4661ee8d8
2019-11-04 08:41:24 +01:00
Umherirrender c19da7d224 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: If87fa3451b328419055ddb1700d9fd3a770f8c76
2019-11-02 19:50:52 +01:00
Ed Sanders c61f6469db build: Update linters
Change-Id: I17a65638e0c7d074d4c1db282b278798e875fbe1
2019-10-31 21:43:20 +00:00
Translation updater bot 04c50cedc4 Localisation updates from https://translatewiki.net.
Change-Id: I56654ae229775b3671161fad50175242bc2aaad0
2019-10-30 08:38:51 +01:00
jenkins-bot ac483a78ed Merge "hygiene: Make LESS imports non-ambigious" 2019-10-28 08:31:27 +00:00
Translation updater bot acc1405a32 Localisation updates from https://translatewiki.net.
Change-Id: Ibba4fb2168893e58b1b4570a1e41b97fdc432874
2019-10-28 08:58:20 +01:00
Volker E f2695a5bf3 hygiene: Make LESS imports non-ambigious
Some LESS parsers will get confused with the lack of file extension.
It's better to be explicit and in alignment with recent change in core
I379334d7729e587a2a00.
It was already weirdly mixed in this repo with some imports featuring
extension and some not.

Change-Id: If5065cf9e30289de9b4fd33315bd65b75959ecb7
2019-10-25 20:54:49 +00:00
Timo Tijhof a5fe72696b Remove extra <span> from Vector tabs
No longer needed as of I8237976e0587.

Bug: T236410
Change-Id: I5a59c136de4572e5f11b52cc11bc93251c972369
2019-10-25 15:22:57 +00:00
Timo Tijhof 481c90798e Make extra <span> in Vector tabs optional
Applying calculation measurments to have full pixel equivalent to
`em` based properties that are necessary for user font scaling
preference ability.

Also:
* Changing watchlist icon to `em` based sizing and remodulate positioning
  by putting it on `:before` elements.
* Changing calculation of `.vectorMenu h3` to acommodate down arrow indicator.

TODO:
* Remove the extra <span> (in separate commit, to make it easier
  to rest cache compat during code review).

Bug: T236410
Change-Id: I8237976e05870378be3430e3e14c3e6993de3dc1
2019-10-24 22:42:32 -07:00
jenkins-bot 0e2f5de63c Merge "Don't overspecify selector" 2019-10-24 17:13:11 +00:00
Volker E c27700d811 Don't overspecify selector
Remove unneeded `div` from selector.

Change-Id: I7f69b8cde8a721d13b2578bac11db2c3dea690f2
2019-10-23 15:11:30 -07:00
Volker E 51dd4bb7d9 Remove ignored properties in certain combinations
Removing
- `clear` when used with `position: absolute`
- `float` when used with `position: absolute`

Change-Id: I14661c4078e4d5f776596842674cef7e7ddcf708
2019-10-23 14:54:45 -07:00
Fomafix 2f94748938 Use stroke-width="1" instead of stroke-width=".99992"
This make the file size smaller without any visible change.

Change-Id: Ib840585b1a06a42e7ebfc64fa04d840716fc81b7
2019-10-17 09:26:05 +02:00
Translation updater bot 2a7e8ea8c6 Localisation updates from https://translatewiki.net.
Change-Id: Iff06025f9a08a353dc3981410e8a73faef6cf514
2019-10-17 09:12:35 +02:00
Timo Tijhof b7b8c77c1e Update ResourceModuleSkinStyles for jquery.ui change
Follows-up I9070ad905 in MediaWiki core.

Depends-On: I9070ad9052319f5ca2bc67e0ffaf502db0f13ceb
Bug: T219604
Change-Id: Ib13bf24f4d8fa8da932b57439e2b52ec10545f3c
2019-10-16 23:44:40 +01:00
Translation updater bot 1232a9bfdd Localisation updates from https://translatewiki.net.
Change-Id: I7bdc3fbbef521fad5be543319b24ea2ede3713c5
2019-10-16 20:47:07 +02:00
Translation updater bot 6234e6c1d2 Localisation updates from https://translatewiki.net.
Change-Id: Ifd5544868b795f577f1b515ba4a68f7d8ca1e68b
2019-10-16 09:29:39 +02:00
jenkins-bot 1372dd2258 Merge "Print: Remove underline for image links" 2019-10-15 13:53:22 +00:00
Derk-Jan Hartman 202205c0d0 Print: Remove underline for image links
Bug: T225093
Change-Id: I80efccab2dd2e5a0808eb57fab06e9cde73c1844
2019-10-15 12:48:10 +00:00
Bartosz Dziewoński 34c3da2ecb Apply transparent background to both search buttons
Bug: T235319
Change-Id: I7c0f64cef0d429166ad044ea9ddd55c4c7d1dec2
2019-10-14 16:50:17 +02:00
James D. Forrester 82bed7da8c build: Upgrade mediawiki-codesniffer to v28.0.0
Change-Id: I61a3c466aa3deba61f2cc437498dc941cd9ee426
2019-10-11 12:13:38 -07:00
Jforrester d2b6a3524a Revert "Localisation updates from https://translatewiki.net."
This reverts commit 31b53496e8.

Reason for revert: Corrupted export.

Bug: T235188.
Change-Id: I823d47d3f9657b7268ad264fd068f35ded2a187e
2019-10-10 16:44:13 +00:00
Translation updater bot 31b53496e8 Localisation updates from https://translatewiki.net.
Change-Id: I2bfcdc0dfc1a0bdd4b361873f3a59140933dfe5d
2019-10-10 08:37:48 +02:00
Ed Sanders 370f52e692 build: Update linters
Change-Id: I58969b531c70eba70a7fa7a8fc0ba1ad521ba9f5
2019-10-07 16:41:27 +01:00
Volker E 9fc3d8d684 Remove IE 6 & 7 hasLayout hacks
Bug: T234582
Change-Id: I43b2feb6941769524dfe2c728dfb62f999d5f65b
2019-10-03 20:00:54 -07:00
Volker E 9bc73009cb Remove IE 6 & 7 specific star hack
Internet Explorer 6 & 7 support. Gone.

Bug: T234582
Change-Id: I0878fa73146596362c88a0c4cbfd6121440bbde3
2019-10-03 18:10:51 -07:00
Timo Tijhof e5c837e3eb Remove unused 'jquery.tabIndex' dependency
Follows-up bfc5a57.

Bug: T226148
Bug: T233676
Change-Id: Icb4a2458c40482a45172ce09f6ec14c4f7d1ccdf
2019-10-04 00:07:44 +00:00
Volker E ef18f498a8 Remove obsolete @content-line-height LESS var
Made obsolete in I514467e4065d2.

Change-Id: I83489b899be62c2f0f2f6fc34ac6c0bc8a4caa34
2019-10-02 14:59:22 -07:00
jenkins-bot 37e2db256f Merge "Lighten up search input background slightly" 2019-10-02 19:30:34 +00:00
jenkins-bot 5b03d18ce9 Merge "Re-order background* properties to unify across files" 2019-10-02 19:30:33 +00:00
Volker E a10382b144 Lighten up search input background slightly
Increasing contrast by ligthened search input background and moving
properties to search input alone.

Bug: T225331
Change-Id: If888d32b829b01b2457f3f5c727fb59a6219f940
2019-10-02 00:24:25 -07:00
Translation updater bot 59eb70d648 Localisation updates from https://translatewiki.net.
Change-Id: I4ac823ac48c53b4f82c02f891c14e819aeb5eec2
2019-10-02 08:28:01 +02:00
Timo Tijhof e32df2ad20 vector.js: Remove eager calculation of p-cactions width on page load
With these optimisations applied, there is no longer any need for
the width value during most page views, and even for most resize
operations. As such, eagerly computing it ahead of time, even from an
idle callback, no longer makes sense.

It is still memoised because it's worth avoiding a recalc during
some of the code paths that need it. Also because this way the
logic stays compatible. I don't know for sure if all involved logic
would be able to handle the value changing over time.

Optimisations:

* Where possible, don't depend on jQuery width() working on invisible
  elements. Specifically, don't depend on it giving you the width of the
  element *as if* it were visible when it is invisible. When logged-out and,
  when navigating special pages (e.g. Special:Blankpage), the #p-cactions
  element is an emptyPortlet with `display: none;` set.

  The animation logic was depending on initialCactionsWidth() providing
  the width the element would have if it were visible. This is because
  jQuery width(), will actually change 'display: none' to 'display: block',
  force render virtually, compute the width, and then change back.
  Instead of depending on this discouraged feature [1], move this calculation
  to the code dealing with the animation and calculating it there, ourselves,
  right after making it visible for real (but before shrinking it for the
  hidden-to-visible growing expansion animation).

* Document our reliance on this discouraged feature for the remaining two
  callers in expandCondition() and collapseCondition(). Both of those
  need the initial width as-if visible and generally are not in charge
  direclty of making it visible (so there's no better place to measure
  it), and are in fact almost always called when the element is invisible,
  thus pretty much exclusively depending on it, not even as an edge case.

* In collapseCondition(), optimise the logic to remember whether
  collapsing is needed. This way, it won't need to call initialCactionsWidth()
  if the loop iterated zero times (turns out to be impossible, but not
  obvious from the code).

Follows-up 46f1d41 and 9b2bcbb.

Change-Id: I6f3a5c937eb17d194a7e00ab273768a5f2cb7cd2
2019-10-02 05:58:13 +00:00