Commit graph

1176 commits

Author SHA1 Message Date
Stephen Niedzielski 625ec18f81 Hygiene: divide VectorTemplate.renderNavigation()
Cut up renderNavigation() into several discrete methods. Smaller methods
are easier to read and reason about.

Change-Id: I4e55d858ab1745fb2baddef02f7046ec842eb149
2019-11-18 15:26:20 -05:00
Translation updater bot 6ce3b83954 Localisation updates from https://translatewiki.net.
Change-Id: I42bcb178a4fe1df0e617b218e7cce99c8d7fae87
2019-11-18 08:35:36 +01:00
jenkins-bot dca39c79cc Merge "Bump running text to more generally readable 12pt on print stylesheet" 2019-11-12 10:45:43 +00:00
Volker E 1d68f1dec3 Bump running text to more generally readable 12pt on print stylesheet
Also bumping headings to not go smaller than running text and
leaving footer text unchanged.

Bug: T183105
Change-Id: Ifb57a6261b6908f23dca52e4544c58ec1935009a
2019-11-12 10:30:24 +00:00
Translation updater bot 45f66ed038 Localisation updates from https://translatewiki.net.
Change-Id: Iaf9ec4c1d26fbc0c580ae03c2edbe8159f8d7f07
2019-11-11 08:40:46 +01:00
Translation updater bot 28b575ddff Localisation updates from https://translatewiki.net.
Change-Id: Ia65aaa9ca4b598f45f1a4b9c5957cab46aa4b6c8
2019-11-07 08:52:29 +01:00
Translation updater bot e8c9b1e47d Localisation updates from https://translatewiki.net.
Change-Id: I4730c4ffcfa25dac408e2449dfa734b4661ee8d8
2019-11-04 08:41:24 +01:00
Umherirrender c19da7d224 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: If87fa3451b328419055ddb1700d9fd3a770f8c76
2019-11-02 19:50:52 +01:00
Ed Sanders c61f6469db build: Update linters
Change-Id: I17a65638e0c7d074d4c1db282b278798e875fbe1
2019-10-31 21:43:20 +00:00
Translation updater bot 04c50cedc4 Localisation updates from https://translatewiki.net.
Change-Id: I56654ae229775b3671161fad50175242bc2aaad0
2019-10-30 08:38:51 +01:00
jenkins-bot ac483a78ed Merge "hygiene: Make LESS imports non-ambigious" 2019-10-28 08:31:27 +00:00
Translation updater bot acc1405a32 Localisation updates from https://translatewiki.net.
Change-Id: Ibba4fb2168893e58b1b4570a1e41b97fdc432874
2019-10-28 08:58:20 +01:00
Volker E f2695a5bf3 hygiene: Make LESS imports non-ambigious
Some LESS parsers will get confused with the lack of file extension.
It's better to be explicit and in alignment with recent change in core
I379334d7729e587a2a00.
It was already weirdly mixed in this repo with some imports featuring
extension and some not.

Change-Id: If5065cf9e30289de9b4fd33315bd65b75959ecb7
2019-10-25 20:54:49 +00:00
Timo Tijhof a5fe72696b Remove extra <span> from Vector tabs
No longer needed as of I8237976e0587.

Bug: T236410
Change-Id: I5a59c136de4572e5f11b52cc11bc93251c972369
2019-10-25 15:22:57 +00:00
Timo Tijhof 481c90798e Make extra <span> in Vector tabs optional
Applying calculation measurments to have full pixel equivalent to
`em` based properties that are necessary for user font scaling
preference ability.

Also:
* Changing watchlist icon to `em` based sizing and remodulate positioning
  by putting it on `:before` elements.
* Changing calculation of `.vectorMenu h3` to acommodate down arrow indicator.

TODO:
* Remove the extra <span> (in separate commit, to make it easier
  to rest cache compat during code review).

Bug: T236410
Change-Id: I8237976e05870378be3430e3e14c3e6993de3dc1
2019-10-24 22:42:32 -07:00
jenkins-bot 0e2f5de63c Merge "Don't overspecify selector" 2019-10-24 17:13:11 +00:00
Volker E c27700d811 Don't overspecify selector
Remove unneeded `div` from selector.

Change-Id: I7f69b8cde8a721d13b2578bac11db2c3dea690f2
2019-10-23 15:11:30 -07:00
Volker E 51dd4bb7d9 Remove ignored properties in certain combinations
Removing
- `clear` when used with `position: absolute`
- `float` when used with `position: absolute`

Change-Id: I14661c4078e4d5f776596842674cef7e7ddcf708
2019-10-23 14:54:45 -07:00
Fomafix 2f94748938 Use stroke-width="1" instead of stroke-width=".99992"
This make the file size smaller without any visible change.

Change-Id: Ib840585b1a06a42e7ebfc64fa04d840716fc81b7
2019-10-17 09:26:05 +02:00
Translation updater bot 2a7e8ea8c6 Localisation updates from https://translatewiki.net.
Change-Id: Iff06025f9a08a353dc3981410e8a73faef6cf514
2019-10-17 09:12:35 +02:00
Timo Tijhof b7b8c77c1e Update ResourceModuleSkinStyles for jquery.ui change
Follows-up I9070ad905 in MediaWiki core.

Depends-On: I9070ad9052319f5ca2bc67e0ffaf502db0f13ceb
Bug: T219604
Change-Id: Ib13bf24f4d8fa8da932b57439e2b52ec10545f3c
2019-10-16 23:44:40 +01:00
Translation updater bot 1232a9bfdd Localisation updates from https://translatewiki.net.
Change-Id: I7bdc3fbbef521fad5be543319b24ea2ede3713c5
2019-10-16 20:47:07 +02:00
Translation updater bot 6234e6c1d2 Localisation updates from https://translatewiki.net.
Change-Id: Ifd5544868b795f577f1b515ba4a68f7d8ca1e68b
2019-10-16 09:29:39 +02:00
jenkins-bot 1372dd2258 Merge "Print: Remove underline for image links" 2019-10-15 13:53:22 +00:00
Derk-Jan Hartman 202205c0d0 Print: Remove underline for image links
Bug: T225093
Change-Id: I80efccab2dd2e5a0808eb57fab06e9cde73c1844
2019-10-15 12:48:10 +00:00
Bartosz Dziewoński 34c3da2ecb Apply transparent background to both search buttons
Bug: T235319
Change-Id: I7c0f64cef0d429166ad044ea9ddd55c4c7d1dec2
2019-10-14 16:50:17 +02:00
James D. Forrester 82bed7da8c build: Upgrade mediawiki-codesniffer to v28.0.0
Change-Id: I61a3c466aa3deba61f2cc437498dc941cd9ee426
2019-10-11 12:13:38 -07:00
Jforrester d2b6a3524a Revert "Localisation updates from https://translatewiki.net."
This reverts commit 31b53496e8.

Reason for revert: Corrupted export.

Bug: T235188.
Change-Id: I823d47d3f9657b7268ad264fd068f35ded2a187e
2019-10-10 16:44:13 +00:00
Translation updater bot 31b53496e8 Localisation updates from https://translatewiki.net.
Change-Id: I2bfcdc0dfc1a0bdd4b361873f3a59140933dfe5d
2019-10-10 08:37:48 +02:00
Ed Sanders 370f52e692 build: Update linters
Change-Id: I58969b531c70eba70a7fa7a8fc0ba1ad521ba9f5
2019-10-07 16:41:27 +01:00
Volker E 9fc3d8d684 Remove IE 6 & 7 hasLayout hacks
Bug: T234582
Change-Id: I43b2feb6941769524dfe2c728dfb62f999d5f65b
2019-10-03 20:00:54 -07:00
Volker E 9bc73009cb Remove IE 6 & 7 specific star hack
Internet Explorer 6 & 7 support. Gone.

Bug: T234582
Change-Id: I0878fa73146596362c88a0c4cbfd6121440bbde3
2019-10-03 18:10:51 -07:00
Timo Tijhof e5c837e3eb Remove unused 'jquery.tabIndex' dependency
Follows-up bfc5a57.

Bug: T226148
Bug: T233676
Change-Id: Icb4a2458c40482a45172ce09f6ec14c4f7d1ccdf
2019-10-04 00:07:44 +00:00
Volker E ef18f498a8 Remove obsolete @content-line-height LESS var
Made obsolete in I514467e4065d2.

Change-Id: I83489b899be62c2f0f2f6fc34ac6c0bc8a4caa34
2019-10-02 14:59:22 -07:00
jenkins-bot 37e2db256f Merge "Lighten up search input background slightly" 2019-10-02 19:30:34 +00:00
jenkins-bot 5b03d18ce9 Merge "Re-order background* properties to unify across files" 2019-10-02 19:30:33 +00:00
Volker E a10382b144 Lighten up search input background slightly
Increasing contrast by ligthened search input background and moving
properties to search input alone.

Bug: T225331
Change-Id: If888d32b829b01b2457f3f5c727fb59a6219f940
2019-10-02 00:24:25 -07:00
Translation updater bot 59eb70d648 Localisation updates from https://translatewiki.net.
Change-Id: I4ac823ac48c53b4f82c02f891c14e819aeb5eec2
2019-10-02 08:28:01 +02:00
Timo Tijhof e32df2ad20 vector.js: Remove eager calculation of p-cactions width on page load
With these optimisations applied, there is no longer any need for
the width value during most page views, and even for most resize
operations. As such, eagerly computing it ahead of time, even from an
idle callback, no longer makes sense.

It is still memoised because it's worth avoiding a recalc during
some of the code paths that need it. Also because this way the
logic stays compatible. I don't know for sure if all involved logic
would be able to handle the value changing over time.

Optimisations:

* Where possible, don't depend on jQuery width() working on invisible
  elements. Specifically, don't depend on it giving you the width of the
  element *as if* it were visible when it is invisible. When logged-out and,
  when navigating special pages (e.g. Special:Blankpage), the #p-cactions
  element is an emptyPortlet with `display: none;` set.

  The animation logic was depending on initialCactionsWidth() providing
  the width the element would have if it were visible. This is because
  jQuery width(), will actually change 'display: none' to 'display: block',
  force render virtually, compute the width, and then change back.
  Instead of depending on this discouraged feature [1], move this calculation
  to the code dealing with the animation and calculating it there, ourselves,
  right after making it visible for real (but before shrinking it for the
  hidden-to-visible growing expansion animation).

* Document our reliance on this discouraged feature for the remaining two
  callers in expandCondition() and collapseCondition(). Both of those
  need the initial width as-if visible and generally are not in charge
  direclty of making it visible (so there's no better place to measure
  it), and are in fact almost always called when the element is invisible,
  thus pretty much exclusively depending on it, not even as an edge case.

* In collapseCondition(), optimise the logic to remember whether
  collapsing is needed. This way, it won't need to call initialCactionsWidth()
  if the loop iterated zero times (turns out to be impossible, but not
  obvious from the code).

Follows-up 46f1d41 and 9b2bcbb.

Change-Id: I6f3a5c937eb17d194a7e00ab273768a5f2cb7cd2
2019-10-02 05:58:13 +00:00
Volker E 7446c28f79 Re-order background* properties to unify across files
Orienting on https://www.mediawiki.org/wiki/Topic:Tv3wddg7n9nz8ft8

Change-Id: I4504600fcc0c54f684eddde9c66cbc6b4d419846
2019-10-01 17:14:30 -07:00
jenkins-bot 60c59736da Merge "Replace raster image gradients with CSS where easily applicable" 2019-10-01 21:52:23 +00:00
Volker E 0e0d77fef3 Replace raster image gradients with CSS where easily applicable
Replace raster image gradients (before base64 embedded) for modern
browsers by CSS gradients. Only relying on conventional image URLs
in browsers that don't support linear-gradient.
Also
- adding a darkened border for inactive tabs to harmonize visual
  perception of border as one continuous line and
- DRYing tab separator selectors, saving ~8 bytes gzipped.

Bug: T63099
Bug: T121730
Change-Id: I76d32b84ddff06a2c7ef983e6f89ca6e74257a67
2019-10-01 14:24:07 -07:00
jenkins-bot ad3c268a93 Merge "Replace portal break image by SVG gradient" 2019-10-01 19:11:24 +00:00
Volker E 5ed9bf8be6 Replace portal break image by SVG gradient
Replace raster image gradients (before base64 embedded) for modern
browsers by CSS gradients. Only relying on conventional image URLs
in browsers that don't support linear-gradient.
Also updating color to Wikimedia Design Style Guide color and
removing obsolete *-ltr/*-rtl images that have been introduced in
MW core 1.16.0beta1 but have been replaced by unified 'portal-break'
image afterwards.

Bug: T63099
Bug: T121730
Change-Id: Id0ab5eb7d4a5751316ce750aff2dffbda62f6b09
2019-10-01 19:39:34 +01:00
Translation updater bot 46ad65a7b8 Localisation updates from https://translatewiki.net.
Change-Id: I656224205bd85d4c3ec95df6e18a0e7a4ee0bc82
2019-10-01 08:34:32 +02:00
Volker E 0175a2be2e Remove unneeded portal background properties.
Have been in since before Idfc38503d8397ffe where 'portal-break.png'
was still applied on `div.portal` and not ever after on `.portal .body`.

Change-Id: Icbaed3f9d41a46a0f5d17266c29703024ffc1412
2019-09-30 19:09:38 -07:00
Volker E 7227e50b0a Simplify watch link selectors
Change-Id: I51b1f66900dbc4982156b5356783a69a7025ebe7
2019-09-30 14:05:31 -07:00
Volker E 190d9830ca Reduce specificity by using classes without element selector addition
That's not only good practice, it also allows to widely simplify
'watchstar.less' selectors.

Change-Id: Ic31452f985e99d60f6fc71473be7de08bdc16148
2019-09-30 00:36:32 -07:00
Volker E 1d7c3fac99 Remove unneeded selector
Has been added in 8db5779682, but there's no `span` as direct child
of the watchstar `a` (any more).

Change-Id: I989cfd0c1fe30a0b4821f79e1d9377b8d888c24b
2019-09-30 00:07:17 -07:00
Volker E e3f9cdcf70 Variablize all color property values
Also going with `--modifier` naming scheme when direct pseudo-class
modifying variable. And fixing small typo.

Change-Id: Ife2f9dc9cb57c063a43e4b3dfad3c737aaf3b72b
2019-09-29 23:36:58 -07:00