Commit graph

5376 commits

Author SHA1 Message Date
bwang 716aad56af Add width exclusion notice
Bug: T366216
Change-Id: If50e9adcec6f2fa139e793b3a8108f3b4dd689ca
2024-06-05 19:15:11 +00:00
Jon Robson 8bb2e7d0ae VisualEditor toolbar should use notheme
For now, let's exclude VisualEditor's toolbar from the night theme.
This should result in no visual change, but will make sure it and
its associated icons are not impacted by the roll out of OOUI.

Bug: T365764
Change-Id: Id626a75dbdeddc8809e4ea75eba3c0fd6d2b08fe
2024-06-05 18:13:21 +00:00
bwang 225a02ff20 Make paragraph spacing 0.5em top and 1em bottom by default, handle adjacent inline elements manually
Bug: T366389
Change-Id: If83c7af5ccd4147bcf9b45436c905efac865b98a
2024-06-05 16:02:13 +00:00
Translation updater bot 7775e08ccf Localisation updates from https://translatewiki.net.
Change-Id: I0631dec47bedfb4d8829cafcc6692a32a797d269
2024-06-05 09:26:13 +02:00
Translation updater bot 51f323e3d7 Localisation updates from https://translatewiki.net.
Change-Id: I7df1ad098b6502d90399faadc5b0fa09b2b8a912
2024-06-04 09:34:47 +02:00
Jon Robson e469d75505 [Vector 2010] Increase bundle size limit for responsive behaviours
We will be adding support for responsive images in
core (see I604ea436a816939cd6b2d9ef8c352e319ffcbec0)
so we will need to increase the permitted bundle size for
legacy Vector.

Bug: T113101
Change-Id: I7d9eab9b01bdfa49c7aa0db4a82e006b775cc172
2024-06-03 23:39:27 +00:00
Jon Robson 78136827ce Vector and Vector 2022 no longer share site styles or scripts
Bug: T365771
Change-Id: I508eeb143ecd0a972e2b8790ca2b5982b1d83e71
2024-06-03 18:13:28 +00:00
Translation updater bot 0f4d1bc3b4 Localisation updates from https://translatewiki.net.
Change-Id: I5e72d23f98082599496ba33218b5c39f49022df6
2024-06-03 09:37:11 +02:00
Bartosz Dziewoński 25cc1d2ad7 [Vector legacy] Indicate support for new heading HTML
Add `"supportsMwHeading": true` to the skin definition,
so that MediaWiki 1.43+ will output new heading markup
when using this skin.
https://www.mediawiki.org/wiki/Heading_HTML_changes

The required CSS changes were already made in commit
3c2602b682.

Bug: T365736
Change-Id: I2fd2ef99e49f1c3d0711a08f7bc72fc3cff9e444
2024-06-03 03:33:12 +00:00
jenkins-bot bbfd2ff26c Merge "PerformanceBudgetTest: Increase WikiLambda's budget post-Codex 1.6.1" 2024-05-31 20:19:19 +00:00
jenkins-bot 930665bbed Merge "build: Updating npm dependencies" 2024-05-31 14:01:22 +00:00
James D. Forrester ab7d8ada65 PerformanceBudgetTest: Increase WikiLambda's budget post-Codex 1.6.1
Change-Id: Id2ce4de5efc7bfa67334eecfea0bdda85ac11640
2024-05-31 09:45:51 -04:00
Translation updater bot 83dc6fed7c Localisation updates from https://translatewiki.net.
Change-Id: I6327461cf9d32f76c1851ce756e54d9f5f2673db
2024-05-31 10:00:50 +02:00
libraryupgrader 47c1b2417c build: Updating npm dependencies
* vue: 3.3.9 → 3.4.27
* @wikimedia/codex: 1.6.0 → 1.6.1
* @wikimedia/codex-icons: 1.6.0 → 1.6.1

Additional changes:
* Re-generated the NPM lock file.

Change-Id: Ib47b554180c4140c3fe04f857a5ed810919da108
2024-05-31 05:30:37 +00:00
Steph Toyofuku 84be3de748 Minor fixes to gadget disable logic
Two small changes per comments on
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1036766:
* remove both night mode classes in a single function call
* slightly rework alterDisableLink logic to account for the possibility
that the message is empty when we check it

Bug: T365083
Change-Id: I1633df85e768b7da2f1f542fb793089f34bcc6b7
2024-05-30 16:48:55 -07:00
jenkins-bot 66bc7dbca7 Merge "Minor code change to literal" 2024-05-30 23:04:38 +00:00
jenkins-bot 3fb0bb484b Merge "Disable night mode if gadget detected" 2024-05-30 22:53:51 +00:00
Jon Robson deedcbcdb1 Minor code change to literal
Satisfy typescripts needs
Literals are evaluated faster and what we use more consistently.
With typescript, since keys and values can be any value, we need
to declare explictly the expected types of the values via a
@type command.

Note Object is also a constructor, if you use `new Object()` you
would get the same typescript error.

Follow up to I9583ee7ebf8c810ddd504193d568034c954d28f2

Bug: T365083
Change-Id: Ibfda8ea1bcf2ecb6b280302197af33e4c4065d95
2024-05-30 15:38:04 -07:00
Steph Toyofuku 4a0c2cb684 Disable night mode if gadget detected
While our implementation of night mode is in beta, we want to respect
the existing night mode gadget and disable night mode in favor of the
gadget, providing a notice with an option to disable the gadget and
reload the page

Additionally, raise the max bundle size to account for the additional
code added

Note: the tests still aren't exactly where I'd like them to be, but
hopefully they raise confidence a little bit with reviewing this patch

Additional changes:
* Upgrade to latest version of TypeScript types and remove several
@ts-ignore statements

Bug: T365083
Change-Id: I9583ee7ebf8c810ddd504193d568034c954d28f2
2024-05-30 20:23:38 +00:00
Bernard Wang 503559a05c Restrict table logic to nonfloated wikitables
Bug: T330527
Change-Id: I386a88481210f459d2174ff69e0f84d40fc9e3bd
2024-05-30 11:52:20 -05:00
jenkins-bot d39f14a398 Merge "Limit table wrapping to configuration flag" 2024-05-30 15:23:05 +00:00
Translation updater bot bbe03514fd Localisation updates from https://translatewiki.net.
Change-Id: I27492e4eced36f18851ab36e220192d7c04427b0
2024-05-30 09:39:17 +02:00
Jon Robson dba9e16be2 Limit table wrapping to configuration flag
We want to limit this behaviour on initial roll out to certain
wikis.

Bug: T330527
Change-Id: If73f6f3d182cc386ebf0e750206afdb05fd3d863
2024-05-29 15:35:45 -07:00
jenkins-bot 03fd09ff1b Merge "remove redundant HTML roles" 2024-05-29 21:06:23 +00:00
Novem Linguae 158269333d remove redundant HTML roles
Fixes 9 warnings generated by https://validator.w3.org/nu/

- The navigation role is unnecessary for element nav.
- The main role is unnecessary for element main.
- The contentinfo role is unnecessary for element footer.

Bug: T365938
Change-Id: Ibdbe70900f9a85d904252ad8ac26e4bb6e813a1c
2024-05-29 15:25:33 -05:00
Jon Robson 5fb18fdb96 Mark ADR as accepted
We are doing this so the state should be accepted

Change-Id: I1d872f8e320df2eadb7caeb57e83d9f889ba3c65
2024-05-29 19:47:13 +00:00
Anne Tomasevich 72fde056fb Bump codex search styles bundlesize limit
The Menu/MenuItem files got slightly larger due to new
config options related to the MenuButton component.

Change-Id: I04c1250aef3afbff43c11a012194263ec6b0f533
2024-05-29 13:46:40 -04:00
Translation updater bot 3ec7a1f4bc Localisation updates from https://translatewiki.net.
Change-Id: Idd5128d9db1dcc106fcac825e53228b804daafdf
2024-05-29 09:34:40 +02:00
jenkins-bot 33403ddc80 Merge "Limit responsive tables to .wikitables" 2024-05-29 00:05:18 +00:00
Jon Robson caa650a881 Limit responsive tables to .wikitables
Bug: T330527
Change-Id: I61280270c6257ceaf5a6d74bb01be37063474bc7
2024-05-28 16:27:16 -07:00
jenkins-bot 5340f59b61 Merge "fix 3 empty HTML ID attributes" 2024-05-28 22:59:49 +00:00
jenkins-bot 042bf26957 Merge "fix double id="p-variants"" 2024-05-28 22:57:14 +00:00
Volker E 783d67e077 Replace border-color-portal-heading with Codex border-color-subtle
Replacing Vector specific variable with standard token that is meant
for exactly the applied use cases.
Note, I've left `border-color-subtle-transparent` because of that
extra engineering leg. I assume it was meant for animating the property,
which is not there. It seems better to me to replace this variable too
with `border-color-transparent`.

Change-Id: If264e04e576f044b98ec0d61b085f65af0110b6d
2024-05-28 14:29:20 -05:00
jenkins-bot 3ebd429f16 Merge "Remove redundant test cases and comments from tests" 2024-05-28 17:23:23 +00:00
Novem Linguae 3f5dd3c066 fix 3 empty HTML ID attributes
HTML validator says these are errors.

Before: `<button id="" class="foo">`

After: `<button class="foo">`

Bug: T365938
Change-Id: I9450eaaaa79c5aaf8f54b34effff04fba80cd450
2024-05-28 09:03:52 -07:00
Novem Linguae 4f609e6ba1 fix double id="p-variants"
Should only have one HTML ID per page. I've decided to remove
the first of the two duplicate IDs and to replace it with
#vector-variants-dropdown, to match the code style of the similar
#vector-user-links-dropdown

Bug: T343730
Change-Id: I6abdc293c1dbb18faf9751b4633a572a019593ab
2024-05-28 15:19:18 +00:00
Translation updater bot 4664ecf49a Localisation updates from https://translatewiki.net.
Change-Id: I12faf96b6557be29934c259350c11c3c2bb4f597
2024-05-28 09:33:26 +02:00
Translation updater bot 49152c98a4 Localisation updates from https://translatewiki.net.
Change-Id: I5b0fd05cb7686d9884a2af76d778a97040e48900
2024-05-27 09:32:29 +02:00
thiemowmde 79dae4ad7a Remove redundant test cases and comments from tests
* Remove stray @package comments. They appear to be auto-generated
  as they just repeat the namespace name (but the wrong one).
* Remove redundant test that effectively doesn't do anything other
  than testing if the constructor doesn't fail. This is already
  covered by other tests.

Change-Id: Icb1136b7018a88310a37a3989d18a678e6cb9ddf
2024-05-27 09:18:05 +02:00
jenkins-bot 4235ff0efd Merge "Wrap tables with JS" 2024-05-24 22:46:24 +00:00
bwang e42b235669 Wrap tables with JS
Depends-on: Ia271a57776e6f38384c5855727ab82fd7af83241
Bug: T330527
Change-Id: I756f8e1bcd86867bee52962a0d1c2dbb34ca75eb
2024-05-24 15:49:54 -05:00
Jon Robson 48b0eeac2f Icons should not repeat at larger font sizes
Bug: T365731
Change-Id: I539f906e06bb2dc133885092dbacb851fd774c23
2024-05-24 20:32:46 +00:00
jenkins-bot 4665273b40 Merge "Fix missing span tag on ToC items" 2024-05-24 19:43:07 +00:00
weebney 6dcb40447d Fix missing span tag on ToC items
There is a missing span tag in the table of contents where text is placed directly into a div, breaking convention.

Change-Id: I12280e2c6a6e688b36a906d5b5a5c5deba42c977
2024-05-24 11:29:06 -07:00
ksarabia 17a71f3c82 Adds invert exception for dropdown
* Adds a filter invert rule for toggle

Bug: T365035
Change-Id: Id04e3937ff1ef3982563003346fda07348ae26ea
2024-05-24 11:55:20 -05:00
Translation updater bot a4af4b12f8 Localisation updates from https://translatewiki.net.
Change-Id: I19719bf05d58e7f62954608a6c55785646eacc81
2024-05-24 09:47:15 +02:00
Jdrewniak 607e6b39c5 Revert "Add exclusion behaviour for "width" option in Appearance menu"
This reverts commit ff5a61e9c6.

Reason for revert: The behaviour introduced in this patch needs some more consideration.

Bug: T364015
Change-Id: Ieab4ca4084df4f1b5c942fe81c7fb99b058e0623
2024-05-23 23:51:46 +00:00
jenkins-bot f075bb0823 Merge "fix(vector): Set popup notification color to inverted" 2024-05-23 17:07:28 +00:00
Translation updater bot 7b08449c0c Localisation updates from https://translatewiki.net.
Change-Id: Ieca3832ba8642e86d41366260e60aa5676099b15
2024-05-23 09:30:45 +02:00
James D. Forrester ac3c525420 PerformanceBudgetTest: Add WikiLambda dependencies to unbreak merge
Rough numbers for now.

Change-Id: Ie487fc56eb199f94e0b72f59d5c54f623570773b
2024-05-22 13:25:01 -04:00