Commit graph

2242 commits

Author SHA1 Message Date
jenkins-bot 297322f810 Merge "Remove caching FIXMEs" 2021-07-15 21:12:00 +00:00
jenkins-bot 2e5ecae6d2 Merge "Consolidate user links outside of the user menu dropdown into a single new menu" 2021-07-15 20:48:37 +00:00
jdlrobson dd73491331 Remove caching FIXMEs
Code here has been in production a week now, so we no longer need to support
the old HTML structure.

Change-Id: I508dec3294588c9fc7f86958c47a3e5b52493df9
2021-07-15 20:28:48 +00:00
jdlrobson 276738b620 Consolidate user links outside of the user menu dropdown into a single new menu
- Adds UserLinks__more template to process the list of user links.
- Simplifies styles in UserLinks.less, and namespace them under .vector-user-menu-more
- Add i18n for the label of the new navigation menu
- Update storybook and typing

Bug: T284584
Change-Id: I92290815869dcb939f01d9aff4aa202f6f004894
2021-07-15 20:27:54 +00:00
jenkins-bot 73fd6c0290 Merge "Add querystring parameter override for user links, language in header." 2021-07-15 19:26:35 +00:00
Clare Ming cb3d5742da Add querystring parameter override for user links, language in header.
- Add new OverridableConfigRequirement class.
- Add query parameter constant for user links.
- Update Feature Manager with new requirements.
- Use new class for LanguageInHeader requirement.
- Remove LanguageInHeaderTreatmentRequirement class and test.
- Add unit test to cover user links and language in header.

Bug: T285855
Change-Id: I56b729a9e245ed2ddc85625c0be39f5c26320ac4
2021-07-15 16:51:48 +00:00
Translation updater bot c5c0ff6037 Localisation updates from https://translatewiki.net.
Change-Id: Ib228299fbacab42ebf180ea117895bdcc1d8d7b6
2021-07-15 08:13:44 +02:00
Nicholas Ray ca22b84df4 Make #p-search's start margin dependent on .vector-search-box-show-thumbnail
Before this commit, the following config would result in the search box
not lining up vertically with the tabs:

$wgVectorWvuiSearchOptions = [
  "showThumbnail" => false,
];
```

This commit fixes that by making the start margin dependent on the
`showThumbnail` option.

Bug: T284242
Change-Id: I0132ef8afb3206836d9f16771cbefda5b8bfa3ec
2021-07-14 13:40:54 -06:00
Nicholas Ray 7d917c8dbb Widen WVUI search suggestions to edge of search button when search is toggled
Per T284242#7206507, the width of the search suggestions should be
increased at small resolutions.

Bug: T284242
Change-Id: I16ac7c4174c427d340dc16b0b56221ff7b6e1016
2021-07-14 13:36:35 -06:00
Nicholas Ray 91af0e098d Make search toggleable at smaller screen widths
Now that the header collapses at small resolutions
(I89d75843ca7e33e6de93af5d7c22e46b7249c4b7), this commit wires the
search toggle to show the search box when clicked and hides it when the
user clicks outside the search box.

* Adds searchToggle.js to perform handle the toggle behavior of the
searchbox.
* Adds `@padding-horizontal-tabs`, `@size-search-expand` to variables.less
so that these can be used to set the start margin of the search box
(enabling its start edge to match the tab text start edge).
* Modifies screen.less to only apply search max-width when >=
@width-breakpoint-tablet

Bug: T284242
Change-Id: I82563d44967f60aee1cd4d3aa6fb4f405822686b
2021-07-14 00:14:45 +00:00
jenkins-bot e750b8212e Merge "Fix collapsible item behaviour" 2021-07-14 00:04:05 +00:00
jdlrobson 91e07c6b9a Fix collapsible item behaviour
the user-links-collapsible-item class now applies to list items
not links

Follow up to 05a02a39fb59117c522678001d79b0d9dfdf63ca

Bug: T285960
Bug: T276566
Change-Id: I04fa303c4e95373fdf5ff090de1bba030386c286
2021-07-13 23:42:34 +00:00
Clare Ming c4efbb3d6a Update styles for talk message at lower port widths.
Bug: T284243
Depends-On: Icb349987c5f5939b7f4ffa477ac1ecb35b5425e7
Change-Id: I69bc3a1aea6b5a640b91c67f5beae4c263c8d31a
2021-07-13 15:47:08 -06:00
jenkins-bot a377b46fcf Merge "Move userpage link to precede notifications" 2021-07-13 18:27:26 +00:00
Translation updater bot 66002b600f Localisation updates from https://translatewiki.net.
Change-Id: I0d21dc89ff2ded399b6198470bc39ee6c632955d
2021-07-13 08:13:04 +02:00
Clare Ming 19173ea296 Move userpage link to precede notifications
Update user links template to reshuffle order.

Bug: T285728
Change-Id: Ie33a513a9a72e9d659d04a76bb38d8fb1977fb19
2021-07-12 13:06:18 -06:00
Translation updater bot fb3561e756 Localisation updates from https://translatewiki.net.
Change-Id: I4fdcf601bd0a499fae40c16d8860500d01c599e2
2021-07-12 08:08:17 +02:00
Translation updater bot e9053a1f76 Localisation updates from https://translatewiki.net.
Change-Id: Ic4374b1d6d485bb42c2fa19a0b373d9ee0215318
2021-07-09 08:08:01 +02:00
Translation updater bot 493d5c4cc5 Localisation updates from https://translatewiki.net.
Change-Id: I10a10fb843ede4eb2afc6f757c49301e7d7eea52
2021-07-07 08:08:56 +02:00
Translation updater bot f72d5ba87d Localisation updates from https://translatewiki.net.
Change-Id: Ib3107b10031bc68da586779a22e09155dccda804
2021-07-06 08:39:59 +02:00
Translation updater bot 60a6f9ea0b Localisation updates from https://translatewiki.net.
Change-Id: Idfa16d8f08dbfd7adfe61d6f6be0906dcae3ccf1
2021-07-05 08:08:44 +02:00
Translation updater bot f3a4f9cc52 Localisation updates from https://translatewiki.net.
Change-Id: I870e10db1691e47fc2807f96a067e2a72be8e1ff
2021-07-02 08:32:37 +02:00
jenkins-bot 7c1455b90e Merge "Refactor the way we add classes to list items" 2021-07-01 22:13:43 +00:00
jdlrobson 3dffee277c Refactor the way we add classes to list items
Append mw-ui-icon classes to list item not list link
This allows us to apply a custom padding separate from the icon.

Note due to a bug in how core handles personal user items,
this will result in the icons temporarily disappearing for several
items until If399dfff9bbdd3b03b2ca702face3ec5164bef11 is resolved.
This is okay given the user menu is currently feature flagged.

Bug: T191021
Change-Id: I766aeb4d1bb36cebd0d80ad43ced940dbea96477
2021-07-01 14:25:46 -07:00
Translation updater bot 07bc73cbce Localisation updates from https://translatewiki.net.
Change-Id: I3482cfda1cec0c738c18c91c6579ffe490e71f65
2021-07-01 08:11:07 +02:00
bwang 0a75e2e627 Ensure userAvatar icon is only used in logged in users
Additional change: A bundlesize increase is required given
recent developments in the user menu.

Bug: T284748
Change-Id: I2b0981d621c3add42731e50d5aef299b32548b4a
2021-06-30 22:41:47 +00:00
jenkins-bot 6597bc7d86 Merge "Collapse header at lower resolutions" 2021-06-30 22:11:34 +00:00
jdlrobson 6777c5b1fe Collapse header at lower resolutions
Reduces the min-width to 340px with several changes at lower
resolutions
* collapses create account into dropdown
* hides language button and user messages
* The search component is updated to include a search toggle which
can be used to hide and show the search input at lower resolutions
- this leads to a slight HTML change with caching implications,
it also moves away from a BEM usage which is not standard for this
repository.
* limits width of logo based on the dimensions we display
in mobile

Bug: T276566
Change-Id: I89d75843ca7e33e6de93af5d7c22e46b7249c4b7
2021-06-30 21:43:35 +00:00
jenkins-bot 91aeef476d Merge "search: Disable query highlight for some languages" 2021-06-30 21:01:01 +00:00
Sam Smith 445ba883a2 search: Disable query highlight for some languages
Following on from I551414b1, disable query highlighting for the list of
languages provided by @TJones in T281797.

The user's interface language can be different from the wiki's content
language and so the former is not available at configuration time. Thus,
we fetch the user's interface language at request time. Fortunately,
@TJones' list of languages is small so there should be little
perceivable performance impact from the perpective of the user.

Additional changes:

- Remove the config.VectorWvuiSearchOptions.value.highlightQuery
  property from skin.json

Bug: T281797
Change-Id: Ib39736a93fa64e82253f88551d125413e672558b
2021-06-30 16:47:46 +01:00
jenkins-bot 400f67e526 Merge "Fixes transition from input focus state to WVUI focus state" 2021-06-30 13:42:31 +00:00
Translation updater bot c437f38e59 Localisation updates from https://translatewiki.net.
Change-Id: I0bcae0aa7904b677a88e4f5ce38bf8b2988a3f7b
2021-06-30 08:27:22 +02:00
jdlrobson a220e553eb Fixes transition from input focus state to WVUI focus state
VueEnhancedSearchBox tries to mimic the styles of WVUI to get a
seamless transition however doesn't account for the focus state that
shows briefly while this occurs.

This was leading to the icon jumping as it transitioned.

Bug: T279015
Change-Id: I10a4ec5d64bb58e2f21506c8a09a1bb6c34ecd65
2021-06-29 14:39:10 -07:00
Translation updater bot 4ba15fc73f Localisation updates from https://translatewiki.net.
Change-Id: I44f778770a21d3ff8357aac22143ca3498dd664e
2021-06-28 09:25:07 +02:00
jdlrobson 62d0cf8d92 Dropdown toggles trigger click tracking instrumentation
Bug: T284542
Change-Id: Ib019c616bc53ebab50ed9eeef05b6d9712958f38
2021-06-24 23:08:19 +00:00
jenkins-bot b8545c4b5e Merge "Remove whitespace from page title template" 2021-06-24 22:16:07 +00:00
jenkins-bot 170a4eb9fa Merge "Update search loading animation delay to 500ms" 2021-06-24 17:49:13 +00:00
bwang 0c8154f1bd Update search loading animation delay to 500ms
Bug: T273093
Change-Id: I517bb80a9557c85607ae3588bb44dc83cbeb1dc0
2021-06-24 17:18:16 +00:00
bwang 9dc295945c Remove whitespace from page title template
Bug: T282318
Change-Id: Idd36ad20545e04706bbc9bfa034c65fc0d6bba16
2021-06-24 16:47:31 +00:00
Nicholas Ray b82ecc2173 Remove SkinVector::ICON_USER_LINK_MAP usage
Per T284594, we are now setting the icon key/value when the relevant
menu item is created (e.g see I95f2a0a01134f2c3dfc22083be66c99de26b530f
) to allow for easier reuse of icons across skins.

Additionally:

* Refactor SkinVector to pull the appropriate login/logout icon from
core instead of setting this in Vector

Bug: T284594
Depends-On: I95f2a0a01134f2c3dfc22083be66c99de26b530f
Depends-On: I6292de50c3940f39b0084a2af4f79af78583720f
Change-Id: I02163645937de4b8a2c4375f29851c29462a582d
2021-06-23 18:33:17 +00:00
Translation updater bot 02de393331 Localisation updates from https://translatewiki.net.
Change-Id: I3b20c80a5e5bc49fcef47d6b1d9c0cb9aeb6970b
2021-06-23 08:12:53 +02:00
jenkins-bot bea07a11c6 Merge "Partial Revert "Update tests for default Menu template value"" 2021-06-22 21:30:24 +00:00
bwang d8351bc0ae Update user links storybook
- Remove logged in links from logged out user links storybook
- Add icons to all user links

Bug: T284584
Change-Id: I7fbe22b257d1a6e08c27315d69b0ae1233868aed
2021-06-22 18:52:26 +00:00
jenkins-bot f6d116ff98 Merge "Add icon prefix to login link" 2021-06-22 17:06:10 +00:00
Clare Ming d9f4c51b4e Add icon prefix to login link
Add classes to prefix login link with login icon.

Bug: T276562
Change-Id: I2b188a25986a717436af223a469b05c95e5b2d88
2021-06-22 09:18:06 -06:00
bwang 84737bc9c7 Remove reference to BaseTemplateAfterPortlet
Bug: T280608
Change-Id: I87ebd765defd7c71f2463257d8bae14107988220
2021-06-22 15:02:01 +00:00
Translation updater bot 5029ce11e4 Localisation updates from https://translatewiki.net.
Change-Id: I689d4e589d662e41e166f8846308b25da3886760
2021-06-22 08:11:24 +02:00
bwang 7909cf1eb6 Update user links storybook
- Fixes logged in and logged out links in the user links storybook
- Fixes type def warnings by importing defs
- Update the user page styles in storybook

Bug: T284584
Change-Id: I8e56df16617f71be89ac8d3094497cdb0daa64ef
2021-06-21 21:34:35 +00:00
jenkins-bot b4e1929d84 Merge "VectorUseWvuiSearch should reflect production config" 2021-06-21 20:54:38 +00:00
jdlrobson 7d32418513 VectorUseWvuiSearch should reflect production config
At this point most wikis enable this config flag. Explicit overrides
exist for wikis where it is not available (commons and wikidata).

The config on master should always reflect production config so
it's time to change the default.

Change-Id: I8835e070d2636f600f733645119b0f8497eda3e8
2021-06-21 13:26:55 -07:00