Commit graph

4740 commits

Author SHA1 Message Date
jenkins-bot 1673d3522d Merge "Implement new font-sizes for custom front-size preference" 2023-11-27 08:08:40 +00:00
Translation updater bot fd4a7edac7 Localisation updates from https://translatewiki.net.
Change-Id: I7c6f072afaec2bae7774fc9d271ed08a026a39ca
2023-11-27 08:35:59 +01:00
Jan Drewniak edfdf05f12 Implement new font-sizes for custom front-size preference
Adds different font-sizes and line-heights for the custom
font-size UI. The custom font-size preference options are now:

1. Compact - 14px font-size & 22px line-height
2. Standard - 16px font-size & 24px line-height
3. Open - 20px font-size & 26px line-height

This removes the "xl" font-size option
(`vector-feature-custom-font-size-3`) and it's related i18n messages,
and changes the remaining message to match the new options.

The default font-size, when the custom font-size feature is disabled,
is "compact".

Bug: T351693
Change-Id: I5975a78ce7327f314fd55de55c222ac08d801fbd
2023-11-24 15:23:56 +00:00
Moh'd Khier Abualruz e480bfa2b5 Update theme icon for client preferences in user links
- Add appearance.svg file and classes
- Update the icon name in php
- Update icon name in test data and Snapshot

To test: change return value of
  isClientPreferencesPinned() from SkinVector22
  PHP Class to false

Bug: T351142
Change-Id: If61f3019430be3cb9c926b09bc397e27d8e636f2
2023-11-24 15:01:35 +00:00
jenkins-bot 9062e6f96e Merge "Follow-up to 7a8059d76 - Vector increase paragraph spacing to 1em" 2023-11-23 23:35:02 +00:00
jenkins-bot f26a8a0556 Merge "Revert "Vector increase paragraph spacing to 1em"" 2023-11-23 23:27:37 +00:00
Jan Drewniak 78f1f1c671 Follow-up to 7a8059d76 - Vector increase paragraph spacing to 1em
This patch changes the paragraph spacing for Vector 2022
instead of legacy Vector.

Bug: T351754
Change-Id: If205abd17236f9e325cb477b589fa35da246d623
2023-11-23 18:16:00 -05:00
Jdrewniak c3b10b4cac Revert "Vector increase paragraph spacing to 1em"
This reverts commit 7a8059d767.

Reason for revert: Didn't realize this changes the paragraph spacing in the legacy styles module instead of the Vector 2022 module.

Change-Id: I08f2a6b1f43fc088e6552fb6a9011b41ebb698a2
2023-11-23 23:09:03 +00:00
jenkins-bot a4ed8727cb Merge "Vector increase paragraph spacing to 1em" 2023-11-23 16:47:20 +00:00
jenkins-bot 37c2a0016f Merge "Make client prefs fully pinnable" 2023-11-23 16:34:33 +00:00
Translation updater bot 3e4cc22bec Localisation updates from https://translatewiki.net.
Change-Id: I0663354ddf899f244c772808793a608f28884cd8
2023-11-23 12:00:57 +01:00
Moh'd Khier Abualruz 7a8059d767 Vector increase paragraph spacing to 1em
.vector-body p now should have top and bottom margins as 1em instead of 0.5em which translate now to 14px instead of 7px

Bug: T351754
Change-Id: Ifd405d7754f9062d9a84237560495a36d1dab8e9
2023-11-23 11:28:06 +01:00
bwang d2b413a721 Make client prefs fully pinnable
Bug: T351141
Change-Id: Ic4a166fb3234b27dbf3d37891abfdf15781c8867
2023-11-22 14:39:28 -06:00
jenkins-bot 84ce8cdd41 Merge "Fix the toc header underline" 2023-11-22 18:44:26 +00:00
Piotr Miazga d6945f5f46 Skin shouldn't call SkinMustache::getTemplateData twice
Calling this method twice within the same function introduces
uncessary performance decline.

Bug: T351807
Change-Id: I5a28f2a3884ea22a6e0bba666f73bd8596ccafbe
2023-11-22 14:11:14 +01:00
Translation updater bot 98651517b9 Localisation updates from https://translatewiki.net.
Change-Id: I02ec5b825443f832514b59288f7bc3130b9435d3
2023-11-22 08:22:20 +01:00
Jan Drewniak 791b9bb0d5 [Zebra] Vertically align sidebar menus
Removes padding from the top and bottom of the
.mw-body element so that the border of the sidebar
menus align with border of the tab area.

Also removes the bottom margin on the sidebar menus
so that the bottom of the menus align with the bottom
of the content. (This was an artifact from the gray
background design).

**Visual Changes**
- The content will move up by 8px with this change.
- The bottom of the TOC will also move down by 24px
  to align with the content.

Bug: T351432
Change-Id: If0a8189b228ffb6fb63dfd8be40955653caa0b34
2023-11-21 18:59:15 +00:00
bwang b74b45d65d Fix the toc header underline
Bug: T340481
Change-Id: Iefbaae291c091b51910180c619993843895c9a20
2023-11-21 17:35:40 +00:00
jenkins-bot b64b137223 Merge "[Zebra] Align sidebar TOC with main menu" 2023-11-21 17:10:20 +00:00
jenkins-bot 76a81c6d10 Merge "Tweak OOUI dialog compatibility styles for better compatibility" 2023-11-21 17:10:12 +00:00
Jan Drewniak 483c6bb51f [Zebra] Align sidebar TOC with main menu
Aligns the text of the sidebar TOC with the
main menu using negative margins. This only
affects the TOC in the sidebar position.

Bug: T351697
Change-Id: Ie4e78379e8682636ebf72913e995b69e922b4983
2023-11-21 16:02:10 +00:00
Translation updater bot 4eaff59bdb Localisation updates from https://translatewiki.net.
Change-Id: Ia14c7d4cadc25c7627d51cb4a9e005debc6defb0
2023-11-21 08:31:12 +01:00
Jon Robson 845a0ab71d Make the limited width and font size controls work for logged in users
For time being manage classes inside Vector. Document with FIXME and a
test.

Bug: T351447
Change-Id: Icc084a59a0141ec2b7c772cf92e8cc58c11f15b1
2023-11-21 02:16:52 +00:00
Translation updater bot c4802af02c Localisation updates from https://translatewiki.net.
Change-Id: Ide3878c7d65534d44066dd49e807d086e32c67b6
2023-11-20 08:54:49 +01:00
Bartosz Dziewoński 3cae30c131 Tweak OOUI dialog compatibility styles for better compatibility
Move 'z-index' to the nested .oo-ui-dialog element. Previously
it had no effect, because .oo-ui-windowManager is not positioned.

This makes the styles closer to how they were before change
I174a1c125e4ee451ec9b203654f6eff2d335bb5d. Although bug T351003
doesn't currently affect Vector, this is just by luck and future
changes to 'z-index' rules in the skin could cause a similar issue.

Bug: T351003
Change-Id: I80d8c796ec413824c523e0000c869ce61d120e2e
2023-11-18 17:12:05 +00:00
jenkins-bot 76667fbeae Merge "Revert "mw.notify: Limit width of overlay to max-width-page-container"" 2023-11-17 19:41:25 +00:00
Jdlrobson 45ded33a4c Revert "mw.notify: Limit width of overlay to max-width-page-container"
This reverts commit a34ef3822a.

Reason for revert: Per Olga. This didn't factor in limited width mode.

Bug: T349622
Change-Id: I0571443fbbade31a9a929e520213141b5c95e2f5
2023-11-17 19:21:32 +00:00
Bartosz Dziewoński ef7605257c Remove unused styles for .mw-specialpages-table
This element has been removed from MediaWiki core in 2015
(change I1b0c0a38f0842fb259a4e525f1578980acfa4cd6).

Change-Id: Ibff977259c504c50eca83752b882c5683e4f53c1
2023-11-17 17:50:57 +01:00
Translation updater bot 44cd7fb13c Localisation updates from https://translatewiki.net.
Change-Id: I185209a156490370052a58ee15a070d8d7b573ae
2023-11-17 08:55:51 +01:00
ksarabia 45332cfcb6 Fix alignment issue in Zebra
Addresses misalignment of client pref in zebra

Bug: T350417
Change-Id: Ib4b80b13dc67d00362abf168853c3ae58ae808b3
2023-11-16 13:53:41 -06:00
Translation updater bot a555367a67 Localisation updates from https://translatewiki.net.
Change-Id: I3ce44f0847b7974583c6786ee6bce13697044e06
2023-11-16 09:11:51 +01:00
Jon Robson 4235a1f355 Theme preferences should not display when feature disabled
This was being flagged by Pixel
Follow up to I0b1ec445c4d292bbf417a39dbc5d2032b563f525

Bug: T350195
Change-Id: I7e4b7b453a518a94a75e952bdeaf4e84b23396c8
2023-11-15 16:42:11 -08:00
ksarabia 1a15dbd4d0 Fix sidebar component order
* This moves down the client pref menu
* For now when page tools is collapsed the client preference menu
is hidden. This will be revisited when we implement pinning
in the next sprint.

Bug: T350417
Change-Id: Ic94d6fd2c4ccb667b0ae602d03c564f88a14b8ec
2023-11-16 00:30:28 +00:00
jenkins-bot 7657f28701 Merge "Allow client side preferences to render in a dropdown" 2023-11-15 22:01:16 +00:00
jenkins-bot 5e6bb68217 Merge "Update skin[-legacy].mustache type documentation" 2023-11-15 16:30:11 +00:00
Translation updater bot 5b8dc0b7f8 Localisation updates from https://translatewiki.net.
Change-Id: I44d860158139fe8b830f133462b9442b3305584a
2023-11-15 15:45:39 +01:00
Jon Robson 5a0678c77d Allow client side preferences to render in a dropdown
Known problems:

- For now, this can only be rendered by manually updating
the isClientPreferencesPinned local variable in SkinVector22
This will be addressed in T351141
- The icon is not correct. This will be addressed in
https://phabricator.wikimedia.org/T351142

Bug: T350195
Change-Id: I0b1ec445c4d292bbf417a39dbc5d2032b563f525
2023-11-15 12:50:54 +01:00
Gergő Tisza f1db8517a5
Update skin[-legacy].mustache type documentation
Depends-On: I8e0cf13093a0c738038a01a0ae120861642a2aa1
Change-Id: I5df124869aa3130573fdb627f5e2588beba3570f
2023-11-14 20:57:25 -08:00
Moh'd Khier Abualruz 412c1f2d83 Create a sidebar for user preferences
* Adds mustache for sidebar
* Adds file to render sidebar

Bug: T350417
Change-Id: I691c8a0487e158e96027109c223569224f03a102
2023-11-14 14:33:01 -08:00
jenkins-bot 9a3137ad89 Merge "PerformanceBudget: Remove FlaggedRevisions workaround" 2023-11-14 17:45:27 +00:00
jenkins-bot 020e51cc8c Merge "i18n: client preferences" 2023-11-14 17:35:01 +00:00
Jon Robson 9d054339db PerformanceBudget: Remove FlaggedRevisions workaround
With I1e45d0dacf58b2e03886d3b986309e13e754e324 this should no
longer be needed as the styles are now restricted to reviewers and
the default user is not a reviewer

After merging this change, please confirm that any open
FlaggedRevisions patches pass Jenkins CI.

Change-Id: I53e3f2c15ad6797f39747e5bc00039582edb8f61
2023-11-14 17:25:56 +00:00
Translation updater bot 7b87da7647 Localisation updates from https://translatewiki.net.
Change-Id: I333bca31a6f7888c29032c087f4b110a577e630a
2023-11-14 09:16:48 +01:00
Jon Robson 6f264d8493 i18n: client preferences
Changes:
- Use "Theme" for the settings heading
- Update column width options to wide and standard

Notes:
- I haven't changed type size or column width as the proposed
text includes "Article". On many projects outside Wikipedia,
the use of "article" is semantically incorrect.
- Type size currently has 4 options. Need to talk to Justin
before renaming those.

Bug: T350417
Bug: T350195
Change-Id: I1c98e510b731e3671c36e095081975400edf4e49
2023-11-14 00:43:11 +00:00
jenkins-bot 8664294709 Merge "Remove Zebra A/B test code" 2023-11-13 22:17:52 +00:00
Jon Robson 0a33ffffac Remove Zebra A/B test code
Additional change:
* Remove duplicate A/B test requirement for language in header

Bug: T339957
Change-Id: I0258e71ac0e270682ec1f3bcb0f10198892f058d
2023-11-13 21:56:34 +00:00
Jan Drewniak 6fcecec64e [Zebra] Remove underline from pages with blank title
Removes the underline below the page title if it's blank.

Bug: T351119
Change-Id: Ie177aecc92bd7f18175e1dc875e5f8471b38c7bb
2023-11-13 21:39:29 +00:00
jenkins-bot d2f6813b1b Merge "Fixes orange bar of doom (echo alert)" 2023-11-13 19:55:01 +00:00
Jon Robson 332678a991 Fixes orange bar of doom (echo alert)
* Updates CSS selector for the Echo alert
* Prevents conversion of OBOD to a button via a generic
array of "exception" names.

Bug: T350195
Change-Id: Id9b2763fe4d893fa4b4ce1e740dba59e6d887436
2023-11-13 11:17:51 -08:00
Translation updater bot 99e7250892 Localisation updates from https://translatewiki.net.
Change-Id: I305ff0cd71898e6327fe5a5d115927a57798b0ba
2023-11-13 08:45:06 +01:00