Commit graph

3729 commits

Author SHA1 Message Date
Lucas Werkmeister 090500276d search: Don’t pass searchApiUrl into fetchByTitle()
Not all implementations will need this (e.g. the Wikibase search is
based on the Action API, not the REST API), so simplify App and move
this bit of complexity into the default search client instead.

As far as I can tell from MediaWiki code search [1] and Global Search
[2], nothing apart from Wikibase uses wgVectorSearchClient yet, so we
should be able to make this breaking change now.

[1]: https://codesearch.wmcloud.org/search/?q=wgVectorSearchClient
[2]: https://global-search.toolforge.org/?q=wgVectorSearchClient&namespaces=2%2C4%2C8&title=%28Gadgets-definition%7C.*%5C.js%29

Change-Id: I0d52e407c12b3fbf80cd36ed66c67da4cba9acbd
2022-11-25 15:00:16 +01:00
Translation updater bot 135f0c246e Localisation updates from https://translatewiki.net.
Change-Id: If198cd3d4b8f4027bcbb213e0aa9e2ec06b1209c
2022-11-25 08:28:53 +01:00
Translation updater bot 54e70084d1 Localisation updates from https://translatewiki.net.
Change-Id: Ie40c765feada49444f80b3c556a45d5a743fa1ce
2022-11-24 08:20:21 +01:00
jenkins-bot 3381aa5c7e Merge "Add jQuery.UI styles to Vector 2022" 2022-11-23 23:29:28 +00:00
Ed Sanders 364b8a58f3 Add jQuery.UI styles to Vector 2022
Bug: T322000
Bug: T323673
Change-Id: I01621504c83cf2d0d961b829418dcf7340a9f31c
2022-11-23 23:12:51 +00:00
jenkins-bot 6612e4990f Merge "Ensure more menu shows on lower resolutions" 2022-11-23 21:31:28 +00:00
bwang 78b20092c4 Ensure more menu shows on lower resolutions
Bug: T323730
Change-Id: I874e93fed7287dd6276b8a47ba1ea15624b75d84
2022-11-23 20:58:23 +00:00
Translation updater bot f4a56a4b30 Localisation updates from https://translatewiki.net.
Change-Id: I568794c880255afdbe69027012a8ca53fa98aaad
2022-11-23 08:35:32 +01:00
jenkins-bot 9be75feb0d Merge "Prepare styles for Page Tools menu" 2022-11-22 18:26:09 +00:00
Jan Drewniak 69f3dcd7a7 Prepare styles for Page Tools menu
Makes the dropdown styles compatible with the pinned state of the
menu so that both states can share the same styles.

- New vector-menu-heading mixin shared between main menu headings
  and dropdown headings.
- New @font-size-dropdown variable so font-size is consistent in
  dropdown and pinned state.
- Ensure hidden 'more' menu works in both pinned and dropdown state.
- Removes extra <ul><li> from PinnableDropdownContents.mustache, as the
  child Menu template already contain <ul><li> elements.

Bug: T318434
Change-Id: Ie1a56d8584c1dc3f20c6643ff4cfc740be4007fa
2022-11-22 12:57:29 -05:00
Translation updater bot 38014d4342 Localisation updates from https://translatewiki.net.
Change-Id: I9f99f86823d3c22323a24910a923096aa6edad2a
2022-11-22 08:36:25 +01:00
Jon Robson 7c24aa46fb Drop the VisualEnhancementsNext feature flag
Bug: T320101
Change-Id: I6d536af034dafd66c6478183de8029be9ed3e8b7
2022-11-21 13:27:34 -08:00
bwang d6a99e2f08 Fix icon button spacing in sticky header
Bug: T323176
Change-Id: Iceea571a112b3ae7b07246326ec2bdae9fd0c50c
2022-11-21 18:13:46 +00:00
Translation updater bot 1a16477ff0 Localisation updates from https://translatewiki.net.
Change-Id: Idb6c2ce05a8e3442bd15768a844cb9ce9a087669
2022-11-21 08:19:27 +01:00
jenkins-bot 4bd65489d4 Merge "Update ToC selector to account for page tools" 2022-11-18 22:47:29 +00:00
bwang 862ded4e17 Update page tools to use VectorComponentPinnableHeader
Change-Id: I2640cd177a312d98d931ab082d5c8942b042212a
2022-11-18 11:58:59 -06:00
bwang 6eb5bd05fb Update ToC selector to account for page tools
Change-Id: Ib2504bf16969d3b6af2a827ae7b7cfd8aa5fc468
2022-11-18 11:15:16 -06:00
Translation updater bot 1e69e2de1e Localisation updates from https://translatewiki.net.
Change-Id: Ia94f3fdd837a6511885b7abd08eea9cd8056e85f
2022-11-18 09:23:32 +01:00
jenkins-bot 0244b2d41b Merge "Reintroduce h2 to Table of contents label" 2022-11-17 19:41:09 +00:00
bwang 1b4376c946 Reintroduce h2 to Table of contents label
Depends-on: I752eadc9bf54d58c799060a9eaefa0b125dd7952

Bug: T320451
Change-Id: Ic4ca5490a9a33cb319821bbdaa57d29f0ed9c887
2022-11-17 19:26:44 +00:00
jenkins-bot f4f416a1ce Merge "[Cleanup] Address FIXMES relating to cached HTML" 2022-11-17 17:35:46 +00:00
Translation updater bot 6a94f19694 Localisation updates from https://translatewiki.net.
Change-Id: I841b973be4b624e76e4d4f1cebe405ffd837be98
2022-11-17 08:29:41 +01:00
Jon Robson f31f0bbf50 [Cleanup] Address FIXMES relating to cached HTML
Change-Id: I6f5e97dde1f774e741a4236d1f6b49ad146cc236
2022-11-15 23:23:56 +00:00
jenkins-bot a0f7e2db32 Merge "Update TOC to use PinnableHeader" 2022-11-15 23:10:35 +00:00
bwang 0f7411bdf2 Update TOC to use PinnableHeader
- Update 'collapsed' naming convention to 'pinned'
- Introduce VectorComponentPinnableHeader

Bug: T317897
Change-Id: I752eadc9bf54d58c799060a9eaefa0b125dd7952
2022-11-15 16:37:50 -06:00
Translation updater bot b6b1de1083 Localisation updates from https://translatewiki.net.
Change-Id: I8227a92785cb98823d8b52a4f0f4caaca71d535b
2022-11-15 08:25:50 +01:00
jenkins-bot 8c48541379 Merge "Rename TOC locales to be generic pin/unpin labels, standardize toc label locale name" 2022-11-15 01:19:03 +00:00
jenkins-bot 63dbf2ad06 Merge "Drop unnecessary watchstar icon classes on toggle" 2022-11-15 00:38:03 +00:00
bwang ddf8706ae4 Fix main menu button spacing when the VisualEnhancementNext flag is enabled
This patch results in an expected visual change for the main menu button when the flag is on
When comparing with master with the flag off, this patch will still show a 1px difference for the main menu button, as well as user menu and language button. These are not introduced by this patch and are due to the flush classes taking into account the 1px border

Change-Id: Id46bc939338d5bbcc3459ab502e1cf8b8f2020b2
2022-11-14 22:32:51 +00:00
bwang 17bdb31de5 Rename TOC locales to be generic pin/unpin labels, standardize toc label locale name
- 'vector-toc-toggle-position-title' -> 'vector-pin-element-label'
- 'vector-toc-toggle-position-sidebar' -> 'vector-unpin-element-label'
- 'vector-toc-heading' -> 'vector-toc-label'

Change-Id: I4c45fa9a152e26691cc0b62ce8d40d00f8f2e617
2022-11-14 16:26:08 -06:00
Jon Robson 3e40a753b1 Drop unnecessary watchstar icon classes on toggle
These interfere with the toggle on certain pages
see T317710#8389485

Bug: T322673
Change-Id: I3e40cc0c5701a3c055ced1c74e9cac1b369586a3
2022-11-14 13:54:16 -08:00
Jan Drewniak 6b67e9adda Limited width toggle (0eb8811 follow-up)
Refactors styles for limited width toggle and
fixes issue with close icon not appearing.

Bug: T319449
Change-Id: If53c3921e54565c47eb0868329e0b79f60073792
2022-11-14 21:29:18 +00:00
bwang f73d255810 Replace aria-labelledby in ToC with aria-label
Bug: T318178
Change-Id: I7abcc977276b979c5a515fbbcccf42d7c993a130
2022-11-14 18:10:38 +00:00
Translation updater bot 43887fe6f9 Localisation updates from https://translatewiki.net.
Change-Id: Ia8d858325d8836850aab03947385b0ef228d0741
2022-11-14 08:13:09 +01:00
bwang 6bff0011c1 Fix ToC dropdown menu spacing when visual next flag is enabled, address icon related feedback
Causes 20 visual progressions regardless of visual next flag, the ToC moves 1px when in the sidebar

Follow up to If3aed0ac401b0abc80c3ad52806eb85b33d43f06

Bug: T321504
Change-Id: I4b3ec90d8e79791a1bf17ba02c9f9d722499bec8
2022-11-11 18:56:12 +00:00
jenkins-bot f5992cf7ee Merge "[Technical] Remove common Menu styles" 2022-11-11 18:36:42 +00:00
jenkins-bot f031d69668 Merge "Convert limited width toggle button from a div to a button" 2022-11-11 18:32:54 +00:00
Translation updater bot 0821002384 Localisation updates from https://translatewiki.net.
Change-Id: I66ce37af6a02fcc11c8c2f602d5234a2ddc4272a
2022-11-11 08:45:18 +01:00
jenkins-bot cd0250dbb4 Merge "Replace 'more' menu with page tools pinnable dropdown" 2022-11-10 22:21:38 +00:00
bwang 8f5b33fee3 Replace 'more' menu with page tools pinnable dropdown
Bug: T317897
Change-Id: Ia94ebc32041bb3c2f86d461b310766b2d14c66a2
2022-11-10 15:33:16 -06:00
Nicholas Ray 7a1059b98d Convert limited width toggle button from a div to a button
The toggle was a div that tried to act like a button. This commit converts it to
a button for semantic and accessibility reasons.

Change-Id: Idf5643926611ae8e9a7ec4163cf3cb1e51ec7310
2022-11-10 12:14:29 -07:00
jenkins-bot 04e3f9a6f1 Merge "Dropdown arrow pixel should only apply to modern Vector" 2022-11-10 18:46:39 +00:00
jenkins-bot 4f6068ab33 Merge "Hide width toggle when performing suggested edit" 2022-11-10 12:15:31 +00:00
Jon Robson c56505de85 Dropdown arrow pixel should only apply to modern Vector
This is leaking into legacy Vector as well.

Bug: T322673
Change-Id: Iec9714395539ae7739b4136c87b481a691e2a516
2022-11-10 01:38:30 +00:00
jenkins-bot a26529ca1e Merge "Echo in Legacy Vector should not be impacted by feature flag" 2022-11-10 01:30:18 +00:00
Jon Robson 2f56d5d649 Echo in Legacy Vector should not be impacted by feature flag
The feature flag seems to incorrectly be applying inside legacy
Vector causing an unexpected visual regression.

Bug: T322673
Change-Id: I3c66ddeb4de8c5a31a63025141e04b47e2bcb83c
2022-11-10 01:14:05 +00:00
bwang 16da6a5e6a [Technical] Fix sticky header search input alignment when VisualEnhancementFlag is enabled
Visual changes when the flag is on

Follow up to If3aed0ac401b0abc80c3ad52806eb85b33d43f06
More context at T322673#8383888

Bug: T322673
Change-Id: I64a47fa869247f758c6369c2e0ff8b12f87f9d9e
2022-11-10 00:48:07 +00:00
jenkins-bot e60d8f6917 Merge "Add ColumnEnd.mustache and new grid styles to support third column" 2022-11-09 23:08:31 +00:00
Jon Robson e62b74acae Hide Echo notification count when zero
Bug: T322673
Change-Id: I125359d0d8c525e5d9867e21c6e3c16897013adb
2022-11-09 21:45:44 +00:00
Jon Robson 79ea216e77 Hide width toggle when performing suggested edit
Bug: T322597
Change-Id: I4290de12b2e79dc1121499341432c5f0221a5bb7
2022-11-09 12:18:46 -08:00