Some feature requirements needs access to the request user or title.
Currently the context is given in the ServiceWiring callback,
access to RequestContext::getMain() should be avoided during service
wiring (T218555).
Create a factory to hold the code from the service wiring and call the
factory with the request context from the skin to get a feature manager.
Bug: T359665
Change-Id: I57515ec02ed454620f729a109d0ace43b447b6ce
This was never implemented and will likely cause avoidable
confusion if allowed to persist in the codebase given our work on T359606
Change-Id: Icf36108f24198358e53bf04942751fe3306bc726
According to a Google contact, given we set viewport to 1000px
for mobile devices viewing Vector get a tap delay.
The solution was suggested in https://developer.chrome.com/blog/300ms-tap-delay-gone-away?hl=en
and Peter has confirmed helps improve performance.
A supports query is added to limit this rule to only browsers where
it applies.
Bug: T358380
Change-Id: Ifd7d8951e06e3ba0faaed354492d23e6e0bc8f69
- Added Code sharing between Vector and Minerva Skins ADR
- Updated the title of an old ADR to "Publish client preferences" it was wrong before
Bug: T357077
Change-Id: Ied0d4f008969b6ef0adac7f22bb374843519b408
This reverts commit 7548b0dd99.
Reason for revert: Breaks CI
1 documented message is undefined.
Message "vector-language-redirect-to-top" is documented but undefined.
Build step 'Execute shell' marked build as failure
Change-Id: I6f893e9348d7452f990544b21085af2fa9dbdd8a
This should encourage translators to translate the Desktop Improvements project name.
Bug: T356739
Change-Id: I5335f6d7b616bb54458ee3a03e87672b825b38b2
- Add new module 'skins.vector.search.codex.styles' to skin.json
- Added 'skins.vector.search.codex.styles' to bundlesize.config.json
- Replace the old styles module 'codex-search-styles' with the new one 'skins.vector.search.codex.styles' in skin.js
Bug: T353844
Change-Id: If3cbcac64242c403b42811159882741fda132555
- Exclude the checkbox in the TOC from the hack done in https://phabricator.wikimedia.org/T333394
- This patch might not be needed as a restructure of codex import to vector could resolve most of the issues
Bug: T344066
Change-Id: I35b2ffa7a761e3ea1460fa97642966486791bab9
Temporarily hard-codes some CSS background rules after Codex's
CSS-icon mixins stopped supplying them upstream (after changing
to use mask-image in icons).
Bug: T358160
Change-Id: I13be424c58b105472ef22f14e4381693f2985cd8
The margin and font rules are being overriden in DiscussionsTools
using equal specificity. The correction to the load order in
ResourceLoader skin module in
I83ac918ad8807c65aab2cd1dd8d7d2cd34b512af will break this.
Bug: T354975
Bug: T357929
Change-Id: I15eaf43c6750c76363ec804eda9b8ca6ec4709c2
These are currently being overriden by styles inside core
which also set margin to 0.
In I83ac918ad8807c65aab2cd1dd8d7d2cd34b512af these would override the
default leading to unintended UI changes.
Bug: T354975
Change-Id: I379ad6293bd1aa2a9304369969978cea684da98a
