Fix Yoda conditionals

Change-Id: I5074e8555154c421f4821de37c79d85e1a33d68d
This commit is contained in:
Ed Sanders 2020-07-30 17:01:59 +01:00
parent 0ab352856b
commit ad6c4ea6f3

View file

@ -396,7 +396,7 @@ class VectorTemplate extends BaseTemplate {
// It should not be applied elsewhere per T253329.
self::MENU_TYPE_DROPDOWN => 'menu vector-menu-content-list',
];
$isPortal = self::MENU_TYPE_PORTAL === $type;
$isPortal = $type === self::MENU_TYPE_PORTAL;
// For some menu items, there is no language key corresponding with its menu key.
// These inconsitencies are captured in MENU_LABEL_KEYS
@ -408,7 +408,7 @@ class VectorTemplate extends BaseTemplate {
'label' => $msgObj->exists() ? $msgObj->text() : $label,
'list-classes' => $listClasses[$type] ?? 'vector-menu-content-list',
'html-items' => '',
'is-dropdown' => self::MENU_TYPE_DROPDOWN === $type,
'is-dropdown' => $type === self::MENU_TYPE_DROPDOWN,
'html-tooltip' => Linker::tooltip( 'p-' . $label ),
];