From ad6c4ea6f3b3a803d3ccc5484d560e3be75a88be Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Thu, 30 Jul 2020 17:01:59 +0100 Subject: [PATCH] Fix Yoda conditionals Change-Id: I5074e8555154c421f4821de37c79d85e1a33d68d --- includes/VectorTemplate.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/VectorTemplate.php b/includes/VectorTemplate.php index 6e56aa5cf..f61ac018f 100644 --- a/includes/VectorTemplate.php +++ b/includes/VectorTemplate.php @@ -396,7 +396,7 @@ class VectorTemplate extends BaseTemplate { // It should not be applied elsewhere per T253329. self::MENU_TYPE_DROPDOWN => 'menu vector-menu-content-list', ]; - $isPortal = self::MENU_TYPE_PORTAL === $type; + $isPortal = $type === self::MENU_TYPE_PORTAL; // For some menu items, there is no language key corresponding with its menu key. // These inconsitencies are captured in MENU_LABEL_KEYS @@ -408,7 +408,7 @@ class VectorTemplate extends BaseTemplate { 'label' => $msgObj->exists() ? $msgObj->text() : $label, 'list-classes' => $listClasses[$type] ?? 'vector-menu-content-list', 'html-items' => '', - 'is-dropdown' => self::MENU_TYPE_DROPDOWN === $type, + 'is-dropdown' => $type === self::MENU_TYPE_DROPDOWN, 'html-tooltip' => Linker::tooltip( 'p-' . $label ), ];