wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-12 09:21:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change magnifying glass cursor from pointer to default (arrow)

Browse source 
Before WVUI loads, we show a magnifying glass at the start of the input
that visually mimics the magnifying glass start icon in WVUI's typeahead
search component. Unfortunately, this element is a submit button in
Vector instead of the inert span element used in WVUI.

Although the submit button is useful for no-js users, it might be
confusing for js users. Ideally, an inert element like a span would be
used instead, but that deserves its own ticket. As a temporary easy
stopgap, changing the cursor to be an arrow instead of the pointer might
make this less confusing and discourage clicks to it.

Bug: T270202
Change-Id: Ibab9992a6aa3a60f83324b40017b53fb061991d7
This commit is contained in:
Nicholas Ray 2021-01-13 15:02:52 -07:00
parent 538ccb24d8
commit ab4a41426d
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
resources/skins.vector.styles/VueEnhancedSearchBox.less
View file

@ -80,6 +80,11 @@
// Move & resize search icon to match WVUI.
#searchButton,
#mw-searchButton {
// T270202: Cursor should be an arrow instead of a pointer when hovering
// over the magnifying glass before WVUI loads to discourage people
// clicking on it since it is a submit button styled to look like WVUI's
// inert start icon.
cursor: default;
// Override the default right & left position of the icon.
right: auto;
// Accounts for the 1px input border. Derived from