From ab4a41426d9a607bfd25d2d389785c832809881b Mon Sep 17 00:00:00 2001 From: Nicholas Ray Date: Wed, 13 Jan 2021 15:02:52 -0700 Subject: [PATCH] Change magnifying glass cursor from pointer to default (arrow) Before WVUI loads, we show a magnifying glass at the start of the input that visually mimics the magnifying glass start icon in WVUI's typeahead search component. Unfortunately, this element is a submit button in Vector instead of the inert span element used in WVUI. Although the submit button is useful for no-js users, it might be confusing for js users. Ideally, an inert element like a span would be used instead, but that deserves its own ticket. As a temporary easy stopgap, changing the cursor to be an arrow instead of the pointer might make this less confusing and discourage clicks to it. Bug: T270202 Change-Id: Ibab9992a6aa3a60f83324b40017b53fb061991d7 --- resources/skins.vector.styles/VueEnhancedSearchBox.less | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/resources/skins.vector.styles/VueEnhancedSearchBox.less b/resources/skins.vector.styles/VueEnhancedSearchBox.less index 83616b15b..45e4a5c4f 100644 --- a/resources/skins.vector.styles/VueEnhancedSearchBox.less +++ b/resources/skins.vector.styles/VueEnhancedSearchBox.less @@ -80,6 +80,11 @@ // Move & resize search icon to match WVUI. #searchButton, #mw-searchButton { + // T270202: Cursor should be an arrow instead of a pointer when hovering + // over the magnifying glass before WVUI loads to discourage people + // clicking on it since it is a submit button styled to look like WVUI's + // inert start icon. + cursor: default; // Override the default right & left position of the icon. right: auto; // Accounts for the 1px input border. Derived from