wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-12 09:21:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/includes/templates/PageToolbar.mustache

27 lines
1 KiB
Plaintext
Raw Normal View History

Remove CSS classes and selectors from cached HTML Bug: T316570 Depends-on: Ib4050768f20b1734d356104f18aa539f657099d8 Change-Id: I97f87b32402d7f4fd790f9a8b9abab42efd9d890
2022-10-17 21:27:57 +00:00
<div class="vector-page-toolbar">
<div class="vector-page-toolbar-container">
[Grid preparation] ArticleToolbar component Structural change to prepare for CSS grid usage. ArticleToolbar component is defined and self contained with all layout rules relating to toolbar UI regression testing suite shows 6 failures due to pixel alignment changes to tabs. When comparing to the current release, you should see 34 failures before /and/ after this change. Notable changes: - #mw-head element is no longer present in modern Vector skin to allow us to distinguish between cached HTML and modern HTML Bug: T303484 Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-04-28 21:31:59 +00:00
<div id="left-navigation">
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
<nav aria-label="{{msg-namespaces}}">
Separate dropdown/menu references in PHP and templates - VectorComponentMenuVariants.php is renamed to VectorComponentVariants.php, and returns menu and dropdown data - Remove TabsMenuContents.mustache in favor of MenuContents.mustache - Fix the variants dropdown to use the full Menu template Follow-up: Idf05c1664c026f58487ba34af5ede8a11e695baf Change-Id: I0e9b1ab3306b04ee0d226048c6885beab4f310c6
2023-06-30 21:49:17 +00:00
{{#data-portlets}}{{#data-associated-pages}}{{>Tabs}}{{/data-associated-pages}}{{/data-portlets}}
{{>Variants}}
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</nav>
[Grid preparation] ArticleToolbar component Structural change to prepare for CSS grid usage. ArticleToolbar component is defined and self contained with all layout rules relating to toolbar UI regression testing suite shows 6 failures due to pixel alignment changes to tabs. When comparing to the current release, you should see 34 failures before /and/ after this change. Notable changes: - #mw-head element is no longer present in modern Vector skin to allow us to distinguish between cached HTML and modern HTML Bug: T303484 Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-04-28 21:31:59 +00:00
</div>
Fix border when title is hidden and when toolbar is empty Bug: T317930 Change-Id: Iba89a2e642a8377c3603d099fb1157fc2df465d0
2022-09-19 18:26:12 +00:00
<div id="right-navigation" class="vector-collapsible">
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
<nav aria-label="{{msg-views}}">
Separate dropdown/menu references in PHP and templates - VectorComponentMenuVariants.php is renamed to VectorComponentVariants.php, and returns menu and dropdown data - Remove TabsMenuContents.mustache in favor of MenuContents.mustache - Fix the variants dropdown to use the full Menu template Follow-up: Idf05c1664c026f58487ba34af5ede8a11e695baf Change-Id: I0e9b1ab3306b04ee0d226048c6885beab4f310c6
2023-06-30 21:49:17 +00:00
{{#data-portlets}}{{#data-views}}{{>Tabs}}{{/data-views}}{{/data-portlets}}
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</nav>
Update label for Page tools navigation region - Set aria-label to read 'Page tools' in the nav elements Bug: T330326 Change-Id: I99119aebe98b329d6d1f4e2f8c9f37f77692e8ab
2023-09-04 13:24:17 +00:00
<nav class="vector-page-tools-landmark" aria-label="{{msg-vector-page-tools-nav-label}}">
Refactor: PageTools composes several different components * Introduce Dropdownmenu, PinnableElement and PinnedContainer components Additional changes: * Drops unused has-multiple-menus * Update TableOfContents to use PinnedContainer and PinnableElement Bug: T317900 Change-Id: I0a740f8543831e266f2b1b874b40e44c8241d4cb
2022-12-07 01:05:22 +00:00
{{#data-page-tools-dropdown}}{{>Dropdown/Open}}{{/data-page-tools-dropdown}}
{{#data-page-tools}}
Templates: Reorganize pinned containers The UnpinnedContainer and PinnedContainer are versions of the same component but with different states. Recognize them by organizing them in the same subfolder. Update all existing usages. Bug: T317900 Change-Id: I2c25937190997764fa23e0b581be5538ba4d06de
2022-12-09 23:32:43 +00:00
{{>PinnableContainer/Unpinned/Open}}
Add generic classes to pinnable container Bug: T324877 Change-Id: Iab94f9f600f8e6d032ad70d6b8e502686977441c
2022-12-19 17:40:17 +00:00
{{! Use `#vector-page-tools-unpinned-container .vector-page-tools` to target styles at this element}}
Generalize Pinnable functionality to not be limited to dropdowns, make Pinnable templates composable This patch involves cached HTML changes - Replace '-content-container' id with '-unpinned-container' - Replace '-content' id with '-pinnable-element' - Rename pinnableHeader.js to pinnableElement.js - Replace PinnableDropdownContents.mustache with PinnableElement/Open.mustache and Close - Add PinnedContainer/Open & Close and UnpinnedContainer/Open & Close - Rename .vector-dropdown-content to .vector-pinnable-element - Add new PinnableElement.less stylesheet Bug: T318013 Change-Id: I85aec387f87126a17e760fd9fd10e10572ff3152
2022-11-28 21:08:40 +00:00
{{^is-pinned}}{{>PageTools}}{{/is-pinned}}
Templates: Reorganize pinned containers The UnpinnedContainer and PinnedContainer are versions of the same component but with different states. Recognize them by organizing them in the same subfolder. Update all existing usages. Bug: T317900 Change-Id: I2c25937190997764fa23e0b581be5538ba4d06de
2022-12-09 23:32:43 +00:00
{{>PinnableContainer/Close}}
Refactor: PageTools composes several different components * Introduce Dropdownmenu, PinnableElement and PinnedContainer components Additional changes: * Drops unused has-multiple-menus * Update TableOfContents to use PinnedContainer and PinnableElement Bug: T317900 Change-Id: I0a740f8543831e266f2b1b874b40e44c8241d4cb
2022-12-07 01:05:22 +00:00
{{/data-page-tools}}
{{#data-page-tools-dropdown}}{{>Dropdown/Close}}{{/data-page-tools-dropdown}}
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</nav>
[Grid preparation] ArticleToolbar component Structural change to prepare for CSS grid usage. ArticleToolbar component is defined and self contained with all layout rules relating to toolbar UI regression testing suite shows 6 failures due to pixel alignment changes to tabs. When comparing to the current release, you should see 34 failures before /and/ after this change. Notable changes: - #mw-head element is no longer present in modern Vector skin to allow us to distinguish between cached HTML and modern HTML Bug: T303484 Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-04-28 21:31:59 +00:00
</div>
</div>
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</div>
Reference in a new issue Copy permalink