wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-13 17:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/includes/templates/PageToolbar.mustache

31 lines
1.1 KiB
Plaintext
Raw Normal View History

Remove CSS classes and selectors from cached HTML Bug: T316570 Depends-on: Ib4050768f20b1734d356104f18aa539f657099d8 Change-Id: I97f87b32402d7f4fd790f9a8b9abab42efd9d890
2022-10-17 21:27:57 +00:00
<div class="vector-page-toolbar">
<div class="vector-page-toolbar-container">
[Grid preparation] ArticleToolbar component Structural change to prepare for CSS grid usage. ArticleToolbar component is defined and self contained with all layout rules relating to toolbar UI regression testing suite shows 6 failures due to pixel alignment changes to tabs. When comparing to the current release, you should see 34 failures before /and/ after this change. Notable changes: - #mw-head element is no longer present in modern Vector skin to allow us to distinguish between cached HTML and modern HTML Bug: T303484 Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-04-28 21:31:59 +00:00
{{#data-portlets}}
<div id="left-navigation">
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
<nav aria-label="{{msg-namespaces}}">
[Technical] Split up Menu.template, restrict decoratePortletData to legacy Vector Changes: * Code is moved from SkinVector to SkinVectorLegacy verbatim since it is now only needed by SkinVectorLegacy so we remove it: ** This step broke MainMenu rendering so this was captured in VectorComponentMainMenu ** The isLegacy code no longer makes sense and is removed in a follow up * storybook no longer run on CI Authors: Bernard Wang and Jon Robson Bug: T321102 Bug: T319349 Change-Id: Ib424ca1c767161fdae8c0aeedfe662b7fa039ff6
2022-10-27 23:52:23 +00:00
{{#data-associated-pages}}{{>Tabs}}{{/data-associated-pages}}
[Refactor] Rethink Dropdown component The Dropdown component should be considered the dropdown folder going forward. This should be distinguished as a different component that composes the Dropdown component Since the template itself is rather simple it seems preferable to have duplicate templates that describe the actual component (PageTools, VariantsDropdown and LanguageButton) MenuDropdown is renamed Dropdown and styles that don't correspond to the Dropdown component are moved to the relevant components. MenuContents mustache template (future component) is added to DRY up several of the new templates. Bug: T320927 Change-Id: I220d0a477b3f05b278bd2cec7dd601c7b3b17c6f
2022-11-17 23:12:52 +00:00
{{#data-variants}}{{>VariantsDropdown}}{{/data-variants}}
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</nav>
[Grid preparation] ArticleToolbar component Structural change to prepare for CSS grid usage. ArticleToolbar component is defined and self contained with all layout rules relating to toolbar UI regression testing suite shows 6 failures due to pixel alignment changes to tabs. When comparing to the current release, you should see 34 failures before /and/ after this change. Notable changes: - #mw-head element is no longer present in modern Vector skin to allow us to distinguish between cached HTML and modern HTML Bug: T303484 Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-04-28 21:31:59 +00:00
</div>
Fix border when title is hidden and when toolbar is empty Bug: T317930 Change-Id: Iba89a2e642a8377c3603d099fb1157fc2df465d0
2022-09-19 18:26:12 +00:00
<div id="right-navigation" class="vector-collapsible">
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
<nav aria-label="{{msg-views}}">
Add ColumnEnd.mustache and new grid styles to support third column Bug: T317897 Depends-On: Ibf304843a62d5269992a01eb826edf71ce8d3c35 Depends-On: Ib424ca1c767161fdae8c0aeedfe662b7fa039ff6 Change-Id: Ie7d31df972ff68313b2437ff14b7b6b8d7078204
2022-10-20 21:52:21 +00:00
{{#data-views}}{{>Tabs}}{{/data-views}}
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</nav>
Add ColumnEnd.mustache and new grid styles to support third column Bug: T317897 Depends-On: Ibf304843a62d5269992a01eb826edf71ce8d3c35 Depends-On: Ib424ca1c767161fdae8c0aeedfe662b7fa039ff6 Change-Id: Ie7d31df972ff68313b2437ff14b7b6b8d7078204
2022-10-20 21:52:21 +00:00
<nav class="vector-page-tools-landmark" aria-label="{{msg-tooltip-p-cactions}}">
Refactor: PageTools composes several different components * Introduce Dropdownmenu, PinnableElement and PinnedContainer components Additional changes: * Drops unused has-multiple-menus * Update TableOfContents to use PinnedContainer and PinnableElement Bug: T317900 Change-Id: I0a740f8543831e266f2b1b874b40e44c8241d4cb
2022-12-07 01:05:22 +00:00
{{#is-page-tools-enabled}}
{{#data-page-tools-dropdown}}{{>Dropdown/Open}}{{/data-page-tools-dropdown}}
{{#data-page-tools}}
Templates: Reorganize pinned containers The UnpinnedContainer and PinnedContainer are versions of the same component but with different states. Recognize them by organizing them in the same subfolder. Update all existing usages. Bug: T317900 Change-Id: I2c25937190997764fa23e0b581be5538ba4d06de
2022-12-09 23:32:43 +00:00
{{>PinnableContainer/Unpinned/Open}}
Generalize Pinnable functionality to not be limited to dropdowns, make Pinnable templates composable This patch involves cached HTML changes - Replace '-content-container' id with '-unpinned-container' - Replace '-content' id with '-pinnable-element' - Rename pinnableHeader.js to pinnableElement.js - Replace PinnableDropdownContents.mustache with PinnableElement/Open.mustache and Close - Add PinnedContainer/Open & Close and UnpinnedContainer/Open & Close - Rename .vector-dropdown-content to .vector-pinnable-element - Add new PinnableElement.less stylesheet Bug: T318013 Change-Id: I85aec387f87126a17e760fd9fd10e10572ff3152
2022-11-28 21:08:40 +00:00
{{^is-pinned}}{{>PageTools}}{{/is-pinned}}
Templates: Reorganize pinned containers The UnpinnedContainer and PinnedContainer are versions of the same component but with different states. Recognize them by organizing them in the same subfolder. Update all existing usages. Bug: T317900 Change-Id: I2c25937190997764fa23e0b581be5538ba4d06de
2022-12-09 23:32:43 +00:00
{{>PinnableContainer/Close}}
Refactor: PageTools composes several different components * Introduce Dropdownmenu, PinnableElement and PinnedContainer components Additional changes: * Drops unused has-multiple-menus * Update TableOfContents to use PinnedContainer and PinnableElement Bug: T317900 Change-Id: I0a740f8543831e266f2b1b874b40e44c8241d4cb
2022-12-07 01:05:22 +00:00
{{/data-page-tools}}
{{#data-page-tools-dropdown}}{{>Dropdown/Close}}{{/data-page-tools-dropdown}}
{{/is-page-tools-enabled}}
Undo PageTools template confusion The PageTools template is currently only being used when page tools is disabled which is super confusing. Rectify that immediately. Follow up to I220d0a477b3f05b278bd2cec7dd601c7b3b17c6f Change-Id: I4a984b959b764386133934c81e625dfde19d023b
2022-11-30 22:13:23 +00:00
{{^is-page-tools-enabled}}{{#data-actions}}{{>LegacyMoreMenu}}{{/data-actions}}{{/is-page-tools-enabled}}
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</nav>
[Grid preparation] ArticleToolbar component Structural change to prepare for CSS grid usage. ArticleToolbar component is defined and self contained with all layout rules relating to toolbar UI regression testing suite shows 6 failures due to pixel alignment changes to tabs. When comparing to the current release, you should see 34 failures before /and/ after this change. Notable changes: - #mw-head element is no longer present in modern Vector skin to allow us to distinguish between cached HTML and modern HTML Bug: T303484 Change-Id: Ia261ea53931217f32a21b33c2ab3d4ec64efa48a
2022-04-28 21:31:59 +00:00
</div>
{{/data-portlets}}
</div>
Restore navigation landmarks in page toolbar Adds landmarks to the article toolbar - Namespace navigation - View navigation - More options navigation Removes the "tools" landmark and associated aria-label (and translation message). Makes the #left-navigation and #right-navigation flexbox to ensure the new <nav> elements, along with gadgets, align on one line. Moves the styles for these elements from screen.less to ArticleToolbar.less. Bug: T317440 Change-Id: Iceff337b0e250c1f368dbaea6cc41a977d8ee868
2022-09-29 15:28:57 +00:00
</div>
Reference in a new issue Copy permalink