a30b575271
Additional changes: * Separate CSSCustomProperties.less from skin.less so that we can obtain the unmodified original values for the colors Depends-On: I363a97d33d85a9033da753f2a8fe730d80206639 Depends-On: I148eaca747352ffdc9d1423f20d34bd5a1d0e447 Bug: T356427 Change-Id: I916450c276cabb0c7c871525c50f95fb87f498ad
1.3 KiB
1. Drop support for Codex Design Tokens with LESS mixins
Date: 2024-02-16
Status
Accepted.
Context
In order to reduce the strain on other teams/developers to update their extensions to use
CSS variables rather than LESS, we decided to use Wikimedia skin variables to re-map LESS variables to their
CSS variable equivalent. This is consistent with the Codex design token experimental build which we will
make use of in T358059 This had implications on native LESS mixins such as average, fade and tint.
Decision
Given the few consumers of these LESS mixins, we decided to remove support for LESS mixins that operate on colors. One of the downsides of using these LESS mixins is that it produces colors that are not approved by the design style guide.
Consequences
Skins or extensions that need to work with Vector 2022 for the time being can no longer use Codex design tokens. They can continue to use these mixins if they instead make use of hardcoded hex codes with a comment. We filed a ticket for addressing this on the long term. This may require upgrading our version of LESS to a more modern version or a decision to drop support altogether.