Commit graph

1226 commits

Author SHA1 Message Date
jdlrobson 6a7d350160 QA: Page issues browser test is ready for new treatment
The page issues browser test is now compatible with both the old
and new treatments.

For consistency, in integration tests it will be run always in
treatment B since that will be the new way to do this going forward.

The beta cluster will test issue treatment A while it continues to be
the default. So with this we enjoy the best of both worlds.

When we enable page issues, the beta cluster will inherit the config
from production and we can remove the treatment testing for treatment B.

A follow up patch, might add testing for a page issue on talk pages,
which will retain treatment A for completeness if this is deemed useful.

Bug: T206647
Change-Id: I586523e452a6809e310f65a2ed55c6771d1965b6
2018-11-20 23:38:04 +00:00
jenkins-bot 58cfdbff89 Merge "page issues is feature flagged" 2018-11-20 22:44:40 +00:00
jenkins-bot 09534b7b84 Merge "Don't open images if control keys are pressed" 2018-11-20 21:41:03 +00:00
jdlrobson 97fd861a63 page issues is feature flagged
* New feature/skin option is added and value is read inside
the pageIssues setup code
* issues-group-a class is added to page on server side to remove
the flash of unstyled content
* issues-group-A class is dropped (it's not doing anything!)
* The minerva-issues flag will now accept any value to avoid confusion.
It is used to override the default setting of wgMinervaPageIssuesNewTreatment
A note has been added that this can be removed in future.

Bug: T206179
Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-20 12:41:41 -08:00
jenkins-bot 15ec367b0c Merge "Drop unnecessary prefix config" 2018-11-19 22:24:01 +00:00
LukBukkit 9e114731ce
Don't open images if control keys are pressed
This replicates the behavior of the MultimediaViewer on the
desktop when using the mobile page with a desktop browser.

But we have to be careful that this change don't break
other extensions or functions of the skin.

Bug: T206348
Change-Id: Ib4b928eae136d781782dc96e82d653806587292b
2018-11-19 22:10:19 +01:00
Translation updater bot 11764cb9d9 Localisation updates from https://translatewiki.net.
Change-Id: Ib5348ef1f9f5106be2ff059beb10068562c25f42
2018-11-19 21:59:25 +01:00
jenkins-bot c9dee311ea Merge "Fix invalid selector" 2018-11-19 15:35:38 +00:00
Translation updater bot 13017beb8d Localisation updates from https://translatewiki.net.
Change-Id: Ie556f92f87dfb26a899bec962b4860be001417cf
2018-11-18 22:27:43 +01:00
Volker E 51304f9bad Fix invalid selector
Seems like one of the selectors in this group has been removed.
Found with `"block-opening-brace-space-before": "always"` added in
.stylelintrc.json – It's going to be part of next
stylelint-config-wikimedia release. This issue here has caused an
invalid selector though, therefore fixing immediately.

Change-Id: If9603f12b9ad236b1517eb8861d220e991fa0a8d
2018-11-16 18:32:35 -08:00
Translation updater bot 7b89beca05 Localisation updates from https://translatewiki.net.
Change-Id: I24dc5ce82880995d28360cefdda66e21878eeb81
2018-11-16 22:08:19 +01:00
jdlrobson 2922cc6fd1 QA: Drop more toast notification tests from Firefox (logged in search)
Toast tests are often failing in Firefox build.
They are also tested and pass more consistently in Chrome

Stable browser tests means real bugs get caught more often
so let's disable this browser test against Firefox for the time
being.

Bug:  T208808
Change-Id: I05d77eb53657bb3ea0daaad7906a50db6aab66db
2018-11-16 20:41:17 +00:00
jdlrobson 2e3528ea62 Drop unnecessary prefix config
These values are never read.
In includes/MinervaHooks.php when registering the features in
onMobileFrontendFeaturesRegistration we pass the group name `skin-minerva`

Change-Id: I7e2af47daa4369d3124686de64fc197881bd3c5f
2018-11-16 20:40:33 +00:00
jenkins-bot 1d6865bba4 Merge "Remove obsolete aliases from closures" 2018-11-16 19:38:38 +00:00
jenkins-bot 4f2695907f Merge "Update references to deprecated modules" 2018-11-16 18:15:47 +00:00
Ed Sanders def03877ce Remove obsolete aliases from closures
Bug: T208951
Change-Id: I7cd5ab010596d964fc0896ed250f40d5b6344f6e
2018-11-16 15:16:25 +00:00
libraryupgrader 582066e1c3 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I2ea16b428e3e4d2dbbaed956a4a4d070e94b1e2e
2018-11-16 14:46:46 +00:00
jenkins-bot 9a641cd597 Merge "[Bug] Special:MobileOptions heading padding should be consistent" 2018-11-16 00:17:13 +00:00
jenkins-bot 4c8b538634 Merge "Avoid overlapping text on Russian and Farsi projects" 2018-11-16 00:14:58 +00:00
jdlrobson 0638296fb3 QA: Remove hacks introduced for T170890
These no longer seem to be achieving their original
intention and may even be causing the
flakiness we experience now.

Additional changes:
* Disable some more tests in Firefox job

Bug: T208808
Change-Id: I735ec0ff293cfd7aa60519c080a300bd40dc0abc
2018-11-15 14:59:08 -08:00
Translation updater bot 2e7c44fdfa Localisation updates from https://translatewiki.net.
Change-Id: Ia4b0a54a29accaf25ad016abb5d9003da5136745
2018-11-15 22:43:55 +01:00
jdlrobson 5e9739b9ff QA: Drop some tests in Firefox
The toast tests are flaking quite a bit in Firefox but pass in Chrome.
Having them run in both Firefox and Chrome seems less important than
being able to have better confidence in non-flaking tests so I'm removing.

Bug: T208808
Change-Id: I306518a7f3eb375715f6b9d6d599bf4f711ab6aa
2018-11-15 20:53:17 +00:00
jdlrobson 89fdcca241 [Bug] Special:MobileOptions heading padding should be consistent
This simplifies commit 17a3b5b6b0

The top or bottom margins of contained elements will always collapse together
(per http://seifi.org/css/understanding-taming-collapsing-margins-in-css.html)

What we actually want is a margin bottom in tablet mode for Special:MobileOptions
and a padding bottom for taglines that only exists if the tagline is not empty

Bug: T202557
Change-Id: I741f08d2dec04f94b7c233a04a3fca7a065520f8
2018-11-15 11:38:06 -08:00
jenkins-bot 5a2cfe3623 Merge "Remove 'skins.minerva.editor' module (moved to MobileFrontend)" 2018-11-14 23:37:31 +00:00
jdlrobson f5acba28f3 QA: Remove redundant test so beta cluster tests pass
Currently beta cluster tests are failing because of a single test.

The test for whether a "tagline" appears on special pages is outdated. We now
show taglines on all special pages (defaulting to empty)

Let's thus remove it.

Additional changes:
* Rephrase "wikidata description" as "tagline" - we use the tagline to display
things other than wikidata descriptions e.g. the tagline on Special:MobileOptions

Change-Id: Icb66563cb3a5e7043ca41f59c826bd4247d89d52
2018-11-14 22:39:06 +00:00
Bjornskjald dc61408a59
Add checking if template should output <sup>β</sup>
Bug: T208185
Change-Id: I4d564d9398947ea650b935b42cf79ef4a36d1b7e
2018-11-14 21:39:26 +01:00
jenkins-bot 986f8a3013 Merge "QA: Don't check when_visible twice" 2018-11-14 01:10:29 +00:00
jdlrobson f2639e7a73 QA: Don't check when_visible twice
Instead check the element is in the DOM before testing its
visibility.

This might help T208808 but it's a stab in the dark.

Change-Id: If7ccf5f2f03073c247de7fa497b3a6e31b570918
2018-11-13 16:49:24 -08:00
jenkins-bot 9582c298b2 Merge "Special:MobileOptions: Consistent padding of heading" 2018-11-13 22:29:50 +00:00
Bartosz Dziewoński b17d3f70da Remove 'skins.minerva.editor' module (moved to MobileFrontend)
Added in MobileFrontend in Iaaed72c32b9c4f4e15c320b79e29e9af3609069a.

(The module's name is included in cached page HTML, so to avoid
breaking them, 'skins.minerva.editor' must temporarily remain as an
alias for 'mobile.editor'. It is otherwise unused and can be removed
after caches expire on Wikimedia wikis.)

Depends-On: Iaaed72c32b9c4f4e15c320b79e29e9af3609069a
Bug: T198765
Change-Id: I52c4e0941dcf8f176e3ac32d8a1f72a0f8e1d6a6
2018-11-13 23:27:29 +01:00
takidelfin 17a3b5b6b0 Special:MobileOptions: Consistent padding of heading
Fixed it by adding a new media query for <720px and defining `default` for MobileOptions regardless of screen width.

Bug: T202557
Change-Id: I11deac1a36d9ab02ccfbce639490a95ca176f136
2018-11-13 15:42:03 +01:00
jdlrobson f173dabf75 Avoid overlapping text on Russian and Farsi projects
Account for the fact that many wikis use `mbox-text-div` rather
than `mbox-text-span` and that the element might not be display
block/inline block

Bug: T206887
Change-Id: I6b3cee4339fc7ddb035a99fb4929b1ab67f22333
2018-11-12 16:44:06 -08:00
Translation updater bot 6bc349f1d5 Localisation updates from https://translatewiki.net.
Change-Id: I769985bb9f72ce82e673de559ce80fa515dd0ee7
2018-11-12 21:58:12 +01:00
jenkins-bot 6dfde3c19f Merge "Hygiene: remove package-lock.json" 2018-11-12 20:48:50 +00:00
jenkins-bot 16c0567578 Merge "skins.minerva.editor: Remove unused dependencies" 2018-11-12 20:48:48 +00:00
Stephen Niedzielski d0c035ea3e Hygiene: remove package-lock.json
Remove package-lock.json until a Node.js version that supports it is
possible.

Change-Id: Id26bbd63aefabbc1e06f2e108dc2c23868138b31
2018-11-12 07:53:49 -07:00
Translation updater bot 3b6d2cf9d8 Localisation updates from https://translatewiki.net.
Change-Id: Id85c6546e1d825cad963ab5d2324f9b1e46a5679
2018-11-10 22:06:35 +01:00
jenkins-bot 90629a0578 Merge "Move canEdit checks to server from client" 2018-11-09 22:07:47 +00:00
arcayn c64a4cf811 Move canEdit checks to server from client
Bug: T206262
Change-Id: I08bfc56998f4fb42c8ce76cc2ad9fba83106d476
2018-11-09 21:26:49 +00:00
Translation updater bot 084d255fa4 Localisation updates from https://translatewiki.net.
Change-Id: I9df1e3acaf11b47be95e43105db9fcd9f7713e36
2018-11-09 21:56:29 +01:00
jenkins-bot 241c319bbb Merge "skins.minerva.editor: Remove remaining uses of 'skins.minerva.scripts'" 2018-11-09 17:19:18 +00:00
jenkins-bot 5a1dd4a52a Merge "skins.minerva.scripts/init: Use singleton OverlayManager from MF" 2018-11-09 17:19:16 +00:00
jenkins-bot 65b00b4a41 Merge "Merge remote-tracking branch 'gerrit/page-issues-cleanup'" 2018-11-09 01:11:10 +00:00
jdlrobson 846b37c708 Update references to deprecated modules
Change-Id: Id5ec727eb32c7b5207bb1175ebcdb0c1c4a4911a
Depends-On: I7b0090c3e4268ea147f1d8707ee62f90e7d48724
Bug: T207805
2018-11-08 13:34:50 -08:00
Translation updater bot 6681de52de Localisation updates from https://translatewiki.net.
Change-Id: Ic48b3a4f7b7594cfba0cc4ca6631d6f385f2d677
2018-11-08 22:00:23 +01:00
Bartosz Dziewoński 3a0e46907b skins.minerva.editor: Remove unused dependencies
We were not using some of the code this was depending on. No idea when
it stopped being required.

'skins.minerva.scripts' was used until recently (d27a9481, 72cd31f2),
but now its only purpose was to load other dependencies. Add them
separately instead.

Removed dependencies:
* mediawiki.ui.input
* skins.minerva.icons.images.scripts
* skins.minerva.scripts
* skins.minerva.toggling

Added dependencies:
* mediawiki.api
* mediawiki.storage
* mediawiki.user
* mobile.init

Bug: T198765
Change-Id: Ic80ba016adca377cb539adf672793fa103deb150
2018-11-08 17:42:53 +01:00
jenkins-bot 880607b55a Merge "No Minerva variables should be loaded on a non-Minerva skin" 2018-11-08 16:32:30 +00:00
Bartosz Dziewoński d27a9481bc skins.minerva.editor: Remove remaining uses of 'skins.minerva.scripts'
We want to remove dependencies on Minerva code from this file to move
it to MobileFrontend.

* Use 'mobile.init/skin' instead of 'skins.minerva.scripts/skin'.
* Use 'mobile.startup/OverlayManager' and #getSingleton
  instead of 'skins.minerva.scripts/overlayManager'.

Both of them are just aliases for modules defined in MobileFrontend.

Bug: T198765
Change-Id: Id017dd4b6d1fe31a735613f991721c4dddafbde9
2018-11-08 16:17:21 +01:00
Bartosz Dziewoński 7bbba14ee1 skins.minerva.scripts/init: Use singleton OverlayManager from MF
Bug: T198765
Depends-On: Ie83846e7dfabe302006d0979f2f21913839e1795
Change-Id: I9c07863ab9c68886d6c5b5f09756e034a4d96477
2018-11-08 16:14:40 +01:00
Bartosz Dziewoński 7b5928d795 Merge remote-tracking branch 'gerrit/page-issues-cleanup'
Bug: T198765
Bug: T208514
Change-Id: I9467101c9b01cbd7682de859e43e04966760eea6
2018-11-08 16:00:39 +01:00