QA: Page issues browser test is ready for new treatment

The page issues browser test is now compatible with both the old
and new treatments.

For consistency, in integration tests it will be run always in
treatment B since that will be the new way to do this going forward.

The beta cluster will test issue treatment A while it continues to be
the default. So with this we enjoy the best of both worlds.

When we enable page issues, the beta cluster will inherit the config
from production and we can remove the treatment testing for treatment B.

A follow up patch, might add testing for a page issue on talk pages,
which will retain treatment A for completeness if this is deemed useful.

Bug: T206647
Change-Id: I586523e452a6809e310f65a2ed55c6771d1965b6
This commit is contained in:
jdlrobson 2018-11-13 16:17:49 -08:00 committed by Jdlrobson
parent 58cfdbff89
commit 6a7d350160
2 changed files with 9 additions and 1 deletions

View file

@ -19,6 +19,11 @@ $wgHooks['InterwikiLoadPrefix'][] = function ( $prefix, &$iwdata ) {
};
$wgInterwikiCache = false;
$wgMinervaPageIssuesNewTreatment = [
"base" => true,
"beta" => true,
];
$wgMFEnableBeta = true;
// Set the desktop skin to MinervaNeue. Otherwise, it will try to guess the skin name using the

View file

@ -178,7 +178,10 @@ class ArticlePage
h2(:third_section, css: '.collapsible-block', index: 2)
# issues
a(:issues_stamp, css: '.mw-mf-cleanup')
# We use 2 selectors here - the first relates to the old treatment (A) and
# the 2nd relates to the new treatment (.ambox)
# see https://phabricator.wikimedia.org/T206647
a(:issues_stamp, css: '.mw-mf-cleanup, .ambox')
# page info (action=info)
td(:edit_count, css: '#mw-pageinfo-edits td', index: 1)