Commit graph

284 commits

Author SHA1 Message Date
Jon Robson d407d1054c Remove or document remaining mw-ui-icon usages
Most of these are captured in other bugs
The anon talk message style doesn't do anything.

Bug: T344022
Change-Id: Iba1fce98ea05931fe07b2b20f07c62d198039d1b
2023-09-13 00:03:38 +00:00
jenkins-bot d676f6e910 Merge "Ensure header edit icons are the same size" 2023-09-12 00:09:12 +00:00
bwang 9e9c1292e4 Ensure header edit icons are the same size
Bug: T345969
Change-Id: Ica191284df74610c958ad8808dcd1c03839b1a5d
2023-09-11 18:37:31 -05:00
Derk-Jan Hartman 2728752633 Add figure and picture elements to the reset.
These are newer elements but they have similar user agent defaults to
img/video/audio etc.

This should fix the usage of imagemaps, which use frameless figures
and currently have excessive margin in minerva

Change-Id: If9f995401b771baffe221e474991cf1e3fbc7f76
2023-09-09 13:53:06 +02:00
bwang 7bbb240db1 Make menuGroup.mustache use togglelist classes, ensuring ToggleList HTML is consistent. Remove duplicated CSS
Bug: T343920
Change-Id: I567d20171b0e511d00922adf250f97b9b8ed146b
2023-08-25 17:57:47 +00:00
Jon Robson 952789bc17 Switch Minerva button template to use Codex and remove mw-ui-button
- Removes 'mw-ui-icon-with-label-desktop' as that is now the default behavior for icon only buttons in Minerva
- Removes icon flushing classes, use codex mixins instead

80 Visual changes relating to minor icon/button subpixel changes in the heading, edit section links, and page actions

Bug: T319260
Change-Id: I503b643d33e43196483af4b5f9dd312237322ac8
2023-08-24 15:57:01 -05:00
bwang b66ac786d1 Prepare addPortletLink handler for Codex switchover
Change-Id: I33e541ab7b816640a63541ce719e094bb8f5d78e
2023-08-24 12:07:28 -05:00
jenkins-bot 7c59e349a9 Merge "Edit icon uses template parser" 2023-08-16 22:27:51 +00:00
Jon Robson f3c1b06ce6 Move button styles out of icons.less
Follow up to
I84407fb562c288bafe02e97ba7f3366de7f61611

Change-Id: I80c2b63077d38203fcef09d473c82f5566a92467
2023-08-11 17:54:59 +00:00
Jon Robson 12f3e033a7 Redo icon sizing
The current implementation enforces the size to be part of the
icon name. It would be preferable to have a specific class for
controlling size given we don't want to have to update all the
names of our icons.

Bug: T342908
Change-Id: I84407fb562c288bafe02e97ba7f3366de7f61611
2023-08-11 17:08:28 +00:00
Jon Robson 0c6ac2926d Edit icon uses template parser
Bug: T344007
Change-Id: I772f2c8be7e4f48e9d67a5d1d7d3ef9e6af17851
2023-08-10 22:04:11 +00:00
bwang 0648dbf29c Fix header overflow style causing header buttons from being cut off
Reverts the change to flushing for notification icons in
I55c18cf723a32f80b93a01dd0687e005162c4e93

Bug: T343908
Change-Id: I1c9b9969c822f90f8edeb90ce8b27d79d378cf64
2023-08-10 18:14:05 +00:00
Esanders 35dfdfceb9 Revert "Any header overflow should be hidden"
This reverts commit e78d6a5216.

Reason for revert: Completely truncates the user popup menu.

Bug: T343908
Change-Id: I320103bb7563c9265afb9956b9375d2a96b37172
2023-08-10 12:54:36 +00:00
Jon Robson e78d6a5216 Any header overflow should be hidden
One of the child elements are flushed right.

Bug: T343908
Change-Id: I227264ad50e7ce8dbaac260d607824ec47a81739
2023-08-09 10:10:59 -07:00
jenkins-bot 0c69779b73 Merge "Echo uses Button template" 2023-08-08 17:44:22 +00:00
Jon Robson ded6430b47 Echo uses Button template
Changes
* Update FIXME in userMenu.less to merge selectors
* We replace minerva-user-notifications class with minerva-notifications
to short-circuit Echo's code so that it no longer replaces the Minerva
notification badge with its own.
* We update resources/skins.minerva.scripts/initMobile.js to introduce
our own wire up code - this is responsible for opening Echo overlay
and reseting the counter. The code in Echo will be removed in a follow
up (see <I2f923e509d24524a2375ffbe6b3ef336487574bb>)
* We update skinStyles/ext.echo.styles.badge.less with styles from Vector 2022
so that Minerva desktop remains consistent with desktop Vector 2022 experience.
* We clearly mark technical debt relating to the special mobile version.

Testing:
* Pixel.js has a group echo that covers all the different variants.
Make sure to update to latest main branch before running these.
* Desktop should behave the same for Minerva as Echo.
* On mobile only when a user has unseen notifications a red circle
is shown. Otherwise a bell icon is shown, never with number.
* On mobile a single button is visible that combines alert and count
numbers.
* With Echo disabled a bell shows that links to the user talk page

Visual changes:
* Previously the red circle became a transparent/gray circle on click. Now
it will always be red.
* Minor aligment changes to red circle and bell icon are expected as
the change prevents MobileFrontend/Echo updating the icon to use
Codex.

Bug: T342907
Change-Id: I55c18cf723a32f80b93a01dd0687e005162c4e93
2023-08-08 15:44:38 +00:00
bwang 465e66aad5 Update page issues to use new MF icon class
Bug: T343053
Change-Id: I917a4ac4d0a8af5162959f4514bc184670582b50
2023-08-04 16:50:26 +00:00
bwang e6511ebe8f Add option for different icon sizes, reduce size of arrow icon in last modified bar
Change-Id: I494a02e5ba08cc7849cf1973f8f9163c672fccff
2023-07-31 14:18:49 -05:00
Jon Robson a8362a9237 Hide image overlay slider buttons
There is one instance of icon only buttons in the overlay content.

Bug: T342936
Change-Id: I8aef02c87b63d2248c30371c98e390322f5c706c
2023-07-31 08:51:15 -07:00
jenkins-bot 7e1e418d1f Merge "Fixes: Close label showing in reference drawer" 2023-07-31 15:05:19 +00:00
Jan Drewniak 11e09ea7b3 [Icons] Convert history/next status bar icons to Codex
Creates a new Icon.mustache file in favour of using
MinervaUI::iconClass.

Add a new icons.less file and the following icons:
- history
- expand (next) arrow.

These icons are used exclusively in the history
status bar at the bottom of most pages.

Bug: T319260
Change-Id: If81186418fe758d7be9c3e57cf5d2aa889517f2d
2023-07-28 16:56:24 -07:00
Jon Robson ad000ae002 Fixes: Close label showing in reference drawer
Bug: T340262
Change-Id: Ib03a468aa156e4deb0ac21e7c9f40838657a55d9
2023-07-28 14:31:00 -07:00
Jon Robson 6dad2802f3 Handle icon only labels with Codex in Minerva
In Minerva icon only buttons reveal themselves at desktop
resolution, except for any buttons in the header.

Bug: T340262
Change-Id: Iba6c633164a615b96bf19d5fe8f202b925bcace9
2023-07-27 23:23:44 +00:00
jenkins-bot 8a2aff6fd7 Merge "[Icons] Update usage of MobileFrontend Icon code" 2023-07-25 18:11:13 +00:00
bwang 6635693826 [Icons] Update usage of MobileFrontend Icon code
Visual change:
* Improves vertical alignment of TOC

Technical change:
* Remove dependency on MobileFrontend

Bug: T319260
Change-Id: I0526293c6a99dfe078b9e32aa247522a63b6d0fd
2023-07-25 17:55:02 +00:00
SnowFire e3515afdf0 Add margin top/bottom to dl list style to match other skins
Bug: T341915
Change-Id: I520e1bcf5010646b0032f85cc080b37c25744a0e
2023-07-18 17:37:05 +00:00
Daimona Eaytoy af8e939c41 Update ambox styles so that they also work on divs
This rule was assuming that the ambox is always a table, but that may
not be the case; for instance, it might be a div (using CSS for layout).

So update the selector to target the new mbox-text, in addition to td
elements.

Bug: T339040
Change-Id: I7611e0de92afc4aef5bf56beb52de3f92e6b30c7
2023-06-18 12:08:40 +00:00
jenkins-bot 33b2b037a7 Merge "Style thumbs in places that don't set a content language" 2023-06-14 22:10:48 +00:00
Arlo Breault 9e02cb7713 Style thumbs in places that don't set a content language
Bug: T337804
Depends-On: I23a2c4f812c57cbd7801c4d5aae84ca4d696d542
Change-Id: I0b58fd5a9957226ac1842a45885ee758efe43cb9
2023-06-14 16:08:23 -04:00
Ed Sanders d09600aa51 build: Update linters
Change-Id: Iaa1c41ab1af4802fd71896b471eda8dd8852a323
2023-06-13 13:56:14 +01:00
jenkins-bot 722e453c28 Merge "Revert "styles: Apply Codex z-index tokens"" 2023-05-29 22:11:07 +00:00
Jdrewniak cc513b9e72 Revert "styles: Apply Codex z-index tokens"
This reverts commit b28b80e222.

Reason for revert: Changes broke dialogs in mobile VE.

Change-Id: I957661a882b1d8aa50cede906631d29f4a51e530
2023-05-26 15:29:03 +00:00
jenkins-bot acc6286ecd Merge "styles: Apply Codex z-index tokens" 2023-05-25 16:17:49 +00:00
Arlo Breault a59bf8066e Make use of mw-file-element class
Added to core in Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b

Applies the border more generally.

Bug: T314097
Change-Id: I884010c6b84b2dcb4dfc55f7b4cab9fefd3f6786
2023-05-25 10:33:14 -04:00
Volker E b28b80e222 styles: Apply Codex z-index tokens
Applying central Codex design tokens in new architecture.
This replaces all existing MN `z-index` tokens and comments on
replacement choice.

Bug: T285592
Change-Id: I23d794566898946a500c10713802d8dfaad993d1
2023-05-18 23:33:38 -07:00
Volker E 38ca243e39 styles: Replace 'mediawiki.ui/variables' call with skin variables
Replacing 'mediawiki.ui/variables.less' @import with
new skin-aware 'mediawiki.skin.variables.less' standard.
Removing calls for 'mediawiki.skin.variables.less' in favor for
'minerva.variables.less' for consistency.
Also
- replacing several static values with new Codex design token featuring
  skin variables of `background-color`, `color`, `border-*` and
  `transition` categories
- renaming several Less variables to variable naming standard
- moving a small number of MinervaNeue specific variables into
  'minderva.variables.less' file. Those should be replaced in mid-future
  by Codex design tokens

Please note, that this patch is not replacing all values with
possible Codex tokens. It's just applying them on selected
categories for consistency for now to keep the patch easier reviewable.
Further replacements will be done in follow-up patches.

Bump MediaWiki core required version to >= v1.41.0.

Bug: T319381
Bug: T332541
Depends-On: I98c8cc27527533e2efb3b987ee34bc403e988b75
Change-Id: I86c5a35377541a784552c29456e0b8b507b3ee9c
2023-04-24 16:08:27 +00:00
Umherirrender 5bd834e0c7 build: Updating npm dependencies
* stylelint-config-wikimedia: 0.13.0 → 0.14.0

Run stylelint fix to fix the new stylelint rule

Change-Id: I7738ae421e84dd3171355391ebc82dd812b39ca4
2023-03-31 21:50:36 +02:00
Jon Robson a923e702d5 Enable core interface styles on mobile
Per ResourceLoaderSkinModule disabling these styles is not
recommended. Enabling them is also now needed to support IP masking.

Bug: T325768
Change-Id: Ia7f2eb6ba902ebfc9364147ec0692eaae124469e
2023-03-22 20:34:24 +00:00
jenkins-bot e1ebb4b196 Merge "Remove talk page tools" 2023-03-21 19:03:13 +00:00
Jon Robson b28d802693 Add languages to Minerva HTML
Bug: T331905
Change-Id: I55a25dfb8aba3d1b589a36ba4cba3bba0fe710a1
2023-03-17 20:37:32 +00:00
Bartosz Dziewoński 8c0f0c578e Remove talk page tools
Bug: T319145
Change-Id: Ib432564e1049f18334653e5eb3981f0f051582b3
2023-03-13 18:21:52 +00:00
Bartosz Dziewoński bf9f3972d8 Remove unneeded CSS rule
This has no effect. I don't know why I added it in 2690ea3a9.

Change-Id: I078267dfef5fbe66abd6f632fe644e34769d5f1e
2023-02-08 20:36:58 +01:00
Arlo Breault 0cd677dcec Make figure styling more specific to thumbs
This was requested to free up figure for proposed HTML format
change to galleries.

Bug: T268250
Change-Id: Id1ceac08a46fa1faeb9ac976a53da06e4f8f8c77
2023-02-03 21:45:25 +00:00
Bartosz Dziewoński 50fc799b07 Fix various problems with print styles
These styles have drifted away from the HTML structure since they were
written in 2017.

General:
* Add some comments
* Replace complicated selectors with simple class selectors

styles.less:
* Hide section edit links (previously we relied on MobileFrontend
  styles, which one handled some cases - removing them in I9a88b80c2a)
* Show print footer, hide Minerva footer

header.less:
* Remove FIXME (resolved in c323c6858a).
* Fix hiding the search box. In 0bee6a1eb6 a <form> for the search box
  was added to the header, and these styles (using tag selectors) were
  not updated. Use class selectors instead.
* Remove styles for <h1>. The element was changed to <a> in
  a905b1c161, styles to override font-size etc. are no longer needed.
* Consolidate 'padding' rules and remove unneeded !important.

article.less:
* Replace the `[ class|='mw-content' ]` selector, which was not
  matching anything. It would match elements with `class="mw-content"`
  or `class="mw-content-…"`, but the node we're trying to style has
  `class="mw-body-content mw-content-ltr"` (since 7cda5b0bf8 in
  MediaWiki core). Use a class selector instead.
* Replace the `.mw-body > .content` selector too. While this one
  works, it is also needlessly complicated.

footer.less:
* Fix and simplify how last-modified info and license text is unhidden
  (while other parts of the footer remain hidden).
* Remove styles for .license. Unused since 1f2b7dff15, use the desktop
  footer added in that commit instead.
* Use the desktop footer for last-modified info, since it's more
  suitable for "archiving" (it has a date rather than time ago).

Bug: T323636
Change-Id: I21ef26355e3e6dd8b0c34ae933b7f5b0b222655c
2023-01-03 21:57:11 +00:00
jenkins-bot 754b73c8e2 Merge "Tweak margins/paddings of Echo icons" 2022-12-14 16:43:52 +00:00
jenkins-bot 3c6a66d1af Merge "Use standard subtitle markup" 2022-12-14 04:13:59 +00:00
Bartosz Dziewoński 433458ba98 Tweak margins/paddings of Echo icons
On desktop, the "Alert" icon had more white space around it than the
"Notice" icon, and its popup displayed with a different offset.

On mobile, the combined icon jumped around while the page was loading.

Change-Id: Icdd5bc6e8478f3453b6461a35b7fb53e8ab014e9
2022-12-14 04:36:14 +01:00
Jon Robson f6f2c4f1e4 Show both Echo icons in desktop Minerva
For consistency with desktop Vector, Minerva should show two
icons. This also removes the duplicate #pt-notifications-alert
element in the skin.

Bug: T313609
Change-Id: I6449f0c29b52fd2092d63fbef23205ed8f57d50f
2022-12-14 02:08:44 +00:00
Jon Robson 64fb00e237 Use standard subtitle markup
Bug: T324876
Depends-On: I8e538939a6d7d4474f2e96b93040f3c68c2f98ec
Depends-On: I4b178f67b6718fa9a84827e1804ec4eb1483f735
Change-Id: Ie24c0215d07d5e4605d8479ed9e950a3d9c9b086
2022-12-13 01:32:37 +00:00
Arlo Breault c4fe708a36 Remove b/c for media typeof
Bug: T270150
Bug: T203211
Depends-On: I44b3fb432dd00120a4d5cd5556ba5ba8bc4e65d5
Change-Id: I58d8ce9e2e58916d55c8d838c3fbfb96e2a05f02
2022-11-30 13:55:32 -05:00