Commit graph

4467 commits

Author SHA1 Message Date
jdlrobson 8dad1703af Special handling for links without href attribute
The link change overrides link colors in last modified,
talk button and main menu. This approach was obviously flawed.

Rather than enter a specificity
war let's instead limit the styles to links which do not have
an href. Volker you were right...

* Revert "Last modified links should not be progressive blue"
This reverts commit bc045b78a2.
* Revert "Do not style links without href attribute"
This reverts commit daa6ad5145.
* Apply a not selector for links

Certain links (including links inside navboxes) render
links to themselves - for example the navbox on the San
Francisco article (provided it is not removed by
wgMFRemovableClasses)

These links should be visually distinguished from normal links.
The not selector has support from IE9 onwards and given our browser
matrix and the low impact of if this fallback fails this is a perfectly
acceptable usecase.

Bug: T181472

Change-Id: I61b05e3c223f2ba5314aecdf26b8a0ee8caa6524
2018-03-29 15:58:09 -07:00
jenkins-bot 121958bea1 Merge "Block reason messages escape HTML" 2018-03-29 21:34:34 +00:00
libraryupgrader d925a800ef build: Updating mediawiki/mediawiki-codesniffer to 17.0.0
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment

Change-Id: I036e37625f68b620f505a8d8be4202056fde09ff
2018-03-29 07:59:18 +00:00
jdlrobson ac1ffdb5f1 Restore search placeholder text
Bug: T190939
Change-Id: Ic42ed495b54f153c93ee32ac250dfe5d9233d1cb
2018-03-28 20:00:55 +00:00
jenkins-bot 75cfd47acb Merge "Last modified links should not be progressive blue" 2018-03-28 19:12:00 +00:00
jenkins-bot 94d0229b74 Merge "Fix: always show table of contents" 2018-03-28 19:10:20 +00:00
jdlrobson bc045b78a2 Last modified links should not be progressive blue
This regression was due to I9f842ae09751d299716d752328f747269597fbdb
Updated specifity of selector.

Additional change:
* Update comment per feedback from TheDj

Bug: T181472
Change-Id: I9534cce5f240009c9013b75e1367776519b00d81
2018-03-28 19:00:35 +00:00
Stephen Niedzielski e8b4559f5b Fix: always show table of contents
Do not conditionally render the table of contents. Note: the underlying
condition, MFTOC, appears to still be used by MobileFormatter so it was
unchanged.

Bug: T189699
Change-Id: I7088ccad75c2a8504bf435418d7dd62238b2135d
2018-03-28 13:36:17 -05:00
David Barratt 6bea4324c6
Block reason messages escape HTML
The block reason in the block message has escaped HTML. This
HTML should be rendered to the user.

Bug: T190901
Change-Id: Icda7c5d0c76aff7c22f3a6735d880a5ee49338ff
2018-03-28 12:36:43 -04:00
Translation updater bot 6cfa2c9380 Localisation updates from https://translatewiki.net.
Change-Id: I6d830ecf678c79ce2d6e46a56ec11bdab0d103fd
2018-03-27 21:55:14 +02:00
jenkins-bot 180b55d13b Merge "Do not style links without href attribute" 2018-03-27 18:42:41 +00:00
Zoranzoki21 441f5ac89d Remove unused $useHeadElement property from skins
Bug: T190575
Change-Id: I1ff60f683ba7186343408579d72303fc693b5a87
2018-03-27 17:18:53 +02:00
jenkins-bot da5e271e06 Merge "QA: Remove test not adding value" 2018-03-27 13:44:55 +00:00
Translation updater bot 096c02f100 Localisation updates from https://translatewiki.net.
Change-Id: Ia0cdf3eb9fe4229f7e301c9968db8314f89ab132
2018-03-26 22:06:18 +02:00
jdlrobson 0779626a21 QA: Remove test not adding value
* Drop special.feature - it checks a search box is present on
multiple pages. This dates back to when special pages and normal
pages did not use the same code path.

Bug: T174018
Change-Id: Icf59ff95135af91650f8cdeef79bbaed534165f0
2018-03-26 11:21:03 -07:00
jdlrobson daa6ad5145 Do not style links without href attribute
Certain links (including links inside navboxes) render
links to themselves - for example the navbox on the San
Francisco article (provided it is not removed by
wgMFRemovableClasses)

These links should not look like links as they are not
clickable so should be visually distinguished.

Support for attribute selectors goes way back to IE7
and in the case of IE6, links will still render correctly
falling back to the browser default stylesheet

Bug: T181472
Change-Id: I9f842ae09751d299716d752328f747269597fbdb
2018-03-26 10:44:52 -07:00
Translation updater bot a284c1b75d Localisation updates from https://translatewiki.net.
Change-Id: Ic004d1deb64243cdc2a2aae9a2efe01940c3cd75
2018-03-24 22:07:42 +01:00
Translation updater bot f8961447f9 Localisation updates from https://translatewiki.net.
Change-Id: I4fbd5f8fd5648f47ef5e3178b1d070cb8a389787
2018-03-23 22:00:23 +01:00
Translation updater bot 64eff2ac0a Localisation updates from https://translatewiki.net.
Change-Id: Ie864277f265566ed54e58ec33608b8fdb165e1bd
2018-03-22 21:55:55 +01:00
jdlrobson 922f4a09e4 Remove unnecessary file for gallery styles
This should have been removed back in 2015.
See I0ef5c2d5a9019355aa3a158f9e489df02975e0af
Gallery styles come from mediawiki.page.gallery.styles

Bug: T190215
Change-Id: I87713164e1c3906b341a4fb17be424307f8fa428
2018-03-20 22:12:04 +00:00
Translation updater bot 98a947c3c3 Localisation updates from https://translatewiki.net.
Change-Id: Idca5641ef330f5abb08c27ba2726f3d339a7b067
2018-03-20 22:00:15 +01:00
Volker E 759590873b Replace #toc selector by .toc
Replacing id CSS selector by lower specific class selector.

Bug: T187808
Depends-on: I7f3a9df7f9fd1178986112b5265b1ae7c991d5b7
Change-Id: Ib1a874b644e80a26ff415003684f6ce54fd2b7e6
2018-03-20 01:49:43 +00:00
Translation updater bot fa4835b3bd Localisation updates from https://translatewiki.net.
Change-Id: Iad44bb2bcb7cd47fd89108820d2a414ae4839ad4
2018-03-19 22:03:49 +01:00
jdlrobson cfd5fbbde8 Add icons for all the types of issues
More hackery!
This adds some tests and ensures that our own icons are mapped to the
existing template icons.

Bug: T187916
Change-Id: I49073f22995c6730369235d6039939915ba2079c
2018-03-15 15:02:05 -07:00
jdlrobson eaa2692da0 Use jsdoc for generating Minerva documentation
Given the level of documentation in this repo is extremely
low now seems a good as time as any.

The resulting documentation is a vast improvement on before
grouping functions to an owner and introducing module names.

We can iterate on the documentation over time.

Bug: T138401
Change-Id: I9e787d40931d3d72a7037ce07d3ab0db8e72d825
2018-03-15 15:01:41 -07:00
Translation updater bot c18bcd67fd Localisation updates from https://translatewiki.net.
Change-Id: Ie54bfcb04fa85e2b4f52c60d436b5584966b020e
2018-03-15 22:31:11 +01:00
Volker E 19d9a6367b Replace abandoned color variables
After having aligned vast majority of color variables to WikimediaUI
color palette and/or transformed to use central variables, these
seem abandoned leftovers.

Change-Id: Ic20b445975e920259c808b7a20c6100575c99f82
2018-03-14 17:53:56 -07:00
jenkins-bot f03a0b0884 Merge "Update link color for Minerva skin" 2018-03-14 22:23:35 +00:00
jdlrobson 62f248503f Update link color for Minerva skin
This adds consistency with the Apps, Wikimedia Portal
and wikimedia base ui.

Bug: T178862
Change-Id: I5ecd8d1e9c69c61ef784d61b435af4240dd79c57
2018-03-14 21:56:18 +00:00
Translation updater bot 4111f9b692 Localisation updates from https://translatewiki.net.
Change-Id: Ie6cc3448b5e79ebda441e5a5c935de055d4fa2ab
2018-03-14 21:57:53 +01:00
jdlrobson 0100dc33a4 CSS tweaks to issue overlay
* Remove CSS rule updating the padding of issue-notice
(this is no longer necessary after
I1b880c46fa3debfc5b68d8b416ca642cca98ce7e which defines its own padding
for the element)
* Overlay title is updated to read "Page issues"

Bug: T187916
Change-Id: I7e41d6f03c4cf9fa7563f2f608eec5be89c04a31
2018-03-14 17:54:50 +00:00
jenkins-bot ab34733382 Merge "Generalise search trigger mechanism" 2018-03-12 22:37:26 +00:00
Translation updater bot fcaa7073dd Localisation updates from https://translatewiki.net.
Change-Id: Id78b2972db36671f255de67cce1abf09d7fc1e9c
2018-03-12 22:04:52 +01:00
jdlrobson 888129478b Generalise search trigger mechanism
Allow content to trigger it.

Bug: T189316
Change-Id: Ie9a66b001b3ea4f79e465747b80b181df948cd34
2018-03-12 20:49:25 +00:00
Translation updater bot cb6b99f43b Localisation updates from https://translatewiki.net.
Change-Id: Id4984767dae1544688b9e4f542804d741a1da7f9
2018-03-11 22:10:22 +01:00
Translation updater bot 2aec45b387 Localisation updates from https://translatewiki.net.
Change-Id: I449fb735b8674d45d7026f195e0cc18d53f8bb69
2018-03-10 21:57:39 +01:00
libraryupgrader 9b937643d1 build: Updating jakub-onderka/php-parallel-lint to 1.0.0
Change-Id: I7745caaa2925aea87ad981ab017d7fcb7150309f
2018-03-10 09:59:27 +00:00
jdlrobson b020728668 Run browser test on per commit basis
Additional change
* Add it to the list of smoke tests

Depends-On: I731608412eb2ade95abb79ed8240cfec0f06fb98
Bug: T189194
Change-Id: If8a20202365d92766c52091d96633a74d72e480e
2018-03-08 23:04:57 +00:00
jdlrobson 71bf8604ab Move error handling inside Minerva
ReferenceDrawer
Instead of doing this inside the ReferenceDrawer component
itself, we'll do this here.

To be backwards compatible we check the value is truthy.
When I5a7b23f60722eb5017a85c68f38844dd460f8b63 is merged
this can be removed.

For NotificationBadge we pass the onError option which
is now available and allows us to clean up the NotificationBadge

Change-Id: I47db11fa945a05f3b2a9a43c3cf053ca489a38fa
2018-03-08 20:03:22 +00:00
jenkins-bot 22ca1e5f39 Merge "Hygiene: remove window.location use from overlays" 2018-03-08 17:59:56 +00:00
Stephen Niedzielski 41a43c5ce1 Hygiene: remove window.location use from overlays
Bug: T173539
Depends-On: I158dd7883be2846cf0d48bbd7e89fe2cd64a57d3
Change-Id: I87741667ca06cc701e5265aff13ba0492501de26
2018-03-07 17:13:59 -06:00
Translation updater bot 5ab9828cec Localisation updates from https://translatewiki.net.
Change-Id: Ib83a777455e7495fb66b52a7d0c49d6d93ba49f9
2018-03-07 22:26:25 +01:00
Translation updater bot ce2b87e1c6 Localisation updates from https://translatewiki.net.
Change-Id: I79d2789bb759b98f603784676513a4ee8d65ad45
2018-03-06 21:59:31 +01:00
Stephen Niedzielski 27bc7e7212 Chore: move window.location use to client
Move window.location manipulation from ImageOverlay view to MinervaNeue.
Also, don't leave a hanging empty URL fragment when closing the overlay.

Bug: T173539
Related: I292c0578716ff56e0e069aa8006f840025d78a88
Change-Id: I56ba9217aa9cd4e0a925c623060022392e3021c7
2018-03-06 08:35:48 -06:00
Translation updater bot 973b40c5ad Localisation updates from https://translatewiki.net.
Change-Id: Ib3c8c7bc81b40b967d31c98aff76f725c5470117
2018-03-05 22:07:12 +01:00
Translation updater bot 06618b4714 Localisation updates from https://translatewiki.net.
Change-Id: I5bed0e43bb5143ca8e626993fae18e5bdaa69d44
2018-03-03 22:06:41 +01:00
jenkins-bot 54f07cedf9 Merge "Make dependency to jquery.cookie explicit for mobileRedirect code" 2018-03-02 00:46:18 +00:00
jdlrobson 69053d13d3 Make dependency to jquery.cookie explicit for mobileRedirect code
Change-Id: I9ecdf9b507df6a9ec04933981ec5960c524e2323
2018-03-01 16:27:00 -08:00
Translation updater bot 7f13647e2b Localisation updates from https://translatewiki.net.
Change-Id: Ieed27b7c4e7e562448ab4beccd415095285975d5
2018-03-01 21:59:05 +01:00
Jan Drewniak 3b83933b57 Removing tap-highlight override for iOS
Bug: T188043
Change-Id: I78558b0badc3ecdaf4eb99ab1ed2a17fac3dd9e1
2018-03-01 19:04:13 +00:00