The existing code prevents a black square from appearing on late loading icons.
The problem with it is that if loaded late, it can override actual icon definitions
and make the icon invisible.
Since this typically applies in the case of icons loaded via JavaScript
this shouldn't be a problem on mobile web
Bug: T266361
Change-Id: Icee701761e9db69a6bffb7af4f608ec26c30f2be
Modules loaded with packageFiles are always executed in module scope
(with a closure), even in debug mode.
The behaviour of non-packageFiles debug mode is the only reason files
have closures.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Closure
Change-Id: I14ac680eb67d892618bbc13be9298ec9b8e0e2e9
Set bottom "compare selected versions" box to use z-index zero so IP information popup goes over "compare selected versions" box
Bug: T304944
Change-Id: Id78e643f73dbba740501c67912c869621786a4b3
SingleMenuEntry expects string|array for the parameter $className.
Currently the ltrim converts a false to a ''.
Change-Id: Icac8d41c01331cf7550e3592ee0366bdc561b547
There was an overlooked usecase in T377503 which regressed
by change of hidden characters in the core, this change
makes it possible to remove the last hidden character
there in I3f08595d654fbfe18627b44839eaa5c9fd38274c
and fix that overlooked usecase.
Bug: T377503
Change-Id: Ifb458f80f08d9c6f717f4c035c7d5120cccb04cf
This change avoids manual handling of the class separator spaces.
The rendered HTML doesn't contain multiple spaces in sequence anymore.
Change-Id: I1614281c704558fe2536951975a860ee406d9079
* Add PHP type hints to private functions.
* Remove @param and @return if redundant to type declaration.
Change-Id: I40df9579af92ad1af820d3706a8cd907e9950ce2
Following the migration to Codex, icons do not need suffixes for
their icons.
If we merge this now, we don't need to worry about caching when working
on Bug T266361.
Bug: T266361
Change-Id: Iafeb21858c89df1af35660eb63889fa5335e2b34
With AMC disabled, the logout link does not have the class
menu__item--logout - this breaks the behaviour of the logout
function which has JavaScript that manages a confirmation
workflow.
The issue is a typo - class is mapped to classes in
SingleMenuEntryItem::getComponents
Change-Id: I891ed700edadfad80888120c6e0666b6e7589377
This reverts commit 0585dea9f9.
Reason for revert: Moved logic for wikibase link into Wikibase repo (see 1079302)
Change-Id: I780baa6cd17f8b52ae4bae88e6686c22760f410d
It moves watchStar.less from .scripts to .base as star is
visible also when JavaScript isn't enabled so the right
time to apply styles to it isn't after scripts are added
but right from beginning to avoid initial animations.
It also limits minerva-animations-ready to transition
as that's the only style that needs page load to actually
happen and otherwise the styles will be limited to
JavaScript clients which isn't intended here.
Bug: T376872
Bug: T376559
Change-Id: I394d21689cae01822cf8791b361cd450771f5c31
The .minerva-icon rule sets a transparent PNG. If rules are loaded
before (as in the case of Echo) they get overriden. Make these rules
more specific so they do not apply.
Bug: T376491
Change-Id: Ia5399fa500df69b0a0d34931e30d961fe62a2124
