Jon Robson
480f84bc04
Define background-color-neutral in night mode palette
...
Bug: T357998
Change-Id: Iab5ec302274f65658885325e239329a1836cc8c3
2024-04-01 22:47:02 +08:00
jenkins-bot
53c5817b69
Merge "Apply history styles to watchlist"
2024-04-01 12:00:08 +00:00
Translation updater bot
3317211774
Localisation updates from https://translatewiki.net .
...
Change-Id: Ic893cfb5f61f7b649beb97354c23a3fae10a819d
2024-04-01 09:24:55 +02:00
Jon Robson
3ced132ce1
Define background-color-neutral-subtle in dark mode palette
...
Needed by categories
Bug: T357166
Change-Id: Iea31b59d00c0619567068a5ea5c440222d45ee3e
2024-04-01 09:17:11 +08:00
Fomafix
6f30044448
Replace WebRequest::getText and ::getVal by ::getRawVal or ::getCheck
...
The Unicode and line break normalizations are not needed here.
Change-Id: I4aebc32c938fde8e1b086325d18d72df66ca870f
2024-03-29 12:59:20 +00:00
Fomafix
effd4fe133
Use eslint rule "no-var": "error" and replace all var
...
Change-Id: I67acf88e1b8de55054248d7cf8ca622d5772ea6f
2024-03-29 07:40:22 +00:00
Fomafix
a73e2d2d19
Add eslint rule "max-len": "error" and fix long lines
...
Change-Id: I079f300eea18024a6e1698b5016778fa60c74578
2024-03-29 02:05:03 +00:00
jenkins-bot
90470423ac
Merge "Use alphabetic order for eslintrc rules"
2024-03-29 01:26:50 +00:00
Fomafix
05eb2ac47d
Integrate service 'Minerva.Menu.MainDirector' into SkinMinerva
...
The service 'Minerva.Menu.MainDirector' is bad because it depends
on the global state.
Change-Id: I170653006356932ecdd909b14c193f42c4a5f511
2024-03-28 17:33:18 +00:00
Fomafix
c50069252d
Integrate service 'Minerva.Menu.UserMenuDirector' into SkinMinerva
...
The service 'Minerva.Menu.UserMenuDirector' is bad because it depends
on the global state.
Change-Id: Ife13188745b39844356e7976379582d5f451f5a3
2024-03-28 17:32:42 +00:00
Fomafix
5027a28fc1
Definitions: Remove global state parameter from constructor
...
Move global state parameter to new method setContext.
Change-Id: I07833f60e2796396c3c35776bd7d788d93eb114b
2024-03-28 17:31:13 +00:00
Fomafix
0dbe920285
Remove unused service UserOptionsLookup from Definitions
...
Also use typed properties instead of @var types.
And rename $factory to $specialPageFactory.
Change-Id: I7fe5a8ad96e619019c1bbbb9143ad09174a9de5e
2024-03-28 17:30:45 +00:00
Fomafix
86fb2a8d18
Inject service 'Minerva.SkinUserPageHelper'
...
Change-Id: I91d8066ea860bd4aa5f19f4c326fad032be5b9d0
2024-03-28 17:30:01 +00:00
Fomafix
0adbe80280
Use service 'Minerva.SkinUserPageHelper' in SkinOptions
...
Change-Id: I014e61c6692adbbe449f1e6aa9c6ae73dbcff925
2024-03-28 17:27:45 +00:00
jenkins-bot
7ea5db0344
Merge "SkinUserPageHelper: Use alphabetical order of the parameters"
2024-03-28 17:27:19 +00:00
jenkins-bot
899ebe39f0
Merge "SkinUserPageHelper: Remove global state from constructor"
2024-03-28 17:12:41 +00:00
Fomafix
f8b8a83dc5
SkinUserPageHelper: Use alphabetical order of the parameters
...
Change-Id: I2bce7abfa2740ca7f3fb87968462cdc8eacbde7d
2024-03-28 15:20:36 +00:00
Fomafix
1c26798431
SkinUserPageHelper: Remove global state from constructor
...
* Move global state parameters to new methods setContext and setTitle.
This change solves the circular dependency error for service
'SkinUserPageHelper'. The service will used in SkinOptions in the
follow-up change I014e61c6692adbbe449f1e6aa9c6ae73dbcff925.
Change-Id: I80342e5168435c5318c378e2ac8a9a3c7a28eb4c
2024-03-28 13:10:48 +00:00
Translation updater bot
cdfec8a4bf
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib798c55650bbeba57a6d3670fb48bbab87f7569a
2024-03-28 08:35:06 +01:00
jenkins-bot
e46e0bbf6f
Merge "Inject service 'Minerva.LanguagesHelper' into SkinMinerva"
2024-03-28 02:31:21 +00:00
jenkins-bot
ca8dae0def
Merge "LanguagesHelper: Move $out from contructor to doesTitleHasLanguagesOrVariants"
2024-03-28 02:31:06 +00:00
jenkins-bot
045da4ce5b
Merge "Inject service 'Minerva.Permissions' into SkinMinerva"
2024-03-28 02:24:15 +00:00
jenkins-bot
4a0fac3227
Merge "Avoid setContext in ServiceWiring for Minerva.Permissions"
2024-03-28 02:24:13 +00:00
jenkins-bot
3bfc204f85
Merge "Inject service 'Minerva.SkinOptions' into SkinMinerva"
2024-03-28 02:20:24 +00:00
jenkins-bot
4713a127df
Merge "Improve variables"
2024-03-28 02:20:19 +00:00
jenkins-bot
2a233b1542
Merge "Remove styles in hacks.less that no longer apply"
2024-03-27 21:09:16 +00:00
Fomafix
dfa61af611
Use alphabetic order for eslintrc rules
...
Change-Id: Ic7afff052c004ba179a8814f79e7722fb66bdbbc
2024-03-27 19:54:21 +00:00
bwang
b8a6a9c1bd
Remove styles in hacks.less that no longer apply
...
Bug: T360387
Change-Id: I3eb7ec0c8a52a39cc97b60443cac0e6a5bba5482
2024-03-27 14:14:09 -05:00
jenkins-bot
8df385d08f
Merge "Minerva should use content-tables ResourceLoaderSkinModule feature"
2024-03-26 18:29:57 +00:00
Translation updater bot
7ffe913a64
Localisation updates from https://translatewiki.net .
...
Change-Id: I470441299ff1c0806270d3c68be6cfcab9f709d2
2024-03-26 08:23:31 +01:00
Fomafix
220bf6ff89
Inject service 'Minerva.LanguagesHelper' into SkinMinerva
...
Change-Id: Ie81195f31194bab819491576681b02660ec057b4
2024-03-25 22:36:07 +00:00
Fomafix
f68b218076
LanguagesHelper: Move $out from contructor to doesTitleHasLanguagesOrVariants
...
Services MUST NOT vary their behaviour on global state, especially not
WebRequest, RequestContext (T218555).
Change-Id: I4b73ef713166d8b254023c1eebbb45c963880a99
2024-03-25 22:34:37 +00:00
Fomafix
57d1f15d64
Inject service 'Minerva.Permissions' into SkinMinerva
...
Change-Id: Ie68691d7030ea622f2bc232fea2df49b70484e19
2024-03-25 21:44:13 +00:00
Fomafix
11c0e6966b
Avoid setContext in ServiceWiring for Minerva.Permissions
...
This change avoids a duplicate setContext in SkinMinerva.
Change-Id: I4b716a645bb2b6a5c05aa6e9a463640a2d87ab41
2024-03-25 21:43:50 +00:00
jenkins-bot
4963900d70
Merge "Update padding on <p> elements"
2024-03-25 19:36:20 +00:00
Jan Drewniak
cf723c00c3
Guard against undefined $container element in initMobile.js
...
In order to prevent spikes in JS errors, ensure that the $container
element exists before initializing the mobile media viewer.
Bug: T360781
Change-Id: I48a57e8008e7bd90e9fcfc783f3720f6f75520a7
2024-03-25 09:38:11 -04:00
Fomafix
999f04c366
Inject service 'Minerva.SkinOptions' into SkinMinerva
...
Change-Id: Ia7e7660c55e16731366bdf6332d5237188e9bbb1
2024-03-25 13:17:32 +00:00
Fomafix
1f3fc12bb4
Improve variables
...
* Remove unused private properties.
* Remove unused variable.
* Inline variable used only once.
Change-Id: I7fcab8328264384335371a152c3f3cd4548c4210
2024-03-25 13:09:17 +00:00
jenkins-bot
278b5189bd
Merge "Use Html::element instead of Html::rawElement and htmlspecialchars"
2024-03-25 12:50:29 +00:00
Fomafix
5d27b4ff3e
Use Html::element instead of Html::rawElement and htmlspecialchars
...
Remove the comment about the reason for output encoding. Output
encoding is standard and doesn't require an explanation.
Change-Id: Ia2df4c95dca8aedca70be2f3b3827498de1f2030
2024-03-25 09:32:30 +00:00
Translation updater bot
ed34320ea4
Localisation updates from https://translatewiki.net .
...
Change-Id: Ieac8e8fefa303febbbf60ca33cb9417cbf86a5e9
2024-03-25 08:39:06 +01:00
Jon Robson
32bf846613
Apply history styles to watchlist
...
The changes here only apply to the AMC-disabled mode
and only apply when visiting the watchlist with the
following configuraton:
$wgMFUseDesktopSpecialWatchlistPage = [ 'amc' => true, 'base' => true, ];
This change will allow us eventually to remove the special page
in MobileFrontend.
Bug: T109277
Change-Id: I15e95cbae77edde36ca822345a461d791ea5f29d
2024-03-22 14:10:07 -07:00
Translation updater bot
18d194b957
Localisation updates from https://translatewiki.net .
...
Change-Id: Idce4450d0566d4ba22f12bcf5bd75ef521c14637
2024-03-22 08:47:59 +01:00
Jon Robson
8f8fd6a1e4
Minerva should use content-tables ResourceLoaderSkinModule feature
...
The styles in Minerva are identical to the preset in core with the
own exception being padding. Therefore use the upstream styles
and retain only the override.
Bug: T357998
Depends-On: I206e91dac7e14d80a5ffc6b533255b54dafca29a
Change-Id: I3eb07a03b3b4e2a7544e5b07de6af9f67a1c965f
2024-03-21 22:49:14 +00:00
Jon Robson
c2623ed44f
Add soft dependency on Minerva to Vector
...
Bug: T359607
Change-Id: If293689999a54f067792d172441c7c47d0992ed9
2024-03-21 21:05:47 +00:00
Translation updater bot
02d5f9970e
Localisation updates from https://translatewiki.net .
...
Change-Id: I715446fc0a8051658a259ec8e63c063d89996ec7
2024-03-21 08:59:54 +01:00
jenkins-bot
978702f3be
Merge "Revert "The new class should be present alongside the old class for all page views""
2024-03-20 16:15:18 +00:00
Translation updater bot
a337b23c4b
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie22a6d41c35290109454c4d02bbeef4331f627cf
2024-03-20 08:26:12 +01:00
Jdlrobson
b6ffc85cd4
Revert "The new class should be present alongside the old class for all page views"
...
This reverts commit bca9223bb1
.
Reason for revert: This is now longer needed following the work
in Ia253de68f94236e7fe2219b736dd6084c64ce838.
Bug: T359983
Change-Id: Ibd3013169f26531a0cd879c143692e7030709808
2024-03-19 23:23:54 +00:00
Moh'd Khier Abualruz
5d6b866890
Rename the skin night mode classes to more readable classes
...
The classes:
- skin-night-mode-clientpref-0
- skin-night-mode-clientpref-1
- skin-night-mode-clientpref-2
is being replaced with
- skin-theme-clientpref-day
- skin-theme-clientpref-night
- skin-theme-clientpref-os
- Moved $forceNightMode to be a text parameter (dat|night|os)
- Keep adding the old classes to the html element, to give the ability of gradual deployment
The preference is renamed from minerva-night-mode to minerva-theme (a follow up to consider
migrating existing values will follow).
The query string minervanightmode continues to behave the same but now
accepts other values such as day, night and os.
Bug: T359983
Change-Id: Ia253de68f94236e7fe2219b736dd6084c64ce838
2024-03-19 23:12:59 +00:00