Commit graph

4467 commits

Author SHA1 Message Date
jenkins-bot 8927d37375 Merge "Remove custom styling from 'Add discussion' button" 2021-10-29 18:06:20 +00:00
Translation updater bot 08abf854f9 Localisation updates from https://translatewiki.net.
Change-Id: I03448cef0fbe80f273463cbd4fd0a6bc41378c1e
2021-10-29 08:24:01 +02:00
bwang 50a5253684 Remove whitespace from anon talk message warning
Bug: T284642
Change-Id: I65d03ffa5b3e8a7a855ba5adb3cc90e74c83ad96
2021-10-28 18:11:26 +00:00
Translation updater bot b3e110ff04 Localisation updates from https://translatewiki.net.
Change-Id: Iae79f60da348773f72fb54ecdc4d4a9faa30d245
2021-10-28 08:31:45 +02:00
jenkins-bot b4f947a625 Merge "Update anon talk messages to show on non-main namespaces" 2021-10-27 23:52:19 +00:00
bwang a2d065c062 Update anon talk messages to show on non-main namespaces
- Loads messageBox styles on non-main namespaces
- Add messageBox styles to 'skins.minerva.scripts' module for MobileFrontend's edit overlay page
- Prevent warning box from showing with empty message

Bug: T284642
Change-Id: I70d0d86671384210cc3ab43cb1d350ff2a862fd9
2021-10-27 21:29:42 +00:00
jenkins-bot 2ee31b0096 Merge "Refactor SkinMinerva::getSecondaryActions to match getPageActions()" 2021-10-26 22:49:16 +00:00
Ed Sanders bddfd1d232 Remove custom styling from 'Add discussion' button
These styles conflict with the new max-width on mw-ui-button so
don't behave as they were originally intended.

Bug: T294286
Change-Id: I9a55fb28d422ebf45ec84d399ae05be54a117df5
2021-10-26 23:33:01 +01:00
bwang 2be42b314f Refactor SkinMinerva::getSecondaryActions to match getPageActions()
Change-Id: Ia87fb08204be56e665cd97c57e6ac7df4cb1a02d
2021-10-26 22:24:04 +00:00
jenkins-bot ce6802b4b6 Merge "Restrict overlay button styles to non icon buttons" 2021-10-26 17:06:21 +00:00
jenkins-bot 36729aafd8 Merge "Add yellow talk page message warning to non-main namespace pages" 2021-10-26 16:39:38 +00:00
jenkins-bot 0ca31231fe Merge "Inline PageActionsMenu template" 2021-10-26 16:34:25 +00:00
bwang b4fd1498bc Add yellow talk page message warning to non-main namespace pages
Bug: T284642
Change-Id: I2895975efe1d09d228f80aff74381e88034a0137
2021-10-26 10:44:28 -05:00
Translation updater bot d2ad7f133a Localisation updates from https://translatewiki.net.
Change-Id: I6f2ff429530abdea0e3e2dd29f17466d1e6b274d
2021-10-26 08:20:16 +02:00
jdlrobson b41c7ca7be Inline PageActionsMenu template
Avoid usage of an additional TemplateParser

Bug: T293813
Change-Id: I1cef873d8a3226c9180a0731834f0ecf961f7ece
2021-10-25 16:02:08 -07:00
jenkins-bot 2a60efef79 Merge "Remove MinervaTemplate::getSecondaryActions" 2021-10-25 19:32:53 +00:00
Translation updater bot 6b3ec0458e Localisation updates from https://translatewiki.net.
Change-Id: I99eb2f1a43c98a1a6839e9a6a95706da1e7d73d0
2021-10-25 08:55:44 +02:00
bwang 95abf6b9af Remove MinervaTemplate::getSecondaryActions
Bug: T291875
Change-Id: Iefff2007c561adfd5886f9c0521341b3922e7653
2021-10-22 14:11:54 -05:00
bwang d1049e5407 Restrict overlay button styles to non icon buttons
Bug: T294146
Change-Id: I5f5568407dda5f3a021d64de9efc2bc7aeb5b458
2021-10-22 18:48:26 +00:00
jdlrobson 17968826fa Move components files up one level into Skins directory
Follow up to I4c2e115451c0a76c742734730712814c1f1d838d.
This will allow us to load the templates directly into skin.mustache
via {{>PartialName}}

Templates partials can only be resolved relative to the folder given
to the TemplateParser.

Change-Id: I5783d49c25d2efcf4781dd912500bf8b413b8cb6
2021-10-22 18:45:38 +00:00
jenkins-bot 9b5e07d647 Merge "Remove getPageActionsHtml and related methods" 2021-10-22 18:20:21 +00:00
jdlrobson c407d92d5d Remove getPageActionsHtml and related methods
Bug: T293813
Change-Id: I90e45cac13a13c2ce18af16274e327d951868433
2021-10-22 07:42:56 -07:00
Translation updater bot f33f413e57 Localisation updates from https://translatewiki.net.
Change-Id: Ia0450299f43c2f208e0fa896d69ea424efac34c1
2021-10-22 08:16:42 +02:00
jdlrobson 5a7a9c9c31 Drop wgMinervaPageActions
Remove code per spike outcome (T226490#7438685)

- This configuration option is never used in Wikimedia production
- isTalkAllowed content body is merged into isAllowed. Resulting code
is more readable.
- isAllowed('talk') still returns false on main page for anonymous users
which is the current behavior. Even on sv.m.wikipedia.org where talk pages
are shown to anonymous users, we do not show the talk page on the main page.
Add a comment pointing to the associated phabricator ticket

Bug: T226490
Change-Id: I9f34817c5ad654a6a66fe6156850a3e3fee881a7
2021-10-21 17:25:37 +00:00
Jdlrobson d138fa5cdb Merge "Restore title to mobile skin without logo" 2021-10-21 16:22:40 +00:00
jenkins-bot 818ded15a0 Merge "Move skins.minerva.content.styles into skins.minerva.base.styles" 2021-10-21 16:00:13 +00:00
jdlrobson 894364a3eb Restore title to mobile skin without logo
Bug: T290525
Change-Id: I6eb120a08d15b308d2a4df99900ab86042612b0c
2021-10-21 15:16:14 +00:00
Translation updater bot 6b952c3ffb Localisation updates from https://translatewiki.net.
Change-Id: I47845b84c3e7031171fb6f593154715466057748
2021-10-21 08:24:26 +02:00
Vadim Kovalenko adc4f899d8 Move skins.minerva.content.styles into skins.minerva.base.styles
Remove redundant skins.minerva.content.styles option

Bug: T266361
Change-Id: I8cb20024b648b4a266dd4af9623a896d16bf22da
2021-10-20 15:29:48 +00:00
Translation updater bot 2be89a1833 Localisation updates from https://translatewiki.net.
Change-Id: I1620e199b85412434cf35802adbe9d7a569d48ec
2021-10-20 08:40:08 +02:00
jenkins-bot 044e723ec1 Merge "Make missing links in tabs red like all other skins" 2021-10-19 19:13:05 +00:00
Inductiveload c4e5cbc9a7 Make missing links in tabs red like all other skins
It's extremely annoying to not know if the link you're about to click in
a Minerva tab is a link to an existing page or not.

So, make the new link red, as is customary in all other skins.

Bug: T236608
Change-Id: I3445f91fe0bcf1ddb305f8c350753e10c2dda0b0
2021-10-19 11:33:42 +01:00
bwang c1ea154af8 Generate Minerva search HTML with SkinMustache data
Bug: T290525
Change-Id: I68cde34a41a610872a585f5548dbaf66e3515443
2021-10-18 10:44:15 -05:00
Translation updater bot 6fe5e010a4 Localisation updates from https://translatewiki.net.
Change-Id: I797f54a6df891dfb7b876b3edae53c6fbf5d0752
2021-10-18 15:24:56 +02:00
jenkins-bot 04e5372713 Merge "Revert "Generate Minerva search HTML with SkinMustache data"" 2021-10-15 23:06:19 +00:00
Jdlrobson f9214f8ad5 Revert "Generate Minerva search HTML with SkinMustache data"
This reverts commit ecd35774b1.

Reason for revert: Logo has disappeared on beta cluster.
The Logo template was using data-logos, and
the addition of the data-search-box section broke this. Given its
a Friday, probably best to revert the patch and reapply again.

Change-Id: Id517d32b20b6512b9b2e1fffab012522dfd7b618
2021-10-15 22:43:07 +00:00
jdlrobson a7b66f6f63 Remove MinervaTemplate::getContentHtml
* Move method to SkinMinerva
* Turn preparePageContent into a getter that returns the subject
page
* Use getSubjectPage in template

For mobile special pages this now means the page has two .content elements
On those pages I've disabled the initial content element. It also means
various .content <heading> and .content ul  rules now apply that need to be
disabled.

While testing several other issues were taken care of - for example
the h2 in errors

Depends-On: I7761396d6a33830f279742be01240796573556a7
Bug: T291871
Change-Id: I13bc4b5dae7aed86eca31ef306212365e1759481
2021-10-15 20:49:23 +00:00
jenkins-bot 99008f90db Merge "Generate Minerva search HTML with SkinMustache data" 2021-10-15 16:33:23 +00:00
bwang ecd35774b1 Generate Minerva search HTML with SkinMustache data
Bug: T290525
Depends-on: I175ae29310a7432212a7b9c1c68dac9923665536
Change-Id: I53ea154b815a52e1e2e80a2e7b7114e310e74d47
2021-10-15 10:15:58 -05:00
jdlrobson 3a88911209 Remove whitespace to right of search input in overlay
Bug: T292107
Change-Id: I1143747600a1ffb25dcfe8600c5cd352afb25159
2021-10-12 16:26:53 +00:00
bwang 9a4caa7631 Use skin.json to define messages instead of MinervaTemplate
Bug: T290343
Change-Id: I8daef594ac9efb80f07437c5d8ef5459c37e2ff3
2021-10-12 15:30:58 +00:00
Alexander Vorwerk 702ec511dc MediaWikiTestCase -> MediaWikiIntegrationTestCase
MediaWikiTestCase has been renamed to MediaWikiIntegrationTestCase in 1.34.

Bug: T293043
Change-Id: I5b83516ccdf0ac025421844c9516e856060aefba
2021-10-12 00:53:10 +02:00
jenkins-bot 30e8b34702 Merge "Remove non-standard components folder" 2021-10-08 23:09:57 +00:00
Translation updater bot e16a49c111 Localisation updates from https://translatewiki.net.
Change-Id: I3feecb6df22f2ccd1a5d043801117440bd7c1e1e
2021-10-07 09:05:24 +02:00
jdlrobson d990f99b9e list-header styles should be specific enough to override h2 styles
Change-Id: I83e6992b0a63f456e1c2f7d17c87cbfc903d9c60
2021-10-06 23:56:37 +00:00
jdlrobson aba173efc6 Remove non-standard components folder
For skins, all templates should be in the same folder. This
is for security reasons, to limit access of templates to files
that are not templates. This also adds consistency with other skins
where templates are all in the same subdirectory. It also allows
us to reduce the creation of TemplateParser instances.

Note: All styles and scripts should be in the resources folder but this
is not rectified by this patchset. Will be done in follow ups following
more discussion.

This begins this work in the least disruptive way possible and drops
the README note to avoid this pattern growing.

Bug: T292558
Change-Id: I4c2e115451c0a76c742734730712814c1f1d838d
2021-10-06 20:13:48 +00:00
jenkins-bot 0583e92545 Merge "Rework the Minerva ToC" 2021-10-06 15:40:03 +00:00
Derk-Jan Hartman c0c9a82851 Rework the Minerva ToC
- reserve space for the icons
- break long urls in the ToC
- fix right margin on the ToC
- support without JS

Bug: T292338
Change-Id: Ic279047f297fa132b87b77b6d7127b797015f92a
2021-10-06 10:47:56 +00:00
Translation updater bot 1299cd93d5 Localisation updates from https://translatewiki.net.
Change-Id: I61836dc3bad629ee24354ad1a99473e108b56af1
2021-10-06 09:30:23 +02:00
Translation updater bot 8a71597ee0 Localisation updates from https://translatewiki.net.
Change-Id: I5d706f3a6ab19b688f34f20ffc00b83a0a1c2bfc
2021-10-05 08:31:28 +02:00