In ES5 you can override getters via prototype but not
with ES6.
Rather than patch MobileFrontend just for this use case
its easier to patch Minerva.
Bug: T380314
Change-Id: I69ccdb93287dc5e080a0d5a8faa9d208dc67779d
Delete the following deprecated modules:
skins.minerva.base.styles, skins.minerva.mainMenu.styles,
skins.minerva.icons.wikimedia and skins.minerva.mainMenu.icons
And reorganize files for skins.minerva.styles
Bug: T266361
Change-Id: I35b1d9461edd63a1a5d488a2fdc6939547fd29ad
Replacing error colors with amended design system values.
Note, that error icon color is slightly lighter than the error
text color.
Change-Id: Ia25a9accff2c8ed643252c2cc609b9bb63db4c47
An increasing number of browsers strip utm_ parameters from URLs,
making it impossible for us to tell where a donation comes from. We
are gradually migrating donate links to use wmf_ parameters instead.
Bug: T367361
Change-Id: I98c0b96b84250e94d62424a05ce2f0fea92fef22
"Deny from all" is deprecated; the replacement syntax has been
available since Apache 2.4 (originally released in 2012).
See <https://httpd.apache.org/docs/2.4/howto/access.html>.
Bug: T360850
Change-Id: I6b641c76f3229b70b07422295623deb5612b8030
Codex v1.16.0 added new tokens and styles, in particular CSS-only icons
for table sort and pagination and ~12 new tokens.
Bug: T379636
Change-Id: If0108af217294bafe356072c7b13da00b99619d8
This merges the existing modules skins.minerva.base.styles
and skins.minerva.mainMenu.styles into a new module
skins.minerva.styles which is named consistently with
Vector's style module.
The old modules will be kept for caching reasons
for at least one, and possibly two deploy cycles,
after which we will continue this task.
Additional change:
* drop .minerva-icon--{name}-base20 and .minerva-icon--{name}-disabled variants
since these are no longer utilized and only serve cached HTML
Bug: T266361
Change-Id: Iccf415a22e9535603befae25b8cea467f9905437
The existing code prevents a black square from appearing on late loading icons.
The problem with it is that if loaded late, it can override actual icon definitions
and make the icon invisible.
Since this typically applies in the case of icons loaded via JavaScript
this shouldn't be a problem on mobile web
Bug: T266361
Change-Id: Icee701761e9db69a6bffb7af4f608ec26c30f2be
The skins.minerva.messageBox.styles module is loaded on pages with
old revisions, but this message box is already being styled by another
module added by core.
Skins are not responsible for styling Codex. This is the responsibility
of the code that adds the message box to the page.
In addition to this we were loading another set of styles for message boxes
on skins.minerva.codex.styles
Bug: T375287
Change-Id: I0cf5dc6baf2e447b4944f04365addd614d59cfbe
Modules loaded with packageFiles are always executed in module scope
(with a closure), even in debug mode.
The behaviour of non-packageFiles debug mode is the only reason files
have closures.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Closure
Change-Id: I14ac680eb67d892618bbc13be9298ec9b8e0e2e9