Commit graph

1020 commits

Author SHA1 Message Date
jdlrobson 734ac36f1e Correct feature phone threshold detection
max-width should actually be one smaller than the threshold

Additional changes:
* Also rename to  @width-breakpoint-mobile and
rename @width-breakpoint-desktop for desktop variable in
anticipation of T171365

Bug: T176286
Change-Id: Ia37bceb46a6b780f473828ff38749543bdfcc9f6
2017-10-04 13:51:19 -07:00
jdlrobson 2e8ea6219f Update SVGs for page actions and restore locked edit icon behavior
The locked edit icon will now show on protected pages.

Additional changes:
* userpage and userNormal was not minified. This has been fixed.

Bug: T174105
Change-Id: I0ef9c4cf3ea6cd1c550023fdf99581b665b459b2
2017-09-29 13:20:39 +00:00
jenkins-bot 9bb62a254d Merge "Collapse amboxes in edit view" 2017-09-28 16:11:43 +00:00
jenkins-bot 67766539f9 Merge "EventLogging modules should be soft dependencies" 2017-09-27 21:09:49 +00:00
jdlrobson b19997a970 Collapse amboxes in edit view
In edit mode various amboxes are shown which push the editor area
below the fold.

We solved this problem already for "page issues" in normal page views
so we should apply the same solution here.

"Editing help" message will show under the heading. When clicked
information will show in an overlay.

Change-Id: Ia6e478f289267d22adc55532221cba2aae16ff36
2017-09-27 21:04:36 +00:00
Volker E bf6d1768bd Unify monospace font family stack
Additionally adding MinervaNeue specific variable.

Bug: T176636
Change-Id: I4450508be0b7836602f6fdea603ed5f4d9a0b16d
2017-09-27 20:52:55 +00:00
jdlrobson 0ee78ce0cb EventLogging modules should be soft dependencies
Change-Id: Ibc546a89b11360769c9c50dc52cb9b7b5e433100
2017-09-27 20:52:15 +00:00
jdlrobson 4084c7b5bb Only hide fmbox on editor interface
They also show up on pages that do not exist.
e.g. https://en.m.wikipedia.org/wiki/Teldenia_ruficostawww

Not showing this box provides a confusing experience - a blank
body.

Change-Id: I335a7804bd77df42a23bee569ce52afcfa59a6de
2017-09-26 08:40:46 -05:00
Volker E 5c8fe4c94d Unify box-sizing to LESS mixin
Change-Id: I3c308267e6754d681c26c3799084203fae0cdb42
2017-09-21 15:20:45 -07:00
Chad Horohoe 8a97059c6e Fix another SVG
Change-Id: I95d76339fa5dc8dcbb1472ad98ae8476c35fba1c
2017-09-14 13:24:04 -07:00
Chad Horohoe 0bf4aeb746 Fix userNormal.svg syntax
Change-Id: I350d2c2270fead706240fa0cd1cce17875a8ce0c
2017-09-13 10:19:59 -07:00
jdlrobson bf907afd46 Hygiene: Do not pass mainMenu to Skin
This wires the interaction between the skin and the main menu
into the initialisation script.

Change-Id: I4fac234cb9ead7e99dc52f72819cd4a3c715de1c
Depends-On: Ife64c87716a0f56b55a030a3e4224075af3c6d8c
2017-09-07 17:49:02 +00:00
jdlrobson 38474ed73f Hygiene: Cleanup initialisation files
* Remove deprecated module definitions
* Remove unnecessary check for Minerva skin (this is only
ever run by Minerva skin)
* Move overlayManager to place it is first used
* Make Skin::getMainMenu method redundant

Change-Id: I17ea52172e7fae0a8f0e06b8418c7ed5bb01ef64
2017-09-07 17:48:58 +00:00
jdlrobson c90e62b524 Improve hatnote styling
This improves the hatnote styling on pages such as Iran.

* Remove italics
* Color changes
* Padding changes

Bug: T173600
Change-Id: I50a49d5be3b7e21042dc0415371b3bc94c5ddcf3
2017-09-06 13:56:24 -04:00
jdlrobson 7261945bc6 Adjust language icon color
The hex code for the fill color was wrong resulting in it
appearing black.

Bug: T174747
Change-Id: I52fb30beae49cbb48d050f5c763c42dd6e484003
2017-09-01 11:33:34 -04:00
jdlrobson c323c6858a Hygiene: Merge skins.minerva.print.styles with skins.minerva.base.styles
We no longer need to keep this as a separate entry point now we do not
feature flag our print styles

Please enter the commit message for your changes. Lines starting

Change-Id: I6bf12980aa929e84f239931beb0a505809231830
2017-08-31 19:09:03 +00:00
jdlrobson 8ee37016ee Fix watchstar icon
xml tag was not correctly closed with "?>"

Bug: T174607
Change-Id: Iecab1a8789d5e762447cc8468723b96352738614
2017-08-31 13:15:26 -04:00
Fomafix 73a6b972dc chmod a-x resources/skins.minerva.content.styles/hacks.less
This is reverts the mode change from e89579d201.

Change-Id: I8f0c8b96147c94bf7a8e847196ba948362584639
2017-08-30 12:16:50 +02:00
jdlrobson 79fd8bd799 Hygiene: Remove FIXMEs now enough time has passed
Routine maintenance - all FIXME statements suggest these can
be removed. W00t!

Depends-On: Iee059a6605cf12a073954378f49ddc721a7e016a
Change-Id: I645dca1fa4d9e80d506e907b0be78a5aef0e2f12
2017-08-29 19:26:13 +00:00
jenkins-bot adcdbef9f0 Merge "Switch to @colorGray5 for wikitable borders" 2017-08-28 21:00:17 +00:00
jenkins-bot 4791acade7 Merge "Drop Android2 check for search" 2017-08-28 20:45:36 +00:00
jdlrobson de86a1fdd8 Switch to @colorGray5 for wikitable borders
Bug: T168029
Change-Id: I4507aae9f44538ec024ecc4c5d6219efc10be51e
2017-08-28 15:39:18 -05:00
jdlrobson 1dd2971124 Drop Android2 check for search
Android2 is a grade C browser so this code will never be run in
MediaWiki.

Change-Id: I184df4fbea3743d54b24e3782c4d1debf7ff9095
2017-08-28 15:32:00 -05:00
jenkins-bot d2a022e07b Merge "Logout icon should not be small" 2017-08-28 17:32:24 +00:00
jenkins-bot 7c1be417b0 Merge "Remove special page resource module handling" 2017-08-28 16:21:52 +00:00
jenkins-bot 0591987137 Merge "Align SVGs to color palette and optimize" 2017-08-28 15:01:50 +00:00
jdlrobson ac74369848 Logout icon should not be small
Bug: T170362
Change-Id: I04586cdc1ce1cfe17df8d87ecf4935f211b5f8dc
2017-08-28 09:56:02 -05:00
jenkins-bot a565347d2c Merge "fmboxes should be treated the same as ambox and tmboxes" 2017-08-28 14:50:46 +00:00
jenkins-bot 1207f53428 Merge "Fade table border color" 2017-08-28 14:50:45 +00:00
jdlrobson 32d6d1e7a0 fmboxes should be treated the same as ambox and tmboxes
Change-Id: Ieb5715c2bfd392e22c324c0098ccd29ebebaa440
2017-08-28 09:43:12 -05:00
Volker E a75c7fd257 Align SVGs to color palette and optimize
Aligning remaining SVGs to WikimediaUI color palette.
Also:
 - Aligning markup to each other, among others adding XML declaration
   throughout or removing unnecessary `standalone=no` attribute.
 - Optimizing with SVGO without prettified markup. Savings of up to
   17% of file size.

Bug: T146799
Bug: T172850
Change-Id: I54a21932fd5df64b7716ac66a90de5af73776c23
2017-08-25 12:55:37 -07:00
jenkins-bot d964902226 Merge "Hide last modified text in footer" 2017-08-25 15:53:33 +00:00
jdlrobson d59a65d133 Hide last modified text in footer
This repeats information in the last modified BAR

Bug: T173545
Change-Id: I75e07dfb08b12169cc4215995aa259b731ec2ad8
2017-08-25 15:42:48 +00:00
jdlrobson d2844d7a17 Do not try to enable toggling if using desktop Minerva
There is no lead section (as this is defined by MobileFormatter)
when toggling is not available.

This is defined even if there is no lead content.

Bug: T172948
Change-Id: I5999792296872ce62c399d003e7179153446700d
2017-08-25 10:32:04 -05:00
jdlrobson 5206d48ec5 Fade table border color
Bug: T168029
Change-Id: I6770c50675708f94cde6f8dee8164ba1a0ec612e
2017-08-24 13:31:56 -05:00
jdlrobson 231e68703b Caption should inherit background from table
Since we are fiddling with the default display of table's we need
to declare background of captions explicitly to avoid glitchy
behaviour.

Bug: T170344
Change-Id: I0797d346315c87861075f273baac5acf4e9998cb
2017-08-24 18:03:58 +00:00
Egbe Eugene e89579d201 using an LTR wiki in an RTL language aligns infobox labels incorrectly
When using an LTR wiki in an RTL language, Infobox labels are aligned to the
right, meanwhile they are to be left-aligned.

Added Hack to assign info boxes properly when using RTL languages on LTR wiki

Bug: T161399
Change-Id: I1defc994bf128815e3a2f19cda11c439ab2a6cce
2017-08-24 14:21:52 +00:00
jdlrobson f394cae753 Use mw-ui-icon-large and ResourceLoaderImage module for user page
Bug: T143264
Change-Id: I34b37c4c20f4d6612198096f83dbc509a795ae6d
2017-08-23 15:09:23 -05:00
jdlrobson 36d7092d82 Prepare for adoption of mw-ui-icon-large on user page
When I456714086d2548b2e10cceb2a05f7a0fadf94a3b is merged we will
be able to use an icon on the user page. Ensure the icon continues
to be centered in the screen.

Bug: T143264
Change-Id: I3acfb964a8ef8e7680b2f9d485b90302daeaca9d
2017-08-23 15:05:31 -05:00
jdlrobson ac7fcfc9e1 Disable wikitext editor on non-wikitext content models
Do not allow editing via JavaScript on non-wikitext content models
For these pages ?action=edit will be used

Bug: T173800
Change-Id: Ic62a0c1397ab8a6a59e5382c2999b63b3c60a19f
2017-08-22 17:02:58 +00:00
jdlrobson 61ba76efdb Remove special page resource module handling
This is handled by MobileFrontend now, just as it should do.
We rely on skinStyles where possible.

Depends-On: I665f6fe60939475249786fdc951149c38473fda6
Bug: T173597
Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 19:37:08 +00:00
Volker E f08b6defd7 Replace abandoned @colorGray13 with current WikimediaUI one
Replacing abandoned `@colorGray13` (`#ddd`) with
appropriate variable `colorGray12` (`#c8ccd1`) from WikimediaUI
color palette, which is used for borders elsewhere.

Bug: T146799
Bug: T172850
Change-Id: Id529d79901aab32d30e2b50820b59a84bd9b3693
2017-08-17 15:04:07 -07:00
Volker E 875d31b03b Hygiene: Remove unnecessary Less vars
Removing unnecessary Less vars, which are not in use any more.
Also slightly modifying code comment for better code style.

Change-Id: I6e2417561afb03225eaca99ea93135f975a51593
2017-08-16 18:13:09 +00:00
Baha 97b2ddfa11 Remove first heading padding
The page actions have been brought down to the next line for all screen sizes
in Ie9ba7df0a0f052948d46b6a9b14a3bbcef2b99fe. There's no need to reserve the
space now.

Bug: T171608
Change-Id: I24d54124049895eee38da8de553b7dc15976235a
2017-08-16 11:56:59 -04:00
Baha bea5dbde62 Don't float article actions on tablets
Bug: T171608
Change-Id: Ie9ba7df0a0f052948d46b6a9b14a3bbcef2b99fe
2017-08-14 12:43:34 -04:00
Volker E b3e0ce2bae Replace abandoned color with current WikimediaUI one
Replacing abandoned `@colorGray13` (`#ddd`) with
appropriate variable from WikimediaUI color palette and
remove unneeded `@chromeContentSeparator` var, which is
just used once and not in place with `.header` anyways.

Additional changes:
* Also aligning `border` values to each other.

Bug: T146799
Bug: T172850
Change-Id: Ia9a1736b1ea5fa080b4673038b2c23ddce90f135
2017-08-10 18:06:24 +00:00
Derk-Jan Hartman 56d16e894b Make sure that all buttons in the actions area have pointer
Also include a elements here, as a elements without href, as is used
in some places in Minerva, does not have a pointer by default.

Bug: T145493
Change-Id: I08d9176e55ec298c9d423d391b6fb4ed5e9df5e7
2017-08-10 09:32:04 -04:00
jenkins-bot 43e1a5f0a8 Merge "Disable magnify icon in Parsoid output" 2017-08-09 16:30:36 +00:00
jenkins-bot 615350518f Merge "Hygiene: The main page check is not necessary" 2017-08-08 14:27:38 +00:00
Volker E f4aaea0401 Replace @colorGray6 with appropriate WikimediaUI palette color
Replacing `@colorGray6` with appropriate closest color (semantic variable)
with slightly increased contrast.

Bug: T146799
Change-Id: I067973dca580eddc09b770362183d7a5b1634b7c
2017-08-08 11:29:30 +02:00
jdlrobson b478393e5e Hygiene: The main page check is not necessary
The main page in the Minerva skin is not editable so this code is
just cruft. T89559 no longer applies.

Change-Id: Ifcd30be0d4e328b056cc7fcfb714c9783b62c913
2017-08-03 15:58:18 -07:00
jdlrobson 7e7e532bfb Relax navbox hack
Per discussion in T172078 let's relax these rules so navbox shows
up in the desktop mode of the site.

Note: this will not impact the mobile site as navboxes are stripped
from the HTML.

Bug: T172078
Change-Id: I59d229d75dbcb790eb75dc4b838b2afafd2f3980
2017-08-02 15:14:59 +00:00
jenkins-bot 9a6770ee18 Merge "Use lead section when editing page without section marks" 2017-08-02 14:49:18 +00:00
jdlrobson a93cd66026 Style Parsoid generated references
Bug: T171727
Change-Id: I34838562360ec7d4fc55e1f3a7dad8a926e4da52
2017-08-02 14:43:36 +00:00
Baha 975d632d12 Use lead section when editing page without section marks
The config variable `MFNamespacesWithoutCollapsibleSections` controls
namespaces where section collapsing is disabled. In those namespaces
page is not divided into sections marked with `.mf-section-X` classes.
If that's the case the edit button edits the first section, which is
the whole page.

Bug: T157995
Change-Id: I3ec353575529c1fb11a33fc35c9886cf232e327f
2017-08-01 19:01:20 -04:00
jenkins-bot 8803101c52 Merge "Blank parsoid styles, update thumbnail selectors for Parsoid content" 2017-08-01 00:22:04 +00:00
jenkins-bot 9243513749 Merge "Show cursor:text when pointing over search input" 2017-07-31 21:36:54 +00:00
Baha 6f8b3d040c Make sure lead section exists before accessing its method
The `getLeadSectionElement` method of `Page` may return a `null`. Do
not try to access the `text` method of the returned object if it's
`null`.

Bug: T157995
Change-Id: Ia752fa52d1b09a307dc4b803a6b7e1bdcfe7f867
2017-07-31 15:21:06 -04:00
Piotr Miazga a0e390a9e5 Show cursor:text when pointing over search input
Changes:
 -  added styles pointer:text for #searchInput element

Bug: T161763
Change-Id: I39050a3e81c6b2e014f8955df188629a025ef2c1
2017-07-31 20:26:25 +02:00
jdlrobson a6a093faab Blank parsoid styles, update thumbnail selectors for Parsoid content
This brings Parsoid styles when viewed in Minerva consistent with
MediaWiki parser output styles.

You can verify this with:
https://gerrit.wikimedia.org/r/#/c/368287/

Bug: T171727
Change-Id: If4bd7671a99aefdf074061dd1d5b0bac93620e9e
2017-07-27 14:27:47 -07:00
jenkins-bot ed427dd427 Merge "Don't show ImageOverlay in desktop mode - delegate to multimedia viewer" 2017-07-27 15:30:57 +00:00
jdlrobson 9500297090 Don't show ImageOverlay in desktop mode - delegate to multimedia viewer
Bug: T169622
Change-Id: Ie34297a56f8571b161802ea8a708a8bed37c9173
2017-07-27 15:26:31 +00:00
Fomafix 13bdb53845 chmod a-x resources/*/*.{less,svg}
Change-Id: Ic4a2c91c8282a30ae069cc33deffada1df66ff22
2017-07-26 22:14:13 +00:00
Ed Sanders d2b10cc357 Disable magnify icon in Parsoid output
Bug: T160960
Depends-On: Id66f09c54103854ccbaa54a03e7c62890b67cba9
Change-Id: I40243fa6d85263967314b2b30dd1a7cbda39234d
2017-07-26 17:40:18 +00:00
jenkins-bot bd898e2be4 Merge "Minerva should use mediawiki.hlist" 2017-07-21 18:47:35 +00:00
jenkins-bot 27504d67c0 Merge "Add tooling for documentation" 2017-07-20 22:37:59 +00:00
jdlrobson efc84d2f25 Add tooling for documentation
* Add global View and Page
* Remove inheritdoc statements for globals - docs
  cannot be inherited from a class defined in another repo

Note:
you'll need to `gem install jsduck` for this to work

Bug: T170639
Change-Id: Idb3a6e9edbd45889047e7904561b84033569a689
2017-07-20 22:34:41 +00:00
jdlrobson 747b712509 Minerva should use mediawiki.hlist
Override provided styles

Bug: T42062
Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028
Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-07-19 13:52:09 -07:00
Umherirrender 211a54b568 Update and run existing stylelint
stylelint is part of config, but not run by default
Also update to 0.4.1, it is the current default in many wmf extensions

Change-Id: I55f81489182628c088e362e081417514e252e6d6
2017-07-19 20:31:24 +00:00
jdlrobson 2cc9516cde Minerva is its own skin
This is programmatic output from python3 scripts/migrate.py

This will result in a Minerva skin dependent on MobileFrontend.

Post merge we will rename message keys to have minerva- prefix

Bug: T166748
Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 08:12:40 -07:00