EventLogging modules should be soft dependencies

Change-Id: Ibc546a89b11360769c9c50dc52cb9b7b5e433100
This commit is contained in:
jdlrobson 2017-09-05 17:19:05 -04:00 committed by Jdlrobson
parent 064d08567e
commit 0ee78ce0cb
3 changed files with 15 additions and 10 deletions

View file

@ -168,14 +168,19 @@
* @method
*/
function logInit( editor ) {
mw.track( 'mf.schemaEdit', {
action: 'init',
type: 'section',
mechanism: initMechanism,
editor: editor,
editingSessionId: editorOptions.sessionId
// If MobileFrontend is not available this will not be possible so
// check first.
mw.loader.using( 'mobile.loggingSchemas.edit' ).done( function () {
mw.track( 'mf.schemaEdit', {
action: 'init',
type: 'section',
mechanism: initMechanism,
editor: editor,
editingSessionId: editorOptions.sessionId
} );
} );
}
/**
* Load source editor
* @private

View file

@ -36,6 +36,8 @@
* attributes on elements.
*/
enableLogging: function () {
// Load the EventLogging module inside MobileFrontend if available
mw.loader.using( 'mobile.loggingSchemas.mobileWebMainMenuClickTracking' );
this.$( 'a' ).on( 'click', function () {
var $link = $( this ),
eventName = $link.data( 'event-name' );

View file

@ -233,8 +233,7 @@
"dependencies": [
"skins.minerva.mainMenu.icons",
"skins.minerva.mainMenu.styles",
"mobile.startup",
"mobile.loggingSchemas.mobileWebMainMenuClickTracking"
"mobile.startup"
],
"position": "bottom",
"templates": {
@ -360,8 +359,7 @@
"mediawiki.ui.input",
"mobile.startup",
"skins.minerva.toggling",
"mediawiki.jqueryMsg",
"mobile.loggingSchemas.edit"
"mediawiki.jqueryMsg"
],
"messages": {
"0": "mobile-frontend-editor-disabled",