Commit graph

4254 commits

Author SHA1 Message Date
Jon Robson 72bcebeba8 Use upstream codex variables for diffs and red links
Bug: T361717
Bug: T363743
Change-Id: I4e49a07f9f092ab00e2b2d12fcb146c91a21d8d8
2024-06-12 10:16:59 -07:00
Volker E 6d037d4e9f styles: Apply inversion on certain OOUI icons and indicators
In order for most OOUI grayscale icons and indicators to be inverted
correctly, we need to apply the inversion to a limited number of
elements by a general class.
Applying here to keep OOUI library MediaWiki agnostic.

Bug: T365764
Depends-On: Ib183cd7c28ea3fb68a6614b38362325560b426f8
Change-Id: I437db61c34cdcce8d3602b1354fa4addc98530fd
2024-06-12 10:15:40 -07:00
jenkins-bot 91fd8a977b Merge "Improve Minerva drop-shadows in dark-mode" 2024-06-12 16:02:29 +00:00
Jan Drewniak 98eaa00cd5 Improve Minerva drop-shadows in dark-mode
Converts several drop-shadows to use standard Codex values:
- `.search-box .search` uses `@box-shadow-drop-small`
- `.drawer, .toast` uses `@box-shadow-drop-xx-large`
- `.toggle-list__list--drop-down` uses `@border-color-base`

Bug: T364425
Change-Id: Id00e525655d3a7138aa65f424fd6ab2ff82290c8
2024-06-12 04:05:30 +00:00
jenkins-bot 478d449cb2 Merge "(Almost) no more CSS variables in minerva" 2024-06-11 20:06:56 +00:00
Steph Toyofuku 6f98cc6460 (Almost) no more CSS variables in minerva
Remove direct usage of CSS variables in Minerva, and replace them with
codex design tokens again.  Document this decision in the original ADR

Note: there are still a small number of CSS variables in use, including
most notably the --color-link-red fix, which broke when I removed it,
but this change takes care of all the ones that could be easily replaced

Bug: T363743
Change-Id: I7d3a9dceb908167078987de1733774c8bd4bea2f
2024-06-11 11:44:47 -07:00
Translation updater bot 389518bb4f
Localisation updates from https://translatewiki.net.
Change-Id: Id91d2b2319413c209795d3a4644f448e6453a1ab
2024-06-11 09:58:14 +02:00
jenkins-bot fbd928018d Merge "Indicate support for new heading HTML" 2024-06-10 19:14:51 +00:00
Translation updater bot 8a25048d6c Localisation updates from https://translatewiki.net.
Change-Id: I6ea60897c2528673745ee3ceb065eeefaff9c949
2024-06-10 09:59:59 +02:00
jenkins-bot cc89a4e182 Merge "Migrate service 'Minerva.Menu.PageActionsDirector' into new class PageActions" 2024-06-08 16:20:04 +00:00
jenkins-bot 85eaf4de63 Merge "styles: Replace deprecated breakpoints" 2024-06-07 23:20:54 +00:00
Volker E dd154b4ea7 styles: Replace deprecated breakpoints
The values have slightly changed:
- Tablet breakpoint is decreased by 80px,
  pushing lesser devices into a mobile only experience but
  should make barely a difference to vast majority of our users.
- Biggest difference is in `min-width-breakpoint-desktop`,
  which is increased by 120px in comparison to
  `@width-breakpoint-desktop: 1000px`

Also removing one out-dated feature phone clause.

TECHNICAL CHANGES:
* The previous breakpoint was tied to the maximum content width.
The previous maximum content width is preserved, and several media
queries are adjusted to make use of it.
* The header (logo) is not optimized for  640px-720px. For now
a temporary fix is but in place which will be investigated as part
of T366859

VISUAL CHANGES:
* 6 visual changes which improve alignment in language and
visual editor overlay and diffs (where wikidiff2 is not
installed)

Bug: T349793
Depends-On: I3afba8c51f60de9271054499bfa3ffbcc1a9d779
Change-Id: I9552d8ad7509aae90e15edda26e786465773d3ac
2024-06-07 12:52:39 -07:00
Translation updater bot 499599cbdb Localisation updates from https://translatewiki.net.
Change-Id: Iefbb181b9940631a4188993c5afe37d154acc4b7
2024-06-07 09:49:37 +02:00
Jdlrobson c6209b906b Merge "Add skin-invert-image class" 2024-06-06 17:58:37 +00:00
bwang f99aaddd48 Add skin-invert-image class
Bug: T365102
Change-Id: I76a42a6a957223daf12d884169dad368dcca0300
2024-06-06 11:02:02 -05:00
Translation updater bot a08aa42327 Localisation updates from https://translatewiki.net.
Change-Id: Id0be5ee8eb8c9acf094cb2105b87322c94217a3a
2024-06-05 09:26:11 +02:00
jenkins-bot f5d03a0860 Merge "Skip getContext() and use methods from ContextSource" 2024-06-04 20:13:41 +00:00
Fomafix 4e4caef154 Migrate service 'Minerva.Menu.PageActionsDirector' into new class PageActions
The service 'Minerva.Menu.PageActionsDirector' is bad because it depends
on the global state.

Create a new service 'Minerva.Menu.PageActions' and inject this.

Change-Id: Ie84d02ef29d3b7809f490a1593cb2f3cef60b3a3
2024-06-04 20:10:41 +00:00
jenkins-bot 4eb77c4801 Merge "SkinUserPageHelper: Reset fetchedData on setTile" 2024-06-04 20:07:26 +00:00
Fomafix ad1fa7fbb7 SkinUserPageHelper: Reset fetchedData on setTile
This change restores the special toolbar behavior on user talk pages
lost in I80342e5168435c5318c378e2ac8a9a3c7a28eb4c.

Also add a test case that checks the cache on multiple setTitle calls.

Bug: T366645
Change-Id: Ifb481c546f2f77bd502cd9390d371a6e82bd5e69
2024-06-04 19:42:35 +00:00
Ed Sanders a6ab8d6da3 Prefer arrow callbacks (ESLint autofix)
Change-Id: I52b2feacd6216e99e04f193ba963e897b3e1a771
2024-06-04 08:01:54 -07:00
Translation updater bot 6013fc2639 Localisation updates from https://translatewiki.net.
Change-Id: Id98e451672d34d7d3f79d656160cdd5a901818d3
2024-06-04 09:34:46 +02:00
Bartosz Dziewoński 64fae83264 Indicate support for new heading HTML
Add `"supportsMwHeading": true` to the skin definition,
so that MediaWiki 1.43+ will output new heading markup
when using this skin.
https://www.mediawiki.org/wiki/Heading_HTML_changes

The required CSS changes were already made in commit
97aed1ad86.

Bug: T365736
Change-Id: I6f050ac65e131fa946754f6d6cfe42c77175cbb2
2024-06-03 15:20:01 +00:00
Ed Sanders 5732926921 ESLint: Enforce no-underscore-dangle
The rule is only broken once in reference to a MF class,
so just switch those to inline disables.

Change-Id: I96ebd7f034246da13788b8c8673bff203c18b2db
2024-06-03 12:59:48 +01:00
Ed Sanders a5c9a506c9 ESLint: Remove unnecessary config no-var:error
This is the upstream default.

Change-Id: I09797b9e9243707f0b2a7942d34d27b1271d9eb4
2024-06-03 12:56:30 +01:00
Translation updater bot 1c210fc0f3 Localisation updates from https://translatewiki.net.
Change-Id: Ia81ae54a1aa0a2fcc80502c742762a94146ece29
2024-06-03 09:37:09 +02:00
Fomafix 5f47deaef0 Skip getContext() and use methods from ContextSource
Change-Id: Idd4805e8f49a1b896b9be83c843b59d12136abb9
2024-06-01 14:54:25 +00:00
Fomafix 8acf6771d8 Use $featuresManager instead of $featureManager
This is consistent to the service name 'MobileFrontend.FeaturesManager'.

Change-Id: I31897c60ad2f85c62202efb80db855f96693aee6
2024-05-31 18:18:48 +00:00
Bartosz Dziewoński 5b48e1665a Allow collapsible content in Minerva
Too many projects including notably English Wikipedia are now
enabling this code via gadget, which will make addressing this
problem more difficult in future, by providing an unpredictable
development/testing environment
it would be better if this reflected production, even with the fat
finger problem.

Bug: T323639
Bug: T111565
Change-Id: I81aa514a211710d0eec45329e3e3c7ee331da6ea
2024-05-30 12:49:14 -07:00
Translation updater bot 10eb430c6c Localisation updates from https://translatewiki.net.
Change-Id: I41f24c8c7d140aa703866fd7b8905d46ea253007
2024-05-30 09:39:14 +02:00
jenkins-bot e613fbf0b5 Merge "Fix color contrast on toast/drawers" 2024-05-29 23:06:21 +00:00
jenkins-bot c3db2589df Merge "Night mode: Reflect production settings" 2024-05-29 20:44:42 +00:00
Jon Robson 5846ff838c Night mode: Reflect production settings
In production, night mode is available to all AMC users. Update
default development configuration to match this (I just wasted
ten minutes wondering why night mode wasn't showing up locally
and don't wish the same on anyone else :-))

Change-Id: Ic7cd55fbe2566b083bd4ba3dd0983f88646aca6c
2024-05-29 12:53:45 -07:00
Translation updater bot ab77655a56 Localisation updates from https://translatewiki.net.
Change-Id: I5fcda991f6ec8ca8b18e4acc97db3f14564b51c4
2024-05-29 09:34:36 +02:00
bwang 179d48d4f8 Fix color contrast on toast/drawers
Bug: T364117
Change-Id: Ibdb5cd49f8d4fcd1f69bc1209789a936ba8067ec
2024-05-29 05:46:46 +00:00
jenkins-bot 6ff97b564c Merge "fix(minerva): Fix notification & menu shadows in night mode" 2024-05-28 13:39:39 +00:00
jenkins-bot 7ea9638f81 Merge "SECURITY: Prevent JavaScript injections by messages" 2024-05-28 13:22:05 +00:00
Translation updater bot 127d08104f Localisation updates from https://translatewiki.net.
Change-Id: I460c9b47492c1fbb04bf8963dd20a446b0d78b95
2024-05-28 09:33:23 +02:00
Translation updater bot 93ccb7c0d8 Localisation updates from https://translatewiki.net.
Change-Id: I339a0f76acf6002baa3cf812fdfe106e855448f6
2024-05-27 09:32:27 +02:00
Fomafix a16f637fdc SECURITY: Prevent JavaScript injections by messages
This change prevents the possibility to inject JavaScript by
skin-minerva-night-mode-launch messages introduced by change
I3cfa9517a387df636534a3940e09289e4d7a1e5b.

Change-Id: Ib43bcff1413e6b70cedb7db4fa2c68148c4f13f5
2024-05-25 10:48:43 +00:00
jenkins-bot 9be0279689 Merge "Update namespace of PHP classes" 2024-05-25 00:23:21 +00:00
jenkins-bot c3d07acc78 Merge "Remove margin reset on <pre> tags" 2024-05-24 22:11:57 +00:00
Moh'd Khier Abualruz 1cf4a9866d fix(minerva): Fix notification & menu shadows in night mode
Updates shadow colours to respect user's night mode preference by
using standardized design token.

Bug: T364425
Change-Id: Iebf756c7c9adfdf79d7fee203ee6f02168a636f7
2024-05-24 20:28:42 +00:00
jenkins-bot 565f89e376 Merge "Create dark-mode launch banner component" 2024-05-24 20:22:56 +00:00
Jan Drewniak 903fbda3b0 Create dark-mode launch banner component
Creates a launch banner component for dark-mode
using the CSS-only Codex Dialog component.

This banner is currently not loaded on any page,
but can be invoked using mw.loader:

    mw.loader.using( 'skins.minerva.DarkModeLaunchBanner', r => r( 'skins.minerva.DarkModeLaunchBanner')() );

Bug: T361047
Change-Id: I3cfa9517a387df636534a3940e09289e4d7a1e5b
2024-05-24 14:56:49 -04:00
Translation updater bot 6f9af185c8 Localisation updates from https://translatewiki.net.
Change-Id: I19719bf05d58e7f62954608a6c55785646eacc81
2024-05-24 09:47:15 +02:00
Translation updater bot 3daebc4d8e Localisation updates from https://translatewiki.net.
Change-Id: I1ac75116c76422032fc3ca0ef13d7f329b149f8e
2024-05-23 09:30:42 +02:00
Fomafix 342beaeb18 Update namespace of PHP classes
Change-Id: Ia8a8d643a8e96372ecc7e481c0e3d50a31ccd4e8
2024-05-21 15:08:47 +00:00
Translation updater bot ada7c229d8 Localisation updates from https://translatewiki.net.
Change-Id: Idabe9b1331e9bbd07d1cf816535bc5f922b35c95
2024-05-21 09:30:34 +02:00
Translation updater bot 4eaa83afd8 Localisation updates from https://translatewiki.net.
Change-Id: I3d9aaac4ec6683a838b17c3bb923b5a362578921
2024-05-20 09:28:41 +02:00