Commit graph

725 commits

Author SHA1 Message Date
Translation updater bot 4192d67439 Localisation updates from https://translatewiki.net.
Change-Id: I9d18ee344957313171eaa95979d33f93cfde6c07
2018-07-18 21:59:26 +02:00
jenkins-bot 35f2fc515f Merge "Replace foundationwiki url" 2018-07-18 07:30:33 +00:00
Reedy 7db16b308d Replace foundationwiki url
Bug: T199812
Change-Id: Iec87e90ed3dd058a2b06b87278793dab5c16c0c9
2018-07-17 20:39:19 +00:00
Translation updater bot b515ad47bf Localisation updates from https://translatewiki.net.
Change-Id: I45dea2a0bb23f02c4593b12334fa9f90a8132a83
2018-07-17 22:00:38 +02:00
jdlrobson 99bc9d8c55 Enforce lowercase jsdoc types
Follow up to I6cbac15940e4501aee7ede8f421b77ffd027170d

Change-Id: I22bcbf1f083451a0f68b692b9a0acc716d11c62c
2018-07-17 08:06:35 -05:00
Translation updater bot cedaa3a22c Localisation updates from https://translatewiki.net.
Change-Id: I306c71e24f5c6e7478b6efcbfff969847e01a8e6
2018-07-16 22:02:44 +02:00
Translation updater bot bd0f0ce540 Localisation updates from https://translatewiki.net.
Change-Id: I7ebf8a185e0cf45ce9dffa338a573e67362b0bcc
2018-07-15 21:57:29 +02:00
Translation updater bot 4dc9b28a92 Localisation updates from https://translatewiki.net.
Change-Id: Id5856e553bcab65320d781e16b26025a265959f0
2018-07-14 22:03:16 +02:00
Translation updater bot b5bc3b00e1 Localisation updates from https://translatewiki.net.
Change-Id: Ieca26e38116fe59cbb3bb280abb33c004da69047
2018-07-13 22:04:23 +02:00
jenkins-bot 6c981fa4f8 Merge "Section issues overlay has different heading" 2018-07-13 12:46:20 +00:00
jdlrobson dfc29032b5 Section issues overlay has different heading
Per https://phabricator.wikimedia.org/T197932#4417319
Note that given talk/category overlay does not use or
display section issues, to simplify things any section other
than 0 or all will use this heading.

Bug: T197932
Change-Id: I737fb07aaadcea7772d0b08f8b0652dcf2f4623d
2018-07-12 15:07:22 -07:00
Translation updater bot ecc0edd718 Localisation updates from https://translatewiki.net.
Change-Id: I5bf368993b7610b356d70e989ea953117395da4e
2018-07-12 22:19:27 +02:00
Stephen Niedzielski 10024b641e Hygiene: fix DownloadIcon function typing
Change-Id: I421332acae4ace9d0bb7cfcd4b31d9f4581c3e34
2018-07-11 13:39:55 -05:00
jenkins-bot d2b1771f13 Merge "Tie issues to sections" 2018-07-11 17:33:37 +00:00
jdlrobson 596e405807 Tie issues to sections
Parse all issues inside a page, and load them into the issues overlay.

In group A, given issues inside later sections are hidden, it will not be possible
to navigate to these new overlay screens. In group A, lead section issues will continue
to only show lead section issues.

Changes:
* The /issues route is replaced by the more specific /issues/all and
/issues/{section num}, issues are stored in an "allIssues" module object.
* Begin using constants for namespaces for better readability
* Drop width 100% - this breaks display on tablet devices of issues within
sections
* Improve createBanner documentation to explain different treatments
* Set the issues overlay header inside initPageIssues when setting up
the route.

Bug: T197932
Change-Id: I21470648a61d57cfa4befceec596cf0f6e2110ec
2018-07-11 09:47:46 -07:00
jenkins-bot e3a5513d5a Merge "Reduce render blocking styles by deferring loading of icons" 2018-07-11 16:31:15 +00:00
jdlrobson 3d0587c63d Reduce render blocking styles by deferring loading of icons
Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28
Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c
Bug: T198930
2018-07-11 09:07:10 -07:00
jenkins-bot d5ae991522 Merge "Hygiene: update JSDoc boxed and JQuery types" 2018-07-10 23:00:40 +00:00
jenkins-bot 61bc884204 Merge "Talk page 'issues' are not subject to A/B test" 2018-07-10 22:57:29 +00:00
jenkins-bot 32b15522b1 Merge "Remove unnecessary MinervaResourceLoaderParsedMessageModule" 2018-07-10 17:44:41 +00:00
jenkins-bot c5fff1f0b7 Merge "Remove incorrect code comment" 2018-07-10 01:00:03 +00:00
Bartosz Dziewoński 10fa5f0c55 Remove unnecessary MinervaResourceLoaderParsedMessageModule
All of the uses are unnecessary or harmful:

* 'skins.minerva.toggling'
  This module has no messages, parsed or otherwise.

* 'skins.minerva.editor'
  * 'mobile-frontend-editor-redlink-explain'
    This message has no formatting to be parsed. In the past, it
    included the '{{SITENAME}}' magic word, which is still present
    in some translations, but it is supported by the client-side
    jqueryMsg parser anyway.

  * 'mobile-frontend-editor-blocked-info-loggedin'
    This message only uses '{{GENDER}}', which is supported by
    the client-side jqueryMsg parser. More importantly, it uses
    a parameter for it, which is actually not supported by
    MinervaResourceLoaderParsedMessageModule. The message would
    always use the default gender, regardless of the parameter.

Change-Id: I0c597febf9051670228dd144b53521a121f3a220
2018-07-10 02:29:33 +02:00
Bartosz Dziewoński a2dcc8124f Remove incorrect code comment
This was copy-pasted from the function above and it is not true here.

Change-Id: I0513d46789405ea2e6d1cdb619cc548ab8e9ef2b
2018-07-10 01:24:30 +02:00
jenkins-bot 80b41c0170 Merge "Hygiene: Document why selectors are needed" 2018-07-09 22:07:08 +00:00
jdlrobson 20e3bbd28f Don't render blank issues
If an extracted issue has no text, do not render it

Bug: T199005
Change-Id: I18047492e891285ed3af113200d2909e178b8224
2018-07-09 21:33:13 +00:00
jdlrobson 34e1a80318 Talk page 'issues' are not subject to A/B test
Bug: T199005
Change-Id: Ib5f60fc5c2157d0b10e39209f5ce4ff56d745eee
2018-07-09 14:24:29 -07:00
Translation updater bot 7032d4ff2f Localisation updates from https://translatewiki.net.
Change-Id: Ief009e2b33c941d4706e6c6bae5d2809adb0e0bd
2018-07-09 21:54:47 +02:00
Translation updater bot b575ab2b33 Localisation updates from https://translatewiki.net.
Change-Id: I65894efb7a8c31930e0bb64314a70747e8e6032d
2018-07-07 22:32:11 +02:00
Translation updater bot 8456be7a41 Localisation updates from https://translatewiki.net.
Change-Id: Id3a97ac312f190c7dc094569be0b9c68e5daf8b1
2018-07-06 22:20:25 +02:00
jdlrobson 795c0abf06 Hygiene: Document why selectors are needed
This rule has a lot of selectors (note the fix me)
It's not clear what each of them are needed for so make that
clearer in the code.

Change-Id: I80f07118977f465b7d09efad28f94917dd962a3d
2018-07-05 23:54:52 +00:00
Translation updater bot 2c98ed3def Localisation updates from https://translatewiki.net.
Change-Id: I4fcc54bd3d95e1021fb68bceb71898a80cecce80
2018-07-05 21:57:31 +02:00
jenkins-bot 48e6e4c6ac Merge "Links should not be clickable in mobile page issue element" 2018-07-05 18:26:02 +00:00
jdlrobson a8ed9380ea Do not restrict images to 320px at tablet resolution
Instead max them to the threshold.
Note restricting them is a problem on pages
like en:Ulaanbaatar - in particular the panoramas
inside the "Urga and the Kyakhta trade" section

Change-Id: I28636c62d3545632d3b025b29d154136a81d8218
2018-07-05 18:05:07 +00:00
Translation updater bot 28a5c3bc35 Localisation updates from https://translatewiki.net.
Change-Id: I46252e43b13faa64eac81fcb40bd3edcf7b694f6
2018-07-04 21:54:35 +02:00
Stephen Niedzielski 56dabf0af3 Links should not be clickable in mobile page issue element
Bug: T198115
Change-Id: I18c393d5676084e0be3ba12fa267765593368615
2018-07-04 13:43:11 -05:00
Stephen Niedzielski 874d9c9e3b Hygiene: update JSDoc boxed and JQuery types
From TypeScript's do's and don'ts:[0]

  Don’t ever use the types Number, String, Boolean, or Object. These
  types refer to non-primitive boxed objects that are almost never used
  appropriately in JavaScript code.

Although Minerva only uses JSDocs at this time which seemingly doesn't
care about casing[1], we should endeavor to use the proper return types.

This patch lowercases typing to indicate primitive / boxed type as
appropriate.[2] As a special case, function types are uppercased for
compatibility with TypeScript type checking.

Also, JQuery types are of type "JQuery". The global JQuery object's
identifier is "jQuery". This patch uppercases J's where appropriate.

Lastly, replace unsupported type "Integer" with "number" and a comment.

[0] https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html#general-types

[1] https://github.com/jsdoc3/jsdoc/issues/1046#issuecomment-126477791

[2] find resources tests -iname \*.js|
    xargs -rd\\n sed -ri '
      s%\{\s*(number|string|boolean|object|null|undefined)%{\L\1%gi;
      s%\{\s*function%{Function%g;
      s%\{\s*jquery%{JQuery%gi;
      s%\{\s*integer\s*\}%{number} An integer.%gi
    '

Change-Id: I6cbac15940e4501aee7ede8f421b77ffd027170d
2018-07-03 11:10:12 -05:00
Translation updater bot 65a1344997 Localisation updates from https://translatewiki.net.
Change-Id: Ia4ff66994e1b1092e0039c50120a89660747b5b2
2018-07-02 21:56:05 +02:00
Translation updater bot fa20b69393 Localisation updates from https://translatewiki.net.
Change-Id: I645eb908f7fa72e9da668369bdf9426887c18092
2018-06-30 22:06:13 +02:00
Translation updater bot dc60ea26b8 Localisation updates from https://translatewiki.net.
Change-Id: I0bc5432acf13b640df7e22351b486d2d30adb654
2018-06-29 22:03:15 +02:00
Stephen Niedzielski fde1c1084c Doc: move config type and defaults near identity
The readme describes all of Minerva's configs and includes a type and
what the default value is at the end of each section. Since the
descriptions for some configs is lengthy, moving the type and default
next to each config's name gives a consistent location for the
information and allows for quick look up without parsing.

Change-Id: I1583c11c80d9b775d93f59302eb2666b754fb412
2018-06-29 17:55:14 +00:00
Stephen Niedzielski 4bf2156a2e Doc: add debug tips for AB testing
Change-Id: I46eff8ebf5ea10a14b9a203fc5dbe7e37d0f25a1
2018-06-29 17:55:03 +00:00
jenkins-bot f1a1edcd27 Merge "Fix: add login icon as a server render dependency of main menu" 2018-06-29 01:58:08 +00:00
Stephen Niedzielski b60fab3331 Fix: add login icon as a server render dependency of main menu
The profile icon is necessary for logged in users. This is known when
parsing skin.json but was not added in MinervaHooks.php. This patch adds
the dependency unconditionally although it is only needed for the server
render of Special:MobileMenu for logged in users.

Bug: T196893
Change-Id: I2a8485299162c01d28ca1b07e7071ad0c0ef44fc
2018-06-29 00:24:36 +00:00
Jan Drewniak c10c3f011e Increasing specificity of '.center' class
Bug: T193595
Change-Id: Id365952881118bc3587fe8a0c897892e61f41df1
2018-06-28 22:21:05 +02:00
Translation updater bot 66d88028ad Localisation updates from https://translatewiki.net.
Change-Id: I1f9dca74d880e2f5211faf384cde96d6cfe1ffa6
2018-06-28 22:00:51 +02:00
jdlrobson 9164b9154f External link icons should use defaultColor
Depends-On: I0745e112d11026ed59d8daca990b313305cd094a
Bug: T197909
Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-27 21:21:19 +00:00
Translation updater bot ff3ecc6c78 Localisation updates from https://translatewiki.net.
Change-Id: I0b30fd34bd3e6ca8b7c2af221aca24afda789d33
2018-06-27 21:55:08 +02:00
jenkins-bot a64bc6b878 Merge "Allow non-js users to remember login on grade C browsers" 2018-06-26 14:21:38 +00:00
Translation updater bot cfac90453d Localisation updates from https://translatewiki.net.
Change-Id: I2fe032b99048260883616fa8aed1d279db7ca90d
2018-06-25 22:07:07 +02:00
Translation updater bot a6fb499d48 Localisation updates from https://translatewiki.net.
Change-Id: Ib76d5088788b6c54e4363d29ba3addbfa6953694
2018-06-24 22:09:43 +02:00