Commit graph

4395 commits

Author SHA1 Message Date
bwang 3d74f38a51 Scope codex link styles to footer and content body, remove cached CSS
Depends-on: I22e9c0d67b69ed37310c47db55bedb67f51efc90
Bug: T375832
Change-Id: I6e9e29fd5b140ae8eb4e6b011d558ea778c92028
2024-09-27 16:03:36 -05:00
jenkins-bot 91ca28e801 Merge "Bottom margin not applying to Parsoid H2s" 2024-09-27 17:43:09 +00:00
Jon Robson e03ddb1322 Cleanup: Delete unreferenced file
This got moved to WikimediaMessages and is not being referenced
anywhere.

Bug: T375802
Change-Id: Ib1cace604a9e764f50de746b144e9a8bb5bcf2b2
2024-09-27 08:57:35 -07:00
Jon Robson cef7b1f7bb Bottom margin not applying to Parsoid H2s
Bug: T375822
Change-Id: I99ce2b7640d738457495b57a16cbbbf082066217
2024-09-27 15:48:05 +00:00
Translation updater bot bca4fa9c6c
Localisation updates from https://translatewiki.net.
Change-Id: I94162909a854498696109227ad80b06abd3c80e1
2024-09-27 09:21:57 +02:00
Jon Robson 6bd291c9f4 Fixes last modified colors
Bug: T367892
Bug: T375586
Change-Id: I55a4f17cd3fe9ab9f1a81a28a88edc12eca01ce9
2024-09-26 16:28:52 +00:00
Translation updater bot 7e8c1bff58
Localisation updates from https://translatewiki.net.
Change-Id: Ie63b5ddde2e72b58e3f7e1d70d39326a5e11ad3b
2024-09-26 09:22:03 +02:00
Translation updater bot 348c16d091
Localisation updates from https://translatewiki.net.
Change-Id: Icd76b5fccddd2e267df32bd7cbc0483211ace652
2024-09-25 09:20:27 +02:00
jenkins-bot a6f7817ad0 Merge "Remove @font-size-base" 2024-09-24 23:33:20 +00:00
Translation updater bot 7e2a3b26ea
Localisation updates from https://translatewiki.net.
Change-Id: I3bc9168734142c147f9a007683c373e6008cf9ae
2024-09-24 09:32:45 +02:00
bwang 96580c6a63 Remove @font-size-base
Bug: T367899
Change-Id: I0e48721397c9759c269eb27081b427e942b43422
2024-09-23 14:33:18 -05:00
Translation updater bot 05ab14fd33
Localisation updates from https://translatewiki.net.
Change-Id: Ia600dafa09a9a6967a5838aebee1685ca9056259
2024-09-23 09:24:57 +02:00
Jon Robson 5900ab2c28 Fixes styles of Minerva tabs in visited/active states
Follow up to Iefa1fee9c6ac0326bc43844205dd3f5dc53fc903

Bug: T367892
Change-Id: I832e5a0b8d1febf38d574098e110bac901528b6e
2024-09-19 20:21:40 +00:00
Jon Robson e23c1ae9b6 Use codex link mixin inside Minerva
VISUAL CHANGE:
1 change relating to link color inside ambox

Bug: T367892
Change-Id: Iefa1fee9c6ac0326bc43844205dd3f5dc53fc903
2024-09-18 00:31:48 +00:00
jenkins-bot 5633960a38 Merge "feat: additional test coverage for Minerva 'TOOLBOX'" 2024-09-17 08:37:53 +00:00
Translation updater bot 0947d8ed25
Localisation updates from https://translatewiki.net.
Change-Id: I9f6dde206e772a398c8b5a51171fad1054deb8bb
2024-09-17 09:32:13 +02:00
Sean Leong (WMDE) 92a0197c9f feat: additional test coverage for Minerva 'TOOLBOX'
Bug: T66315

Change-Id: I03cb66a55fddcbae31e6f59f268ccfa7a31318ef
2024-09-16 10:48:15 +00:00
Translation updater bot 52a6a1a147
Localisation updates from https://translatewiki.net.
Change-Id: Ie3a7e0f9b1b2e32ea0932ad3eae6023a27b7c7ef
2024-09-16 09:31:47 +02:00
Translation updater bot 875a2e57dc
Localisation updates from https://translatewiki.net.
Change-Id: I0e2ae16f94489cb0f818d5899c497c2206d8a9b6
2024-09-13 09:20:29 +02:00
jenkins-bot 34c836c2f8 Merge "Fix missing wikibase link in Minerva sidebar" 2024-09-12 13:16:23 +00:00
Translation updater bot 7ae4b9df68
Localisation updates from https://translatewiki.net.
Change-Id: I8c3d14661ba3491acf0d54a6bc3e1051fd3e2076
2024-09-12 09:19:43 +02:00
jenkins-bot 7cdfee24b8 Merge "Fix alignment(Minerva):current marker was not aligned with message" 2024-09-10 22:48:31 +00:00
Abhii67534 9a2ee050ed Fix alignment(Minerva):current marker was not aligned with message
Bug: T372392
Change-Id: I6c00e78fec0dada22134a72ca8e0b6f50764bd13
2024-09-10 22:16:21 +00:00
joelyrookewmde 0585dea9f9 Fix missing wikibase link in Minerva sidebar
Bug: T66315
Change-Id: I01b5fa5be48d3521d57267084b420dcdcbba92f9
2024-09-10 16:21:45 +02:00
Translation updater bot 0cbac1b6d6
Localisation updates from https://translatewiki.net.
Change-Id: I1ea323cd4a1b3ac86453ccbfaac4868ce906ca42
2024-09-10 09:33:34 +02:00
Translation updater bot c02a6c8380
Localisation updates from https://translatewiki.net.
Change-Id: I8b4f324eac5343cec5f64cf0c187df0a2ebfd040
2024-09-09 09:25:14 +02:00
Jon Robson e89aab6b43 Cleanup: Remove dark mode banner code
this is not being utilized any more, tested or maintained so should
be removed.

Change-Id: Ib51bc5cb829f25b8a2ab864f7b9266578a4b1232
2024-09-06 09:31:03 -07:00
jenkins-bot 8c35813ba3 Merge "Revert "Fix missing wikibase link in Minerva sidebar"" 2024-09-05 15:19:57 +00:00
Joely Rooke WMDE 783ccd21df Revert "Fix missing wikibase link in Minerva sidebar"
This reverts commit e1b61ec3c5.

Reason for revert: On wmf.21 that caused: PHP Notice: Undefined index: id

Change-Id: I048d1fd3f192cf306839d71f189bd02f9c8e1ca9
2024-09-05 14:48:46 +00:00
jenkins-bot be2a7378a6 Merge "Fix missing wikibase link in Minerva sidebar" 2024-09-05 08:20:04 +00:00
Translation updater bot 3a231e1333
Localisation updates from https://translatewiki.net.
Change-Id: Ifcc1c39378289e885cd8104645ed71750c134e6c
2024-09-05 09:27:24 +02:00
jenkins-bot e4594a1b32 Merge "Fix eslint warnings in Selenium JavaScript code" 2024-09-05 01:38:35 +00:00
joelyrookewmde e1b61ec3c5 Fix missing wikibase link in Minerva sidebar
Bug: T66315
Change-Id: I51c394193ea37ade37c662edd69ac0df4171c1d9
2024-09-04 15:15:02 +02:00
Fomafix 93945857b8 Fix eslint warnings in Selenium JavaScript code
Change-Id: I02d2114e668d1ea9d2a28d2823dc6f9bfa032b8a
2024-09-04 08:33:13 +00:00
Translation updater bot 8e583b8880
Localisation updates from https://translatewiki.net.
Change-Id: Ic15f20a862e799cb70d465cd74e3743244de4d8e
2024-09-04 09:18:32 +02:00
Jon Robson 1d966ce00b Restore heading margin for Parsoid content
Bug: T373646
Change-Id: I3d20456695229cb203e6d1a125587f367fffe696
2024-09-03 20:48:25 +00:00
Translation updater bot a0021226ac
Localisation updates from https://translatewiki.net.
Change-Id: Ib8f073ccc3cbebf165710d8dca22f190eec814dc
2024-09-03 09:36:06 +02:00
Translation updater bot 90f9366ae7
Localisation updates from https://translatewiki.net.
Change-Id: If9d4c5944b3e0eaa3df16d5fac51d8246b21d71a
2024-09-02 09:23:43 +02:00
Translation updater bot e156deac94
Localisation updates from https://translatewiki.net.
Change-Id: I73e730c51ad8772f8072f1ecd40887461852a473
2024-08-30 09:22:40 +02:00
jenkins-bot 2b77c02639 Merge "tests: Adopt private require() for skins.minerva.scripts (take 2)" 2024-08-29 23:58:39 +00:00
Timo Tijhof 4ca4febd89 tests: Adopt private require() for skins.minerva.scripts (take 2)
Resubmission of Ib68f45d93a (548e94da98), which caused an error due
to `require('../../`)` not working outside the module base directory.
This is fixed with regression test in T373065.

Further confirmed in this repo by viewing
`/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva`
with this patch applied. Without the T373065 fix, the console warns:
> Error: Cannot require undefined file …/ToggleList.js

-------

Support for private require() in tests is available since MW 1.41:
https://mediawiki.org/wiki/RL/PKG#Private_export_and_import
https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules

This fixes a confusing assertion in page-issues/index.test.js,
where for "insertBannersOrNotice()" it was asserting that the HTML
contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character
indicates the message is not found (i.e. an error).

The test had to be written this way in order to pass, because
the skins.minerva.scripts module was not actually loaded, and thus
its templates and messages are not present either. This lack was
filled in by index.js for mw.templates, but not mw.messages.

By adopting private require(), these workarounds can all be removed.

== Motivation ==

In change I3a4024ccf90e505581, I'm working on improving the testrunner
config to enforce uselang=qqx on all tests. This is passing except
for GrowthExperiments and Minerva, both of which have the above
workarounds in place that caused a message to be undefined, and then
kept in the assertion expectation. When using uselang=qqx, values are
returned as (key) instead of ⧼key⧽, which exposes these message
existence errors.

By removing this workaround, the test will simply import the module
in the test as normal, thus the messages will exist, and thus it
will expect (key), and thus it will continue to pass even after
enforcing uselang=qqx.

Bug: T373482
Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1
Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-29 20:34:16 +00:00
jenkins-bot 105b6fc266 Merge "Add a tag to mw.notify" 2024-08-29 16:58:11 +00:00
Translation updater bot e04a660035
Localisation updates from https://translatewiki.net.
Change-Id: Ia2b838102653e3d1bfde9fe281e937d2c56b9d88
2024-08-29 09:20:12 +02:00
Translation updater bot a9fe1ac572
Localisation updates from https://translatewiki.net.
Change-Id: I2bf56eef16be25759192b0b9cffe7c3d2f9b9c65
2024-08-28 09:43:49 +02:00
jenkins-bot 48c0eb44fb Merge "Revert "tests: Adopt private require() for skins.minerva.scripts"" 2024-08-27 20:46:55 +00:00
Jdrewniak dbe79167e5 Revert "tests: Adopt private require() for skins.minerva.scripts"
This reverts commit 548e94da98.

Reason for revert: The patch was causing the following error on pageload

    Error: Cannot require undefined file includes/Skins/ToggleList/ToggleList.js
    require startup.js:1006

Bug: T373482
Change-Id: I22751109c124795af7d2e0ad6c4104745b2d6632
2024-08-27 20:06:24 +00:00
Fomafix 8a78d01763 Add a tag to mw.notify
This prevent multiple notifications for the same message.

Change-Id: I6487852350497a48e1710fb04d3af01fc5c18116
2024-08-27 13:03:10 +00:00
Translation updater bot a67cadbc91
Localisation updates from https://translatewiki.net.
Change-Id: I866d40f9916559d325df4c9e8eeebd2149073d32
2024-08-27 09:51:50 +02:00
jenkins-bot 60507c415b Merge "tests: Adopt private require() for skins.minerva.scripts" 2024-08-27 01:36:47 +00:00
Translation updater bot 87e756408a
Localisation updates from https://translatewiki.net.
Change-Id: I634b30d2b58fd8c30434c6a2a710fcff022bee79
2024-08-26 09:26:01 +02:00