Commit graph

705 commits

Author SHA1 Message Date
jdlrobson 3d0587c63d Reduce render blocking styles by deferring loading of icons
Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28
Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c
Bug: T198930
2018-07-11 09:07:10 -07:00
jenkins-bot 32b15522b1 Merge "Remove unnecessary MinervaResourceLoaderParsedMessageModule" 2018-07-10 17:44:41 +00:00
jenkins-bot c5fff1f0b7 Merge "Remove incorrect code comment" 2018-07-10 01:00:03 +00:00
Bartosz Dziewoński 10fa5f0c55 Remove unnecessary MinervaResourceLoaderParsedMessageModule
All of the uses are unnecessary or harmful:

* 'skins.minerva.toggling'
  This module has no messages, parsed or otherwise.

* 'skins.minerva.editor'
  * 'mobile-frontend-editor-redlink-explain'
    This message has no formatting to be parsed. In the past, it
    included the '{{SITENAME}}' magic word, which is still present
    in some translations, but it is supported by the client-side
    jqueryMsg parser anyway.

  * 'mobile-frontend-editor-blocked-info-loggedin'
    This message only uses '{{GENDER}}', which is supported by
    the client-side jqueryMsg parser. More importantly, it uses
    a parameter for it, which is actually not supported by
    MinervaResourceLoaderParsedMessageModule. The message would
    always use the default gender, regardless of the parameter.

Change-Id: I0c597febf9051670228dd144b53521a121f3a220
2018-07-10 02:29:33 +02:00
Bartosz Dziewoński a2dcc8124f Remove incorrect code comment
This was copy-pasted from the function above and it is not true here.

Change-Id: I0513d46789405ea2e6d1cdb619cc548ab8e9ef2b
2018-07-10 01:24:30 +02:00
jenkins-bot 80b41c0170 Merge "Hygiene: Document why selectors are needed" 2018-07-09 22:07:08 +00:00
jdlrobson 20e3bbd28f Don't render blank issues
If an extracted issue has no text, do not render it

Bug: T199005
Change-Id: I18047492e891285ed3af113200d2909e178b8224
2018-07-09 21:33:13 +00:00
Translation updater bot 7032d4ff2f Localisation updates from https://translatewiki.net.
Change-Id: Ief009e2b33c941d4706e6c6bae5d2809adb0e0bd
2018-07-09 21:54:47 +02:00
Translation updater bot b575ab2b33 Localisation updates from https://translatewiki.net.
Change-Id: I65894efb7a8c31930e0bb64314a70747e8e6032d
2018-07-07 22:32:11 +02:00
Translation updater bot 8456be7a41 Localisation updates from https://translatewiki.net.
Change-Id: Id3a97ac312f190c7dc094569be0b9c68e5daf8b1
2018-07-06 22:20:25 +02:00
jdlrobson 795c0abf06 Hygiene: Document why selectors are needed
This rule has a lot of selectors (note the fix me)
It's not clear what each of them are needed for so make that
clearer in the code.

Change-Id: I80f07118977f465b7d09efad28f94917dd962a3d
2018-07-05 23:54:52 +00:00
Translation updater bot 2c98ed3def Localisation updates from https://translatewiki.net.
Change-Id: I4fcc54bd3d95e1021fb68bceb71898a80cecce80
2018-07-05 21:57:31 +02:00
jenkins-bot 48e6e4c6ac Merge "Links should not be clickable in mobile page issue element" 2018-07-05 18:26:02 +00:00
jdlrobson a8ed9380ea Do not restrict images to 320px at tablet resolution
Instead max them to the threshold.
Note restricting them is a problem on pages
like en:Ulaanbaatar - in particular the panoramas
inside the "Urga and the Kyakhta trade" section

Change-Id: I28636c62d3545632d3b025b29d154136a81d8218
2018-07-05 18:05:07 +00:00
Translation updater bot 28a5c3bc35 Localisation updates from https://translatewiki.net.
Change-Id: I46252e43b13faa64eac81fcb40bd3edcf7b694f6
2018-07-04 21:54:35 +02:00
Stephen Niedzielski 56dabf0af3 Links should not be clickable in mobile page issue element
Bug: T198115
Change-Id: I18c393d5676084e0be3ba12fa267765593368615
2018-07-04 13:43:11 -05:00
Translation updater bot 65a1344997 Localisation updates from https://translatewiki.net.
Change-Id: Ia4ff66994e1b1092e0039c50120a89660747b5b2
2018-07-02 21:56:05 +02:00
Translation updater bot fa20b69393 Localisation updates from https://translatewiki.net.
Change-Id: I645eb908f7fa72e9da668369bdf9426887c18092
2018-06-30 22:06:13 +02:00
Translation updater bot dc60ea26b8 Localisation updates from https://translatewiki.net.
Change-Id: I0bc5432acf13b640df7e22351b486d2d30adb654
2018-06-29 22:03:15 +02:00
Stephen Niedzielski fde1c1084c Doc: move config type and defaults near identity
The readme describes all of Minerva's configs and includes a type and
what the default value is at the end of each section. Since the
descriptions for some configs is lengthy, moving the type and default
next to each config's name gives a consistent location for the
information and allows for quick look up without parsing.

Change-Id: I1583c11c80d9b775d93f59302eb2666b754fb412
2018-06-29 17:55:14 +00:00
Stephen Niedzielski 4bf2156a2e Doc: add debug tips for AB testing
Change-Id: I46eff8ebf5ea10a14b9a203fc5dbe7e37d0f25a1
2018-06-29 17:55:03 +00:00
jenkins-bot f1a1edcd27 Merge "Fix: add login icon as a server render dependency of main menu" 2018-06-29 01:58:08 +00:00
Stephen Niedzielski b60fab3331 Fix: add login icon as a server render dependency of main menu
The profile icon is necessary for logged in users. This is known when
parsing skin.json but was not added in MinervaHooks.php. This patch adds
the dependency unconditionally although it is only needed for the server
render of Special:MobileMenu for logged in users.

Bug: T196893
Change-Id: I2a8485299162c01d28ca1b07e7071ad0c0ef44fc
2018-06-29 00:24:36 +00:00
Jan Drewniak c10c3f011e Increasing specificity of '.center' class
Bug: T193595
Change-Id: Id365952881118bc3587fe8a0c897892e61f41df1
2018-06-28 22:21:05 +02:00
Translation updater bot 66d88028ad Localisation updates from https://translatewiki.net.
Change-Id: I1f9dca74d880e2f5211faf384cde96d6cfe1ffa6
2018-06-28 22:00:51 +02:00
jdlrobson 9164b9154f External link icons should use defaultColor
Depends-On: I0745e112d11026ed59d8daca990b313305cd094a
Bug: T197909
Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-27 21:21:19 +00:00
Translation updater bot ff3ecc6c78 Localisation updates from https://translatewiki.net.
Change-Id: I0b30fd34bd3e6ca8b7c2af221aca24afda789d33
2018-06-27 21:55:08 +02:00
jenkins-bot a64bc6b878 Merge "Allow non-js users to remember login on grade C browsers" 2018-06-26 14:21:38 +00:00
Translation updater bot cfac90453d Localisation updates from https://translatewiki.net.
Change-Id: I2fe032b99048260883616fa8aed1d279db7ca90d
2018-06-25 22:07:07 +02:00
Translation updater bot a6fb499d48 Localisation updates from https://translatewiki.net.
Change-Id: Ib76d5088788b6c54e4363d29ba3addbfa6953694
2018-06-24 22:09:43 +02:00
jenkins-bot 6037e61bc9 Merge "Revert "Suppress display of wikitext editor on action=edit"" 2018-06-22 19:23:37 +00:00
Bartosz Dziewoński 645ffa46f8 Revert "Suppress display of wikitext editor on action=edit"
This reverts commit b8c0e4ff30.

Bug: T196915
Bug: T197834
Change-Id: I875854ab65f8b76929285938d2dbaa996caf3546
2018-06-22 19:11:13 +00:00
jenkins-bot f75590a85b Merge "Update: link icons for standard density displays and CSS" 2018-06-21 22:42:47 +00:00
Stephen Niedzielski 5d938aa9e8 Update: link icons for standard density displays and CSS
The previous lot of link icons look great on high DPI displays but not
as nice as they could on standard resolution displays. According to
Volker, this is because the SVG paths must appear on integer coordinates
and scale up instead of down. The new assets have been designed with
this consideration in mind.

Also, workaround redundant CSS by adding commenting out the "unvaried"
black SVG background-image selector, selectorWithoutVariant.

Bug: T190549
Bug: T197909
Change-Id: Id341d383018a436401541e82cc75d826688eaaae
2018-06-21 17:11:46 -05:00
Translation updater bot bf8f9ab452 Localisation updates from https://translatewiki.net.
Change-Id: Ib871464ec539178f4cf2f392d304c15417a2b957
2018-06-21 22:27:13 +02:00
Translation updater bot 890c525878 Localisation updates from https://translatewiki.net.
Change-Id: Idc278b8ae7afea3768ead707718612908868964f
2018-06-20 22:56:18 +02:00
jdlrobson 903863b7f1 Allow non-js users to remember login on grade C browsers
* Grade C browsers on mobile will now check checkbox
* Grade A browsers will not see it and it will be ticked by default
* On tablet the checkbox will be visible to both grade A and C.

Change-Id: I2c77916097afef8eb6a1b3ea28eb0e50c1dff7f4
Depends-On: I5f646b5c939e498eda9bec249658a969f3f91c5d
Bug: T196947
2018-06-20 11:44:23 -07:00
jenkins-bot efa17f210d Merge "Localise "learn more" and warning icon to issues" 2018-06-20 15:52:42 +00:00
jdlrobson f943abd854 Localise "learn more" and warning icon to issues
This is currently showing up on sisterbox templates e.g.
the one on Category:Beekeeping

Bug: T197728
Change-Id: Idaf4aeb4a9efb668e5c06e19ce1eddace121e741
2018-06-20 08:37:00 -07:00
jenkins-bot d5cd6950b0 Merge "Suppress display of wikitext editor on action=edit" 2018-06-20 09:45:57 +00:00
jenkins-bot 041eaadcb5 Merge "Mobile page issues - visual styling changes" 2018-06-19 22:13:31 +00:00
jdlrobson a231525112 Mobile page issues - visual styling changes
Changes:
* Introduce Jan's beautifully documented $wgMinervaABSamplingRate
Set to 1 to A/B test 50% of the population
* Split out ambox template styles into a separate file referenced
by hacks.less
* Update cleanuptemplates setup script to consider two buckets

Test pages:
* Shqiponja_Partizane
* World_War_II_in_Albania
* Liberation_of_Tirana
* French_Consulate
* Abd_ar-Rahman_IV
* M109_howitzer
* Aimoin
* Transport_in_Brazil
* Transport_in_Cape_Verde

Bug: T191303
Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-06-19 14:11:19 -07:00
jdlrobson 2e7e7d3259 Only render table of contents on pages with a table of contents
Bug: T193517
Change-Id: I0ed0255280f525d7726d2e09ceab15a76e2d6026
2018-06-19 18:18:03 +00:00
Legoktm b56e82c8a8 Revert "Allow type Language for $lang of doEditSectionLink"
This reverts commit 648491015c.

Parent patch is being reverted since it didn't follow the
deprecation policy.

Change-Id: Id0e80bf23593d6fc7c986df7b42ff836cc24d867
2018-06-19 01:35:19 +02:00
jenkins-bot 53741ed02f Merge "Fixing alignment of infoboxes for RTL/LTR" 2018-06-18 20:27:44 +00:00
jenkins-bot 30d1b7fd47 Merge "Add missing return in doEditSectionLink" 2018-06-18 20:22:25 +00:00
Translation updater bot 42acc7a5c5 Localisation updates from https://translatewiki.net.
Change-Id: Ice1a6c3d4d9f6a7a21d0da31d92be3096c34e8a5
2018-06-18 21:55:37 +02:00
Fomafix 72a4f7cf4c Add missing return in doEditSectionLink
Change-Id: If2bfae229c2d12090276a5f8dea00a45746349a6
2018-06-18 21:33:03 +02:00
jenkins-bot 927b1bddd2 Merge "Force type Language for $lang of doEditSectionLink" 2018-06-18 01:14:35 +00:00
eranroz 8ca00225dd Fixing alignment of infoboxes for RTL/LTR
Explicitly set align to left on LTR wikis, and same for RTL wikis.
(tested in en wiki with ?uselang=he and he wiki with ?uselang=en)

Bug: T161399
Change-Id: Ic70acf2c56b52fe52eaac021581617342e3ae74f
2018-06-17 22:14:11 +03:00