Commit graph

100 commits

Author SHA1 Message Date
Fomafix 7f4c7d2db2 Add eslint-disable-next-line security/detect-non-literal-regexp
Change-Id: Ie85cdab8d2407fd432ae420ae46970490c2f693d
2024-05-14 12:41:50 +00:00
Jon Robson 14ca9d0ad9 Selenium: Drop dead code
All these tests and associated steps are skipped and apply to pages that
no longer exist - Special:MobileDiff and Special:MobileHistory and can
safely be removed.

Change-Id: I15edf8c2fc88fbc01585c2b7e1243daa6d9210b9
2024-04-26 10:15:10 -07:00
Ed Sanders 8ef144f936 build: Update linters
Change-Id: I5aa3ab891890b52057a5fc855315e5b1b2203037
2024-01-24 22:02:12 +00:00
Moh'd Khier Abualruz 41a5ac75c5 Update modules to not use data URIs to reduce bundle size
- Add "useDataURI": false to following modules:
 -- skins.minerva.mainMenu.advanced.icons
 -- skins.minerva.personalMenu.icons
 -- Remove .mw-ui-icon-mf-next-invert old class kept for caching from edit.page.js

Bug: T346162
Change-Id: I362fdc9c68a7483c182e3540cba6501d9b12959d
2023-12-06 00:24:22 +00:00
jenkins-bot dc3ffae59d Merge "Disable another flakey test" 2023-11-27 20:27:15 +00:00
jenkins-bot ea6cf440cf Merge "Revert "Revert "Disable flakey test""" 2023-11-27 20:07:23 +00:00
Bartosz Dziewoński 8c6067584b Disable another flakey test
Bug: T348539
Change-Id: Icb79bbd404b445a1c42d52b060475250d155490a
2023-11-27 20:48:05 +01:00
Bartosz Dziewoński 7c645549a6 Revert "Revert "Disable flakey test""
This reverts commit 49e2acf2f4.

Bug: T334634
Change-Id: I672e2a6ad31b02118051a21246d808ea94f0a7e4
2023-11-27 19:45:00 +00:00
jenkins-bot 093f4ee01f Merge "Revert "Disable flakey test"" 2023-11-20 23:27:02 +00:00
Bartosz Dziewoński 49e2acf2f4 Revert "Disable flakey test"
This reverts commit be398f8a29.

Reason for revert: The underlying issue should be fixed.
Let's see if this test works better now.

Bug: T334634
Change-Id: I261606edd277935a34588d9695b9024f01a0d3f0
2023-11-20 22:34:01 +00:00
Jon Robson 691d263144 Account for load basic button
When the editor is loading a loading overlay is shown and its not
possible to escape it via the back button. Make sure that the test
waits for this to disappear before continuing.

Bug: T348539
Change-Id: Ib53f9129d2cc89c23142c447e25d727592521ae0
2023-11-01 20:38:14 +00:00
David Lynch dfccc816af Selenium tests: broaden the definition of the article page edit link
Bug: T348353
Change-Id: I92f7c2c5f4691bd511219432c53379ddd928eae2
2023-10-06 16:27:49 -05:00
Jon Robson 05231bb254 Support extension of page actions via hook and addPortletLink
This adds support for:
mw.util.addPortletLink('p-views', '#', 'text', 'fooz',null,
  null,'#page-actions-overflow' )

and adding multiple edit icons via hooks.

Depends-On: I655097769620301143140ded1cde4c7a16879ef4
Depends-On: I401805224c0f387ac85b52b50c1f298b83c03a91
Bug: T346944
Change-Id: I3c9d59f49f1b939981a7b2b450448db6736d5958
2023-10-04 22:15:47 +00:00
Jon Robson d407d1054c Remove or document remaining mw-ui-icon usages
Most of these are captured in other bugs
The anon talk message style doesn't do anything.

Bug: T344022
Change-Id: Iba1fce98ea05931fe07b2b20f07c62d198039d1b
2023-09-13 00:03:38 +00:00
bwang 269bd5bdaf Remove old :before icon selectors and update selectors to not use minerva and wikimedia prefixes
Bug: T344022
Change-Id: I573d7b36513cd0b74f62621cc246f719bcb94256
2023-09-06 13:53:22 -05:00
Jon Robson 952789bc17 Switch Minerva button template to use Codex and remove mw-ui-button
- Removes 'mw-ui-icon-with-label-desktop' as that is now the default behavior for icon only buttons in Minerva
- Removes icon flushing classes, use codex mixins instead

80 Visual changes relating to minor icon/button subpixel changes in the heading, edit section links, and page actions

Bug: T319260
Change-Id: I503b643d33e43196483af4b5f9dd312237322ac8
2023-08-24 15:57:01 -05:00
Jon Robson be398f8a29 Disable flakey test
Noticed this today.

Apparently was reported a long time ago so let's disable this for
now.

Bug: T334634
Change-Id: Id46a8a7d4b9a22ed5d1bd5df5d5f9b03df1f72b0
2023-07-27 09:45:57 -07:00
Vaughn Walters 677ce50b24 selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki
because async mode needs at least @wdio v7.9.

Remove npm packages: @wdio/dot-reporter and @wdio/sync.

Bug: T293084
Change-Id: I5babbdadf21e9f951f69de93bfca5213a50965aa
2023-04-08 16:18:28 -05:00
Željko Filipin da92d66df1 selenium: Skip flaky test
"Wikitext Editor.Closing editor (overlay button)" is breaking CI in core.

Bug: T313775
Change-Id: I3dd3d196a09d7a62faf78d31239e3c8d00141704
2022-12-07 15:47:58 +01:00
Željko Filipin e4abf9c0fb selenium: Delete failing test
"Wikitext Editor (Makes actual saves).Broken redirects" is constantly
breaking CI in core.

I have enabled it in
b9a92ef717
but it isn't as stable as I thought.

Bug: T280652
Change-Id: I667f65a27fd420a3a70f39fb5e1606907e465897
2022-11-30 18:57:21 +01:00
Željko Filipin b9a92ef717 selenium: Enable one skipped test, delete one failing test
'Broken redirects' was disabled in 69a100cb45
'should be creatable' was disabled in 5e0dd88af0

'should be creatable' is failing so it is deleted.
'Broken redirects' is passing so it is enabled.

To be sure that the passing test is not flaky, the CI has ran it 100
times, it never failed.

Bug: T280652
Change-Id: I34a863dcbd126c2da8a98624e6ba1fa916eac0cf
2022-11-24 12:31:34 +00:00
Moh'd Khier Abualruz 9c94cb9b52 Special contribute Selenium Test
Fix Beta tests on Minerva, to accept both cases of enabled and disabled contribute special page.

Change-Id: Ic538655d63347a432029e7d637e9251662d560aa
2022-11-15 09:49:31 +01:00
Bartosz Dziewoński 69ef22e6bd Remove Minerva talk pages Selenium tests
The feature is being replaced by DiscussionTools. We're not ready to
remove it completely yet, but the tests are preventing us from
enabling it on additional wikis.

Bug: T317467
Change-Id: I8b8206d2810426cf4e09da37d0fcd8dec766ccb3
2022-09-30 00:11:05 +02:00
Ed Sanders c19cdec800 Replace bugzilla bug numbers with Phabricator task IDs
Change-Id: I0e8bd586ee0d3d9c3a1d5c14e96e2d0adc64a427
2022-07-18 14:20:11 +01:00
Ed Sanders 86caa17713 build: Update linters and linter config
* Update stylelint-config-wikimedia to 0.13.0
* Ensure eslintrc.js and root files are linted
  with server config

Change-Id: I59c49fedd5b0c4c5620f960b78e4f781a6bc5abb
2022-05-18 14:33:23 +01:00
Jon Robson 55419f9bcc [Tests] Strengthen the reference drawer test
Assert the drawer is visible before clicking it.

Bug: T266704
Change-Id: Iec1d2a2c0a4b34509f4b73ed87ccc63eeecad671
2022-04-18 23:05:29 +00:00
Jon Robson c4f7c60f9f [Tests] Move beforeEach calls into tests
beforeEach failures do not have videos associated. We'd like to see
what's going wrong with these tests.

Change-Id: I1b723bcd7d00f15907647d5c7a4aa1f57578468c
2022-03-17 14:14:10 -07:00
Jdlrobson 63e744d147 Revert "[Tests] Check for VisualEditor in editor overlay integration test"
This reverts commit 422e3a3b09.

Reason for revert: The Ruby tests don't run. This change should be in
the Node tests.

Change-Id: If59753569b1eb24ffaf2486242ea49e794d388b5
2022-03-16 21:44:55 +00:00
Bartosz Dziewoński ff00b6d9c5 Disable failing talk page tests temporarily
Bug: T302993
Change-Id: I1cbe8367394fdee1c0a88d5dbe2bd00da0b74062
2022-03-03 19:50:09 +01:00
Željko Filipin 436bf80bd8 selenium: Delete tests disabled for more than 1 year
'Redirects' was disabled by Edward Tadros in fbd373b (2021-01-15).

'A newly created topic appears in the list of topics' was disabled by
Jon Robson in d4828b2 (2020-09-24).

Bug: T280652
Change-Id: I63fb62c0c2871ff2713643285cd6e5d878684f83
2022-02-16 15:58:00 +01:00
Umherirrender 791cb1081a selenium: Ensure .waitForDisplayed() before .click()
Avoid time outs
Error in "Opening and closing the reference drawer.Opening a nested
reference"
Error: waitUntil condition timed out after 5000ms
    at Browser.<anonymous>
(/workspace/src/skins/MinervaNeue/node_modules/@wdio/utils/build/shim.js:270:24)
    at iShouldSeeDrawerWithText
(/workspace/src/skins/MinervaNeue/tests/selenium/features/step_definitions/reference_steps.js:25:10)
    at Context.<anonymous>
(/workspace/src/skins/MinervaNeue/tests/selenium/specs/references.js:44:3)
FAILED in chrome - /tests/selenium/specs/references.js

Change-Id: Ia5d493fba4995c1122721b76ae98d6ba60399238
2022-02-03 21:18:02 +01:00
Antoine Musso 0fbb2a34f2 selenium: run tests concurrently
Wikimedia CI now serves MediaWiki over Apache (T285649) which mean we
can do concurrent requests!

Bug: T226869
Change-Id: Ifb155b7a14f5dd7b037578c83c9590f7901feacf
2022-01-05 16:44:12 +00:00
jdlrobson f9a8703a64 Minerva uses core page title handling
Bug: T265892
Change-Id: I2ffdedd64414ffb3c6e441391a75fd6e744847a4
2021-12-20 19:39:42 +00:00
bwang ef4aa95ae2 Remove primary/secondary menu items, instead add a separate log out menu item
Bug: T293041
Change-Id: I9f73fdba1856dd9e0ea7120df0fb18061337961a
2021-11-18 19:51:33 +00:00
Ed Sanders 2ec4b950e2 build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I0185de7ec62c54ee733de94622e0c41a65e86731
2021-11-09 14:48:40 +00:00
Ed Sanders ef742a0d6a build: Update wdio devDependencies
Change-Id: I2d51563517f88ffa50ddf76d1716d13024f21381
2021-11-09 14:41:17 +00:00
jdlrobson 5263b09397 Standardize use of buttons and icons in Minerva
* Adds button hover/focus states to all Minerva button icons
* Removes the deprecated mw-ui-icon-before selector

Depends-On: I4eb28eae4c4e23d58f1f85bc41c0caf77197d8a1
Bug: T288678
Change-Id: I490534f9f704a733191b459c8ee071848c436001
2021-09-17 15:36:54 +00:00
jdlrobson 5e0dd88af0 [Selenium] Skip failing test
Causing error "Node is either not visible or not an HTMLElement"

Change-Id: Id29fe854e04df637dca4d55458b31260b76f2b53
2021-09-16 14:57:03 +00:00
sahil 67e47ac0bd selenium: Update README.md file
Bug: T282237
Change-Id: Ia26bba12ede5e1055122387e36007887669267f8
2021-08-16 12:23:20 +05:30
Edward Tadros 69a100cb45 selenium: Fix failing Jenkins job selenium-daily-beta-Minerva
"Page should be creatable" test is fixed by increasing timeout.
"Wikitext Editor Makes actual saves Broken redirects" is skipped.
The skipped test will be replaced with a new test.

Bug: T269051
Change-Id: I72c43b361bd8e63e500656f164412d37856805c1
2021-07-01 07:50:46 -07:00
jenkins-bot 18329d800a Merge "selenium: Update wdio-mediawiki" 2021-06-09 02:57:25 +00:00
jenkins-bot 8900f58e2f Merge "Replace categories button with HTML rendering" 2021-06-07 08:58:44 +00:00
Željko Filipin ed40ca23c9 selenium: Update wdio-mediawiki
wdio-mediawiki v1.1.1:
- Includes wdio-defaults.conf.js file that vastly simplifies wdio.conf.js.
- Replaces @wdio/spec-reporter with @wdio/dot-reporter.
- Introduces video recording.

Bug: T283597
Change-Id: I5408b35060734709a6d21520c6abd738fb44d5a1
2021-05-27 17:49:19 +02:00
Jdlrobson 8651df02bb Replace categories button with HTML rendering
Bug: T246049
Change-Id: Id8c7493a525844b43c1628a1f4f09ae716ece2ba
2021-05-14 20:34:59 +00:00
Željko Filipin 20bb2bf09c selenium: Run tests from desktop site
Bug: T282058
Change-Id: I342a1ba510ea5da85da904c1bec4f26adfc60d33
2021-05-07 17:44:33 +00:00
Željko Filipin def50f52c1 selenium: Fix 'Page should be creatable' test
The test was failing on The Beta Cluster because of two reasons:
- Local development environment and CI need to switch to mobile view,
The Beta Cluster doesn't.
- Local development environment and CI allow anonymous edits,
The Beta Cluster doesn't.

Bug: T281733
Change-Id: Iedcd94dc5cf1ace14baadfe9d9bd5bed9788f775
2021-05-05 21:12:16 +00:00
jenkins-bot d1527e7aab Merge "selenium: Page should be creatable" 2021-04-29 23:18:09 +00:00
Željko Filipin 8ac75d254a selenium: Add JUnit reporter
JUnit reporter is required to create the XML file that Jenkins uses to
create Test Result Trend chart for selenium-daily-beta-MinervaNeue
job.

Bug: T214686
Change-Id: Ibf4b08f2f4b60ad02a3a3b5a5ba8e0d899a86859
2021-04-29 18:06:15 +02:00
Željko Filipin 238010dbea selenium: Page should be creatable
Bug: T269051
Change-Id: I958d1f5035f7d28c70ff19c3db6f3707defa880f
2021-04-26 15:30:31 +02:00
jenkins-bot db0b1e9585 Merge "selenium: Update WebdriverIO configuration file" 2021-04-23 14:53:51 +00:00