Commit graph

4025 commits

Author SHA1 Message Date
jenkins-bot 8b15df8c75 Merge "Hygiene: collapse mobile.search LESS into mobile.startup" 2018-12-17 22:27:08 +00:00
Stephen Niedzielski 7826a451c9 Fix: use hand cursor for links without href
Links without hypertext references are still functionally links and
should be presented in the same way. This patch forces the hand cursor
to be used for such links which affects the red links drawer's "no
thanks" link.

Change-Id: Iabfef03f6726bb8a5e3a2bc90f2a7f63c8a10c02
2018-12-17 22:20:25 +00:00
Stephen Niedzielski 37333c7189 Hygiene: collapse mobile.search* into mobile.startup
MinervaNeue depends on mobile.search and mobile.search.api. These
ResourceLoader modules existed in MobileFrontend but now have been
collapsed into mobile.startup.

This patch updates Minerva's ResourceLoader module and JavaScript
references.

Bug: T210207
Depends-On: I1eae36f2927a4e0f9d1e91d604d656beb8cc33ae
Change-Id: Ied6f4873bf2550564673296e9ef4fa009ca45e5b
2018-12-17 22:03:41 +00:00
Stephen Niedzielski 0cb19335fa Hygiene: collapse mobile.search LESS into mobile.startup
MinervaNeue depends on mobile.search. mobile.search's LESS has been
collapsed into mobile.startup. This patch updates Minerva's references
and revises the SearchOverlay's CSS selector to increase specificity to
account for the new order of CSS files. Previously:

- ...
- MobileFrontend Overlay.less
- MobileFrontend SearchOverlay.less
- ...
- Minerva Overlay.less
- Minerva SearchOverlay.less
- ...

Now:

- ...
- MobileFrontend Overlay.less
- Minerva Overlay.less
- ...
- MobileFrontend SearchOverlay.less
- Minerva SearchOverlay.less
- ...

Since SearchOverlay's selector are intended to override Overlay's, it
seems appropriate to specify that a SearchOverlay is also an Overlay and
increase specificity.

Bug: T210207
Related: Ib0316020ed10eb0c921a3300501df7634a889977
Change-Id: I5c06b13f22f530fb52f37f373e081ed55f332a07
2018-12-17 22:02:58 +00:00
Translation updater bot 4842928f2b Localisation updates from https://translatewiki.net.
Change-Id: If338c7b94143f4464c0d185f435690970db0f7ae
2018-12-17 21:57:02 +01:00
jenkins-bot 2abb44b24a Merge "Remove references to "mobile.toggle" module." 2018-12-14 16:27:44 +00:00
Jan Drewniak 4522a8e10a Refactor pageIssues.js into smaller functions
Instead of having one large `createBanner` function, breaks down
that responsibility into three smaller functions:

- createPageIssueBanner
- createPageIssueBannerMultiple
- createPageIssueNotice

These functions represent issues in the new treatment, the
multiple-issues template, and the old treatment.

createBanner now delegates the creation of these banner types to these
new functions.

A new property to PageSummary, $el, has also been added. This allows us
to manipulate the issues DOM via the PageSummary object, instead of using
the `$metadata` variable in createBanner.

This approach to the page-issues DOM also solves the problem of
wrong or missing icons in T202349.

Bug: T211257, T202349
Change-Id: I50a2d8e3ae94913dc060ceedaaf1fa7e1756617f
2018-12-14 02:03:58 +01:00
Jan Drewniak 1589a15862 Remove references to "mobile.toggle" module.
mobile.toggle was folded into mobile.startup in
mobileFrontend, so moving references to that instead.
- Changing require statements
- moving skinStyles/mobile.toggle/minerva.less to
   skinStyles/mobile.startup/toggle.less
- Replacing references to mobile.toggle in skin.json

Depends-On: Iecc1870f08532e8c7893861afdd54f069da54be2
Bug: T210208
Change-Id: Ie67cd50a2d042fbbaaef348b9b62d64193900d78
2018-12-14 00:45:34 +01:00
jenkins-bot 9e3e499871 Merge "Tablet style should apply to mbox-text-div as well as mbox-text-span" 2018-12-13 22:32:54 +00:00
jdlrobson 2258da2ff8 Tablet style should apply to mbox-text-div as well as mbox-text-span
Bug: T206887
Change-Id: Id992f92eef8a5b6001e12fa42e2333cd266cc098
2018-12-13 11:41:15 -08:00
Volker E f0608db19a build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Updates code comments and whitespacing.

Change-Id: If7665beaa2d342881483fd7a9fc0fc880768d2ef
2018-12-12 23:26:48 +00:00
Translation updater bot 339e31752a Localisation updates from https://translatewiki.net.
Change-Id: I4cd952aec11b76be8a71dcb0061ae21c72c62e73
2018-12-11 22:21:48 +01:00
jenkins-bot d9831e8ac3 Merge "Remove usage of global event emitter from Minerva" 2018-12-10 15:32:33 +00:00
jenkins-bot c21208fa55 Merge "build: Update sniff list in .phpcs.xml" 2018-12-10 09:47:47 +00:00
Translation updater bot 857f5684bd Localisation updates from https://translatewiki.net.
Change-Id: Id92ed8ce680d235bb51eee651d51bee2c167d7f6
2018-12-09 22:16:15 +01:00
Umherirrender ddbe40b90d build: Update sniff list in .phpcs.xml
FunctionDeclarationArgumentSpacing is now part of the default

Change-Id: Ic71d94a03a733ed2aa83cbddca7c2b239bb30511
2018-12-08 15:34:19 +01:00
Translation updater bot dbf811b736 Localisation updates from https://translatewiki.net.
Change-Id: I36c993bfaf3ad697cc8921bfa0a48126a82f0ece
2018-12-07 22:06:25 +01:00
jenkins-bot b564dabcd9 Merge "Remove usage of global event emitter from skins.minerva.talk/init.js" 2018-12-07 16:00:38 +00:00
Nicholas Ray 5bfd949f9a Remove usage of global event emitter from Minerva
This patch removes the remaining usages of M.on/M.off/M.emit
(functionality derived from moduleLoader.js in MobileFrontend) in
Minerva and continues the work of
Id990b0e1a53221d5c1cb3e3012aed0e27d801fc2 (patch for MobileFrontend).

This patch and the patch for MobileFrontend should be merged together as
they both depend on eachother.

Depends-On: Id990b0e1a53221d5c1cb3e3012aed0e27d801fc2
Bug: T156186
Change-Id: I005d2fcdbf91c2f1ac98178dfa388aa8174e7530
2018-12-06 19:30:09 -07:00
Nicholas Ray 8feff10336 Remove usage of global event emitter from skins.minerva.talk/init.js
This patch removes usages of M.on (functionality derived from
moduleLoader.js in MobileFrontend) in skins.minerva.talk/init.js and
continues the work of I0e35776114ffa137b219eff0a900a0a0c52a27bb (patch
for MobileFrontend).

This patch and the patch for MobileFrontend should be merged together as
they both depend on eachother.

Depends-On: I0e35776114ffa137b219eff0a900a0a0c52a27bb
Bug: T156186
Change-Id: Ic766d0bbf2746df898038115e2e4bc791ac10359
2018-12-06 19:29:43 -07:00
Translation updater bot c95c5ef29a Localisation updates from https://translatewiki.net.
Change-Id: I749bbe36ef57ae054c8fdfac55a23705646f648c
2018-12-06 22:12:28 +01:00
Translation updater bot 4246e079e4 Localisation updates from https://translatewiki.net.
Change-Id: I326243574708aba77901106fd9fa806cd1998b59
2018-12-05 22:09:38 +01:00
jenkins-bot fe983c5102 Merge "mobile.watchstar is a deprecated module" 2018-12-03 21:35:47 +00:00
Translation updater bot f038060595 Localisation updates from https://translatewiki.net.
Change-Id: Ied038f408d97829d787e82a4876b38f5b6a208d7
2018-12-03 22:14:54 +01:00
Translation updater bot 923ab80dba Localisation updates from https://translatewiki.net.
Change-Id: I1c898d02af860833f22300b33cc109a4a73d048c
2018-12-02 21:55:02 +01:00
Translation updater bot 036db5e86d Localisation updates from https://translatewiki.net.
Change-Id: I4a8054a3ea37dc6d33b2c29d5f5edf78e4cd77c7
2018-12-01 22:02:06 +01:00
jdlrobson 87942c34f9 mobile.watchstar is a deprecated module
Referencing it triggers deprecation warnings so should be updated

Bug: T208921
Change-Id: I7266a067a14bfa38a998f426e18f096515b7bfa7
2018-11-30 15:28:03 -08:00
Translation updater bot da1417c1eb Localisation updates from https://translatewiki.net.
Change-Id: I61c6eb128dc8c2eb8cc0ff6414e7d749dc921979
2018-11-30 22:04:05 +01:00
jdlrobson c31da9a236 QA: Drop protected page test
* On commit it needs admin rights which it doesn't have
* On browser tests the toast flakes too much.

Bug: T208808
Change-Id: I1fa93c8f451f3f839030fa7a144b1cb285c4239d
2018-11-29 16:51:04 -08:00
jdlrobson f055f8d789 Drop toast tests from beta cluster
Given the fade in/out animation of the toasts and the instability of
the beta cluster and the round trips to Sauce labs, we're seeing lots
of false positives on our browser test reports

Running these per commit should ensure we see minimal regressions and
get some protection. We'll continue to test other scenarios which do not involve
the toast on beta cluster.

Provided we can rely on green browser tests, we will trust the browser
tests more and they will be more useful than they currently are.

Bug: T208808
Change-Id: Idc601ad462de36f2d6d52fe951194b429e6f824f
2018-11-29 16:40:02 -08:00
Translation updater bot 7b68f3bfe3 Localisation updates from https://translatewiki.net.
Change-Id: I39d8f457769b18e03c57fc1d945905f7cbebcbfd
2018-11-29 22:37:28 +01:00
jdlrobson 0a41aa53ca QA: Browser tests should limit write operations
We use lots of write operations in Minerva browser tests. On the beta
cluster many of these are redundant, as the page already has the content
required or the page already exists

Limit where we do our creation... the less write operations we make the
more stable we can expect these browser tests to be.

Change-Id: If88b878e14bf4a0424fcf23213653cfc2cf8d87b
2018-11-29 07:34:41 -08:00
James D. Forrester a44badacc8 eslint: Drop 'dot-notation' rule
Bug: T210552
Change-Id: I23d8923ffe82b766bbfd7505bd05834e3e6d247a
2018-11-28 11:27:23 -08:00
jenkins-bot 9d4454108c Merge "Provide some recommended (opt-in classes) for projects not opted into page issues" 2018-11-28 13:22:30 +00:00
jdlrobson b71bb0cc8c QA: Tagging changes from beta cluster
* features/search_loggedin.feature
They run on integration and are not super-business-critical.
Given their flakiness and Cirrus's likelihood of being down,
don't run it on beta cluster
* tests/browser/features/language.feature
Tag is superfulous, all scenarios repeat it.
* tests/browser/features/toggling.feature
ocassionally fails on firefox. Limit to Chrome and integration
tests
* tests/browser/features/search.feature
Limit the tests that run against beta cluster to search for
partial text and clicking a search result, since these are
two things we want to check integration well with other extensions.
The rest being testing on the more stable @integration tests
should be more than enough.

Change-Id: Ia2e8d3726212fee30725fdb9167ea38aa41eacbf
2018-11-27 17:53:00 -08:00
Ed Sanders d63de2eb01 Set editfont size to 16px (100%)
Change-Id: I9bff880de792da756f14726042df0a0df4139d1b
2018-11-27 22:56:01 +00:00
jdlrobson 0e4283ae43 Provide some recommended (opt-in classes) for projects not opted into page issues
You can test this against the beta cluster using
$wgMFMwApiContentProviderBaseUri = "https://en.wikipedia.beta.wmflabs.org/w/api.php";

Bug: T206177
Change-Id: Ic2e6859443ed5aa2a3f97218f4c89df2a46000f9
2018-11-27 14:44:07 -08:00
Translation updater bot d3269adc3f Localisation updates from https://translatewiki.net.
Change-Id: Ib903c546a895b312c89630423a3904e4232ab206
2018-11-27 21:59:56 +01:00
jenkins-bot 645073e958 Merge "isBorderBox and className properties are deprecated" 2018-11-27 13:58:37 +00:00
jdlrobson 5c40ddc477 Zero is a sensible default for this feature flag
Bug: T205008
Depends-On: I3640b28c6a930f6e934d22c3375bffcd539902aa
Change-Id: Ie5d63e265469219063e36d6e398fd0a0b1e864db
2018-11-27 12:26:37 +00:00
Piotr Miazga a15119bdc1 Pass mode property to MobileWebMainMenuClickTracking schema
Changes:
 - pass the mode property instead of mobileMode
 - if mobileMode is undefined, pass 'desktop'

Depends-On: Iedd26463128623e56b9a8612ccf2488739c854fa
Bug: T193505
Change-Id: I6706546fc136779e3872ef9405ca6749b01cf751
2018-11-27 00:42:33 +01:00
Translation updater bot 8dfd431744 Localisation updates from https://translatewiki.net.
Change-Id: Iab1c9ac32fb864e76069ade6ca94c6d796985c57
2018-11-25 22:19:14 +01:00
Translation updater bot 110285482b Localisation updates from https://translatewiki.net.
Change-Id: Ib5afa706d5e6be9fa4bc4e33bf9dff561ed3b6b3
2018-11-23 21:58:47 +01:00
jenkins-bot e0365aa3a0 Merge "Update usages of user module to mw.user" 2018-11-23 19:21:48 +00:00
jenkins-bot bce934c54d Merge "QA: Remove hacks introduced for T170890" 2018-11-23 19:08:05 +00:00
Translation updater bot dd3d603e54 Localisation updates from https://translatewiki.net.
Change-Id: I438cab9a887dde3bf231769c242cd70eb9132bb2
2018-11-22 22:01:52 +01:00
jdlrobson c8693b6789 isBorderBox and className properties are deprecated
These will soon throw warnings and soon be removed!

Bug: T209007
Change-Id: Idca4c892366dc5b5e8490f1326188b97abc876f7
2018-11-22 19:11:53 +00:00
Translation updater bot ae77727c7b Localisation updates from https://translatewiki.net.
Change-Id: Ie54ad80829f027188517c1de74ed53f904168ea5
2018-11-21 22:12:29 +01:00
jdlrobson e1b94f3f63 Update usages of user module to mw.user
We are deprecating the MobileFrontend user module. Use the
mw.user module in core instead which supports the same methods.

Bug: T204866
Change-Id: I3d068198ab79fe85823a9d82ef4bd7ca07013d3b
2018-11-21 11:12:41 -08:00
jdlrobson 6a7d350160 QA: Page issues browser test is ready for new treatment
The page issues browser test is now compatible with both the old
and new treatments.

For consistency, in integration tests it will be run always in
treatment B since that will be the new way to do this going forward.

The beta cluster will test issue treatment A while it continues to be
the default. So with this we enjoy the best of both worlds.

When we enable page issues, the beta cluster will inherit the config
from production and we can remove the treatment testing for treatment B.

A follow up patch, might add testing for a page issue on talk pages,
which will retain treatment A for completeness if this is deemed useful.

Bug: T206647
Change-Id: I586523e452a6809e310f65a2ed55c6771d1965b6
2018-11-20 23:38:04 +00:00