Commit graph

3951 commits

Author SHA1 Message Date
Jon Robson 003d9fea5b dd elements should have no margin
In 1.42.0-wmf.17 these had margin 0 in Minerva.
I incorrectly assumed we had defined an explicit margin in content
and for talk pages but apparently none exists, so I have restored
this rule to the list.less file.

Follow up to I6331d88e5b7301fd13249414350a539738cfae53

Bug: T357742
Change-Id: Ib3062bfbffe35415f479bae46ecf02e8a094958b
2024-02-16 16:56:26 +00:00
David Lynch 57d1b2ab5b Add border-collapse to wikitable
Follow-up to 7c9304cbf4 which removed it
from all tables.

Bug: T357589
Change-Id: I1d62a9b2c0f571389f5cbebdc56b24ff4c325283
2024-02-15 18:28:33 +00:00
Translation updater bot acfffcdd5b Localisation updates from https://translatewiki.net.
Change-Id: I3ec6590e580b797ef4010c12445f304c5d5ced6b
2024-02-15 13:31:42 +01:00
Jon Robson 8de0d99882 Disable Extension:DarkMode on Minerva
Bug: T357598
Change-Id: I590ebe574c4c23507525a118cd99cbe31af022db
2024-02-15 01:39:43 +00:00
Jon Robson 145db70286 Reset: Drop p and div inside overlays
Required for proper presentation of page issues overlay
and multimedia viewer.

The div rules were unnecessary.

Bug: T205341
Change-Id: I6fea0f2013a11e5248b71619b795d794c8ed18ad
2024-02-14 22:20:43 +00:00
jenkins-bot 50a55bce7d Merge "Invert logos" 2024-02-14 22:00:47 +00:00
bwang 1e9de11ccf Invert logos
Bug: T356823
Change-Id: I5ccaa865197dd70afb524b3d47515ebc8e9db214
2024-02-14 21:35:27 +00:00
Steph Toyofuku 91c9e68afb Fix borders in night mode palette
Following a discussion in the ticket, update the places where `#eaecf0`
has been hardcoded to reflect whether it is intended to be a border or
background style and replace with CSS variables where applicable.  Add
`--border-color-muted` as a CSS custom property, and update the night
mode palette to use it.  Lastly, add `--color-error`, to be used in a
subsequent patch

Visual changes, but again gated behind night mode feature flag

Bug: T356825
Change-Id: Icb5741190f3e80a20dcedf9b13d6a34fe619b467
2024-02-14 16:18:21 -05:00
jenkins-bot b162411c36 Merge "Send a toast notification if night mode is not available" 2024-02-14 19:39:32 +00:00
jenkins-bot d476676fe2 Merge "Allow us to write Jest tests!" 2024-02-14 14:50:29 +00:00
jenkins-bot cab803db1b Merge "Reset: Further simplify the reset" 2024-02-14 11:58:13 +00:00
Translation updater bot af23e13afd Localisation updates from https://translatewiki.net.
Change-Id: If53a064032c668cdbeb997ae1fa9d63e4f143332
2024-02-14 08:21:02 +01:00
Jon Robson ea6c55f925 Reset: Further simplify the reset
* Move pre to content/text.less
* Move heading styles to text.less
* Move search input styles to ui.less

Bug: T205341
Change-Id: I333918089af1c20e9467ad57596dd9dd6925869a
2024-02-13 18:23:28 -08:00
Jon Robson b079031b0a Send a toast notification if night mode is not available
Add a skin-night-mode-page-disabled class to the HTML element when
a page was disabled by the new MinervaNightModeOptions configuration
flag.

Bug: T356653
Change-Id: I7a6582ef8f66e78cc6f07da06bc4d2a3277cfcf0
2024-02-14 01:51:23 +00:00
Jon Robson cef90c6286 Allow us to write Jest tests!
Change-Id: I6095b08dd72a7ba0ac6bd13c5f5870a1e23c7748
2024-02-13 23:45:26 +00:00
bwang 3d95788553 Flip page issue background color
Bug: T357179
Change-Id: Idd59beb17744ce247be66446dc11214e27328fd3
2024-02-13 21:21:25 +00:00
jenkins-bot ad02a53e8a Merge "Restore link active color" 2024-02-13 17:18:55 +00:00
Jon Robson 138769f60f Restore link active color
Bug: T357381
Change-Id: Idee0532800127285618d3c709eb39d1bf32f83a8
2024-02-13 08:32:40 -08:00
Steph Toyofuku 54d577d9b4 New night mode color palette
Update the `night-mode-palette` styles to reflect the updated design

There is definitionally a visual change, but should only be for night
mode (which is currently gated behind a feature flag)

Bug: T356825
Change-Id: Iebe3b91cdf9e5e5effb2bc3ab4ff75859024056f
2024-02-13 10:22:11 -05:00
Jon Robson a9f45d2adf Always show patrol link on Minerva skin
Bug: T357213
Change-Id: I36a7ce8a86409087e0142fcc11c6285a327b3875
2024-02-12 21:32:19 +00:00
Jon Robson d5d9fe4ea6 Make thanks button show again
Bug: T357202
Change-Id: Ife53355584da6d7d65413173db8bd93d389996c5
2024-02-12 17:36:33 +00:00
Translation updater bot 660e9a9dbb Localisation updates from https://translatewiki.net.
Change-Id: I9e0fbe02f3d4758fe8c609a9f3d8b61f675e00de
2024-02-12 14:52:33 +01:00
libraryupgrader b7cc09b4a3 build: Updating mediawiki/mediawiki-phan-config to 0.14.0
Change-Id: Ib3c5f368f8205728cec4e28c3b832fdc6060a093
2024-02-10 16:03:06 +00:00
Jon Robson 5e2e2142ef Diffs: Localize number in timeago
Bug: T357079
Change-Id: I6c877baa82ac88e50ae0c5e932665bda9122da70
2024-02-09 16:51:30 +00:00
Translation updater bot 1cfa8d2335 Localisation updates from https://translatewiki.net.
Change-Id: Iaa3e7358e3a785fe99194567cbc43fa4ac29122e
2024-02-09 08:45:56 +01:00
Jon Robson 3224b026e4 Font size for search input and overlay search should be consistent
Follow up to: I6331d88e5b7301fd13249414350a539738cfae53

Bug: T205341
Change-Id: I344be341bff06212e911a6935cca4b7551bcf227
2024-02-09 00:01:11 +00:00
Jon Robson 967e0b1e1b Restore night mode on history and diff pages
Follow up to I0fa0eab3bfa57cc6864dbdd2d6aeaa5582767c3c
Initially we want to enable night mode on all pages
This config should therefore not apply to any pages initially.

Bug: T355705
Change-Id: I2ca6d4a971d00d163fa82e93ac99959e41c87b91
2024-02-08 14:48:50 -08:00
jenkins-bot bc22880bfe Merge "Allow pages to not appear in night mode" 2024-02-08 21:48:07 +00:00
jenkins-bot 8dbb6d0be6 Allow pages to not appear in night mode
- Add config to skin.json
- Add the function in SkinMinerva.php to check exclusion of pages and namespaces.

Bug: T355705
Change-Id: I0fa0eab3bfa57cc6864dbdd2d6aeaa5582767c3c
2024-02-08 21:28:14 +01:00
Translation updater bot ca0b7d90f9 Localisation updates from https://translatewiki.net.
Change-Id: I6f4c50bc5de73a31e358fd3f954b679aa5a75a44
2024-02-08 09:18:24 +01:00
jenkins-bot 4121d8c699 Merge "Fixes: Notification icon displayed with bullet point" 2024-02-08 00:55:09 +00:00
Jon Robson aea4156fe7 color-link-visited was not defined
Follow-up to 59fd0cd

Bug: T356928
Change-Id: I079f3de333fd59162f4e2b87d896bb273b3e9b3c
2024-02-07 15:55:43 -08:00
Jon Robson 56e0d84bdc Fixes: Notification icon displayed with bullet point
Follow up to: I6331d88e5b7301fd13249414350a539738cfae53

Bug: T205341
Change-Id: I60b7919d53cf101e4026950331fff93fbef76ac5
2024-02-07 23:05:09 +00:00
jenkins-bot f1cc3ea1ff Merge "Revert "Color subtle should be a CSS variable"" 2024-02-07 20:04:41 +00:00
Jdlrobson af192769a7 Revert "Color subtle should be a CSS variable"
This reverts commit d33a0423b1.

Reason for revert: CSS variables are currently not compatible
with fill colors 

Bug:  T356540
Change-Id: I29c92bb2407a5b8ed38e09a0f48ec834c671c912
2024-02-07 19:40:09 +00:00
jenkins-bot ec453ac037 Merge "Replace reset with SkinModule normalize" 2024-02-07 14:38:30 +00:00
Translation updater bot ab7e7eca0e Localisation updates from https://translatewiki.net.
Change-Id: I3a1dfc3aaf2e6efe94e782a932e69aca67019c67
2024-02-07 08:29:32 +01:00
jenkins-bot 1376e509f1 Merge "Set text color on infoboxes" 2024-02-06 22:26:55 +00:00
Jon Robson e5fa425a84 Set text color on infoboxes
When defining background we should also define color to avoid mixing
styles provided by editor, and us.

This fixes the black on black in infoboxes on the Paris article
for example in night mode.

Bug: T356074
Change-Id: I5a73f5eaf269cb8f771663a9181a67f9af723b13
2024-02-06 13:22:49 -08:00
Jdlrobson 0a1effca13 Merge "Color subtle should be a CSS variable" 2024-02-06 20:42:22 +00:00
Jon Robson d9fa5214a7 Reduce font size of diff heading
Bug: T356728
Change-Id: If7c66ca939d9b27d6d8435336514600453e06670
2024-02-06 19:06:52 +00:00
Jon Robson d33a0423b1 Color subtle should be a CSS variable
Needed for RelatedArticles heading.

Bug: T356074
Change-Id: I031c4b02fcf6898e72aa92fb5cae95ea1d305fbd
2024-02-06 19:05:31 +00:00
jenkins-bot a56c60a3f2 Merge "build: Updating wdio-mediawiki to 2.5.0" 2024-02-06 15:31:04 +00:00
libraryupgrader 5c2d903406 build: Updating wdio-mediawiki to 2.5.0
Change-Id: If978d6da9aefce13ebe018a129011629e2908576
2024-02-06 10:02:33 -05:00
Steph Toyofuku 573ac59dc5 Query params can set night mode value
Whereas previously, the value of the query param would simply determine
whether or not night mode was enabled, we would like to be able to
control the actual night mode setting off of the query param

Now, it functions as an option to force the user into a particular
setting, be it automatic, night, or day.  If the query param is not set
(if night mode is enabled via config), we will default to the user
option as before

Bug: T355118
Change-Id: I38ed94bfc1b80d0a827c63c6dbdd92eb6f1bf531
2024-02-05 14:45:49 -08:00
Translation updater bot ece5ac0803 Localisation updates from https://translatewiki.net.
Change-Id: I04dd990815a32d043ad922d489995bab0d0f416b
2024-02-05 08:52:28 +01:00
jenkins-bot 3fb777580f Merge "Set up user option for night mode" 2024-02-02 22:53:49 +00:00
Jan Drewniak d467f0a418 Follow-up to 59fd0cd (red-link typo)
Fixes typo in variable name.
--color-link-new -> --color-link-red

Bug: T356074
Change-Id: I801e5cd90d63c2af00485621f3774a10ca41804f
2024-02-02 16:54:11 -05:00
Steph Toyofuku ef46f238a7 Set up user option for night mode
Add a new user option, `minerva-night-mode`, and configure it with a
default value of 2 (automatic based on OS).  Rework the code in
`getHtmlElementAttributes` to set the initial class value according to
the user option, which will be set and saved inside of MobileFrontend

Bug: T355118
Change-Id: I4b0d63a186f490ba10b7655b3af4dcb8b64bd400
2024-02-02 13:28:35 -08:00
jenkins-bot 6e4c2e4c60 Merge "Convert all color related Less variables to CSS custom properties" 2024-02-02 18:18:57 +00:00