wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 06:13:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow collapsible content in Minerva

Browse source 
Too many projects including notably English Wikipedia are now
enabling this code via gadget, which will make addressing this
problem more difficult in future, by providing an unpredictable
development/testing environment
it would be better if this reflected production, even with the fat
finger problem.

Bug: T323639
Bug: T111565
Change-Id: I81aa514a211710d0eec45329e3e3c7ee331da6ea
This commit is contained in:
Bartosz Dziewoński 2022-11-22 20:29:22 +01:00 committed by Jon Robson
parent 10eb430c6c
commit 5b48e1665a
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/Hooks.php
View file

@ -269,8 +269,6 @@ class Hooks implements
/** /**
* SkinPageReadyConfig hook handler * SkinPageReadyConfig hook handler
* *
* Disable collapsible on page load
*
* @param Context $context * @param Context $context
* @param mixed[] &$config Associative array of configurable options * @param mixed[] &$config Associative array of configurable options
*/ */
@ -280,7 +278,10 @@ class Hooks implements
): void { ): void {
if ( $context->getSkin() === 'minerva' ) { if ( $context->getSkin() === 'minerva' ) {
$config['search'] = false; $config['search'] = false;
$config['collapsible'] = false; // Enable collapsible styles on Minerva. Projects are already doing this via gadgets
// which creates an unpredictable testing environment so it is better to match production.
// NOTE: This is enabled despite the well documented problems with the current design on T111565.
$config['collapsible'] = true;
$config['selectorLogoutLink'] = 'a.menu__item--logout[data-mw="interface"]'; $config['selectorLogoutLink'] = 'a.menu__item--logout[data-mw="interface"]';
} }
} }