From 5b48e1665ab94eef4e952e3777abdf2654801f7a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Tue, 22 Nov 2022 20:29:22 +0100
Subject: [PATCH] Allow collapsible content in Minerva

Too many projects including notably English Wikipedia are now
enabling this code via gadget, which will make addressing this
problem more difficult in future, by providing an unpredictable
development/testing environment
it would be better if this reflected production, even with the fat
finger problem.

Bug: T323639
Bug: T111565
Change-Id: I81aa514a211710d0eec45329e3e3c7ee331da6ea
---
 includes/Hooks.php | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/includes/Hooks.php b/includes/Hooks.php
index dd59be670..6e0eb5d83 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -269,8 +269,6 @@ class Hooks implements
 	/**
 	 * SkinPageReadyConfig hook handler
 	 *
-	 * Disable collapsible on page load
-	 *
 	 * @param Context $context
 	 * @param mixed[] &$config Associative array of configurable options
 	 */
@@ -280,7 +278,10 @@ class Hooks implements
 	): void {
 		if ( $context->getSkin() === 'minerva' ) {
 			$config['search'] = false;
-			$config['collapsible'] = false;
+			// Enable collapsible styles on Minerva. Projects are already doing this via gadgets
+			// which creates an unpredictable testing environment so it is better to match production.
+			// NOTE: This is enabled despite the well documented problems with the current design on T111565.
+			$config['collapsible'] = true;
 			$config['selectorLogoutLink'] = 'a.menu__item--logout[data-mw="interface"]';
 		}
 	}