wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 06:13:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicate icon loading

Browse source 
"login", "watchlist" and "logout" in skins.minerva.personalMenu.icons
are already defined inside skins.minerva.mainMenu.icons which is
loaded on all page views via CSS so we are loading this icon twice for
no obvious reason. This is why ResourceLoader modules should never reference
files outside their own module folder!

Change-Id: I2097802cc2d42483ef4bdd1ccfa05e0f7b1bcad4
This commit is contained in:
jdlrobson 2020-02-07 10:47:44 +08:00
parent 6e4c6c99bc
commit 041091864d
1 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
skin.json
View file

@ -493,19 +493,6 @@
"selector": ".mw-ui-icon-minerva-{name}:before", "selector": ".mw-ui-icon-minerva-{name}:before",
"defaultColor": "#4A4F53", "defaultColor": "#4A4F53",
"images": { "images": {
"login": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/logIn-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/logIn-rtl.svg"
}
},
"logout": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/logOut-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/logOut-rtl.svg"
}
},
"watchlist": "resources/skins.minerva.mainMenu.icons/watchlist.svg",
"userSandbox": "resources/skins.minerva.personalMenu.icons/userSandbox.svg" "userSandbox": "resources/skins.minerva.personalMenu.icons/userSandbox.svg"
} }
}, },