From 041091864d3ce395d9871aa375198d96771b18f5 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Fri, 7 Feb 2020 10:47:44 +0800 Subject: [PATCH] Remove duplicate icon loading "login", "watchlist" and "logout" in skins.minerva.personalMenu.icons are already defined inside skins.minerva.mainMenu.icons which is loaded on all page views via CSS so we are loading this icon twice for no obvious reason. This is why ResourceLoader modules should never reference files outside their own module folder! Change-Id: I2097802cc2d42483ef4bdd1ccfa05e0f7b1bcad4 --- skin.json | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/skin.json b/skin.json index 580ba7d0e..fc2623c4c 100644 --- a/skin.json +++ b/skin.json @@ -493,19 +493,6 @@ "selector": ".mw-ui-icon-minerva-{name}:before", "defaultColor": "#4A4F53", "images": { - "login": { - "file": { - "ltr": "resources/skins.minerva.mainMenu.icons/logIn-ltr.svg", - "rtl": "resources/skins.minerva.mainMenu.icons/logIn-rtl.svg" - } - }, - "logout": { - "file": { - "ltr": "resources/skins.minerva.mainMenu.icons/logOut-ltr.svg", - "rtl": "resources/skins.minerva.mainMenu.icons/logOut-rtl.svg" - } - }, - "watchlist": "resources/skins.minerva.mainMenu.icons/watchlist.svg", "userSandbox": "resources/skins.minerva.personalMenu.icons/userSandbox.svg" } },