wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-15 02:13:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/skin.json

664 lines
18 KiB
JSON
Raw Normal View History

Add scaffolding for skin Change-Id: Ie9420dc85f658fa21a1524dca9374cb1e14fcad7
2017-04-11 02:30:17 +00:00
{
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"name": "MinervaNeue",
"namemsg": "skinname-minerva",
"descriptionmsg": "minerva-skin-desc",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"author": [
Update link target of the team page Link redirected on mediawiki.org Change-Id: Icdd1ffdb7b60d5030a29fa24d2ad5b8e10d4975c
2022-08-05 12:54:00 +00:00
"[https://www.mediawiki.org/wiki/Readers/Web/Team Readers Web Team]",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Alex Hollender",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"Bahodir Mansurov",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Florian Schmidt",
"Jan Drewniak",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"Joaquin Hernandez",
"Jon Robson",
"Juliusz Gonera",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Piotr Miazga",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"Ryan Kaldari",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Nick Ray",
"Sam Smith",
"Stephen Niedzielski",
"Volker E."
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
],
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"type": "skin",
"url": "https://www.mediawiki.org/wiki/Skin:MinervaNeue",
"license-name": "GPL-2.0-or-later",
"requires": {
Replace Action::getActionName by IContextSource::getActionName IContextSource::getActionName exists since 3fdfef9 and returns a cached action name, while Action::getActionName determine the action name every time it is called. Change-Id: I1390e6b6ecb7606480618dd5792cb0c446e048c1
2022-04-15 21:05:22 +00:00
"MediaWiki": ">= 1.38.0"
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"config": {
Mobile web donate link Add the Donate link with a heart icon in Mobile menu. Bug: T219793 Change-Id: I65d1d7408e2df7b3ae307736ac6d498b1d7f7197
2020-06-17 18:07:02 +00:00
"MinervaDonateLink": {
Donate link should be in a separate group in main menu Bug: T219793 Change-Id: I7501c87eaa799e4c8a9052f5e3f650a89f376d1b
2020-06-25 21:06:46 +00:00
"value": {
Donate link is disabled by default for 3rd parties Bug: T191743 Change-Id: I2b57cd3fa270fab1385319f2cbd33e886ae33843
2021-12-10 19:21:14 +00:00
"base": false
Donate link should be in a separate group in main menu Bug: T219793 Change-Id: I7501c87eaa799e4c8a9052f5e3f650a89f376d1b
2020-06-25 21:06:46 +00:00
}
Mobile web donate link Add the Donate link with a heart icon in Mobile menu. Bug: T219793 Change-Id: I65d1d7408e2df7b3ae307736ac6d498b1d7f7197
2020-06-17 18:07:02 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaDownloadNamespaces": {
"value": [
0
]
},
Revert "Drop MinervaEnableSiteNotice" This reverts commit 33e5c1eb79868d799abffc0ba032f2b6369e6209. I talked to Gergo (tgr) about this and he's convinced me that probably I want to be more conservative and incremently roll the sitenotices out first. With that in mind I'm going to revert this change and do a config flag instead. Bug: T254391 Change-Id: If0f214d23a012fb4ae3e1dff1728f746a22f142a
2020-06-04 22:39:36 +00:00
"MinervaEnableSiteNotice": {
Change default of showing sitenotices to true Wikimedia-related configuration (false) now lives in mediawiki-config which allows us to move this value to the default of true, which should fit most other wikis better. Change-Id: I8060ed5e67370e35f7552b3191f2864fbeb6418e
2020-12-01 22:18:44 +00:00
"value": true
Revert "Drop MinervaEnableSiteNotice" This reverts commit 33e5c1eb79868d799abffc0ba032f2b6369e6209. I talked to Gergo (tgr) about this and he's convinced me that probably I want to be more conservative and incremently roll the sitenotices out first. With that in mind I'm going to revert this change and do a config flag instead. Bug: T254391 Change-Id: If0f214d23a012fb4ae3e1dff1728f746a22f142a
2020-06-04 22:39:36 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaApplyKnownTemplateHacks": {
Enable wgMinervaApplyKnownTemplateHacks by default to reflect production This will give consistent bundle sizes across CI Bug: T283182 Change-Id: Ife597ad5e6f160e4fa576041caffc672f3bfcf55
2021-05-27 20:06:08 +00:00
"value": true
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
},
"MinervaAlwaysShowLanguageButton": {
"value": true
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"MinervaTalkAtTop": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"loggedin": true
}
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
},
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
"MinervaAdvancedMainMenu": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
},
"MinervaPersonalMenu": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
},
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
"MinervaHistoryInPageActions": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"loggedin": true
}
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
},
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"MinervaOverflowInPageActions": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
skin.json: Add value to MinervaOverflowInPageActions Added the loggedin value to MinervaOverflowInPageActions to enable the overflow menu for all logged in users. Bug: T308675 Change-Id: Ic19308c423efc40c70490fed474bee69f1972bca
2022-05-31 18:03:51 +00:00
"amc": true,
"loggedin": true
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
}
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Replace categories button with HTML rendering Bug: T246049 Change-Id: Id8c7493a525844b43c1628a1f4f09ae716ece2ba
2021-04-28 21:58:51 +00:00
"MinervaShowCategories": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
Category feature not ready for logged in users When removing the category overlay this for AMC as part of Id8c7493a525844b43c1628a1f4f09ae716ece2ba the feature was enabled for logged in users unintentionally. Bug: T246049 Change-Id: I1be90b22afa1f6ad5094131485b38253d422cb11
2021-06-21 20:57:12 +00:00
"loggedin": false,
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"amc": true
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
"MinervaPageIssuesNewTreatment": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": true,
"beta": true
}
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaABSamplingRate": {
"value": 0
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"ValidSkinNames": {
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
"minerva": {
Namespace SkinMinerva Change-Id: I8f6bddac9f8cd060c551651e711ee987b8bbfbe3
2022-03-04 16:40:54 +00:00
"class": "MediaWiki\\Minerva\\Skins\\SkinMinerva",
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
"args": [ {
"name": "minerva",
"templateDirectory": "includes/Skins",
"messages": [
Restore title to mobile skin without logo Bug: T290525 Change-Id: I6eb120a08d15b308d2a4df99900ab86042612b0c
2021-10-20 20:40:16 +00:00
"sitetitle",
Use skin.json to define messages instead of MinervaTemplate Bug: T290343 Change-Id: I8daef594ac9efb80f07437c5d8ef5459c37e2ff3
2021-10-07 21:30:29 +00:00
"mainpage",
Generate Minerva search HTML with SkinMustache data Bug: T290525 Change-Id: I68cde34a41a610872a585f5548dbaf66e3515443
2021-10-13 19:19:34 +00:00
"searchbutton",
Use skin.json to define messages instead of MinervaTemplate Bug: T290343 Change-Id: I8daef594ac9efb80f07437c5d8ef5459c37e2ff3
2021-10-07 21:30:29 +00:00
"minerva-user-navigation",
"mobile-frontend-main-menu-button-tooltip",
"mobile-frontend-footer-sitename"
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
],
Mark menus as supported in Minerva Follow up to 44a93ed39 Currently the Skin menu code is forgiving, but it is important to list menus in skin.json so that Skin::supportsMenu works as expected. Without this, other extensions/skins cannot tell if Minerva supports this menu and therefore cannot act accordingly Bug: T319396 Change-Id: I314df011b0c88e9f10842fb445cd7c015dbe5f8a
2022-10-05 20:28:36 +00:00
"menus": [
"notifications",
"associated-pages"
],
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
"responsive": true,
"link": {
"text-wrapper": {
"tag": "span"
}
}
} ]
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
"AutoloadNamespaces": {
Move some more classes to AutoloadNamespaces Bug: T187154 Change-Id: Ia78f963a08cec1490aaff462b9787f7a826bf62c
2020-04-18 15:52:04 +00:00
"MediaWiki\\Minerva\\": "includes/"
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
},
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
"ConfigRegistry": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": "GlobalVarConfig::newInstance"
},
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
"HookHandlers": {
"main": {
"class": "MediaWiki\\Minerva\\Hooks"
}
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"Hooks": {
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
"BeforePageDisplay": "main",
"ResourceLoaderRegisterModules": "main",
"SkinPageReadyConfig": "main",
"UserLogoutComplete": "main",
"FetchChangesList": "main",
Enable Simplified Talk Page only on Pages With Expandable Sections This patch should knock out two bugs we were seeing with the simplified talk page: 1) Removes the "Add discussion" button and "There are no discussions" message from appearing on Flow enabled talk pages. 2) Removes the "Read as wiki page" and "Active Discussions"/"There are no discussions" message we were seeing on Minerva desktop talk pages. To address when the "There are no dicussions"/"Active Discussions" message and "Read as wikipage" button are displayed, Minerva now listens to MobileFrontend's `MobileFrontendBeforeDOM` hook and turns on the simplified talk page (via a skin option) when this hook runs. To address when the "Add discussion" button is added, a check was added to SkinMinerva which only adds it to a talk page if the content model is wikipage. Unfortunately, we can't just check the skin option because we also want to display the button on desktop minerva. Other changes: * Moves around the logic in `getTalkPagePostHeadingHTML` for improved readability Bug: T237589 Bug: T237597 Change-Id: I83fd5cab174d90b24a5335f2b30c912c3b68040a
2019-11-13 01:48:59 +00:00
"MobileFrontendBeforeDOM": [
Namespace two more classes Change-Id: Id32beb98df0f37ced858c17196517f65b64a041c
2022-02-15 18:40:10 +00:00
"MediaWiki\\Minerva\\Hooks::onMobileFrontendBeforeDOM"
Enable Simplified Talk Page only on Pages With Expandable Sections This patch should knock out two bugs we were seeing with the simplified talk page: 1) Removes the "Add discussion" button and "There are no discussions" message from appearing on Flow enabled talk pages. 2) Removes the "Read as wiki page" and "Active Discussions"/"There are no discussions" message we were seeing on Minerva desktop talk pages. To address when the "There are no dicussions"/"Active Discussions" message and "Read as wikipage" button are displayed, Minerva now listens to MobileFrontend's `MobileFrontendBeforeDOM` hook and turns on the simplified talk page (via a skin option) when this hook runs. To address when the "Add discussion" button is added, a check was added to SkinMinerva which only adds it to a talk page if the content model is wikipage. Unfortunately, we can't just check the skin option because we also want to display the button on desktop minerva. Other changes: * Moves around the logic in `getTalkPagePostHeadingHTML` for improved readability Bug: T237589 Bug: T237597 Change-Id: I83fd5cab174d90b24a5335f2b30c912c3b68040a
2019-11-13 01:48:59 +00:00
],
Minerva should use FeatureManagers class Bug: T182362 Depends-On: I6cc4a2ebcd75c054294daf329d94d35a02e50f8e Change-Id: I6ba5bf49b9060c31ad2224a437072b3426a45619
2018-01-08 22:18:16 +00:00
"MobileFrontendFeaturesRegistration": [
Namespace two more classes Change-Id: Id32beb98df0f37ced858c17196517f65b64a041c
2022-02-15 18:40:10 +00:00
"MediaWiki\\Minerva\\Hooks::onMobileFrontendFeaturesRegistration"
Minerva should use FeatureManagers class Bug: T182362 Depends-On: I6cc4a2ebcd75c054294daf329d94d35a02e50f8e Change-Id: I6ba5bf49b9060c31ad2224a437072b3426a45619
2018-01-08 22:18:16 +00:00
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"RequestContextCreateSkinMobile": [
Namespace two more classes Change-Id: Id32beb98df0f37ced858c17196517f65b64a041c
2022-02-15 18:40:10 +00:00
"MediaWiki\\Minerva\\Hooks::onRequestContextCreateSkinMobile"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
hooks: implement PreferencesGetLayout Use mobile layout in Special:Preferences Bug: T320586 Depends-On: I468481b66bf96880d1779cd11a46e18745e2c894 Change-Id: Ic6aa01e6e8806d1f2be8e07ca6c83decd62bc641
2022-10-12 13:37:28 +00:00
"PreferencesGetLayout": "main",
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
"SpecialPageBeforeExecute": "main",
"ResourceLoaderGetConfigVars": "main",
"OutputPageBodyAttributes": "main"
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
styles: Implement mediawiki.skin.variables.less for MinervaNeue For now, only define: - @font-family-sans (unused in MinervaNeue, but for possible future use) - @border-radius-base With current implementation before this patch, MinervaNeue is relying on core's default `@border-radius` which is set to `0` to be close to HTML default. MinervaNeue is currently not applying correct skin's `border-radius`. Bug: T263270 Change-Id: I9a149eefd15efede27416ada4db07072e53628ec
2020-09-25 18:17:15 +00:00
"SkinLessImportPaths": {
"minerva": "resources/mediawiki.less"
},
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
"MessagesDirs": {
"MinervaNeue": [
"i18n"
]
},
"ResourceFileModulePaths": {
"localBasePath": "",
"remoteSkinPath": "MinervaNeue"
},
"ResourceModuleSkinStyles": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": {
Fixes issue with height in slideshow Depends-On: I5c372f8b1bbc44af9c5855baa7ee825ff42fbc96 Bug: T194887 Change-Id: I3904bb158eebe96983ce3318e1e39a6f056624fd
2023-01-06 18:05:42 +00:00
"mediawiki.page.gallery.slideshow": [
"skinStyles/mediawiki.page.gallery.slideshow.less"
],
Move skinStyle from Echo to Minerva Bug: T257143 Change-Id: I1999185d19e171900f2da5acbd39125013d3582c
2022-11-19 00:13:40 +00:00
"ext.echo.styles.badge": [
"skinStyles/ext.echo.styles.badge.less"
],
Move css styles related to lazy-image-placeholder to skinStyles `lazy-image-placeholder` is needed only when MobileFrontend is enabled. So it makes sense to move those styles to mobile.init css. See more details here: T199351#6380240 Bug: T260406 Change-Id: I16ca734af33fb0f3c4c67f20bbca8631279d7778
2020-08-14 07:03:46 +00:00
"mobile.init.styles": [
"skinStyles/mobile.init.styles/mobile.less"
],
Remove MinervaTemplate::getContentHtml * Move method to SkinMinerva * Turn preparePageContent into a getter that returns the subject page * Use getSubjectPage in template For mobile special pages this now means the page has two .content elements On those pages I've disabled the initial content element. It also means various .content <heading> and .content ul rules now apply that need to be disabled. While testing several other issues were taken care of - for example the h2 in errors Depends-On: I7761396d6a33830f279742be01240796573556a7 Bug: T291871 Change-Id: I13bc4b5dae7aed86eca31ef306212365e1759481
2021-10-04 22:03:29 +00:00
"mobile.special.nearby.styles": [
"skinStyles/mobile.special.nearby.styles.less"
],
Diff styles for moving paragraphs and empty lines * Fix styling of empty lines - cover full width * Disable the pseudo element shipped in core * Move styles from mobile.special.mobilediff.styles into mediawiki.diff.styles since the latter is always present, the former isn't if MobileFrontend is not available. Bug: T242310 Bug: T243235 Change-Id: Ic7d12fe890622e7b3ccc7bc56765f505ac0ab651
2020-01-20 21:47:19 +00:00
"mediawiki.diff.styles": [
"skinStyles/mediawiki.diff.styles.less"
],
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"mediawiki.searchSuggest": [
"skinStyles/mediawiki.searchSuggest/index.less"
],
🐛 Bug: Fix iOS input text zoom bug on rcfilters input On iOS Safari, the screen zooms in when the user focused on the text input of the rcfilters overlay. This commit adds a quickfix to address this problem by setting the font-size to its initial value (assumed to be 16px). Bug: T231049 Change-Id: I98d28115e570a11d08ba2bd189c0b9151f834e7d
2019-09-02 15:58:33 +00:00
"mediawiki.rcfilters.filters.ui": [
"skinStyles/mediawiki.rcfilters.filters.ui.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.action.history.styles": [
"skinStyles/mediawiki.action.history.styles.less"
],
Revert back Minerva icon features not ready for production In Ifccaadabd72a12814d3d4d01200931f7254c6cd5 we made some modifications to the icon specification. I haven't run these by Alex yet (as focus is on Vector 2022) and don't want to rush them, so for now temporarily undoing those changes here. Changes: - Reverts icon touch areas from new 44x44 to old 46x46 - Undoes decrease in margins between labels and icons Bug: T319071 Change-Id: I9a02191c57b7e2d24a8bc909f820ba8db942c028
2022-10-03 23:50:08 +00:00
"+mediawiki.ui.icon": [
"skinStyles/mediawiki.ui.icon.less"
],
Add Minerva specific mediawiki.interface.helpers.styles.less file This SkinStyle file adds paranthases around the (diff|hist) links and username(talk|contrib|block) links on special pages. Bug: T222394 Change-Id: Ic291cb795ccad556a5049d970c0282b2d4c65a11
2019-05-07 13:17:04 +00:00
"mediawiki.interface.helpers.styles": [
"skinStyles/mediawiki.interface.helpers.styles.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.rcfilters.highlightCircles.seenunseen.styles": [],
Separate ConfirmEdit styles from Login styles ConfirmEdit styles are migrated from mediawiki.special.userlogin.common.styles to ext.confirmEdit.fancyCaptcha.styles The text of the reload itself mirrors the progressive blue icon by being progressive itself A couple of tweaks to the form (padding) are made to preserve the form to its previous glorious status, other than that the file remains the same. Bug: T213775 Change-Id: I2322194481e4d6b7662c0f075768d5941afa98b8
2019-01-16 19:18:52 +00:00
"ext.confirmEdit.fancyCaptcha.styles": [
"skinStyles/ext.confirmEdit.fancyCaptcha.styles/minerva.less"
],
Optimise Special:MobileOptions for tablet display Bug: T180095 Change-Id: I0ef0ce914a360848f8f66b39c40588f3fa04647c
2017-12-01 18:52:02 +00:00
"mobile.special.mobileoptions.styles": [
"skinStyles/mobile.special.mobileoptions.styles/minerva.less"
],
Restrict gallery styles to only pages which need it The mediawiki.page.gallery.styles module is only loaded when needed, yet inside hacks.less we load gallery styles unconditionally. The hacks.less file is also only meant for css that overrides template styles, so it didn't belong there anyway. Change-Id: I4afc91ad7f67ae66544708d25541b3e8dd247873
2017-12-13 02:03:28 +00:00
"mediawiki.page.gallery.styles": [
"skinStyles/mediawiki.page.gallery.styles/tablet.less"
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special.userlogin.common.styles": [
"skinStyles/mediawiki.special.userlogin.common.styles/minerva.less"
],
"mediawiki.special.search.styles": [
"skinStyles/mediawiki.special.search.styles/minerva.less"
],
Always show search results at full width Ieebc40073eb3d0c8a56ebc8aec3f060199943ddc lowers the breakpoint at which search will break into 2 columns (search + interwiki), in large part because the 2nd column will also be occupied by Extension:SearchVue's side panel. On mobile, Extension:SearchVue presents differently (directly below a search result), so there's not as much need for a 2nd column this early - wider search results are prefered. Bug: T321377 Change-Id: I22c46cfad2e054be679d79cce9b8d1ae04e3c6f1
2022-12-14 14:29:31 +00:00
"mediawiki.special.search.interwikiwidget.styles": [
"skinStyles/mediawiki.special.search.interwikiwidget.styles/minerva.less"
],
Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles We need to load these only when VisualEditor is loaded. This is the best way to ensure that. They have been haphazardly placed in different files. The goal of this change is to move content styling for Minerva out of mobile.editor.ve/minerva.less, and thus to be able to move this file to mediawiki/extensions/MobileFrontend (T202978). But I spotted the other places while working on that. Moved as-is: * skins.minerva.content.styles/links.less * mobile.editor.ve/minerva.less No longer needed: * skins.minerva.content.styles/text.less Parsoid now uses <sup> tags for references rather than <span>, so the existing rules for <sup> tags are enough. See T45094, <https://www.mediawiki.org/wiki/Specs/HTML/1.6.0/Extensions/Cite>. Was never needed: * skins.minerva.content.styles/thumbnails.less The styles from the core module 'mediawiki.skinning.content.parsoid' are never loaded, so we don't need to override them. Bug: T202978 Change-Id: I45e1cb89b65a41a29d2b1a361a79199745ccec14
2018-09-17 20:56:57 +00:00
"mediawiki.skinning.content.parsoid": [
"skinStyles/mediawiki.skinning.content.parsoid/minerva.less"
],
Minerva should use mediawiki.hlist Override provided styles Bug: T42062 Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028 Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-06-01 23:09:24 +00:00
"mediawiki.hlist": [
"skinStyles/mediawiki.hlist/minerva.less"
Icon pseudo elements need top: 0 for RTL languages Document why so it doesn't get removed next time. Bug: T232260 Change-Id: I09cac0403c913e5ff10dfede9355a08f226f395d
2019-09-09 20:42:56 +00:00
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.languages.structured": [
Refactor LanguageOverlay styles In I629245100f4ca430a88e450939b90d075e7021f1, languageOverlay styles and LanguageSearcher styles were split into two different files. This commit mimics that change in skinStyles. All languageOverlay specific styles were moved to languageOverlay.less, while all LanguageSearcher styles were moved to LanguageSearcher.less. Other chagnes: * Changed a reference in init.js Bug: T215657 Change-Id: I395a61cd6051ad5c6b6601205f112b55f5ab8273
2019-02-22 17:59:56 +00:00
"skinStyles/mobile.languages.structured/LanguageSearcher.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"mobile.startup": [
Import all skinStyles/mobile.startup into mobile.startup.less This mimics the structure we follow in MobileFrontend's mobile.startup folder where we have a mobile.startup.js that imports all the mobile.startup files. Bug: T215657 Change-Id: Id7faa45adce7c5aa870d0f7c92f70d39995adac0
2019-02-22 18:15:34 +00:00
"skinStyles/mobile.startup/mobile.startup.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special": [
"skinStyles/mobile.special.styles/minerva.less"
],
Mobile Preferences: Add styles for Special:Preferences mobile Added a stylesheet for when a user views Special:Preferences in mobile Bug: T311717 Depends-On: Ia7a730cd7f009dbb921a810f27fae4a9ee66f793 Change-Id: I83558ca5de50fa7d8c7d75572ffa1c600f660d66
2022-08-13 02:50:53 +00:00
"mediawiki.special.preferences.styles.ooui": [
"skinStyles/mediawiki.special.preferences.styles.ooui/minerva.less"
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mobile.special.styles": [
"skinStyles/mobile.special.styles/minerva.less"
],
Set editfont size to 16px (100%) Change-Id: I9bff880de792da756f14726042df0a0df4139d1b
2018-04-02 20:06:27 +00:00
"mediawiki.editfont.styles": [
"skinStyles/mediawiki.editfont.styles/minerva.css"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.notification": [
Dev: Prep for storybook * Remove ambiguity in imports - say the file extension 'less' for all instances of variables and mixins. * Separate toast styles from drawer styles so they can be imported separately * associate header-action selector with its parent (.overlay-header) not parent's parent (.overlay) so it can be imported and rendered without the Overlay. Change-Id: Ib7e19a440ba095d6424d35305fb41d643ca9764c
2019-08-08 20:01:03 +00:00
"skinStyles/mobile.startup/drawers.less",
Center and align the expiry dropdown in watchstar widget Move the watchlist expiry dropdown list to be aligned in the centre, and its contents to be left-aligned. Bug: T261990 Change-Id: I3073618606636c78e6afb5bf19726c7b3973292b
2020-09-21 04:57:44 +00:00
"skinStyles/mobile.startup/toast.less",
"skinStyles/mediawiki.watchstar.widgets.css"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"mediawiki.action.edit.styles": [
"skinStyles/mediawiki.action.edit.styles/minerva.less"
],
JSON content: Fix table margins Change-Id: I50a2203adb66e634f9d995225075dc29a34ab4dd
2019-05-03 15:27:33 +00:00
"mediawiki.content.json": [
"skinStyles/mediawiki.content-json/minerva.less"
Adding skin styles for the changeslist module. The changeslist module is the list of results on special pages such as recent changes, watchlist, and parts of action history. Adds a skin style to special.changeslist module. Bug: T228419 Change-Id: I324b1f136f5314cb6acdba3155b07136bbde363a
2019-07-29 09:50:05 +00:00
],
"mediawiki.special.changeslist": [
Fix style of clock icon in changes lists Override core styles for the watchlist expiry clock icon in Recent Changes and Watchlists. Bug: T261415 Depends-On: I621b1571b57686beb9fb5802533b1e70d293bc2a Change-Id: Iefdd271aeb6135771aae832e930fe02c73248110
2020-09-23 02:15:08 +00:00
"skinStyles/mediawiki.special.changeslist.less",
"skinStyles/mediawiki.special.changeslist.watchlistexpiry.less"
Adding skin styles for the changeslist module. The changeslist module is the list of results on special pages such as recent changes, watchlist, and parts of action history. Adds a skin style to special.changeslist module. Bug: T228419 Change-Id: I324b1f136f5314cb6acdba3155b07136bbde363a
2019-07-29 09:50:05 +00:00
],
"mediawiki.special.changeslist.legend": [
"skinStyles/mediawiki.special.changeslist.legend.less"
Add max-width limit to empty watchlist page On the Watchlist, when there are no results, the page uses .info and .empty-page classes. This results in text running without max-length. Add max-width rule to contain it. Bug: T222872 Change-Id: I768f800a49e756da1ad2c123c842c37d18fa3310
2021-01-21 13:43:39 +00:00
],
"mobile.special.pagefeed.styles": [
"skinStyles/mobile.special.pagefeed.styles.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
}
},
"ResourceModules": {
"skins.minerva.base.styles": {
Move skins.minerva.content.styles into skins.minerva.base.styles This could be made even simpler by not using a LESS varialbe for hacks.less, but loading it conditionally through the moduel def. But, as a first step we can merge the two as-is. Given that the subject and target are always referenced together in page views, there is no need to keep an alias around. However, I'm keeping it anyway so as to not produce any `/* {"skins.foo":"missing"} */` appendix to the stylesheet response for these cached URLs. Bug: T266361 Change-Id: I8578faab8ca32bd49be90711cbd5e182763b8065
2021-04-29 01:01:54 +00:00
"class": "MediaWiki\\Minerva\\ResourceLoaderSkinModule",
Minerva should respect reduces motion setting Depends-On: Ie1c6c1ba7263c232d874263fdae7427a5ec489f6 Change-Id: Ic08a5f7f60c4b09aab50611d990842a75cbbc7cd
2022-05-10 22:06:25 +00:00
"features": [ "accessibility", "i18n-ordered-lists", "content-body", "content-links" ],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
"styles": [
Move skins.minerva.content.styles into skins.minerva.base.styles This could be made even simpler by not using a LESS varialbe for hacks.less, but loading it conditionally through the moduel def. But, as a first step we can merge the two as-is. Given that the subject and target are always referenced together in page views, there is no need to keep an alias around. However, I'm keeping it anyway so as to not produce any `/* {"skins.foo":"missing"} */` appendix to the stylesheet response for these cached URLs. Bug: T266361 Change-Id: I8578faab8ca32bd49be90711cbd5e182763b8065
2021-04-29 01:01:54 +00:00
"resources/skins.minerva.base.styles/skin.less",
"resources/skins.minerva.base.styles/content/index.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"skins.minerva.content.styles.images": {
"class": "ResourceLoaderImageModule",
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"selectorWithoutVariant": "{name}",
"selectorWithVariant": "{name}--{variant}",
External link icons should use defaultColor Depends-On: I0745e112d11026ed59d8daca990b313305cd094a Bug: T197909 Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-26 23:25:31 +00:00
"defaultColor": "#36c",
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"variants": {
"reference": {
icons: Put reference variant only on external link icon Change-Id: I94587e0695b211b6a92ddf155ab1dd2991c17739
2021-03-24 10:47:32 +00:00
"color": "#69f"
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
}
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"images": {
Fix external icon specificity We've changed the selector in MW core to `.mw-parser-output a.external` a while ago. In order to show the correct image, selector needs to be amended. Change-Id: I83d7b4c8be2eda1876959d000e0fb2d493e12cbc
2021-11-09 07:13:02 +00:00
"toast.mw-notification-type-error, .mw-notification.mw-notification-type-error":
Dev: Address some FIXMEs * Drop non-existent pointer-overlay selector * Drop redundant icon class for arrow * Drop unnecessary !important * Drop transparent-shield class * Reword an existing FIXME about a contensious decision and add a new FIXME for moving some code to a more appropriate place. * Move an image into a ResourceLoaderImage module (test with `mw.notify('error', { type: 'error'} )`) Change-Id: I6e38f07772afae6f13c4851ca17a67d52ca7d331
2020-02-03 08:15:44 +00:00
"resources/skins.minerva.content.styles.images/error.svg",
Fix external icon specificity We've changed the selector in MW core to `.mw-parser-output a.external` a while ago. In order to show the correct image, selector needs to be amended. Change-Id: I83d7b4c8be2eda1876959d000e0fb2d493e12cbc
2021-11-09 07:13:02 +00:00
"a.external, .mw-parser-output a.external": {
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"file": {
"ltr": "resources/skins.minerva.content.styles.images/link-external-ltr.svg",
"rtl": "resources/skins.minerva.content.styles.images/link-external-rtl.svg"
icons: Put reference variant only on external link icon Change-Id: I94587e0695b211b6a92ddf155ab1dd2991c17739
2021-03-24 10:47:32 +00:00
},
"variants": [
"reference"
]
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
}
}
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.icons.loggedin": {
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"targets": [
"mobile",
"desktop"
],
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"defaultColor": "#54595d",
"variants": [],
"selectorWithoutVariant": ".mw-ui-icon-wikimedia-{name}-base20:before",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
"bellOutline"
]
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"skins.minerva.amc.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
"resources/skins.minerva.amc.styles/index.less"
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
]
},
Use standardized icon classes and fix some missing icons The icon pack wikimedia.ui was strangely using a non-standard icon class using empty strings as a way to disable the default behaviour of setIcon. Instead of fighting APIs - use the methods available. The icon pack is also renamed to reflect what it's actually used for - providing icons for overflow menus and it is no longer loaded as a dependency by skins.minerva.scripts Fixes issues with: * History icon with AMC disabled and user is logged in * Table of contents icon * Language icon when it appears in overflow menu on user pages when logged in where AMC is disabled * listBullet appears in 2 modules as it is used in 2 places - the AMC overflow menu (log icon on user overflow menu) and for table of contents (JS only) Bug: T232383 Change-Id: I05220ffa56195be6a594e3a8a57ae16858088444
2020-04-01 23:25:04 +00:00
"skins.minerva.overflow.icons": {
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"useDataURI": false,
Use wikimedia.ui from core directly There's no reason to copy and paste all this here. These icons can be imported directly from core using ResourceLoaderOOUIIconPackModule Depends-On: I7800da87a6a10399f705b43e05c8592c766bae6f Change-Id: I1f25aaca9b7313cd95cefc7f5629b8a7e65c887f
2019-07-12 15:38:41 +00:00
"defaultColor": "#54595d",
"class": "ResourceLoaderOOUIIconPackModule",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
Add block button to user namespace overflow Bug: T307341 Change-Id: Ib8bcca0ab284900eff01468a416177435f02e7aa
2022-05-03 15:54:16 +00:00
"block",
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
"ellipsis",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"articleRedirect",
"infoFilled",
"link",
Allow Users with permissions to do expanded actions in Minerva on mobile Allow Users with the needed permissions to delete, protect or move pages in Minerva on mobile version. Bug: T231291 Change-Id: I1e438b7d3683d288a8a6c5a9f5dcea6b3b3d9f71
2021-03-09 19:43:14 +00:00
"move",
"lock",
"trash",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"listBullet",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"logoWikidata",
"quotes",
User menu overflow: add change block and unblock Added the "Change block" and "Unblock user" to the array of possible menu entries for the overflow menu. These buttons will only appear when a user is already blocked. Bug: T308570 Change-Id: I987083cfeb20a0c691d3fc631a9c844647fec9bf Depends-On: If60a1194d63fff2b7b5ae1565be25a3b7b44fdf1
2022-06-28 23:07:21 +00:00
"unBlock",
Menu: Add "unprotect" action when current user is an admin Accidentally via T231291, a regression was introduced such that, in AMC mode, when a page is protected to be edited only by admins, a corresponding unprotect action is not avaiable to reverse the protect action. This patch fixes that regression. Have tested locally and it works as expected. Bug: T285567 Change-Id: Ie20ca5d9c43fa54dff5d699eb59679585283bdb5
2021-06-30 17:20:39 +00:00
"unLock",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"userAvatarOutline",
"userTalk",
"userAvatar",
"userGroup"
]
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
},
"skins.minerva.icons.wikimedia": {
Remove watch and watched icons from repository in favor of Wikimedia UI Note, because of the two versions of the watch icon, this will temporarily make the watchstar not display for JavaScript users. The accompanying patch Ic974b4d6dff14b0d72b8ca71b02c5ef73b1b1d93 will restore this. Bug: T231613 Change-Id: I16ca70f2892d7418ff245e15f838dfc2b092f3aa
2019-09-17 21:30:33 +00:00
"selectorWithVariant": ".mw-ui-icon-wikimedia-{name}-{variant}:before",
[Refactor] Use core definitions for personal menu icons Rather than hardcoding the icons for all our menu items let's use the definitions in core. This also makes it easier for us to deprecate the MobileMenu hook in future. Rejoice at all the code this removed! Bug: T291568 Change-Id: I69b5ca13aee018982a5ea28677d4a37e663235d4
2022-01-13 00:38:16 +00:00
"selectorWithoutVariant": ".mw-ui-icon-wikimedia-{name}-base20:before, .mw-ui-icon-minerva-{name}:before, .mw-ui-background-icon-{name}",
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"useDataURI": false,
"defaultColor": "#54595d",
Add yellow talk page message warning to non-main namespace pages Bug: T284642 Change-Id: I2895975efe1d09d228f80aff74381e88034a0137
2021-10-25 20:40:47 +00:00
"variants": {
Fix last modified bar icon change and search unStar-progressive In b4fd1498bc we set a variant, which dropped the default global progressive and invert variants. This is turn, made the mobile watchstar on search disappear when selected. Here we restore those icon variants, and take the time to refactor the code so its more resilient against future icon changes. Change-Id: I1423fbf69dce87715c159877b5f536b4e8e13390
2021-11-01 21:00:19 +00:00
"progressive": {
"color": "#36c",
"global": true
},
"invert": {
"color": "#fff",
"global": true
},
Add yellow talk page message warning to non-main namespace pages Bug: T284642 Change-Id: I2895975efe1d09d228f80aff74381e88034a0137
2021-10-25 20:40:47 +00:00
"warning": {
"color": "#fc3",
"global": true
}
},
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
Rename several icons to WikimediaUI naming Renaming to WikimediaUI standard naming and adding to module skins.minerva.icons.wikimedia which is loaded via addModuleStyles 'edit' → 'editLock' 'edit-enabled' → 'edit' 'toc' → 'listBullet' (already included in wikimedia.ui module) 'mainmenu' → 'menu' 'language-switcher' → 'language' 'clock' → 'history' Icon `page-actions-overflow` which is only needed on AMC is moved out of the stable icon pack and added to skins.minerva.mainMenu.advanced.icons temporarily which is loaded on AMC pages only: 'page-actions-overflow' Additional changes: * Renaming 'clockIconClass' to 'historyIconClass' to stay on name. * Module `skins.minerva.icons.images` is deprecated and shipped for old HTML markup. It will be removed in 2 weeks. Bug: T232383 Change-Id: Ia3bafc74a85293c2414c0ef4ccf3bb20c75135d1
2020-03-25 02:02:02 +00:00
"edit",
"editLock",
"history",
"language",
"menu",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"search",
"userAvatar",
Add yellow talk page message warning to non-main namespace pages Bug: T284642 Change-Id: I2895975efe1d09d228f80aff74381e88034a0137
2021-10-25 20:40:47 +00:00
"userTalk",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"star",
Show half star for temporarily watched pages This does not complete watchlist expiry support in MinervaNeue. It only instructs the skin to show a half star instead of a full star on page load if the page is being temporarily watched. Bug: T251690 Change-Id: Ib5c479dcfe49041152ba662c56cc630c32eb220e
2020-08-24 21:49:04 +00:00
"halfStar",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"unStar"
]
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
"skins.minerva.icons.images.scripts.misc": {
Use 'download' icon from OOUI Bug: T244444 Change-Id: Ic65303b42c7b37c4017b98897139273f15ee1598
2020-03-27 01:27:46 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
"defaultColor": "#54595d",
Use standardized icon classes and fix some missing icons The icon pack wikimedia.ui was strangely using a non-standard icon class using empty strings as a way to disable the default behaviour of setIcon. Instead of fighting APIs - use the methods available. The icon pack is also renamed to reflect what it's actually used for - providing icons for overflow menus and it is no longer loaded as a dependency by skins.minerva.scripts Fixes issues with: * History icon with AMC disabled and user is logged in * Table of contents icon * Language icon when it appears in overflow menu on user pages when logged in where AMC is disabled * listBullet appears in 2 modules as it is used in 2 places - the AMC overflow menu (log icon on user overflow menu) and for table of contents (JS only) Bug: T232383 Change-Id: I05220ffa56195be6a594e3a8a57ae16858088444
2020-04-01 23:25:04 +00:00
"icons": [
"download",
"listBullet"
],
Use 'download' icon from OOUI Bug: T244444 Change-Id: Ic65303b42c7b37c4017b98897139273f15ee1598
2020-03-27 01:27:46 +00:00
"variants": []
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
},
"skins.minerva.icons.page.issues.uncolored": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"class": "ResourceLoaderImageModule",
Prefix icons in Minerva Changes: * MinervaUI will now prefix any icons with `minerva` * Update definitions in skin.json, retaining selectors for cached HTML for icons that are rendered via PHP. * In I9021c53c2c04bdd7ce395eed33d89986acbfea6d watch and watched and arrow are moved to MobileFrontend so are removed from the RL module skins.minerva.icons.images.scripts as they are not used directly in this repo. user and anonymous are no longer used so also removed. * Presentation of userpage now belongs to MobileFrontend. Icons are styles were moved there in depends on. They are retained in skin.json to support cached HTML as user pages are subject to cache. They can be removed in a week. * In code review we noticed the anonymous icon was badly named. We rename to login. No caching implications. * Main menu icons are now prefixed with minerva rather than mf to reflect where they come from. Depends-On: I9021c53c2c04bdd7ce395eed33d89986acbfea6d Bug: T182162 Change-Id: I93264024f4915fc910c792b1905b89cdc6b8b546
2018-01-05 18:52:17 +00:00
"selector": ".mw-ui-icon-minerva-{name}:before",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
"issue-severity-low-lowColor": "resources/skins.minerva.icons.page.issues.uncolored/issue-severity-low.svg",
"issue-type-move-defaultColor": "resources/skins.minerva.icons.page.issues.uncolored/issue-type-move.svg"
}
},
"skins.minerva.icons.page.issues.default.color": {
"class": "ResourceLoaderImageModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}-defaultColor:before",
"selectorWithVariant": ".mw-ui-icon-minerva-{name}-{variant}:before",
"defaultColor": "#54595d",
"variants": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"lowColor": {
"color": "#fc3",
"global": true
},
"mediumColor": {
"color": "#ff5d01",
"global": true
},
"highColor": {
"color": "#d33",
"global": true
}
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
},
"images": {
"issue-generic": "resources/skins.minerva.icons.page.issues.default.color/issue-generic.svg"
}
},
"skins.minerva.icons.page.issues.medium.color": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}-mediumColor:before",
"defaultColor": "#ff5d01",
"images": {
"issue-severity-medium": "resources/skins.minerva.icons.page.issues.medium.color/issue-severity-medium.svg",
"issue-type-point-of-view": "resources/skins.minerva.icons.page.issues.medium.color/issue-type-point-of-view.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.mainPage.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.mainPage.styles/common.less"
]
},
"skins.minerva.userpage.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.userpage.styles/userpage.less"
]
},
Render talk page as a tab instead of an overlay Following up on Jon's POC, this will get rid of the talk board component in favor of linking to the server rendered talk page. Additional Changes: * Cleaned up talk selenium tests. Removed talk_steps.rb which doesn't appear to be used anymore. * Changed talk add button classes to a single class * Moved "Add discussion" button to postheadinghtml per design mock * Added "...talk-explained", "...talk-explained-empty" messages to postheadinghtml per design mock * Due to undesirable jumps in window scroll caused by the section anchor & Toggler.js code when opening the TalkSectionOverlay (read fixme in code), a Promise is always returned from OverlayManager route to reset the scroll position to the top when the section overlay is opened. * Moved "mobile-frontend-talk-fullpage", "mobile-frontend-talk-reply-success", "mobile-frontend-talk-topic-feedback", "mobile-frontend-talk-explained" "mobile-frontend-talk-explained-empty" messages to minerva as minerva is the one who initiates those messages now. * Limited $talk selector to only `.talk` elements since amc talk tab does not need to be targeted * After saving a reply from TalkSectionOverlay, the DOM that is not part of the overlay becomes out of sync since a new reply was created. To get around this, an `onSaveComplete` callback was passed (similar to the TalkSectionAddOverlay) to execute a full page refresh. Although this is clunky, it is the easiest way to resync. Bug: T230695 Depends-On: I80201394fd7015db6700446142b0b4b20829f12e Change-Id: I243f1193bce0da9fa710fc3b5379f90b2d079680
2019-10-17 22:46:07 +00:00
"skins.minerva.talk.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.talk.styles/talkpage.less"
]
},
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"skins.minerva.personalMenu.icons": {
Use user sandbox icon from OOUI It's called 'markup'. Since this icon only ever shows to logged in users there are no caching implications. Bug: T244444 Change-Id: I75f5365ccb5a41f1c0628532e81b5ec63804a2a8
2020-02-07 03:11:56 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
Use standard palette color Base20 for icons Bug: T240500 Change-Id: I31302acb6dded8b367cff87e35df2ccbc30b4749
2020-04-21 03:23:37 +00:00
"defaultColor": "#54595d",
Remove markup icon code Bug: T288928 Depends-on: I553bbcc9f1a98d75e160ede7a66ffcf6510fa28a Change-Id: Ida0c41d2dab229e882c5e78e5702cc921bbdb928
2021-11-23 17:25:22 +00:00
"icons": [ "sandbox" ],
Use user sandbox icon from OOUI It's called 'markup'. Since this icon only ever shows to logged in users there are no caching implications. Bug: T244444 Change-Id: I75f5365ccb5a41f1c0628532e81b5ec63804a2a8
2020-02-07 03:11:56 +00:00
"variants": []
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
},
"skins.minerva.mainMenu.advanced.icons": {
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
Use standard palette color Base20 for icons Bug: T240500 Change-Id: I31302acb6dded8b367cff87e35df2ccbc30b4749
2020-04-21 03:23:37 +00:00
"defaultColor": "#54595d",
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
"icons": [
"recentChanges",
"specialPages",
"speechBubbles"
],
"variants": []
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
},
"skins.minerva.mainMenu.icons": {
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"variants": [],
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
Use standard palette color Base20 for icons Bug: T240500 Change-Id: I31302acb6dded8b367cff87e35df2ccbc30b4749
2020-04-21 03:23:37 +00:00
"defaultColor": "#54595d",
Do not use data URI on main menu icons data URIs increase CSS payload which delays render time. If we want to render these by default in the new main menu we will need to stop using data URIs. Bug: T225213 Change-Id: I876317ac28837fae48f504bb8d2637e0e7b85154
2019-11-26 23:11:02 +00:00
"useDataURI": false,
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
"icons": [
"die",
Mobile web donate link Add the Donate link with a heart icon in Mobile menu. Bug: T219793 Change-Id: I65d1d7408e2df7b3ae307736ac6d498b1d7f7197
2020-06-17 18:07:02 +00:00
"heart",
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
"home",
"logIn",
"logOut",
"mapPin",
"settings",
"userContributions",
Add the watchlist icon to Minerva Bug: T289619 Depends-On: I5b1af082503fe22ec6049784fc43b324534c5b95 Change-Id: If8d1fc44327ca89ba34b55ec66bf321db3e7fbdd
2022-01-13 21:04:03 +00:00
"unStar",
"watchlist"
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
]
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
},
"skins.minerva.mainMenu.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
Reorganise stylesheets All stylesheet-only ResourceLoader modules now have a single entry point rather than multiple files. This eases compilation of the content of those modules by all toolchains, which will be useful when introducing the bundlesize tool. Change-Id: Ic38a3e51db2f419fe68efd23a2c48ee69218a526
2020-01-20 21:19:12 +00:00
"resources/skins.minerva.mainMenu.styles/index.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.loggedin.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.loggedin.styles/styles.less"
]
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.scripts": {
"targets": [
"mobile",
"desktop"
],
"dependencies": [
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"mediawiki.ui.anchor",
Merge skins.minerva.scripts.top and skins.minerva.mainMenu into scripts These modules can safely be merged. Since skins.minerva.scripts.top is added via addModules to the HTML it must be marked as deprecated and remain temporarily as a redirection to skins.minerva.scripts All modules have been renamed to be in there new home - no deprecation notices are needed as they are not used outside Minerva. I leave skins.minerva.mainMenu.styles as it is used by Special:MobileMenu and needs to continue to do so. Change-Id: Ie919151630f4389f8e84e808bec003a6d3d07bd9
2019-02-07 16:09:20 +00:00
"skins.minerva.mainMenu.icons",
"skins.minerva.mainMenu.styles",
Make dependency to jquery.cookie explicit for mobileRedirect code Change-Id: I9ecdf9b507df6a9ec04933981ec5960c524e2323
2018-03-02 00:27:00 +00:00
"jquery.cookie",
Inline single use module skins.minerva.icons.images.scripts Only used in one place, as a dependency of skins.minerva.scripts, and only used to collect other dependencies. Does not need its own entry point, merge into user. Bug: T266361 Change-Id: Icc9ecaaec81730d30d7d8b45f1c70764a97de300
2021-09-29 02:58:52 +00:00
"skins.minerva.icons.images.scripts.misc",
"skins.minerva.icons.page.issues.uncolored",
"skins.minerva.icons.page.issues.default.color",
"skins.minerva.icons.page.issues.medium.color",
Update anon talk messages to show on non-main namespaces - Loads messageBox styles on non-main namespaces - Add messageBox styles to 'skins.minerva.scripts' module for MobileFrontend's edit overlay page - Prevent warning box from showing with empty message Bug: T284642 Change-Id: I70d0d86671384210cc3ab43cb1d350ff2a862fd9
2021-10-26 21:19:58 +00:00
"skins.minerva.messageBox.styles",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.util",
"mediawiki.router",
"mediawiki.Title",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"mediawiki.Uri",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.startup",
A/B test bucketing wrapper for page issues AB. Provides a class that initiates AB-test bucketing and registers as a MF module. Activates the reading depth test for users who are bucketed in either buckets "A" or "B". Does not add event-logging or visual style changes for page issues AB test. Bug: T193584 Change-Id: If8504a35059c6d1b056cef063a595b1c2ffd351a
2018-05-09 15:14:44 +00:00
"mediawiki.user",
"mediawiki.storage",
Use watchstar() instead of deprecated jQuery event to update watchstar classes Depends-on: I88af8585e8fc75f77ebef867d267199aeb2c6592 Change-Id: I859c9d763e77bb06b5109d419fb581258f3bd665
2021-12-08 21:08:18 +00:00
"mediawiki.experiments",
"mediawiki.page.watch.ajax"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"messages": [
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"echo-badge-count",
"mobile-frontend-notifications-filter",
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
"skin-minerva-issue-learn-more",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues",
Section issues overlay has different heading Per https://phabricator.wikimedia.org/T197932#4417319 Note that given talk/category overlay does not use or display section issues, to simplify things any section other than 0 or all will use this heading. Bug: T197932 Change-Id: I737fb07aaadcea7772d0b08f8b0652dcf2f4623d
2018-07-11 21:13:19 +00:00
"minerva-meta-data-issues-section-header",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues-talk",
"mobile-frontend-meta-data-issues-categories",
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
"mobile-frontend-cookies-required",
Move redlink CTA out of skins.minerva.editor It is not part of the editor. Redlinks are part of page content. Bug: T198765 Change-Id: Iee77a228b6f2db1c5f2e85226d6cc1c6a73a89be
2018-09-20 22:52:35 +00:00
"mobile-frontend-editor-redlink-create",
"mobile-frontend-editor-redlink-leave",
"mobile-frontend-editor-redlink-explain",
Add feature flagged DownloadIcon Shortcut for print. Disabled by default and controlled by wgMinervaDownloadIcon Note that with lazy images enabled, images will not appear in the printed article. This can be easily addressed inside the onClick function in a later patchset with a few modifications to the Skin class. Currently the flag when enabled will show on all browsers. There are some open questions on the ticket about how we want to limit the feature. This shouldn't block review or merging. Bug: T177215 Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-18 21:03:51 +00:00
"minerva-download",
Use core watchstar code Apply the mediawiki core watchstar to the Minerva skin. Note, watchstars in search and other locations will continue to be provided by the MobileFrontend library (see follow up patch I7b748dc87089389400b0035c62a3b9a00c2e43f9) Bug: T234970 Change-Id: I11bbe976412b50dba76a55f37887e4c9235d0be1
2019-09-19 21:19:07 +00:00
"minerva-watchlist-cta",
Render talk page as a tab instead of an overlay Following up on Jon's POC, this will get rid of the talk board component in favor of linking to the server rendered talk page. Additional Changes: * Cleaned up talk selenium tests. Removed talk_steps.rb which doesn't appear to be used anymore. * Changed talk add button classes to a single class * Moved "Add discussion" button to postheadinghtml per design mock * Added "...talk-explained", "...talk-explained-empty" messages to postheadinghtml per design mock * Due to undesirable jumps in window scroll caused by the section anchor & Toggler.js code when opening the TalkSectionOverlay (read fixme in code), a Promise is always returned from OverlayManager route to reset the scroll position to the top when the section overlay is opened. * Moved "mobile-frontend-talk-fullpage", "mobile-frontend-talk-reply-success", "mobile-frontend-talk-topic-feedback", "mobile-frontend-talk-explained" "mobile-frontend-talk-explained-empty" messages to minerva as minerva is the one who initiates those messages now. * Limited $talk selector to only `.talk` elements since amc talk tab does not need to be targeted * After saving a reply from TalkSectionOverlay, the DOM that is not part of the overlay becomes out of sync since a new reply was created. To get around this, an `onSaveComplete` callback was passed (similar to the TalkSectionAddOverlay) to execute a full page refresh. Although this is clunky, it is the easiest way to resync. Bug: T230695 Depends-On: I80201394fd7015db6700446142b0b4b20829f12e Change-Id: I243f1193bce0da9fa710fc3b5379f90b2d079680
2019-10-17 22:46:07 +00:00
"mobile-frontend-redirected-from",
"minerva-talk-full-page",
"minerva-talk-topic-feedback",
Drop smart logout handling in favor of core ready.js MediaWiki core added support of overrideLogoutSelector skin config variable which allows us to define the logout button selector. Thanks to that we do not have to ship our custom/duplicated smart logout handler as we can use the one shipped with ready.js. Depends-On: Id313337c85229a5e8d0aada3a67d722048709597 Bug: T259200 Change-Id: Ie0192a176dfa8be994a544221aa71de75028d502
2021-02-01 19:35:16 +00:00
"minerva-talk-reply-success"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
"styles": [
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"resources/skins.minerva.scripts/styles.less",
[dev] match page issues LESS filename to JS naming Bug: T212944 Change-Id: I0fa44cdb26b24fff87a7c4dfd424fe4400ceee22
2019-07-10 20:10:43 +00:00
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less"
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
],
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"templates": {
MainMenu is a controller not a View and server rendered (take 2) There should be no caching implications for this change, as the main menu has been server side rendered on all wikis since 10th October. As Stephen pointed out somewhere, this is a bit of a micro-optimisation Let's simplify this code by always rendering it in the HTML. MainMenu.js as a result becomes a controller that just decides when to show it. The geolocation check for Nearby is removed given the fact that all grade A browsers for mediawiki have Geolocation support. ev.preventDefault in onSkinClick is dropped since the link to the '#' (the default behaviour) is wanted Additional changes * Browser support suggests "animations" class is redundant now * `open` event no longer filed - not being used anywhere * Transparent shield is now managed by the MainMenu controller not the skin (which was confusing) * Test geolocation using a simple feature tests rather than abstracting it away inside Browser * The main menu button is always hidden under either a translucent shield and/or the main menu itself when it has been opened so so it's not possible to ever click it while the menu is open - the click handler is thus simplified removing a check for the class of the button Bug: T234650 Change-Id: If101eebbdbda1519af922745917237648722820e
2019-09-05 21:55:55 +00:00
"IssueNotice.mustache": "resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.mustache"
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
},
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"packageFiles": [
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"resources/skins.minerva.scripts/setup.js",
Menu items added via addPortletLinks should look like other menu items Requires `I4c477c88ce48484960e40609cd243e63639175bc` to function. Bug: T236711 Change-Id: I331912a1cd6cd4293c22a1a48bb32cdec48bd37d
2020-02-10 04:13:01 +00:00
"resources/skins.minerva.scripts/addPortletLink.js",
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"resources/skins.minerva.scripts/initMobile.js",
"resources/skins.minerva.scripts/searchSuggestReveal.js",
CtaDrawers no longer stay behind in DOM A new controller is added - drawers.js with methods for controlling display and removal of drawers. The existing code in references is moved there and extended to support scroll to hide behaviour Console warnings will disappear with this change. Additional changes: * Standardise the page issues element selector - should be the container not a link inside it (was a red link so triggering wrong behaviour) Bug: T214045 Change-Id: Id4719b5209dd7647775e2959e46dbae0c3dde3ac
2019-12-16 23:47:54 +00:00
"resources/skins.minerva.scripts/drawers.js",
Use core watchstar code Apply the mediawiki core watchstar to the Minerva skin. Note, watchstars in search and other locations will continue to be provided by the MobileFrontend library (see follow up patch I7b748dc87089389400b0035c62a3b9a00c2e43f9) Bug: T234970 Change-Id: I11bbe976412b50dba76a55f37887e4c9235d0be1
2019-09-19 21:19:07 +00:00
"resources/skins.minerva.scripts/ctaDrawers.js",
Merge skins.minerva.scripts.top and skins.minerva.mainMenu into scripts These modules can safely be merged. Since skins.minerva.scripts.top is added via addModules to the HTML it must be marked as deprecated and remain temporarily as a redirection to skins.minerva.scripts All modules have been renamed to be in there new home - no deprecation notices are needed as they are not used outside Minerva. I leave skins.minerva.mainMenu.styles as it is used by Special:MobileMenu and needs to continue to do so. Change-Id: Ie919151630f4389f8e84e808bec003a6d3d07bd9
2019-02-07 16:09:20 +00:00
"resources/skins.minerva.scripts/menu.js",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.scripts/preInit.js",
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
"resources/skins.minerva.scripts/downloadPageAction.js",
Update page issues folder structure Tests are untouched as these will be moved to headless node-qunit in a follow up. Bug: T212944 Change-Id: I3d9b43387e34fd49827e3ab62420f3555ff4b3cd
2019-07-02 20:34:03 +00:00
"resources/skins.minerva.scripts/page-issues/parser.js",
Hygiene: Separate cleanups library from initialisation In order to write tests, we'd like to separate code without side effects from code that executes it as part of setup. This shuffles dependencies and makes page and overlayManager parameters to the init function (injected dependencies) Change-Id: I96808541d48be7869fed3bc30babb80866e139ec
2018-07-30 14:45:44 +00:00
"resources/skins.minerva.scripts/AB.js",
pageIssuesOverlay is a factory function that returns an Overlay This experiments with making PageIssuesOverlay an Overlay with various options. The appending of children is a little messy and points at a need to standardise this some way (see https://phabricator.wikimedia.org/T209647) TODO: * Remove the iconString property on PageIssueSummary which is no longer needed Bug: T209647 Change-Id: Iadd798a820dca6bbb31edc9a8570b6db7aac237a
2018-11-24 01:49:47 +00:00
"resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueList.js",
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.js",
Hygiene: separate page issue view logic - Move page issue view components that do not modify the DOM during during construction to PageIssueLearnMoreLink.js and PageIssueLink.js. PascalCase is used optimistically for filenaming in the hopes that these functions can become something like a JSX component. A "new" function prefix is used in the meantime. - Move page issue view logic that munges the existing DOM to pageIssueFormatter.js. Substitute "create" prefixes for insert so that clients won't forget that calling the function is a modify operation. Alternative naming welcome but it shouldn't be confused with more idealistic components that do not depend on DOM state for construction. - Consolidate createPageIssueBanner() and createPageIssueBannerMultiple() into insertPageIssueBanner() as the code was quite similar and were it a true component, it would probably be a single component. All new files appear under page/ to keep their distinction from the overlay code clear. Some view logic remains in pageIssues.js but it shall be difficult to isolate. Bug: T212376 Change-Id: Iccce709c34fa8de5a28a5a00098add5775e3dc9a
2019-01-23 20:16:11 +00:00
"resources/skins.minerva.scripts/page-issues/page/PageIssueLearnMoreLink.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLink.js",
"resources/skins.minerva.scripts/page-issues/page/pageIssueFormatter.js",
Update page issues folder structure Tests are untouched as these will be moved to headless node-qunit in a follow up. Bug: T212944 Change-Id: I3d9b43387e34fd49827e3ab62420f3555ff4b3cd
2019-07-02 20:34:03 +00:00
"resources/skins.minerva.scripts/page-issues/index.js",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"resources/skins.minerva.scripts/UriUtil.js",
"resources/skins.minerva.scripts/TitleUtil.js",
Move components files up one level into Skins directory Follow up to I4c2e115451c0a76c742734730712814c1f1d838d. This will allow us to load the templates directly into skin.mustache via {{>PartialName}} Templates partials can only be resolved relative to the folder given to the TemplateParser. Change-Id: I5783d49c25d2efcf4781dd912500bf8b413b8cb6
2021-10-19 18:45:43 +00:00
"includes/Skins/ToggleList/ToggleList.js",
Improve tab scrolling logic * If the leftmost tab is selected, scroll all the way to the left * If the rightmost tab is selected, scroll all the way to the right * If a tab in the middle is selected, scroll to center it * If the selected tab is wider than the tab container, make sure its start (left edge in LTR, right edge in RTL) is always made visible. As Bartosz reminded me, .scrollLeft in RTL is a cross-browser nightmare (see https://github.com/othree/jquery.rtl-scroll-type), so add a bunch of code working around this. Some of this logic is in OOUI already, but what's there is not enough for what we need here, and we also don't want to load OOUI for this. Bug: T223142 Change-Id: Ica298954b42f9daa4819043ec24bc0266290a927
2019-06-25 01:10:51 +00:00
"resources/skins.minerva.scripts/TabScroll.js",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"resources/skins.minerva.scripts/Toolbar.js",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.scripts/mobileRedirect.js",
"resources/skins.minerva.scripts/search.js",
Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script Logic is moved from server to client. Config is added via getSkinConfigVariables (e.g. passed to mw.config ) and a JavaScript if statement. The IIFE in watchstar and talk files is replaced with a module.exports function to avoid refactoring at this point and added risk. The file contents remain the same. skins.minerva.options is left as is, given the code is more experimental and used in the beta mode - should not be sent to all clients. Additional change: * Remove skins.minerva.toggling (that module has been empty for a week now and functionality moved to mobile.init module) Depends-On: Ie71adbe18e8dbeb661ddb9d7d3d1d0897891d515 Bug: T233048 Change-Id: Ife777e76d9d77894fb5d09e7c8f0238b00596a7a
2019-09-18 23:07:21 +00:00
"resources/skins.minerva.scripts/references.js",
"resources/skins.minerva.scripts/talk.js",
"resources/skins.minerva.scripts/watchstar.js"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Message box styles for Minerva come from core Just as before styles for message boxes will be kept off the critical path of most page views and loaded on special pages, old revisions and action= URIs, however unlike before the CSS will come from the definition in core. It must also be loaded in JavaScript for compatibility with the use of warnings in JavaScript, for example MobileFrontend overlays. This change will allow us to remove the mobile.messageBox.styles module in MobileFrontend I8b6bdfceaf33b9527dbe6790d2a39e335fb692b2 Bug: T233160 Change-Id: I7d8d1d34621c36c26ec03a3773d4d1e67bd14f2e
2021-03-23 22:04:58 +00:00
"skins.minerva.messageBox.styles": {
"class": "ResourceLoaderSkinModule",
"features": [ "interface-message-box" ]
},
Replace categories button with HTML rendering Bug: T246049 Change-Id: Id8c7493a525844b43c1628a1f4f09ae716ece2ba
2021-04-28 21:58:51 +00:00
"skins.minerva.categories.styles": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
Replace categories button with HTML rendering Bug: T246049 Change-Id: Id8c7493a525844b43c1628a1f4f09ae716ece2ba
2021-04-28 21:58:51 +00:00
"class": "ResourceLoaderSkinModule",
"features": [ "interface-category" ]
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"QUnitTestModule": {
"localBasePath": "",
"remoteSkinPath": "MinervaNeue",
"dependencies": [
Message box styles for Minerva come from core Just as before styles for message boxes will be kept off the critical path of most page views and loaded on special pages, old revisions and action= URIs, however unlike before the CSS will come from the definition in core. It must also be loaded in JavaScript for compatibility with the use of warnings in JavaScript, for example MobileFrontend overlays. This change will allow us to remove the mobile.messageBox.styles module in MobileFrontend I8b6bdfceaf33b9527dbe6790d2a39e335fb692b2 Bug: T233160 Change-Id: I7d8d1d34621c36c26ec03a3773d4d1e67bd14f2e
2021-03-23 22:04:58 +00:00
"skins.minerva.messageBox.styles",
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"mobile.startup",
"mediawiki.user",
QUnit: Add dependency on mw.Uri Allows running the tests via `grunt qunit --qunit-project=MinervaNeue` with I977150ece26f5878a0ccc42d39bed6c7e74e9602 Change-Id: I8f747e3df196055361d53d00fea833fb9de892f0
2022-02-02 10:15:48 +00:00
"mediawiki.experiments",
"mediawiki.Uri"
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
],
"packageFiles": [
"tests/qunit/skins.minerva.scripts/index.js",
"resources/skins.minerva.scripts/page-issues/parser.js",
"resources/skins.minerva.scripts/downloadPageAction.js",
"resources/skins.minerva.scripts/AB.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueList.js",
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLearnMoreLink.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLink.js",
"resources/skins.minerva.scripts/page-issues/page/pageIssueFormatter.js",
"resources/skins.minerva.scripts/page-issues/index.js",
"resources/skins.minerva.scripts/UriUtil.js",
"resources/skins.minerva.scripts/TitleUtil.js",
watchstar: Add temp-watched css class when expiry is present MobileFrontend extension is currently tracking watched/temp-watch css classes and applying animations to the "watch" event. This patch starts adding temp-watched accordingly now that the expiry is part of the event's data. Note: this patch does not fix the lack of animation when transitioning from half-star to empty-star or on page-load when the page is temporarily watched but it fixes the awkward angle the half-star icon was left in when transitioning from a full-star to a half-star Bug: T262862 Change-Id: I1c8cb9c33cda76b87b6a9f15e408d88edbf61d93
2020-09-14 20:46:26 +00:00
"resources/skins.minerva.scripts/watchstar.js",
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"tests/qunit/skins.minerva.scripts/downloadPageAction.test.js",
"tests/qunit/skins.minerva.scripts/page-issues/parser.test.js",
"tests/qunit/skins.minerva.scripts/AB.test.js",
"tests/qunit/skins.minerva.scripts/page-issues/index.test.js",
"tests/qunit/skins.minerva.scripts/UriUtil.test.js",
watchstar: Add temp-watched css class when expiry is present MobileFrontend extension is currently tracking watched/temp-watch css classes and applying animations to the "watch" event. This patch starts adding temp-watched accordingly now that the expiry is part of the event's data. Note: this patch does not fix the lack of animation when transitioning from half-star to empty-star or on page-load when the page is temporarily watched but it fixes the awkward angle the half-star icon was left in when transitioning from a full-star to a half-star Bug: T262862 Change-Id: I1c8cb9c33cda76b87b6a9f15e408d88edbf61d93
2020-09-14 20:46:26 +00:00
"tests/qunit/skins.minerva.scripts/TitleUtil.test.js",
"tests/qunit/skins.minerva.scripts/watchstar.test.js"
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
]
},
Use MediaWikiServices to cache commonly used helpers SkinMinerva cached the ContentHandler object for better performance. In the future the ContentHandler will be also used in the Menu, for better readability, store ContentHandler as Service. MediaWikiServices will initialize service on first access and cache it for future needs. Same applies to SkinUserPageHelper, Bug: T216152 Change-Id: Ia98dc860862360a68556272714669f0c3a13eb1e
2019-04-10 12:52:34 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Set MobileFrontendEditorAvailableSkins attribute The attribute tells MF this skin is ready to allow the user to show the editor. Bug: T257746 Depends-On: Iac3fc9571827782c2a9fe9531b885218e2159d29 Change-Id: Ib435929376bc34a1dcede1cd142b0e1cb186b6a9
2022-04-19 18:10:59 +00:00
"attributes": {
"MobileFrontend": {
"EditorAvailableSkins": [
"minerva"
]
}
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"manifest_version": 2
Use a Drawer for Block Notices When a user is blocked, the toast message provides insufficent information to the user. To provide more information, as well as a better design, the block message will be moved into a drawer. Bug: T165535 Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-04-14 17:54:25 +00:00
}
Reference in a new issue Copy permalink