Dev: Address some FIXMEs

* Drop non-existent pointer-overlay selector
* Drop redundant icon class for arrow
* Drop unnecessary !important
* Drop transparent-shield class
* Reword an existing FIXME about a contensious decision and
add a new FIXME for moving some code to a more appropriate place.
* Move an image into a ResourceLoaderImage module (test with
`mw.notify('error', { type: 'error'} )`)

Change-Id: I6e38f07772afae6f13c4851ca17a67d52ca7d331

includes/skins/MinervaTemplate.php

@@ -125,9 +125,7 @@ class MinervaTemplate extends BaseTemplate {
 				'clockIconClass' => MinervaUI::iconClass( 'clock', 'mw-ui-icon-small' ),
 				'arrowIconClass' => MinervaUI::iconClass(
 					'expand-gray', 'small',
-					// FIXME: `mw-ui-icon-mf-arrow-gray` can be removed from list of classes
-					// when Ibbc706146710a9e31a72b3c2cd4e247d7a227488 lands.
-					'mf-mw-ui-icon-rotate-anti-clockwise indicator mw-ui-icon-mf-arrow-gray',
+					'mf-mw-ui-icon-rotate-anti-clockwise indicator',
 					// Uses icon in MobileFrontend so must be prefixed mf.
 					// Without MobileFrontend it will not render.
 					// Rather than maintain 2 versions (and variants) of the arrow icon which can conflict

includes/skins/minerva.mustache

@@ -1,8 +1,7 @@
 {{{headelement}}}
 <div id="mw-mf-viewport">
 	<div id="mw-mf-page-center">
-		<!-- transparent-shield can be removed when Drawer updated -->
-		<a class="mw-mf-page-center__mask transparent-shield" href="#"></a>
+		<a class="mw-mf-page-center__mask" href="#"></a>
 		<header class="header-container header-chrome">
 			<form class="header" action="{{wgScript}}" method="get">
 				<nav class="navigation-drawer toggle-list view-border-box">

resources/skins.minerva.base.styles/print/footer.less

@@ -36,10 +36,7 @@
 
 	.post-content {
 		margin-top: 15px !important;
-		// FIXME: There is a print style in skins.minerva.base.styles
-		// that sets display: none; When promoting to stable the !important here
-		// should be dropped and skins.minerva.base.styles moved into here.
-		display: block !important;
+		display: block;
 
 		// ... and add these instead.
 		.hlist,

resources/skins.minerva.base.styles/print/header.less

@@ -1,6 +1,7 @@
 // FIXME: Ensure resources/skins.minerva.base.styles/print.less is removed when promoting
-.header-container {
-	background: @skinContentBgColor !important;
+.header-container,
+.header-container.header-chrome {
+	background: @skinContentBgColor;
 	box-shadow: none !important;
 }
 

resources/skins.minerva.base.styles/ui.less

@@ -259,7 +259,6 @@ input.search {
 .page-list li,
 .topic-title-list li,
 .site-link-list li,
-.pointer-overlay,
 .drawer,
 .messagebox,
 .errorbox,

resources/skins.minerva.content.styles/tablet/common.less

@@ -101,9 +101,7 @@ A file for css that optimises the Minerva skin on larger devices.
 	.pre-content,
 	.post-content,
 	/* Form only pages e.g. Special:MobileOptions */
-	#mw-content-text > form,
-	/* FIXME: remove need for id selector */
-	#mw-mf-page-center .pointer-overlay {
+	#mw-content-text > form {
 		margin-left: auto;
 		margin-right: auto;
 		width: 90%;

resources/skins.minerva.loggedin.styles/styles.less

@@ -14,6 +14,7 @@
 	}
 }
 
+// FIXME: Belongs in Echo extension.
 .notification-count {
 	display: inline-block;
 	margin: auto;

resources/skins.minerva.mainMenu.styles/MainMenu.less

@@ -1,5 +1,5 @@
 // Component of ui.less
-// FIXME: Move to components/
+// FIXME: Discuss the components folder with team and possibly move to components/
 @import '../../minerva.less/minerva.variables.less';
 @import '../../minerva.less/minerva.mixins.less';
 

resources/skins.minerva.scripts/preInit.js

@@ -13,10 +13,6 @@ module.exports = function () {
 
 	// loads lazy loading images
 	mobile.Skin.getSingleton();
-	// remove transparent-shield
-	// FIXME: Remove when transparent-shield has been removed from Mobilefrontend Skin.js
-	// eslint-disable-next-line no-jquery/no-global-selector
-	$( '.transparent-shield:not( .mw-mf-page-center__mask )' ).remove();
 
 	// setup main menu
 	menus.init();

resources/skins.minerva.scripts/styles.less

@@ -4,8 +4,6 @@
 
 @animationDuration: 0.3s;
 
-// transparent-shield class can be removed when removed from MobileFrontend Skin.js
-.transparent-shield,
 .mw-mf-page-center__mask {
 	position: absolute;
 	top: 0;
@@ -21,8 +19,6 @@
 }
 
 .navigation-enabled {
-	// transparent-shield class can be removed when removed from MobileFrontend Skin.js
-	.transparent-shield,
 	.mw-mf-page-center__mask {
 		visibility: visible;
 		opacity: 0.5;

skin.json

@@ -286,6 +286,8 @@
 				}
 			},
 			"images": {
+				"toast.mw-notification-type-error,.mw-notification.mw-notification-type-error":
+					"resources/skins.minerva.content.styles.images/error.svg",
 				"input.search,.mw-ui-icon-minerva-magnifying-glass:before": "resources/skins.minerva.content.styles.images/magnifying-glass.svg",
 				"a.external": {
 					"file": {

skinStyles/mobile.startup/toast.less

@@ -23,11 +23,6 @@
 	//
 	// Styleguide 3.2.
 	&.mw-notification-type-error {
-		// FIXME: Use `mobile.startup.images` to serve this file.
-		// Styling icon with the class mw-notification-type-error
-		// allows extensions ot use mw.notify( msg, 'error' ) and have those styled as errors.
-		// see https://github.com/search?l=JavaScript&q=org%3Awikimedia+mw.notify&type=Code
-		.background-image( 'images/error.svg' );
 		background-size: 24px;
 		background-position: 16px 50%;
 		background-repeat: no-repeat;