wikimedia/mediawiki-extensions-WikiEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/WikiEditor synced 2024-11-24 00:06:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Partially revert mistake in JavaScript code optimization

Browse source 
The mistake here was that these are two different fields, but with
variable names that look very similar. Only 2 characters differ. :(

 insertLinkLinkTextField.…
 insertLinkLinkTypeField.…

Bug: T304476
Change-Id: I459133d3ba5c327e34c689ad0d3c046116f438a9
This commit is contained in:
Thiemo Kreuz 2022-03-23 08:00:34 +01:00
parent dbb6583bbb
commit fa64decfce
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/jquery.wikiEditor.dialogs.config.js
View file

@ -247,9 +247,8 @@
// Blank form
insertLinkTitleInputField.reset();
insertLinkLinkTextField.getField()
.setValue( '' )
.selectItem( null );
insertLinkLinkTextField.getField().setValue( '' );
insertLinkLinkTypeField.getField().selectItem( null );
}
},
'wikieditor-toolbar-tool-link-cancel': function () {