From fa64decfce23c5eab0b02e25807b18dd06abea53 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Wed, 23 Mar 2022 08:00:34 +0100 Subject: [PATCH] Partially revert mistake in JavaScript code optimization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The mistake here was that these are two different fields, but with variable names that look very similar. Only 2 characters differ. :( insertLinkLinkTextField.… insertLinkLinkTypeField.… Bug: T304476 Change-Id: I459133d3ba5c327e34c689ad0d3c046116f438a9 --- modules/jquery.wikiEditor.dialogs.config.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/jquery.wikiEditor.dialogs.config.js b/modules/jquery.wikiEditor.dialogs.config.js index 1c4688af..58b9e704 100644 --- a/modules/jquery.wikiEditor.dialogs.config.js +++ b/modules/jquery.wikiEditor.dialogs.config.js @@ -247,9 +247,8 @@ // Blank form insertLinkTitleInputField.reset(); - insertLinkLinkTextField.getField() - .setValue( '' ) - .selectItem( null ); + insertLinkLinkTextField.getField().setValue( '' ); + insertLinkLinkTypeField.getField().selectItem( null ); } }, 'wikieditor-toolbar-tool-link-cancel': function () {