mediawiki-extensions-Visual.../modules/ve
Roan Kattouw 3f5486a43f Use a sane recursion guard in ve.ui.Context.prototype.hide()
The previous recursion "guard" relied on the recursion to occur for
the function to work correctly, which was very confusing. Additionally,
it didn't actually work: if the inspector's onClose handler changed
the selection (which is common), .hide() would recurse and the recursion
guard didn't catch this (inspector wasn't undefined yet). Fortunately
all that did was call .close() on the inspector again, which was caught
by .close()'s own recursion guard.

Instead, simply use this.hiding as a recursion guard, and refactor the
function so it doesn't do two different things depending on whether it's
expecting recursion or not.

Change-Id: I09eb9229530468ee319ca53b730784a3f632375d
2013-10-21 14:10:23 +02:00
..
ce Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
dm Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
init Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
test Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
ui Use a sane recursion guard in ve.ui.Context.prototype.hide() 2013-10-21 14:10:23 +02:00
ve.BranchNode.js Kill getOffsetFromNode() with fire 2013-05-09 17:26:22 -07:00
ve.debug.js ve.debug: Document why we use global Function#apply+Function#call instead of method.apply 2013-05-30 13:03:14 +01:00
ve.Document.js Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
ve.Element.js Toolbar action widgetization and UI refactoring 2013-10-04 16:26:13 -07:00
ve.EventEmitter.js oojs: Integrate with OOJS v1.0.0 2013-06-06 17:29:55 +02:00
ve.EventSequencer.js Fix initialisation errors in EventSequencer 2013-10-08 00:24:45 +01:00
ve.Factory.js Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
ve.js Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
ve.LeafNode.js
ve.Node.js ve.ce.Document: Introduce getRelativeRange method 2013-06-05 13:10:38 +01:00
ve.Range.js doc: Fix incorrect syntax 2013-09-06 20:29:18 +00:00
ve.Registry.js Remove ve.{inheritClass,mixinClass} and use OO instead 2013-10-18 18:58:08 +02:00
ve.track.js ve.track: add topic-based analytic event subscription 2013-10-16 10:03:27 -07:00