mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-28 16:20:52 +00:00
3f5486a43f
The previous recursion "guard" relied on the recursion to occur for the function to work correctly, which was very confusing. Additionally, it didn't actually work: if the inspector's onClose handler changed the selection (which is common), .hide() would recurse and the recursion guard didn't catch this (inspector wasn't undefined yet). Fortunately all that did was call .close() on the inspector again, which was caught by .close()'s own recursion guard. Instead, simply use this.hiding as a recursion guard, and refactor the function so it doesn't do two different things depending on whether it's expecting recursion or not. Change-Id: I09eb9229530468ee319ca53b730784a3f632375d |
||
---|---|---|
.. | ||
jquery | ||
jquery.uls | ||
oojs | ||
qunit | ||
rangy | ||
syntaxhighlight | ||
unicodejs | ||
ve | ||
ve-mw |