mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-12-12 06:27:01 +00:00
0f309f5b90
The previous patch I15aa2c0 (approved by UX) was incomplete. The required indicator was still shown, depending on the skin. This patch also reduces the amount of generated HTML when it doesn't have an effect anyway. At the moment an empty <span></span> is generated for _every_ parameter in the dialog. That's potentially hundreds. But the element is only needed for deprecated and (in the old UI) required parameters. A missing space is added while we touch this code anyway. The missing whitespace between label and indicator icon is confirmed to be a bug by UX. Styles that are the same on all skins are moved to the .css file that's loaded for all skins. Missing word-wrapping for overly long template parameter names (on the right side of the dialog) is added. The position of the indicator icon was broken on Minerva the moment a parameter name is a bit longer. Fixed by replacing `inline-block` with `inline`. Bug: T290492 Change-Id: Ie346d88969cec2effaf90d328d08567ab7b7bf75 |
||
|---|---|---|
| .. | ||
| ve.ui.MWAddParameterPage.js | ||
| ve.ui.MWAdvancedSettingsPage.js | ||
| ve.ui.MWCategoriesPage.js | ||
| ve.ui.MWLanguagesPage.js | ||
| ve.ui.MWParameterPage.js | ||
| ve.ui.MWParameterPlaceholderPage.js | ||
| ve.ui.MWSettingsPage.js | ||
| ve.ui.MWTemplatePage.js | ||
| ve.ui.MWTemplatePlaceholderPage.js | ||
| ve.ui.MWTemplatesUsedPage.js | ||
| ve.ui.MWTransclusionContentPage.js | ||